Commit graph

36419 commits

Author SHA1 Message Date
Alicia Cozine
b48b5c585e
adds table of connections by platform (#40688) (#40830)
(cherry picked from commit 43ca9d1548)
2018-05-30 08:17:04 -05:00
Trishna Guha
8e8b469416
nxos bugfixes 2.5.4 cherry-pick (#40861)
* Fix legacy Nexus 3k integration test and module issues. (#40322)

* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag

(cherry picked from commit 63e16431b7)

* Skip N35 and N3L platforms for nxos_evpn_global test (#40333)

(cherry picked from commit ad69ef88e7)

* add normalize_interface in module_utils and fix nxos_l3_interface module (#40598)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 0b7932db30)

* nxos_interface: Disable switchport for loopback/svi (#40314)

* nxos_interface: Disable switchport for loopback/svi

* Replace interface_type with get_interface_type(name)

(cherry picked from commit d04a989bd2)

* fixes bug with matching nxos prompts (#40655)

This change addresses an issue where the prompt matching regular
expressions would not match a prompt if the hostname starts with a
numeric value.  Before this change, the connection would fail with a
socket.timeout() error.  This change updates the termnal_stdout_re
values to now check for a number.

See Github issue #38639

(cherry picked from commit d829ff6993)

* fix nxos_vrf and migrate get_interface_type to module_utils (#40825)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit b4baa2d484)

* nxos_vlan fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* changelog nxos bugfixes 2.5.4

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-30 11:21:53 +05:30
Yuwei Zhou
5f384ec0a6 Fix #26755 by ensuring that the first nic in the nic list is primary (#38994) (#40781) 2018-05-29 10:28:54 +08:00
Benoit Dunand-Laisin
116a504825 Fixes #24241 Module always updates installed plugins (#40645)
* Update jenkins_plugin.py

When setting state=latest, plugin are always updated because old sha1 is bytes and and is compared to new sha1 which is str (so it always detecting a sha1 change)

* Add changelog
2018-05-25 10:09:17 -04:00
Jordan Borean
7ffbdd5214
win_scheduled_task fix doc example with datestamp (#40691)
(cherry picked from commit 0df6b085c0)
2018-05-25 11:40:19 +10:00
Sam Doran
b20b29ac0a
Insert set commands if a delete command is entered (#40666) (#40672)
(cherry picked from commit 8b4e36e711)
2018-05-24 13:21:16 -04:00
Nathaniel Case
d6a07186fd
Backport ios test fixes to 2.5 (#40662)
* Ios test fixes (#40503)

* Return messages generated from edit_config to module

* This does not seem to work that way

* Change test IP addresses to not conflict with device config

(cherry picked from commit eb818df1ec)

* Search all assigned ipv6 addresses instead of just the first (#40533)

* Search all assigned ipv6 addresses instead of just the first

* Add test for idempotency with multiple ipv6 addresses assigned

(cherry picked from commit e8d02a3a0f)

* Fix ios test pt. 2 (#40628)

* Add missing idempotence assert

* Remove dhcp with other addresses on ipv6

(cherry picked from commit f88412b7cd)
2018-05-24 10:22:46 -04:00
saydamir
3f2831c6e2 ec2_instance - fix instance creation with IPv6 (#40334)
IPv6 addresses and IPv6 address count may not be specified on the same request https://docs.aws.amazon.com/cli/latest/reference/ec2/assign-ipv6-addresses.html#options
2018-05-24 10:10:23 -04:00
Sviatoslav Sydorenko
0b080de855
[2.5] Fix ios_vlan to correctly identify unmodified config when having long interface names (#40145) (#40656)
Change the command to get the interface in a vlan "show vlan" => "show vlan brief"
Change the parsing of the return command of the switch.
The return of the ios command is fixed so i cut with fix number of carracter.
Adding looking for the next line to add the forgeted interfaces.
(cherry picked from commit 3903ca5)

Co-authored-by: pierremahot <pierre.mahot@orange.fr>
2018-05-24 15:55:13 +02:00
Martin Krizek
18581adbb5
Backport: apt: don't markmanual if apt-mark is not installed (#40605)
(cherry picked from commit a3cfe0d72f)
2018-05-24 09:27:38 +02:00
Jordan Borean
12ac23bad3
Win get url auth 2.5 (#40642)
* Fixed WebRequest init (#40641)


(cherry picked from commit 4fbdc1a497)

* Added changelog fragment
2018-05-24 14:42:39 +10:00
Matt Martz
fac5a14ded Backport #40500 for 2.5 - synchronize fixes (#40545)
* Group logic detecting user, ensure rsync_opts is a list if omitted. Fixes #40483

(cherry picked from commit ea176427b4)

* Add changelog for #40500
2018-05-24 12:04:18 +10:00
Daryl Tucker
70a60b6166
Updates to fileglob Documentation (#40461)
(cherry picked from commit 5edc46431a)
2018-05-24 12:01:00 +10:00
Jordan Borean
a63b6d363b
winrm: add better exception handling for krb5 auth with pexpect (#39930) (#40634)
* winrm: add better exception handling for krb5 auth with pexpect

* Added changelog fragment

* Added exception handler in case kinit path isn't valid, added test cases

* fixed for Python 2 compatibility

(cherry picked from commit 5e28e282a5)
2018-05-24 07:17:21 +10:00
Sviatoslav Sydorenko
2cb9f7f5b9
[backport] Detect separate git dir and set git config path value appropriately
PR #38016

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 0a701ff)

Co-authored-by: Senya <senya@riseup.net>
2018-05-23 21:01:07 +02:00
Ludek Finstrle
786911d26f constructed inventory does not use group variables from previous inventory #37397
* Add support for loading invenotry group variables in constructed plugin

(cherry picked from commit 81cfbbbeb9)
2018-05-23 10:59:26 -04:00
Sam Doran
02e66617f2
Make xenserver_facts actually work (#35821) (#40552)
* Get the str value of xmlrpc.client.DateTime

* get_all_records should be used instead of get_all

* Facts returned with 'ansible_facts'

* Remove some redundant code

* Add cheese as maintainer

* Add changelog entry

(cherry picked from commit d45b044992)
2018-05-22 14:01:19 -04:00
Sam Doran
dbcecb64b8
Fix ctrl+c in pause module and add tests (#40134) (#40480)
Backport # 40134 - Ensure Ctrl+C interrupt for pause module works in all cases
2018-05-22 13:11:21 -04:00
Sam Doran
4c279f5e45
EdgeOS module improvements (#39530) (#40548)
* Update docs and use to_text on strings

* Add warning to use network_cli

(cherry picked from commit d5dbd8c76d)
2018-05-22 12:52:57 -04:00
Sam Doran
9bef06ccd9
Add better error messages and checking to known_hosts (#38307) (#40502)
(cherry picked from commit 13aff08748)
2018-05-22 12:42:39 -04:00
Nathaniel Case
7df6df9017
Ios fixes 2.5 (#40543)
* Ios test fixes (#40503)

* Return messages generated from edit_config to module

* This does not seem to work that way

* Change test IP addresses to not conflict with device config

* Add test for idempotency with multiple ipv6 addresses assigned
2018-05-22 12:00:29 -04:00
Sam Doran
e877469533
Do not join flag parameters in iptables module (#36658) (#40501)
* Do not join flag parameters

This put a comma between every character of the tcp flag parameters, resulting in a bad iptables command.

Fixes #36490

* Use suboptions to ensure tcp_flags options are lists

* Add unit tests for tcp_flags

* Add example of how to use tcp_flags

(cherry picked from commit c9d3bb59a4)
2018-05-22 11:29:33 -04:00
Artem Goncharov
13c88fe2d2 fixes issue 39472: (#40379)
With python 3.6 spwd.getspnam returns PermissionError instead of
KeyError if user does not have privileges

(cherry picked from commit 0023b1ee9eca1286493c56ce5e1aa1b2272c3e39)
2018-05-22 11:29:00 -04:00
Alicia Cozine
7c49648a39
uses .txt for shared content (#40416) (#40538)
(cherry picked from commit 69eef14e3b)
2018-05-22 10:21:08 -05:00
Jordan Borean
9d8d1de182
winrm: source user from options than remote_user (#40467) (#40516)
* winrm: source user from options than remote_user (#40467)

* winrm: source user from options than remote_user

* fixed up mock for kerberos import

* Added changelog fragment

* get hostname from option as well

(cherry picked from commit 1ac180c74d)

* Also removed uneeded method that wasn't backported
2018-05-22 10:46:13 +10:00
Jordan Borean
6eb0af96de
win_environment: Added explicit check for null, empty string with state=present (#40468) (#40508)
* win_environment: Added explicit check for null, empty string with state=present

* Added changelog fragment

(cherry picked from commit db195831fd)
2018-05-22 07:15:34 +10:00
Martin Krizek
d60f70b47b
Clarify in docs that end_play affects all hosts (#40235) (#40306)
(cherry picked from commit b116eaa485)
2018-05-21 07:47:51 +02:00
Ryan S. Brown
d0cf81883c Move EC2 ASG changelog entry to correct directory 2018-05-18 13:57:52 -04:00
John R Barker
54413642db
removed_in: 2.6 is valid (#40399) (#40407)
(cherry picked from commit fe4368ce15)
2018-05-18 16:23:50 +01:00
Matt Davis
778cb5bd8b New release v2.5.3 2018-05-17 16:29:23 -07:00
Nathaniel Case
864fd7c53e Local remote 2.5 backport (#40363)
* Don't rewrite remote paths when remote is secretly local

* Remote overriding is configurable in connection

* Use c.DEFAULT_LOCAL_TMP instead of remote_tmp

* Remove remote_is_local from ConnectionBase

* remote_is_local->_remote_is_local

* Add warning signs to _remote_is_local and explanatory comments to its use
2018-05-17 15:25:44 -07:00
Sloane Hertel
84f9303c52 aws_ec2: tag values as hostnames - backport #35880 (#40325)
* aws_ec2 inventory: add support for tag values as hostnames (#35880)

(cherry picked from commit b345b79dcd)

* changelog
2018-05-17 08:59:20 -07:00
Jordan Borean
a0b608f311 small grammar improvements to add clarity (#40157) (#40298)
(cherry picked from commit 98579029d7)
2018-05-16 22:47:28 -07:00
Sloane Hertel
ae2453850e aws_ec2 inventory plugin: backport/2.5/40240 (#40277)
* Add fallback check for IAM role temp creds (#40240)

* Add fallback check for IAM role temp creds

(cherry picked from commit d5a5e37fcf)

* changelog

* Fix changelog

* Fix fix changelog
2018-05-16 22:47:07 -07:00
Ondra Machacek
136e8a1e58 ovirt: fix quota_id check (#40081) 2018-05-16 22:44:50 -07:00
Julien PRIGENT
b4a4f0f605 ec2_vpc_route_table: Update matching_count parsing on find_subnets fu… (#38707) (#39899)
* ec2_vpc_route_table: Update matching_count parsing on find_subnets function and tests

* ec2_vpc_route_table: Update matching_count parsing on find_subnets function

(cherry picked from commit 1905a6e8fb)
2018-05-16 22:44:32 -07:00
Jordan Borean
8f09190100
win_updates: fix typo with download failure and whitelist on multiple updates (#40283) (#40292)
(cherry picked from commit 837aada4a8)
2018-05-17 08:55:21 +10:00
Matt Clay
f86f51a8e1 Fix uri test on Python 2.6.
(cherry picked from commit 5c124876fa)
2018-05-16 15:34:29 -07:00
John R Barker
f791ec285c
Backport/2.5/37461 (#40252)
* Fixing lack of failure when uploaded source is invalid (#37461)

Checking the response status for 400 and throwing exception.
Unit tests updated.

Fixes #37406
(cherry picked from commit 5e990301bb)

* changelog
2018-05-16 20:23:09 +01:00
Matt Clay
a8628898ff Add missing test network prefixes. 2018-05-16 11:23:17 -07:00
Trishna Guha
2fec98aa5d
nxos bugfix changelog 2.5.3 (#40263)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-16 22:17:52 +05:30
Alicia Cozine
0d1af1df10
add SVI example for Cisco IOS/IOS-XE platform (#40021) (#40253)
on networktocode slack there was a user that wanted an example of how to add a switch vlan interface.  This will work and was tested on a 3850 cisco ios switch
(cherry picked from commit 0dc73e7822)
2018-05-16 10:49:58 -05:00
Ganesh Nalawade
f5463f9099
Fix junos_config confirm timeout issue (#40238) (#40255)
* Fix junos_config confirm timeout issue

* Fix unit test

* Update changelog

(cherry picked from commit 865f2c5990)
2018-05-16 20:55:13 +05:30
John R Barker
9818636a7c
Lenovo cli expansion - Modify command acronyms to full commands (#40218) (#40254)
* Changing Lenovo Inc to Lenovo and update License file to be consistent.

* Editing cli commands to expanded form. Changing username and password fields as per Ansible standards.

(cherry picked from commit f60731e27e)
2018-05-16 15:59:30 +01:00
John R Barker
4924398e0f
Network requirements to be installed by ansible-test (#40042) (#40250)
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
(cherry picked from commit 27942d937f)
2018-05-16 15:25:44 +01:00
Nathaniel Case
affbab8e3f
ios_facts: Add check to skip lldp neighbors if lldp doesn't exist or isn't enabled. (#40247)
* Add check to skip lldp neighbors if lldp doesn't exist or isn't enabled.

* Re-enable check_rc on ios' run_commands

(cherry picked from commit 39bed45baf)
2018-05-16 09:54:24 -04:00
Trishna Guha
f1fc7cf384
nxos_snapshot fix cherry-pick (#40231)
* save_snapshot_locally nxos_snapshot (#40227)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 979f1e5ed1)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-16 16:22:47 +05:30
Trishna Guha
b582ae6e29
documents usage of enable mode on NXOS (#39859) (#40221)
(cherry picked from commit 64f87867dd)
2018-05-16 13:33:59 +05:30
Trishna Guha
299047d963
cherry-pick stable-2.5 (#40177)
* Fix nxos terminal plugin regex (#39659)

Fix nxos terminal plugin regex to match
command prompt without newline character as prefix

(cherry picked from commit 0ac222d68b)

* remove purge from nxos_logging doc, argspec (#39947)

* remove purge from nxos_logging doc, argspec

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit f1103a7a02)

* IT cases for nxos_logging (#39929)

* IT cases for nxos_logging

* review comment

(cherry picked from commit 2557c0662a)

* fix nxos_ping issues (#40028)

(cherry picked from commit 6fac574f17)

* Fix vxlan_vtep_vni tests (#39968)

(cherry picked from commit 0407c51447)

* ios cliconf plugin fix regex for version (#40066)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 5cf61d7401)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-16 12:19:39 +05:30
Matt Clay
f6cbb45b39 Disable failing etcd3 integration test.
(cherry picked from commit 00d10e1d78)
2018-05-15 23:31:07 -07:00