Commit graph

44727 commits

Author SHA1 Message Date
Chris Archibald
ba30649af9 Backport/2.8/57379 (#58080)
* Duplicate rules were being created if rule index was not set (#57379)

* bug fixes

* Revert "bug fixes"

This reverts commit 2d839ecf350260ba857ef820f761c8a0e1241102.

* bug fix

(cherry picked from commit e80d6f18ce)

* add fragment
2019-06-19 10:56:15 -07:00
Sam Doran
32503a55c4 [stable-2.8] Change integration tests in order to pass on Fedora 30 (#58081)
* Use different package for DNF tests
    Ninja caused errors in Fedora 30. This works in both Fedora 29 and 30.

* Fix git integration tests
    Git >= 2.21.0 has either a bug or change in behavior where it errors when fetching a
    repository containing submodules that are behind the upstream submodule commits.
    It's weird and I don't fully understand it.

    Get around this my checking out specific commits from a repository rather than
    switch the origin URL.

* Fix PostgreSQL tests
    The error message is slightly different
(cherry picked from commit 18feeb51a8)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-19 10:55:13 -07:00
Paul Belanger
7bd503c52a Remove pause logic form junos_netconf tests (#57966)
We can switch to wait_for / meta, as using pause can lead to race
conditions on slower / faster hardware.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 8dc51dfe1c)
2019-06-19 10:54:46 -07:00
Nilashish Chakraborty
05c7f7a230 Remove backup from iosxr replace_config test (#57830)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit af25274d6a)
2019-06-19 10:53:41 -07:00
Nathaniel Case
378ddec5c6 [stable-2.8] Fix RESTCONF media types (#58015)
Fixes #56680
(cherry picked from commit f656959)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
2019-06-19 10:39:34 -07:00
Martin Nečas
ab50e41a4c Ovirt vnic profile fix backport (#58058)
* Ovirt vnic profile fix (#57936)

* ovirt vnic profile fix init

* ovirt vnic profile fix init

* update syntax whitespace

* document pass_through

* create get entity method

* update example syntax

* update docs

* change force_create style

* add fragment
2019-06-19 06:24:02 -07:00
Martin Nečas
4a7a8ecf50 Ovirt nic default vnic backport (#58057)
* Ovirt nic default vnic (#57945)

* default vnic init

* ovirt default nic

* add spacing

* use network must be specified

* Update ovirt_nic.py

* Update ovirt_nic.py

* add no vnic profile exception

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax

* add fragment
2019-06-19 06:22:25 -07:00
Daniel Mellado Area
20fa1156b7 Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.

(cherry picked from commit 091bebcbf7)
2019-06-19 06:18:30 -07:00
Ganesh Nalawade
bafc95eb0f More iosxr integration zuul CI test fixes (#57909)
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test

(cherry picked from commit 4a3e14f90b)
2019-06-19 06:16:08 -07:00
Will Thames
1e5e663d42 rds_instance: allow empty iops and storage_type (#57943)
(cherry picked from commit a66687f2d2)
2019-06-18 12:22:27 -07:00
Stefan Horning
e720df0e5d Fix rds_instance module to run against an (older) existing RDS instance successfully
Only pop Iops param if no storage_type is given. If given and set to wrong type we get to the AWS client error that informs the user

Docs syntax fix

Fix typo in docs

Co-Authored-By: stefanhorning <stefan@hornings.de>

Added changelog fragment for rds_instance bugfix
2019-06-18 12:22:27 -07:00
Chris Archibald
221a14f674 add fragment 2019-06-18 12:22:03 -07:00
Chris Archibald
d4f2df7731 Bug Fixes for na_ontap_interface (#57363)
* bug fixes

* bug fix

(cherry picked from commit 98da0e6c99)
2019-06-18 12:22:03 -07:00
Jordan Borean
0c85472e9b Fix changelog entry (#57979)
(cherry picked from commit 40540f4d98)
2019-06-18 11:21:25 -07:00
Ganesh B Nalawade
ae995a19e2 Fix junos integration zuul CI failures
(cherry picked from commit 0957835a4814bfc0c7649675963de5e88df5060e)
2019-06-18 11:20:39 -07:00
Sumit Jaiswal
db13610701 fix 57447 bug (#57938)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit d63ccb5bc8)
2019-06-18 11:18:04 -07:00
Mariusz Mazur
b41bbd9564 Backport/2.8/57617 (#57756)
* kubevirt_pvc: fix parameter priority (#57617)

* Add changelog

* Drop superfluous dict()

Co-Authored-By: Toshio Kuratomi <a.badger@gmail.com>
2019-06-18 11:16:18 -07:00
Guillaume Martinez
36df5d22a4 gitlab_runner: Fix idempotency when creating runner (#57833)
(cherry picked from commit ec7b18952b)
2019-06-18 10:51:51 -07:00
Chris Archibald
fa6e39ddf2 Backport/2.8/57320 (#58009)
* new feature

(cherry picked from commit dbeaf30f975190cc20fbece88b12d8dd062aad07)

* add fragment
2019-06-18 10:47:47 -07:00
Guillaume Martinez
4c6a1254ef gitlab_group: doc: fix sample code that used 'parent_path' which does not exists (#56256) (#57997)
(cherry picked from commit a7bf728555)
2019-06-18 09:53:17 -05:00
Felix Fontein
b3c19e5aae Fix missing doc type. (#57884) (#57982)
(cherry picked from commit da6f6cc456)
2019-06-18 09:16:29 -05:00
Sayed Anisul Hoque
9da6fc1754 Documentation error (#57924)
* Update changelogs/fragments/contains-test.yaml - allowed filters are 'select/reject' and 'selectattr/rejectattr'.
2019-06-18 09:10:24 -05:00
Brian Coca
808c2faba2 show host_vars/ also in --graph (#56307)
* show host_vars/ also in --graph

  fixes #53422

(cherry picked from commit de87b25a45)
2019-06-17 21:58:41 -07:00
Paul Belanger
ee02a98d19 ansible-test: ios_command cli test should only be network_cli (#56955)
We do not support testing under ansible_connection=local

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 21:57:07 -07:00
Kevin Breit
81dc2ac233 [stable-2.8] - Restructure meraki_network execution (#57663)
* Resolve conflicts

* Fixes for the merge since 2.8 and devel are quite different

* Add changelog
2019-06-17 21:56:40 -07:00
ShachafGoldstein
ee48ceaf10 win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test

(cherry picked from commit 66728cb93f)
2019-06-17 21:47:14 -07:00
Jordan Borean
c1391fd636 win_shell - fix space escaping for custom executable (#57455)
(cherry picked from commit d0c4914469)
2019-06-17 21:38:16 -07:00
YuandongXu
ad0cc5dc1e Backport/2.8/57268 update acl (#57268) (#57890)
* update acl (#57268)


(cherry picked from commit e009936f87)

* add a changelog fragment for PR 57890.

* add a changelog fragment for PR 27890.
2019-06-17 21:37:42 -07:00
YuandongXu
da9f3021be Backport/2.8/57264 update vxlan to fix bugs (#57889)
* update vxlan (#57264)

* update vxlan

* add a changelog fragment for the PR 57264

* Update 57264-update-vxlan-to-fix-bugs.yml

update for change request

* Update ce_vxlan_vap.py

remove commented codes.

(cherry picked from commit 5bddd55703)

* add a changelog fragment for PR 57889.

* add a changelog fragment for PR 57889.
2019-06-17 21:35:28 -07:00
YuandongXu
9d3d8bec23 backport/2.8/57025 update snmp modules to fix bugs for cloudengine (#57025) (#57888)
* update snmp modules to fix bugs for cloudengine (#57025)

* update snmp modules to fix bugs for cloudengine

* update snmp modules to fix bugs for cloudengine

* update "ce_snmp_contact", list may be out range

(cherry picked from commit 5ac3661176)

* add a changelog fragment for PR 5788.

* add a changelog fragment for PR 57888.
2019-06-17 21:33:57 -07:00
Guillaume Martinez
0f651baf41 Backport/2.8/57024 (#57846)
* Adds visibility parameter to gitlab group creation (#57024)

(cherry picked from commit e7bf46d8bc)

* Add changelog for backport/2.8/57024
2019-06-17 21:32:42 -07:00
Sam Doran
0cc78fa3af [stable-2.8] Change RHEL8 image name to match changes in ansible-test (#57807)
* Change RHEL8 image name to match changes in ansible-test

Continue to use the beta version of RHEL 8 until we fix tests that are breaking with the GA version.

* Skip ufw integration test on RHEL 8 Beta
(cherry picked from commit 84075fe351)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-17 20:07:05 -07:00
Martin Krizek
188688cc6b gather_facts: clean up tmp files upon completion (#57845)
Fixes #57248

(cherry picked from commit e9c83b7a17)
2019-06-17 20:05:41 -07:00
Sander Steffann
d46c187470 netbox: inventory: fix implementation of groups option (#57689)
(cherry picked from commit 71a704cc14)
2019-06-17 20:04:24 -07:00
Nijin Ashok
bad860ad46 ovirt_vm: Fix issue in resetting the storage domain lease (#57469)
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
2019-06-17 20:03:55 -07:00
Alexey Kamenskiy
15880a0c23 lvg: fix default value type, should be str (#57723)
(cherry picked from commit 793c18506a)
2019-06-17 20:03:13 -07:00
Martin Nečas
0521b30515 set ovirt disk active default (#57464) (#57748)
* set ovirt disk active default  (#57464)

* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs

* Update ovirt_disk.py

* Update ovirt_disk.py
2019-06-17 20:01:57 -07:00
YuandongXu
466b039b1c backport/2.8/57269 update info-center (#57269) (#57752)
* update info-center (#57269)


(cherry picked from commit 4dc6faea59)

* add a changelog fragment fot PR 57752.
2019-06-17 20:00:11 -07:00
YuandongXu
bb6955c5eb Backport/2.8/57257 option is marked as required but specifies a default (#57750)
* option is marked as required but specifies a default (#57257)

* required and default are conflicting

(cherry picked from commit 05e6339c49)

* add a changelog fragment for PR 57750.
2019-06-17 18:29:35 -07:00
Felix Fontein
fd04094bde acme_*: new test container, tests for IP certificates (#57530)
* Bump container version.

* Use new URLs.

* Add IP certificate tests.

* Disable IPv6 IP from IP certificate.

Background: in CI, the ACME test container apparently has no IPv6 support.
Without IPv6 support, Pebble can't connect to validate, and thus validation
fails.

(cherry picked from commit c50a75a41e)
2019-06-17 18:27:47 -07:00
Martin Krizek
0690aab25d Actually run valid_include_keywords test (#57687)
(cherry picked from commit e8948f7655)
2019-06-17 18:27:02 -07:00
YuandongXu
1b073fccc2 backport/2.8/57187 update ce_facts to fix array out of range bug (#57187) (#57698)
* update ce_facts (#57187)


(cherry picked from commit 229d20b6d9)

* add a changlog fragment for PR 57698
2019-06-17 17:15:41 -07:00
Paul Belanger
d419a2777c Make netconf_get python3 compat (#57578)
This uses to_text to ensure tostring() from lxml is decoded properly.

Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f709d2e2bb)
2019-06-17 17:15:08 -07:00
YuandongXu
ce3e358587 Backport/2.8/57183 update lib/ansible/plugins/action/ce.py to fix a bug (#57696)
* update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)

* update lib/ansible/plugins/action/ce.py

(cherry picked from commit 9c3ae4c1f4)

* add a changelog fragment for PR 57696
2019-06-17 17:14:22 -07:00
Anton Nikulin
afb718f001 [stable-2.8] ftd_configuration: fix a bug with response parsing (#57480) (#57676)
* FTD configuration module: fix a bug with response parsing (#57480)

* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message

(cherry picked from commit 4fa93d5b9b)

* Add backlog entry
2019-06-17 16:27:42 -07:00
Abhijeet Kasurde
91b703b0f0 [2.8] VMware: Handle VMs with no configurations
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 7505550500)
2019-06-17 16:23:40 -07:00
ShachafGoldstein
dfc47bd6d6 win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog

(cherry picked from commit a87495d07c)
2019-06-17 15:48:47 -07:00
Matt Williams
133c7adad5 Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return

(cherry picked from commit cf00883c9d)
2019-06-17 15:47:20 -07:00
Paul Belanger
07806f36b6 Remove hardcoded ansible user for junos_user integration tests (#56452)
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: https://github.com/ansible/ansible/pull/57639
Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 15:46:33 -07:00
Sloane Hertel
4b0c8f1a12 [FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog

(cherry picked from commit 598a058afe)
2019-06-17 15:45:58 -07:00