Commit graph

44689 commits

Author SHA1 Message Date
YuandongXu
bb6955c5eb Backport/2.8/57257 option is marked as required but specifies a default (#57750)
* option is marked as required but specifies a default (#57257)

* required and default are conflicting

(cherry picked from commit 05e6339c49)

* add a changelog fragment for PR 57750.
2019-06-17 18:29:35 -07:00
Felix Fontein
fd04094bde acme_*: new test container, tests for IP certificates (#57530)
* Bump container version.

* Use new URLs.

* Add IP certificate tests.

* Disable IPv6 IP from IP certificate.

Background: in CI, the ACME test container apparently has no IPv6 support.
Without IPv6 support, Pebble can't connect to validate, and thus validation
fails.

(cherry picked from commit c50a75a41e)
2019-06-17 18:27:47 -07:00
Martin Krizek
0690aab25d Actually run valid_include_keywords test (#57687)
(cherry picked from commit e8948f7655)
2019-06-17 18:27:02 -07:00
YuandongXu
1b073fccc2 backport/2.8/57187 update ce_facts to fix array out of range bug (#57187) (#57698)
* update ce_facts (#57187)


(cherry picked from commit 229d20b6d9)

* add a changlog fragment for PR 57698
2019-06-17 17:15:41 -07:00
Paul Belanger
d419a2777c Make netconf_get python3 compat (#57578)
This uses to_text to ensure tostring() from lxml is decoded properly.

Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f709d2e2bb)
2019-06-17 17:15:08 -07:00
YuandongXu
ce3e358587 Backport/2.8/57183 update lib/ansible/plugins/action/ce.py to fix a bug (#57696)
* update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)

* update lib/ansible/plugins/action/ce.py

(cherry picked from commit 9c3ae4c1f4)

* add a changelog fragment for PR 57696
2019-06-17 17:14:22 -07:00
Anton Nikulin
afb718f001 [stable-2.8] ftd_configuration: fix a bug with response parsing (#57480) (#57676)
* FTD configuration module: fix a bug with response parsing (#57480)

* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message

(cherry picked from commit 4fa93d5b9b)

* Add backlog entry
2019-06-17 16:27:42 -07:00
Abhijeet Kasurde
91b703b0f0 [2.8] VMware: Handle VMs with no configurations
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 7505550500)
2019-06-17 16:23:40 -07:00
ShachafGoldstein
dfc47bd6d6 win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog

(cherry picked from commit a87495d07c)
2019-06-17 15:48:47 -07:00
Matt Williams
133c7adad5 Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return

(cherry picked from commit cf00883c9d)
2019-06-17 15:47:20 -07:00
Paul Belanger
07806f36b6 Remove hardcoded ansible user for junos_user integration tests (#56452)
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: https://github.com/ansible/ansible/pull/57639
Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 15:46:33 -07:00
Sloane Hertel
4b0c8f1a12 [FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog

(cherry picked from commit 598a058afe)
2019-06-17 15:45:58 -07:00
Eric Pulvino
dcb06ab78f Fix lack of support for Cumulus Linux with Hostname module in Ansible v2.8.0. (#57493)
(cherry picked from commit 1661c87bae)
2019-06-17 15:13:06 -07:00
Matt Martz
1422785f1f [stable-2.8] Provide a better error when python-dnf install fails (#57622)
(cherry picked from commit c3ca375)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-17 14:24:04 -07:00
xuxiaowei0512
b88a39fc22 add changelogs fragments 2019-06-17 14:23:29 -07:00
xuxiaowei0512
2f2a54f67f update ospf modules to fix bugs as software version changes (#56974)
(cherry picked from commit b7f4e2a190)
2019-06-17 14:23:29 -07:00
Martin Nečas
dd678197d3 Ovirt host facts fix (#57793)
* ovirt host facts fix (#57790)

* add changelog
2019-06-17 13:01:47 -07:00
Sebastiaan Mannem
9e100212e2 Backporting requires order option in new implementation 2019-06-17 13:01:08 -07:00
Sebastiaan Mannem
7b73604058 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-06-17 13:01:08 -07:00
Strahinja Kustudic
3368780cbd Added environment variables to gcp_compute to align with gcp_* modules (#57776)
Added all variables that are also used by the gcp_* modules as described
in the docs
https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables

(cherry picked from commit 8e9f29c40c)
2019-06-17 12:55:57 -07:00
Paul Belanger
335c2026fa Add missing changelog fragments
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Albert Siersema
0a8d237238 Issue55222 (#55223)
* Python 3.7 compatibility for re.Pattern (Fixes #55222)

* Python 3.7 compatibility for re.Pattern (Fixes #55222)
2019-06-17 12:55:30 -07:00
Paul Belanger
57e323dd8f Fix ios_smoke failure
Set ansible_buffer_read_timeout to be larger then
ansible_command_timeout, as both appliance / controller are on the same
physical network and we are not triggering ansible_command_timeout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Sumit Jaiswal
7f1888cef4 PR to fix the IOS_NTP integration TC failure (#57481)
* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix for local connection

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
545b5af2fb ios_ntp: Switch interface to GigabitEthernet0/1 for tests (#56964)
* ios_ntp: Switch interface to GigabitEthernet0/1 for tests

Lets use an interface we know that exists for testing, in some cases
Loopback0 maybe not be configured.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* ios_ntp: properly register result variable for testing

This is currently broken, and tests don't work. Fix this by properly
registering the result variable.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
b381967194 Fix syntax issue with ios_ntp tests
This was missing a yaml anchor.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
ac2f1c4a26 ansible-test: use become for connection=local on ios_user
ios_user requires escalated privledges, rather then doing this in the
inventory, we can just add it into the playbook tasks.

Also add missing provider settings for authorize.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
7b2906243b Add missing scp dependency for ios_file tests
This was required to be installed by a human, out side of our testing.
Add it so ansible-test can now manage.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Abhijeet Kasurde
034d030a89 [2.8] VMware: Fix vmware_guest_move undefined VM name error
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 00604d3f2c)
2019-06-17 12:51:13 -07:00
LucasBoisserie
e4a70d2822 Remove required field on service_account_file in gcp_compute plugin inventory (#57345)
(cherry picked from commit 1d76635206)
2019-06-17 11:39:21 -07:00
Strahinja Kustudic
dbaecb648e Improve speed of the gpc_compute dynamic inventory (#57591)
To get all instances gcp_compute made a call to the Google API for each
zone separately. Because of this if all zones needed to be queried
fetching hosts lasted 30+ seconds. Now the module will use a single
query that will return all the instances, so the execution should last
just a few seconds.

This commit also suppresses a warning from the google-auth library about
using user credentials because if an Ansible user wants to use user
credentials, there is no need to warn him about it.

(cherry picked from commit f6a0f9874d)
2019-06-17 11:38:16 -07:00
Sloane Hertel
01386cca4a preserve same order as inventory manager when using host lookup (#57769)
* preserve same order as inventory manager when using host lookup (#55331)

* preserve same order as inventory manager when using inventory_hostnames lookup

add a test

* move generic code

(cherry picked from commit afb5e02c19)

* changelog
2019-06-17 11:22:21 -07:00
Alicia Cozine
64a83a031a
Adds custom 404 with cowsay image (#57422) (#57955)
* Adds custom 404, updates CI reqs, TOC on 404 page links to latest

(cherry picked from commit 5658b2ee3e)
2019-06-17 11:55:03 -05:00
Mikhail Yohman
395b722585 Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix

(cherry picked from commit d07d394779)
2019-06-14 19:24:06 -07:00
Martin Krizek
ea735a1602 Fix --diff to produce output when creating a new file (#57744)
* Fix --diff to produce output when creating a new file

Fixes #57618

* Make the check more defensive

(cherry picked from commit 1fa7bfcd5d)
2019-06-14 19:23:08 -07:00
YuandongXu
2645c43a2b backport/2.8/57270 update vrf to fix bugs (#57270) (#57757)
* update vrf to fix bugs (#57270)

* update vrf

* update vrf

(cherry picked from commit 76e06fa7c2)

* add changelog fragment fot PR 57757.
2019-06-14 19:21:40 -07:00
YuandongXu
814349c368 Backport/2.8/56976 update ce_ntp.py to fix bug (#57175)
* update ce_ntp.py and remove the root tag name to find all nodes (#56976)

* add a maintainer

* update ce_ntp.py and remove the root tag name to find all node

* update ce_ntp.py and remove the root tag name to find all node

(cherry picked from commit 0137c4343b)

* add changelogs  fragments

* add changelogs  fragments
2019-06-14 19:20:07 -07:00
krisvasudevan
211a2da2b9 Backport to fix bug in nios member module (#57218)
* Bug fixes for the nios member object (#56045)

* Bug fixes in api.py

* Examples updated in nios_member.py

* Update lib/ansible/module_utils/net_tools/nios/api.py

Co-Authored-By: Sumit Jaiswal <sjaiswal@redhat.com>

(cherry picked from commit d998791b4a)

* Create 56045-nios-member-module.yaml

* Bug fixes to nios_member module
2019-06-14 11:51:44 -07:00
Simon Dodsley
35ffd2825d Make purefa_pgsnap module handle its own exit correctly
(cherry picked from commit d4c0269fbbb177165d9eeb2dbec450f8552face8)
2019-06-14 09:35:21 -07:00
Ian Wienand
daef4d9c95 openssh_keypair: make fingerprint result a string (#57295)
The extant documentation says that the fingerprint return value is a
single string, but it is currently being returned as a split list.
Convert the returned value to a string as documented, and add some
basic test-case coverage for the return values.

(cherry picked from commit 6f06fc9945)
2019-06-11 19:54:54 -07:00
Jordan Borean
074b71f7fe win_chocolatey - honour version when bootstrapping chocolatey and fix package listing - 2.8 (#57380)
* win_chocolatey - honour version when bootstrapping chocolatey and fix package listing (#57208)

* win_chocolatey - honour version when bootstrapping chocolatey

* skip upgrade all step

* Fix install latest step

* Remove test changes now that Chocolatey is released

* tweak the package version detection

(cherry picked from commit b5b75daaa5)

* removed disabled alias
2019-06-11 19:54:11 -07:00
Trishna Guha
b8a41594fc nxos_snmp_user, nxos_snmp_host integration test fixes. (#57201) (#57443)
* Fix nxos_snmp tests

* Add imagetag check for nxos_snmp_user test

(cherry picked from commit 87422ea7e7)
2019-06-11 19:53:28 -07:00
Trishna Guha
28db439e01 nxos_logging facilties defaults (#57144) (#57444)
* Add new logging facilties defaults (#57144)


(cherry picked from commit 1dc3fe5317)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:53:02 -07:00
Trishna Guha
736e26f019 Fix nxos_vtp_version test (#57358) (#57445)
(cherry picked from commit 870d8bf10b)
2019-06-11 19:52:19 -07:00
Trishna Guha
b428d36724 nxos_install_os: Fix nxapi local failures (#55993) (#57446)
* nxos_install_os: Fix nxapi local failures (#55993)

* Fix nxapi failures

* Remove logit debug calls

* Remove msg_timestamps

* Fix code alignment issue

(cherry picked from commit 7c73dd3e78)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:51:50 -07:00
Trishna Guha
30aba1a7fd nxos_vlan purge fix 2.8 (#57442)
* nxos_vlan: fix broken purge behavior (issue #57101) (#57229)

* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check

(cherry picked from commit 6bb13bbb84)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:50:35 -07:00
James Cassell
769cc117a7 group_chars: default change warning only when needed
(cherry picked from commit 1fb0335243)
2019-06-11 19:49:18 -07:00
dw
b6d74466d4 [stable-2.8] Fix file descriptor leak in lineinfile module. (#57328)
(cherry picked from commit 3fadf4a1cb)

Co-authored-by: dw <dw@botanicus.net>
2019-06-11 19:48:42 -07:00
Sumit Jaiswal
e6e797af6e Backport PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57347)
* PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57221)

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* shippable error fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit e620e27609)

* B_PR for PR57721

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* renaming changelog file

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* renaming changelog file

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-11 19:48:07 -07:00
Sloane Hertel
95b1b42d4f improve conditional warnings (#57190)
* Fix order for warning on templated conditionals

Fix bare variable warnings when the variable is a boolean

* changelog

* Add tests for cases that should and should not give warnings

If the behavior may change when the default behavior for CONDITIONAL_BARE_VARS becomes False there should be a warning. Boolean type conditionals will not change in behavior so don't warn.

* oops, forgot to add files

* typo

(cherry picked from commit 21cd24a0dd)
2019-06-11 19:44:01 -07:00