Commit graph

44702 commits

Author SHA1 Message Date
ShachafGoldstein
ee48ceaf10 win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test

(cherry picked from commit 66728cb93f)
2019-06-17 21:47:14 -07:00
Jordan Borean
c1391fd636 win_shell - fix space escaping for custom executable (#57455)
(cherry picked from commit d0c4914469)
2019-06-17 21:38:16 -07:00
YuandongXu
ad0cc5dc1e Backport/2.8/57268 update acl (#57268) (#57890)
* update acl (#57268)


(cherry picked from commit e009936f87)

* add a changelog fragment for PR 57890.

* add a changelog fragment for PR 27890.
2019-06-17 21:37:42 -07:00
YuandongXu
da9f3021be Backport/2.8/57264 update vxlan to fix bugs (#57889)
* update vxlan (#57264)

* update vxlan

* add a changelog fragment for the PR 57264

* Update 57264-update-vxlan-to-fix-bugs.yml

update for change request

* Update ce_vxlan_vap.py

remove commented codes.

(cherry picked from commit 5bddd55703)

* add a changelog fragment for PR 57889.

* add a changelog fragment for PR 57889.
2019-06-17 21:35:28 -07:00
YuandongXu
9d3d8bec23 backport/2.8/57025 update snmp modules to fix bugs for cloudengine (#57025) (#57888)
* update snmp modules to fix bugs for cloudengine (#57025)

* update snmp modules to fix bugs for cloudengine

* update snmp modules to fix bugs for cloudengine

* update "ce_snmp_contact", list may be out range

(cherry picked from commit 5ac3661176)

* add a changelog fragment for PR 5788.

* add a changelog fragment for PR 57888.
2019-06-17 21:33:57 -07:00
Guillaume Martinez
0f651baf41 Backport/2.8/57024 (#57846)
* Adds visibility parameter to gitlab group creation (#57024)

(cherry picked from commit e7bf46d8bc)

* Add changelog for backport/2.8/57024
2019-06-17 21:32:42 -07:00
Sam Doran
0cc78fa3af [stable-2.8] Change RHEL8 image name to match changes in ansible-test (#57807)
* Change RHEL8 image name to match changes in ansible-test

Continue to use the beta version of RHEL 8 until we fix tests that are breaking with the GA version.

* Skip ufw integration test on RHEL 8 Beta
(cherry picked from commit 84075fe351)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-17 20:07:05 -07:00
Martin Krizek
188688cc6b gather_facts: clean up tmp files upon completion (#57845)
Fixes #57248

(cherry picked from commit e9c83b7a17)
2019-06-17 20:05:41 -07:00
Sander Steffann
d46c187470 netbox: inventory: fix implementation of groups option (#57689)
(cherry picked from commit 71a704cc14)
2019-06-17 20:04:24 -07:00
Nijin Ashok
bad860ad46 ovirt_vm: Fix issue in resetting the storage domain lease (#57469)
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
2019-06-17 20:03:55 -07:00
Alexey Kamenskiy
15880a0c23 lvg: fix default value type, should be str (#57723)
(cherry picked from commit 793c18506a)
2019-06-17 20:03:13 -07:00
Martin Nečas
0521b30515 set ovirt disk active default (#57464) (#57748)
* set ovirt disk active default  (#57464)

* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs

* Update ovirt_disk.py

* Update ovirt_disk.py
2019-06-17 20:01:57 -07:00
YuandongXu
466b039b1c backport/2.8/57269 update info-center (#57269) (#57752)
* update info-center (#57269)


(cherry picked from commit 4dc6faea59)

* add a changelog fragment fot PR 57752.
2019-06-17 20:00:11 -07:00
YuandongXu
bb6955c5eb Backport/2.8/57257 option is marked as required but specifies a default (#57750)
* option is marked as required but specifies a default (#57257)

* required and default are conflicting

(cherry picked from commit 05e6339c49)

* add a changelog fragment for PR 57750.
2019-06-17 18:29:35 -07:00
Felix Fontein
fd04094bde acme_*: new test container, tests for IP certificates (#57530)
* Bump container version.

* Use new URLs.

* Add IP certificate tests.

* Disable IPv6 IP from IP certificate.

Background: in CI, the ACME test container apparently has no IPv6 support.
Without IPv6 support, Pebble can't connect to validate, and thus validation
fails.

(cherry picked from commit c50a75a41e)
2019-06-17 18:27:47 -07:00
Martin Krizek
0690aab25d Actually run valid_include_keywords test (#57687)
(cherry picked from commit e8948f7655)
2019-06-17 18:27:02 -07:00
YuandongXu
1b073fccc2 backport/2.8/57187 update ce_facts to fix array out of range bug (#57187) (#57698)
* update ce_facts (#57187)


(cherry picked from commit 229d20b6d9)

* add a changlog fragment for PR 57698
2019-06-17 17:15:41 -07:00
Paul Belanger
d419a2777c Make netconf_get python3 compat (#57578)
This uses to_text to ensure tostring() from lxml is decoded properly.

Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f709d2e2bb)
2019-06-17 17:15:08 -07:00
YuandongXu
ce3e358587 Backport/2.8/57183 update lib/ansible/plugins/action/ce.py to fix a bug (#57696)
* update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)

* update lib/ansible/plugins/action/ce.py

(cherry picked from commit 9c3ae4c1f4)

* add a changelog fragment for PR 57696
2019-06-17 17:14:22 -07:00
Anton Nikulin
afb718f001 [stable-2.8] ftd_configuration: fix a bug with response parsing (#57480) (#57676)
* FTD configuration module: fix a bug with response parsing (#57480)

* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message

(cherry picked from commit 4fa93d5b9b)

* Add backlog entry
2019-06-17 16:27:42 -07:00
Abhijeet Kasurde
91b703b0f0 [2.8] VMware: Handle VMs with no configurations
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 7505550500)
2019-06-17 16:23:40 -07:00
ShachafGoldstein
dfc47bd6d6 win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog

(cherry picked from commit a87495d07c)
2019-06-17 15:48:47 -07:00
Matt Williams
133c7adad5 Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return

(cherry picked from commit cf00883c9d)
2019-06-17 15:47:20 -07:00
Paul Belanger
07806f36b6 Remove hardcoded ansible user for junos_user integration tests (#56452)
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: https://github.com/ansible/ansible/pull/57639
Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 15:46:33 -07:00
Sloane Hertel
4b0c8f1a12 [FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog

(cherry picked from commit 598a058afe)
2019-06-17 15:45:58 -07:00
Eric Pulvino
dcb06ab78f Fix lack of support for Cumulus Linux with Hostname module in Ansible v2.8.0. (#57493)
(cherry picked from commit 1661c87bae)
2019-06-17 15:13:06 -07:00
Matt Martz
1422785f1f [stable-2.8] Provide a better error when python-dnf install fails (#57622)
(cherry picked from commit c3ca375)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-17 14:24:04 -07:00
xuxiaowei0512
b88a39fc22 add changelogs fragments 2019-06-17 14:23:29 -07:00
xuxiaowei0512
2f2a54f67f update ospf modules to fix bugs as software version changes (#56974)
(cherry picked from commit b7f4e2a190)
2019-06-17 14:23:29 -07:00
Martin Nečas
dd678197d3 Ovirt host facts fix (#57793)
* ovirt host facts fix (#57790)

* add changelog
2019-06-17 13:01:47 -07:00
Sebastiaan Mannem
9e100212e2 Backporting requires order option in new implementation 2019-06-17 13:01:08 -07:00
Sebastiaan Mannem
7b73604058 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-06-17 13:01:08 -07:00
Strahinja Kustudic
3368780cbd Added environment variables to gcp_compute to align with gcp_* modules (#57776)
Added all variables that are also used by the gcp_* modules as described
in the docs
https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables

(cherry picked from commit 8e9f29c40c)
2019-06-17 12:55:57 -07:00
Paul Belanger
335c2026fa Add missing changelog fragments
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Albert Siersema
0a8d237238 Issue55222 (#55223)
* Python 3.7 compatibility for re.Pattern (Fixes #55222)

* Python 3.7 compatibility for re.Pattern (Fixes #55222)
2019-06-17 12:55:30 -07:00
Paul Belanger
57e323dd8f Fix ios_smoke failure
Set ansible_buffer_read_timeout to be larger then
ansible_command_timeout, as both appliance / controller are on the same
physical network and we are not triggering ansible_command_timeout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Sumit Jaiswal
7f1888cef4 PR to fix the IOS_NTP integration TC failure (#57481)
* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix for local connection

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
545b5af2fb ios_ntp: Switch interface to GigabitEthernet0/1 for tests (#56964)
* ios_ntp: Switch interface to GigabitEthernet0/1 for tests

Lets use an interface we know that exists for testing, in some cases
Loopback0 maybe not be configured.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* ios_ntp: properly register result variable for testing

This is currently broken, and tests don't work. Fix this by properly
registering the result variable.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
b381967194 Fix syntax issue with ios_ntp tests
This was missing a yaml anchor.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
ac2f1c4a26 ansible-test: use become for connection=local on ios_user
ios_user requires escalated privledges, rather then doing this in the
inventory, we can just add it into the playbook tasks.

Also add missing provider settings for authorize.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
7b2906243b Add missing scp dependency for ios_file tests
This was required to be installed by a human, out side of our testing.
Add it so ansible-test can now manage.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Abhijeet Kasurde
034d030a89 [2.8] VMware: Fix vmware_guest_move undefined VM name error
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 00604d3f2c)
2019-06-17 12:51:13 -07:00
LucasBoisserie
e4a70d2822 Remove required field on service_account_file in gcp_compute plugin inventory (#57345)
(cherry picked from commit 1d76635206)
2019-06-17 11:39:21 -07:00
Strahinja Kustudic
dbaecb648e Improve speed of the gpc_compute dynamic inventory (#57591)
To get all instances gcp_compute made a call to the Google API for each
zone separately. Because of this if all zones needed to be queried
fetching hosts lasted 30+ seconds. Now the module will use a single
query that will return all the instances, so the execution should last
just a few seconds.

This commit also suppresses a warning from the google-auth library about
using user credentials because if an Ansible user wants to use user
credentials, there is no need to warn him about it.

(cherry picked from commit f6a0f9874d)
2019-06-17 11:38:16 -07:00
Sloane Hertel
01386cca4a preserve same order as inventory manager when using host lookup (#57769)
* preserve same order as inventory manager when using host lookup (#55331)

* preserve same order as inventory manager when using inventory_hostnames lookup

add a test

* move generic code

(cherry picked from commit afb5e02c19)

* changelog
2019-06-17 11:22:21 -07:00
Alicia Cozine
64a83a031a
Adds custom 404 with cowsay image (#57422) (#57955)
* Adds custom 404, updates CI reqs, TOC on 404 page links to latest

(cherry picked from commit 5658b2ee3e)
2019-06-17 11:55:03 -05:00
Mikhail Yohman
395b722585 Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix

(cherry picked from commit d07d394779)
2019-06-14 19:24:06 -07:00
Martin Krizek
ea735a1602 Fix --diff to produce output when creating a new file (#57744)
* Fix --diff to produce output when creating a new file

Fixes #57618

* Make the check more defensive

(cherry picked from commit 1fa7bfcd5d)
2019-06-14 19:23:08 -07:00
YuandongXu
2645c43a2b backport/2.8/57270 update vrf to fix bugs (#57270) (#57757)
* update vrf to fix bugs (#57270)

* update vrf

* update vrf

(cherry picked from commit 76e06fa7c2)

* add changelog fragment fot PR 57757.
2019-06-14 19:21:40 -07:00
YuandongXu
814349c368 Backport/2.8/56976 update ce_ntp.py to fix bug (#57175)
* update ce_ntp.py and remove the root tag name to find all nodes (#56976)

* add a maintainer

* update ce_ntp.py and remove the root tag name to find all node

* update ce_ntp.py and remove the root tag name to find all node

(cherry picked from commit 0137c4343b)

* add changelogs  fragments

* add changelogs  fragments
2019-06-14 19:20:07 -07:00