Commit graph

17870 commits

Author SHA1 Message Date
John Molakvoæ (skjnldsv)
323dd31056
Tooltip fix on status icon
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:37 +01:00
John Molakvoæ (skjnldsv)
1f3eef9460
fixup! Changed config saving feedback design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:34 +01:00
John Molakvoæ (skjnldsv)
884605ac18
Better label styling
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:32 +01:00
John Molakvoæ (skjnldsv)
0cc520f3a0
Changed config saving feedback design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:32 +01:00
Morris Jobke
9aaf1c2a06
Show hint in OCS API for user creation
* adds a 107 error code together with the hint of the exception
* logs the exception as warning
* fixes #7946

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-22 14:16:49 +01:00
Arthur Schiwon
9bc75307e7
track the state of the bind result
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 13:05:33 +01:00
John Molakvoæ (skjnldsv)
1e2a082cd2
Use popovermenu instead of dropdown and small fix to popovermenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 12:15:32 +01:00
Arthur Schiwon
49ec5ff4e4
2nd parameter to t() must be array
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 12:10:30 +01:00
Joas Schilling
6340e78be8
Use mixin for translations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:19:55 +01:00
Joas Schilling
59c007bedd
Use VueSelect instead of select2
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:42 +01:00
Joas Schilling
308c7db333
Move updatenotifications to webpack with .vue file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:42 +01:00
Joas Schilling
b12b391d7c
Migrate the app to Vue.js
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:41 +01:00
Joas Schilling
52f8d75d1a
Rename legacy notification so it's less confusing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:41 +01:00
Roeland Jago Douma
a660946ac6
Merge pull request #8490 from nextcloud/strict_systemtags
Make SystemTag strict
2018-02-22 10:01:20 +01:00
Nextcloud bot
4b352a345b
[tx-robot] updated from transifex 2018-02-22 01:12:26 +00:00
Roeland Jago Douma
096ea2c390
Properly cast
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 22:45:28 +01:00
Sagorika Das
dca75448d0 rename dialog closed when not active
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-02-21 23:16:27 +05:30
Kyle Fazzari
a1f1824116
theming: handle not being in the serverroot
Currently, the theming app assumes it's in the serverroot. However, with
Nextcloud's flexibility regarding configurable app paths, this is not a
safe assumption to make. If it happens to be an incorrect assumption,
the theming app fails to work.

Instead of relying on the serverroot, just use the path from the
AppManager and utilize relative paths for assets from there.

Fix #8462

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-02-20 22:45:10 -08:00
Nextcloud bot
6591a3bc36
[tx-robot] updated from transifex 2018-02-21 01:12:10 +00:00
Roeland Jago Douma
30017e3364
Properly set the mount type for external storages
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-20 15:51:12 +01:00
Nextcloud bot
c48332a14f
[tx-robot] updated from transifex 2018-02-20 01:11:55 +00:00
Robin Appelman
817f2f8f49
adjust swift external storage to new openstack sdk
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-19 19:41:16 +01:00
Roeland Jago Douma
7ad1e13961
Merge pull request #8158 from nextcloud/s3-minio
Use a more widely available method to test s3 settings
2018-02-19 17:09:36 +01:00
Morris Jobke
70b1f510f2
Use normal header() calls instead of private method calls
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-19 09:40:25 +01:00
Nextcloud bot
b3ca73dc27
[tx-robot] updated from transifex 2018-02-19 01:11:54 +00:00
Nextcloud bot
667d21ac7d
[tx-robot] updated from transifex 2018-02-18 01:12:03 +00:00
Morris Jobke
ac63c207a9
Merge pull request #8411 from nextcloud/add-strict-types-to-oc_app
Add strict types to OC_App
2018-02-17 21:34:20 +01:00
Morris Jobke
edee243b27
OC_App::loadApps now only accepts an array as type list
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 15:27:43 +01:00
Nextcloud bot
d953db8683
[tx-robot] updated from transifex 2018-02-17 01:12:04 +00:00
Joas Schilling
f095001e4b
Fix info.xml files of shipped apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 10:24:03 +01:00
Nextcloud bot
620ee00ac5
[tx-robot] updated from transifex 2018-02-16 01:12:10 +00:00
Roland Tapken
38ba64af77 Split move and copy operations
The new 'Move and copy' operation from #6040 requires UPDATE permissions
on the selected files. However, READ would be sufficient to create a
copy of a file (if not viewed as a public share). For this reason this patch:

- changes the permission of the 'MoveCopy' action to PERMISSION_READ
- changes the label of the action depending on the permissions
- changes the available buttons in the Move/Copy dialog depending on the
  permissions.

The same changes are done to the filelist view for bulk actions.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-15 18:51:12 +01:00
Joas Schilling
339e320064
Fix existing usages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-15 12:18:51 +01:00
Julius Härtl
c300a64520
Merge pull request #8277 from nextcloud/avatars-shared-all
Show share owner avatars on all file lists
2018-02-15 12:11:09 +01:00
Nextcloud bot
01623d4aca
[tx-robot] updated from transifex 2018-02-14 21:37:31 +00:00
Morris Jobke
236086c457
Merge pull request #8335 from nextcloud/remove-unused-import
Remove unused import statements
2018-02-14 22:23:07 +01:00
Arthur Schiwon
aeb7503feb
fix systemtags event with numeric user ids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 17:02:54 +01:00
Morris Jobke
d3d045dd5c
Remove unused import statements
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
Arthur Schiwon
023d028c57
fix creating comments when file is accessible to users with numeric ids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:39 +01:00
Arthur Schiwon
a5a0a938f2
test creating comments with numeric user ids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:10 +01:00
Joas Schilling
c32a94b78d
Merge pull request #8337 from nextcloud/use-non-alias-method
Use non aliased method instead
2018-02-14 10:09:09 +01:00
Joas Schilling
d1fb939e86
Merge pull request #8338 from nextcloud/simplify-return-statement
Simplify return statement
2018-02-14 10:08:28 +01:00
Nextcloud bot
ff1b343c4a
[tx-robot] updated from transifex 2018-02-14 01:11:53 +00:00
Morris Jobke
e2974f1133
Simplify return statement
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:55:24 +01:00
Morris Jobke
954da26e26
Use non aliased method instead
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:48:24 +01:00
Nextcloud bot
3fc6d6234e
[tx-robot] updated from transifex 2018-02-13 10:48:27 +00:00
Nextcloud bot
91c67eb667
[tx-robot] updated from transifex 2018-02-12 21:33:37 +00:00
Joas Schilling
4bd14ef308
Merge pull request #8308 from nextcloud/public_link_wa_preview
Show open graph preview in WhatsApp
2018-02-12 11:09:08 +01:00
Roeland Jago Douma
20844c828a
Show open graph preview in WhatsApp
Whatsapp is picky about the size of the open graph images.
So we do some special handling.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-12 10:42:18 +01:00
Joas Schilling
a11415b167
Fix example regex for user agent matching
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-10 16:39:53 +01:00
Roland Tapken
8e251e5d5a Make SMB module more fault-tolerant
Ignore unavailable files when fetching the share's mtime
or reading directory listings. This can happen on servers using a
distributed file system (DFS) with unavailable destinations, for example
when the remote server is offline.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-09 17:40:00 +01:00
Nextcloud bot
ee77f37df2
[tx-robot] updated from transifex 2018-02-09 15:28:58 +00:00
Julius Härtl
cae311460a
Show share owner avatars on all file lists
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-09 11:42:47 +01:00
Nextcloud bot
15b4797629
[tx-robot] updated from transifex 2018-02-09 01:10:53 +00:00
Morris Jobke
12c9bad5b2
Merge pull request #8100 from nextcloud/s3-folder-delete
Fix deleting folders when using s3 external storage
2018-02-08 14:11:12 +01:00
Robin Appelman
48ea714341
Use a more widely available method to test s3 settings
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 09:34:05 +01:00
Morris Jobke
e5c08621af
Merge pull request #8023 from nextcloud/webdavsearch_limit_order_fixing
Respect limit and order in webdav search
2018-02-08 09:11:39 +01:00
Nextcloud bot
71382daf67
[tx-robot] updated from transifex 2018-02-08 01:10:28 +00:00
Robin Appelman
e4129b0dc7
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 14:55:50 +01:00
Roeland Jago Douma
c1ff12e234
CacheJail should apply limit and offset after searching
Else the results might not be correct.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
Robin Appelman
6b5419ddf0
Adjust to updated searchdav library
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:41:15 +01:00
Roeland Jago Douma
ec144281ef
Respect limit and order in webdav search
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
Robin Appelman
9d6d23d1f7
keep previous exception when transforming to dav exception
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:34:30 +01:00
Nextcloud bot
3063131e6d
[tx-robot] updated from transifex 2018-02-07 11:31:55 +00:00
Roland Tapken
cf4ec7a4b6 Apply ldapUserFilter on members of group
Refers to issue #8220

user_ldap configured with custom filters for active directory access
(group-member-association is "member"). Then it can happen that the
members of a group contain members that don't belong to the users
available in Nextcloud (the most trivial reason is that the user filter
contains "(!(UserAccountControl:1.2.840.113556.1.4.803:=2))" to exclude
disabled users from being imported).

This can be fixed by applying the ldapUserFilter when resolving the UID
for a DN fetched from the group's member list.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-07 12:02:58 +01:00
Nextcloud bot
2a3272331f
[tx-robot] updated from transifex 2018-02-07 01:10:23 +00:00
Morris Jobke
0225ea1b9a
Merge pull request #8155 from nextcloud/use-guest-css
Fix styling issues of guest pages
2018-02-05 12:14:09 +01:00
Nextcloud bot
a0dfc7d34a
[tx-robot] updated from transifex 2018-02-05 01:10:16 +00:00
Nextcloud bot
58b568fd5d
[tx-robot] updated from transifex 2018-02-04 01:10:28 +00:00
Roeland Jago Douma
79e81c15c5
Merge pull request #8163 from nextcloud/fix_themeing_test
Fix theming test
2018-02-03 14:11:03 +01:00
Nextcloud bot
7af48b4187
[tx-robot] updated from transifex 2018-02-03 01:10:30 +00:00
Roeland Jago Douma
0bde91600a
Fix theming test
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-02 21:26:33 +01:00
Julius Härtl
1ac352de6c
Add space on guest pages with custom logo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-02 14:20:13 +01:00
Julius Härtl
39461a2e09
Make sure theming logo css only applies when a logo is set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-02 14:20:12 +01:00
Morris Jobke
6428cf552c
Merge pull request #8122 from nextcloud/fix-6851
fix reading the ldapIgnoreNamingRule config value
2018-02-02 09:34:03 +01:00
Nextcloud bot
17a2dbb7de
[tx-robot] updated from transifex 2018-02-02 01:10:15 +00:00
Nextcloud bot
b78da27d0a
[tx-robot] updated from transifex 2018-02-01 18:28:02 +00:00
Nextcloud bot
b006f25457
[tx-robot] updated from transifex 2018-02-01 17:19:47 +00:00
Morris Jobke
4739076474
Use correct update server
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-01 13:22:36 +01:00
blizzz
8f29f9a59b
typo
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 21:50:55 +01:00
Julius Härtl
372e06d742
Add all parameters to returnValueMap
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:12 +01:00
Julius Härtl
44b002665c
Remove deprecated isEnabled call from files_trashbin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:13:15 +01:00
Arthur Schiwon
8753a816d8
fixes reading the sysconfig value
settings without the entry in the translation array are computed

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 13:46:13 +01:00
Nextcloud bot
cb26f6d014
[tx-robot] updated from transifex 2018-01-31 01:10:51 +00:00
Morris Jobke
78e4f6f312
Merge pull request #8000 from nextcloud/fix_7983
Provide list of editable fields via OCS API
2018-01-30 22:46:20 +01:00
Roeland Jago Douma
48884c9b6a
Merge pull request #8111 from nextcloud/only_encrypted_prop_on_folders
Only handle encrypted property on folders
2018-01-30 21:54:18 +01:00
Roeland Jago Douma
9896b15ec8
Only handle encrypted property on folders
Exposing the encrypted property is required for E2E. However, there is
no need to expose this on files as then it is server side encryption
(which the clients don't care about).

Better to not confuse the output.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-30 12:25:49 +01:00
Nextcloud bot
3867717107
[tx-robot] updated from transifex 2018-01-30 01:11:04 +00:00
Morris Jobke
4fcdfbf5de
Merge pull request #8078 from nextcloud/theming-validate-scss
SCSS hardening
2018-01-29 16:12:10 +01:00
Robin Appelman
84bd2b6bc9
fix invalidating folder cache for s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-29 15:09:15 +01:00
Robin Appelman
7afd77604e
adjust s3 bulk delete to new sdk syntax
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-29 15:06:10 +01:00
Morris Jobke
eb51f06a3b
Use ::class statement instead of string
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
Nextcloud bot
1d8b90b8d3
[tx-robot] updated from transifex 2018-01-29 01:10:53 +00:00
Morris Jobke
a661f043e1
Remove unneeded semicolon and parentheses
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
Julius Härtl
5dbf733395
Fix theming tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 20:13:28 +01:00
Julius Härtl
6770213649
Do not rewrite absolute URLs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:08:45 +01:00
Julius Härtl
60e601f4ab
Only override image styles if the theming values are set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:05:10 +01:00
Morris Jobke
9be6050cc4
Merge pull request #8072 from nextcloud/type-casting
Use type casting instead of *val() method
2018-01-26 17:34:55 +01:00
Morris Jobke
97c216ea06
Merge pull request #8071 from nextcloud/remove-silly-code
Cleanup unused code
2018-01-26 15:47:06 +01:00
Morris Jobke
c67736a542
Merge pull request #7707 from nextcloud/bugfix/noid/birthdaycalendar-different-uids
generate different UIDs for Birthday, Anniversary and Death event
2018-01-26 15:46:46 +01:00
Morris Jobke
08d184816f
Merge pull request #8070 from nextcloud/remove-theming-migration
Remove theming migration
2018-01-26 15:46:29 +01:00
Morris Jobke
4c38d1ed01
Merge pull request #8054 from nextcloud/substr-use-index
Use index based string access for substr with length of 1
2018-01-26 15:40:44 +01:00
Morris Jobke
c005fc6755
Cleanup unused code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:25:19 +01:00
Julius Härtl
5e325730d6
Remove theming migration
Those images are alredy migrated after the instance has been updated to NC12

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 15:10:22 +01:00
Morris Jobke
2ad2eb38e8
Use type casting instead of *val() method
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:01:27 +01:00
Morris Jobke
ca493ab5b1
Merge pull request #8069 from nextcloud/no-catch-serverdown
do not catch and ignore ServerNotAvailable in the wrong spot
2018-01-26 14:01:07 +01:00
Morris Jobke
9ff51aafc5
Use index based string access for substr with length of 1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 13:38:34 +01:00
Roeland Jago Douma
119896a8d7
Fix tests
* Add factory for the federatedfilesharing app

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 12:49:11 +01:00
Arthur Schiwon
b61b906abe
do not catch ServerNotAvailable
might cause the user to be unavailable (race condition).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-26 12:47:19 +01:00
Morris Jobke
6bbea33133
Simplify ternary operator statements
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 12:36:25 +01:00
Morris Jobke
c1e4f9f305
Use type casting instead of *val() method
It should be up to 6x faster

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +01:00
Roeland Jago Douma
f3723434ee
Don't expose language and password as editable
* Password might not always be editable
  - Also chaging that will invalide apptokens etc which will directly
  lock out your phone
* Chaging the language also doesn't make that much sense to me currently

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 11:22:20 +01:00
Roeland Jago Douma
70b19761aa
Provide list of editable fields via OCS API
Fixes #7983

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 11:20:58 +01:00
Joas Schilling
a7ad7cb08e
Merge pull request #8053 from nextcloud/simplify-substr
Use short for of substr to not need strlen()
2018-01-26 10:25:09 +01:00
Joas Schilling
c2b1bd92d6
Merge pull request #8063 from nextcloud/inline-value
Return value immediately instead of assigning to a one-time variable
2018-01-26 10:15:39 +01:00
Roeland Jago Douma
ec1d94c629
Merge pull request #8052 from nextcloud/fix-array-methods
Fix array method usages with a proper call
2018-01-26 09:53:13 +01:00
Roeland Jago Douma
5a7a5e5352
Merge pull request #8058 from nextcloud/useless-return
Remove useless return statements
2018-01-26 09:51:26 +01:00
Roeland Jago Douma
68f44a9a93
Merge pull request #8059 from nextcloud/use-stripos
Use stripos instead of strpos(strtolower(), 'something')
2018-01-26 09:50:31 +01:00
Roeland Jago Douma
43ed8b446c
Merge pull request #8060 from nextcloud/proper-codeflow
Use proper code flow instead of not needed else branch
2018-01-26 09:49:30 +01:00
Roeland Jago Douma
aebb443ca5
Merge pull request #8056 from nextcloud/array-push
Use $var[] = $a instead of array_push - 2x faster
2018-01-26 09:41:31 +01:00
Nextcloud bot
469b3724b5
[tx-robot] updated from transifex 2018-01-26 01:10:52 +00:00
Morris Jobke
0a56d2185e
Return value immediately instead of assigning to a one-time variable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +01:00
Morris Jobke
16a558871c
Use proper code flow instead of not needed else branch
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 23:01:03 +01:00
Morris Jobke
464f024fa9
Use stripos instead of strpos(strtolower(), 'something')
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:59:50 +01:00
Morris Jobke
4dbee99b7b
Remove useless return statements
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:50:40 +01:00
Morris Jobke
870fe20acc
Use $var[] = $a instead of array_push - 2x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:36:03 +01:00
Morris Jobke
e6efa755c9
Use short for of substr to not need strlen()
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:23:48 +01:00
Morris Jobke
7800a9bc24
Fix array method usages with a proper call
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:20:10 +01:00
Morris Jobke
b9bbb894f8
Merge pull request #7916 from nextcloud/2fa_log
Add 2FA to logfile
2018-01-25 15:57:32 +01:00
Roeland Jago Douma
8160d0bc2a
Merge pull request #8036 from nextcloud/phpunit6
Require PHPUnit 6.5 or higher
2018-01-25 14:50:46 +01:00
Roeland Jago Douma
9e76577ead
Add tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:44:47 +01:00
Roeland Jago Douma
a5fe6a6118
Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
Roeland Jago Douma
b2ca1d6553
Make admin_audit listen to 2fa events
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
Joas Schilling
3917a54113
Class "ProgressBar" is declared "final" and cannot be mocked.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:26 +01:00
Joas Schilling
bf2be08c9f
Fix risky tests without assertions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:25 +01:00
Joas Schilling
870023365c
Fix "Undefined method setExpectedException()"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 18:10:16 +01:00
Joas Schilling
c3424df1f0
Require PHPUnit 6.5 or higher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 17:23:59 +01:00
Daniel Calviño Sánchez
5d7eded809 Fix missing clipboard icon in shared links
The clipboard icon in shared links appears either directly on the link
input field or, if any social sharing app is enabled, in a menu. The
clipboard icon uses the same CSS rules as other icons (like the
information icon) to be posioned on the end of the input field, and
those rules have to be "cancelled" when the icon is shown in the menu.

Fixes #7990

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-24 16:40:21 +01:00
Roeland Jago Douma
cda811b6b4
Make filelist and sidebar use the fileid preview endpoint
This makes sure the preview is cached even after rename! yay!

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-24 11:24:18 +01:00
Roeland Jago Douma
4537faa5da
Merge pull request #7918 from nextcloud/properly-log-exceptions
Properly log the full exception instead of only the message
2018-01-23 11:56:02 +01:00
Morris Jobke
2a38605545
Properly log the full exception instead of only the message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-23 10:57:21 +01:00
Nextcloud bot
cc4f9986cf
[tx-robot] updated from transifex 2018-01-23 01:10:50 +00:00
blizzz
c7d9e5fd63
Merge pull request #7354 from nextcloud/refacor-update-page-print
Refactor method to check if update is needed
2018-01-22 22:50:05 +01:00
Roeland Jago Douma
23768d5fea
Merge pull request #7985 from nextcloud/remove-public-video
Remove video preview from files_sharing
2018-01-22 21:05:41 +01:00
Roeland Jago Douma
97aff2dbe0
Merge pull request #7994 from nextcloud/smb-notify-test-timeout
increase the time we wait for smb notifications in the test
2018-01-22 19:54:00 +01:00
Robin Appelman
80aef8ed08
increase the time we wait for smb notifications in the test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-22 17:08:24 +01:00
Julius Härtl
4d3dbb345f
Remove video preview from files_sharing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-22 13:22:52 +01:00
Nextcloud bot
5845b177c7
[tx-robot] updated from transifex 2018-01-21 01:10:50 +00:00
Roeland Jago Douma
0599d9284d
Merge pull request #7961 from nextcloud/smb-2.0.4
update icewind/smb to 2.0.4
2018-01-19 20:23:14 +01:00
Robin Appelman
f6c95ca850
update icewind/smb to 2.0.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-19 16:22:36 +01:00
Julius Härtl
422e20569b
Theming: adjust background image resizing
Support high resolution login images by resizing only images that are wider than 4096px

fixes #7459

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-19 13:34:43 +01:00
Nextcloud bot
fdd7a53250
[tx-robot] updated from transifex 2018-01-19 01:10:55 +00:00
Arthur Schiwon
116bcb9c60
remove hardcoded sharepoint icon path
it does not exist and if it would, it was not themable

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-18 15:32:19 +01:00
Morris Jobke
d0c46ab45e
Merge pull request #7923 from nextcloud/files_external_ocscontroller
[files_external] OCS endpoint to proper OCSController
2018-01-18 12:17:46 +01:00
Morris Jobke
d78a4daf7e
Merge pull request #7924 from nextcloud/dep_iappconfig
Remove deprecated function from IAppConfig
2018-01-18 12:03:55 +01:00
Roeland Jago Douma
05f75f803a
[files_external] OCS endpoint to proper OCSController
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-18 11:15:03 +01:00
Joas Schilling
19f7cc9e92
Make Update notficiations strict and fix all inspections
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-18 10:55:44 +01:00
Morris Jobke
9296116297
Merge pull request #7863 from nextcloud/update-notifications-plusplus
Update notifications ++
2018-01-18 10:51:14 +01:00
Roeland Jago Douma
1e7b20f615
Remove IAppConfig::setValue
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:41:57 +01:00
Morris Jobke
24c58d39f4
Merge pull request #7909 from nextcloud/fix-migration-type-hints
Fix the type hints of migrations and correctly inject the wrapped sch…
2018-01-17 13:47:58 +01:00
Roeland Jago Douma
f8756d96bc
Merge pull request #7847 from nextcloud/avatarmanager_strict
Fixes for avatarmanager
2018-01-17 13:46:18 +01:00
Joas Schilling
4a5282ba21
Fix the type hints of migrations and correctly inject the wrapped schema into migrations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 11:37:36 +01:00
Morris Jobke
4ef302c0be
Request->getHeader() should always return a string
PHPDoc (of the public API) says that this method returns string but it also returns null, which is not allowed in some method calls. This fixes that behaviour and returns an empty string and fixes all code paths that explicitly checked for null to be still compliant.

Found while enabling the strict_typing for lib/private for the PHP7+ migration.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-17 09:51:31 +01:00
Morris Jobke
22b3280ac2
Merge pull request #7897 from nextcloud/strict_lockingproviders
Made locking providers strict
2018-01-17 09:33:52 +01:00
Morris Jobke
0b464e5274
Merge pull request #7884 from nextcloud/cleanup-oc_user
Cleanup OC_User and OCP\User
2018-01-17 05:33:07 +01:00
Nextcloud bot
ca2904a017
[tx-robot] updated from transifex 2018-01-17 01:10:58 +00:00
Roeland Jago Douma
8edbfdb291
Made locking providers strict
* Added typehints
* Added return types
* Made strict

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 21:54:20 +01:00
Roeland Jago Douma
fde1ada916
Fix federatedshareprovidertest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 19:25:08 +01:00
Morris Jobke
55532f19d9
Cleanup OC_User and OCP\User
* mainly removes deprecated methods and old static code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 18:39:11 +01:00
Morris Jobke
c2cc30741a
Fix systemtags/list to be compliant
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 15:55:01 +01:00
Roeland Jago Douma
8614eb91db
Fix avatarHome
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 15:37:47 +01:00
Joas Schilling
7deb76e405
Split controller and settings
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-16 11:34:16 +01:00
Nextcloud bot
a02a7593cf
[tx-robot] updated from transifex 2018-01-16 01:10:52 +00:00
Joas Schilling
088505058a
Refactor all the logic from app.php to Application class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 09:55:03 +01:00
Joas Schilling
50e1cee5c7
Automatic DI for Controllers also works
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 09:55:03 +01:00
Joas Schilling
ffb3a3e33a
Improve ResetTokenBackgroundJob and unit test
* Automatic DI is implemented since 11
* Correctly type hint parameters
* Optimise the tests

Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 09:55:03 +01:00
Nextcloud bot
0f729e2cd3
[tx-robot] updated from transifex 2018-01-15 01:10:43 +00:00
Morris Jobke
c14dad90e8
Merge pull request #7857 from nextcloud/dep_template
Remove deprecated template functions from OCP directly
2018-01-15 00:01:49 +01:00
Roeland Jago Douma
419de27b6d
Merge pull request #7840 from nextcloud/dep_config
Remove deprecated \OCP\Config
2018-01-14 22:21:37 +01:00
Roeland Jago Douma
4b9890fefd
Remove deprecated template functions from OCP directly
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:39:36 +01:00
Morris Jobke
fcea6e1564
Merge pull request #7849 from nextcloud/strict_securerandom
Strict ISecure random
2018-01-14 21:05:19 +01:00
Roeland Jago Douma
6e1ee1e7a7
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:04:52 +01:00
Morris Jobke
7d9146db38
Merge pull request #7846 from nextcloud/this_is_14
Bump version number
2018-01-14 20:54:16 +01:00
Morris Jobke
3adda336a5
Merge pull request #7843 from nextcloud/dep_util
Remove deprecated functions for OCP\Util
2018-01-14 14:56:38 +01:00
Roeland Jago Douma
db411f8771
Bump apps
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 11:40:53 +01:00
Nextcloud bot
cbce239c8c
[tx-robot] updated from transifex 2018-01-14 01:10:43 +00:00
Roeland Jago Douma
dffa922c0b
Remove deprecated functions for OCP\Util
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:41:34 +01:00
Roeland Jago Douma
8a41d05761
Remove deprecated \OCP\Config
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 14:25:04 +01:00
Morris Jobke
f578b69729
Update composer
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:16:10 +01:00
Joas Schilling
91d3677446
Make sure the arrays are arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-12 14:08:00 +01:00
Nextcloud bot
33a6e265b2
[tx-robot] updated from transifex 2018-01-12 01:11:34 +00:00
Morris Jobke
9898ec95c1
Merge pull request #7796 from nextcloud/ldap-sync-fixes
LDAP Sync fixes: revert recursion resolution, fixed handling of pagingsize of 0
2018-01-11 17:22:00 +01:00
Morris Jobke
33b82f34be
Merge pull request #7709 from nextcloud/fix-password-displayed-as-username-in-password-manager
Fix password displayed as username in Firefox password manager dialog
2018-01-11 15:21:35 +01:00
Arthur Schiwon
f84ec92563
revert resolving of recursion (3628d4d65d)
without recursion we have issues with internal states. paged search status
are set to false, cookies are not being set. In the end we have  endless
requests which pile up enormously with a high initial offset.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 15:17:18 +01:00
Morris Jobke
aab39ba5bd
Merge pull request #7776 from nextcloud/theming-capabilties-enhancements
More detailed theming capabilities
2018-01-11 14:56:58 +01:00
Arthur Schiwon
9031ae0281
fix return value when ldapPagingSize returns null
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 14:47:51 +01:00
Morris Jobke
f3eb9eeb1d
Merge pull request #7791 from nextcloud/bugfix/noid/fix-update-notification
Fix displaying of the HTML update notification
2018-01-11 14:23:33 +01:00
Arthur Schiwon
15a3f4659f
enrich log message with backtrace, but level it down to DEBUG
The message is not helpful anyway for an admin, and oftentimes is just
valid (e.g. when searching with an offset beyond users in LDAP).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 14:17:14 +01:00
Daniel Calviño Sánchez
b83204bf2c
Add strengthify bar after plain text input clone of password input
To show the password in plain text "showPassword" adds a text input
after the password input and swaps their visibility depending on whether
the password has to be shown in plain text or not. In a similar way,
"strengthify" by default adds the strength bar after the input element
it was called on. Due to this, if "showPassword" is called before
"strengthify" on the same password input then the strength bar ends
between the password input and the text input, and when the text input
is shown it appears below the strength bar.

To fix this now the strength bar is added after the text input in those
places in which "strengthify" was called after "showPassword" on the
same element.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 14:08:47 +01:00
Arthur Schiwon
f292f98060
when paged results are turned off, all (max possible) users are returned
thus hasMoreResult should return false

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 13:20:17 +01:00
Joas Schilling
fd19d944cc
Fix displaying of the HTML notification
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-11 13:04:56 +01:00
Julius Härtl
7de3cced7a
Merge pull request #7783 from nextcloud/fix-empty-details-view-after-renaming-a-file
Fix empty details view after renaming a file
2018-01-11 12:27:07 +01:00
Roeland Jago Douma
d56c566ff5
Merge pull request #7785 from nextcloud/mount-type-federated-shares
return correct mount type for federated shares
2018-01-11 11:45:29 +01:00
Bjoern Schiessle
286de0c239
return correct mount type for federated shares
fix https://github.com/nextcloud/server/issues/6584

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-01-11 10:17:05 +01:00
Daniel Calviño Sánchez
f29c1cf13a Fix empty details view after renaming a file
"FileList._updateDetailsView" expects either a file name (as a string)
or a file model (as an "OCA.File.FileInfoModel"), but when called
through "updateInList" an "OC.Files.FileInfo" object was given instead.
As the given attribute was not a model "_updateDetailsView" treated it
as a file name and tried to get the model for that file, which failed
and caused the details view to be emptied.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 02:47:11 +01:00
Daniel Calviño Sánchez
7a088cfcf5 Move adding test files to "beforeEach()"
All the tests in the "Renaming files" section added the test files,
although those calling "doRename()" added them by setting a path for the
file too. However, the path is ignored in the other tests, so adding the
files can be unified and moved to "beforeEach()".

This would be needed, for example, to show the details view for a file
before calling "doRename()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 02:45:47 +01:00
Nextcloud bot
2a24f45b5f
[tx-robot] updated from transifex 2018-01-11 01:11:35 +00:00
Morris Jobke
00a823f62e
Merge pull request #7765 from nextcloud/fix_5574
Don't encode paths that will be passed to the davclient
2018-01-10 21:00:19 +01:00
Morris Jobke
9978cee1e3
Merge pull request #7773 from nextcloud/add-events-for-favorites
Add events for favorites
2018-01-10 14:42:31 +01:00
Julius Härtl
d4e106f2b3
More detailed theming capabilities
This will allow clients to easily check if a custom background is used

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-10 13:23:22 +01:00
Joas Schilling
3af6d112ce
Add events for favorites
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-10 11:20:21 +01:00
Julius Härtl
927626cbaa
Fix appmenu svg double invert
This fixes a regression caused by 9b668d0, where the css filters to
preview color inversion of the app menu was applied by default. This
commit makes the css filters sensitive on what the current state of the
app menu is.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-10 09:11:32 +01:00
Roeland Jago Douma
d4f163b230
Don't encode paths passed to the OC.Files.Client
This is handled already in the client. So double encoding breaks things
in some situations.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 08:35:40 +01:00
Roeland Jago Douma
e5cc8ebe7a
Return proper principal on the uploads collection listing
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 08:35:20 +01:00
Nextcloud bot
e18c0b2ac3
[tx-robot] updated from transifex 2018-01-10 01:11:20 +00:00
Morris Jobke
8257689e35
Merge pull request #7705 from nextcloud/theming-calc-adjust
Adjust theming color calculations using sRGB luma
2018-01-09 23:04:30 +01:00
Morris Jobke
167f4624ce
Merge pull request #7713 from nextcloud/fix-sync-offset
Fix LDAP Background Sync does not reset offset
2018-01-09 18:39:31 +01:00
Julius Härtl
3379290a73
Fix SCSS processing when undoing theming values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-09 14:18:03 +01:00
Nextcloud bot
4dd4e43320
[tx-robot] updated from transifex 2018-01-09 01:11:15 +00:00
Julius Härtl
9bb0299c98
Add colors to tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-08 16:50:03 +01:00
Morris Jobke
9c3ac19b33
Merge pull request #7716 from nextcloud/hide-favourite-icon-in-details-view-if-favourite-action-is-not-available
Hide favourite icon in details view if favourite action is not available
2018-01-08 15:42:58 +01:00
Arthur Schiwon
cf915b0f75
extend test for rotating prefixes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:46:07 +01:00
Arthur Schiwon
7c3db54ff6
fix changing to next cycle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:45:06 +01:00
Arthur Schiwon
0d3f945209
add tests for whole run command
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:44:45 +01:00
Arthur Schiwon
b17c5fec40
add unit test for qualifies to run
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:08:59 +01:00
Arthur Schiwon
e4310648df
add unit test for determining next cycle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 12:57:14 +01:00
Julius Härtl
9b668d01f5
Fix preview when theming changes invertion of icons
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-08 10:32:25 +01:00
Julius Härtl
e4f9c75a05
Adjust theming color calculations using sRGB luma
based on https://robots.thoughtbot.com/closer-look-color-lightness

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-08 10:31:34 +01:00
Nextcloud bot
75f3b605d3
[tx-robot] updated from transifex 2018-01-08 01:11:17 +00:00
Nextcloud bot
f25e51c369
[tx-robot] updated from transifex 2018-01-07 01:11:11 +00:00
Nextcloud bot
2e683d3502
[tx-robot] updated from transifex 2018-01-06 01:11:09 +00:00
Daniel Calviño Sánchez
3113ee1129 Hide favourite icon in details view if favourite action is not available
When the favourite icon in the details view is clicked the "Favorite"
action is triggered. However, if the action name given to
"triggerAction" is not found then the "Download" action is triggered
instead. As the "Favorite" action is not available in some file lists
(like "Recents") the "Download" action was executed instead in those
cases, which was a strange behaviour. Now the favourite icon is
hidden if its action is not available.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-05 19:06:06 +01:00
Arthur Schiwon
a565bf0b9f
fix offset is never being reset
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-05 14:29:11 +01:00
Arthur Schiwon
82da4fde18
create failing test for this case
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-05 14:27:36 +01:00
Julius Härtl
24233162a0
Fix faulty path in theming scss generation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-05 09:43:09 +01:00
Nextcloud bot
1f8896d8c9
[tx-robot] updated from transifex 2018-01-05 01:11:18 +00:00
Georg Ehrke
1b8fc260c6
generate different UIDs for Birthday, Anniversary and Death event
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-01-04 20:15:24 +01:00
Roeland Jago Douma
0280cff66f
Composer updated
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-04 16:31:16 +01:00
Morris Jobke
e655732458
Merge pull request #7570 from nextcloud/s3-legacy-auth
add option to use legacy v2 auth with s3
2018-01-04 13:17:58 +01:00
Nextcloud bot
298b79410d
[tx-robot] updated from transifex 2018-01-04 09:48:31 +00:00
Roeland Jago Douma
493c255f7f
Merge pull request #7686 from nextcloud/fix-quota-update-3
Fixed quota update on upload and on delete
2018-01-04 08:32:36 +01:00
Morris Jobke
19280adc0d
Merge pull request #7611 from nextcloud/fix-7445
Don't attempt to translate login names to uids when uids are provided
2018-01-03 23:45:31 +01:00
Arthur Schiwon
e9eccf34f9
removes invalid tests, adapts another one
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-03 21:44:30 +01:00
Roeland Jago Douma
5011142024
Merge pull request #7685 from nextcloud/link-to-update
Make update notification open the new update view from apps management
2018-01-03 21:30:52 +01:00
John Molakvoæ (skjnldsv)
88dd8e46f9
Fixup! removed unwanted line
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-01-03 17:55:53 +01:00
John Molakvoæ (skjnldsv)
ab1985b62b
Fixed quota update on upload and on delete
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-01-03 17:53:48 +01:00
Julius Härtl
bdea20330d
Make update notification open the new update view from apps management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-03 17:21:41 +01:00
Roeland Jago Douma
62d71158a9
Merge pull request #7680 from nextcloud/fix-7609
format links in comments
2018-01-03 16:59:08 +01:00
Morris Jobke
722097f7a0
Merge pull request #7669 from nextcloud/ie-fix-invert
Fix inverted app icons on IE11
2018-01-03 16:58:11 +01:00
Morris Jobke
0bc6a7d7fd
Merge pull request #7681 from nextcloud/fix-quota-update-2
Update quotas on each upload
2018-01-03 16:30:19 +01:00
Morris Jobke
876238ce8b
Merge pull request #7533 from nextcloud/oc-28545-handle-oc-total-length-in-new-chunking
[oc] Handle OC-Total-Length in new chunking
2018-01-03 16:18:24 +01:00
Julius Härtl
63b4d7e183
Remove css invert since we are using svg filters for now
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-03 14:42:08 +01:00
Morris Jobke
ee0653d68b
Merge pull request #7678 from nextcloud/fix-share-logo
Use guest css on sharing authentication page
2018-01-03 14:18:17 +01:00
John Molakvoæ (skjnldsv)
51eb26e183
Fix unwanted var
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-01-03 14:01:47 +01:00
John Molakvoæ (skjnldsv)
c4490c6ba8
Update quotas on each upload
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-01-03 13:59:36 +01:00
Arthur Schiwon
282567fced
format links in comments
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-03 13:11:20 +01:00
Julius Härtl
aed7052a38
Use guest css on sharing authentication page
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-03 12:03:26 +01:00
Morris Jobke
0b4d18673e
Do not log user errors as log level 4
* hides log entries for the case the parent folder does not exist

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-03 11:58:55 +01:00
Morris Jobke
31c0efc299
Show warning if slash is entered as filename
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-03 11:42:49 +01:00
Roeland Jago Douma
f159d8d835
Merge pull request #7634 from Abijeet/bug-7539
Fixes the delete button not appearing on certain lower resolutions
2018-01-03 08:28:26 +01:00
Daniel Calviño Sánchez
c500b19762 Remove margin for selected files summary
The selected files summary shown in the multiselect header has a margin
to align it with the names of the files in the contents of the file
list. However, on very narrow screens, and depending on the verbosity of
the language, the summary can overlap with the actions when the
selection contains files and folders. To try to mitigate this, besides
showing only the icons for the actions, the summary margin is removed
too in very narrow screens.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-03 02:22:00 +01:00
Daniel Calviño Sánchez
64c0874a15 Increase touch area for header icons
On narrow screens only the action icons are shown in the multiselect
header of the file list. In that case the padding of those icons is
increased to provide a larger touch area (the padding used is the same
as in the inline actions of the file list).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-03 01:32:39 +01:00
Morris Jobke
4d0315ceae
Merge pull request #7599 from nextcloud/quieter-debug-log
don't show recurring log msg when paged result was turned off
2018-01-03 00:40:46 +01:00
Morris Jobke
7be9b38e51
Merge pull request #7658 from nextcloud/update-external-storages-to-current-file-list-layout
Update "External storages" to current file list layout
2018-01-03 00:37:41 +01:00
Abijeet
361aaf0c95 Fixes the delete icon not appearing on certain resolutions.
Fixes #7539

Also fixes overlap of text on mobile devices by resorting to just icons on lower resolutions.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-01-02 23:24:43 +01:00
Roeland Jago Douma
7fdd9097bb
Merge pull request #7663 from nextcloud/fix-file-list-visible-behind-the-multiselect-header
Fix file list visible behind the multiselect header
2018-01-02 19:58:17 +01:00
Roeland Jago Douma
194e955c88
Merge pull request #7662 from nextcloud/ldap-shutdown
throw ServerNotAvailableException when LDAP is caught shutting down
2018-01-02 19:57:11 +01:00
Morris Jobke
588b0085dd
Merge pull request #7598 from nextcloud/fix-closing-menu-on-second-click-in-sharing-page
Fix closing menu on second click in sharing page
2018-01-02 15:11:30 +01:00
Daniel Calviño Sánchez
0b494b1f20 Fix file list visible behind the multiselect header
Some parts of the file list contents (file name and actions) had a
higher z-index than the file list multiselect header. That header is
fixed in place, so when the file list contents were scrolled and those
parts with a higher z-index overlapped the multiselect header they were
fully visible. Now the z-index for the multiselect header has a higher
value (the same used in the controls bar) to ensure that the contents
are shown behind the header.

Fixes #7540

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-02 14:05:15 +01:00
Arthur Schiwon
c8851e24a8
throw ServerNotAvailableException when LDAP is caught shutting down
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-02 12:20:44 +01:00
Roeland Jago Douma
75d4f0bcda
Merge pull request #7644 from nextcloud/fix_7184
Do not run SyncJob in cron
2018-01-02 11:12:14 +01:00
Roeland Jago Douma
4c0c3c0bef
Show max warning comment lenth again
Fixes #7414

Since we no longer use an input field we have to use text instead of
val.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-02 10:28:09 +01:00
Morris Jobke
fa2fe34b7a
Merge pull request #7624 from nextcloud/fix-fileActions-currentFile-not-set-before-using-it
Fix "fileActions.currentFile" not set before using it
2018-01-02 10:28:04 +01:00
Roeland Jago Douma
0585b776fb
Do no run SyncJob in cron
Fixes #7184

The SyncJob can be very resource intensive. Since it requests all users
on the system to create the system addressbook. In order to do this it
creates a vcard for every user and updates the addressbook.

There is no need for this job since the proper signals are emitted and
handled in the carddav backend to update the addressbook live.

Worst comes to worst there is always the occ command to bring the
address book in sync again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-02 10:00:01 +01:00
Roeland Jago Douma
ea858fcb55
Merge pull request #7626 from nextcloud/fixed-files-multiselect-top-margin
Fixed top position of multiselected files table
2017-12-28 11:22:44 +01:00
Roeland Jago Douma
08cbfb6c6b
Merge pull request #7592 from nextcloud/update-quota-on-files-upload
Update quota on files upload
2017-12-28 10:53:14 +01:00
Daniel Calviño Sánchez
11125164be Disable selection in "External storages" file list
When the checkbox was moved to where the favourite icon was shown before
the layout of the file list was modified. The checkbox is no longer a
descendant of the ".filename" element, so it is no longer removed by the
"External storages" file list.

However, even before the checkbox was moved, explicitly removing it was
not the best approach, as file list rows could still be selected using
"Ctrl/Shift+click". This did not provide much value, as the selection
header has no actions; it simply states the number of selected elements.
The proper way to disable the selection is by setting "_allowSelection"
to false in the file list instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-27 16:31:22 +01:00
Daniel Calviño Sánchez
78891ac320 Fix selectors for file list elements
When the checkbox was moved to where the favourite icon was shown before
the layout of the file list was modified. The first column is no longer
the file name, so neither the thumbnail nor the name link were found.
Due to this the thumbnail was not set to the appropriate icon, and the
dummy event handler was not removed from the name link, so clicks on the
name were basically ignored. Now the selectors are based on the
".filename" CSS class instead of relying on the column position.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-27 16:17:00 +01:00
John Molakvoæ (skjnldsv)
84c961919b
Fixed top position of multiselected files table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-26 17:22:18 +01:00
John Molakvoæ (skjnldsv)
c8db1ed741
Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-26 16:37:34 +01:00
Daniel Calviño Sánchez
ea40ade8ad Fix "fileActions.currentFile" not set before using it
When an empty area of a file row was clicked and the "Details" action
was executed "fileActions.currentFile" was not guaranteed to be set to
the appropriate object (it depended on the previous actions of the
user), so when it was used by "getCurrentMimeType()" and other
FileActions functions they may not work as expected. Now it is
explicitly set to the appropriate value before its use.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-26 04:56:25 +01:00
Morris Jobke
e37fa60784
Merge pull request #7591 from nextcloud/trigger-events-before-and-after-a-file-action-is-executed
Trigger events before and after a file action is executed
2017-12-22 12:31:55 +01:00
Roeland Jago Douma
e40d6f6d8c
Merge pull request #7597 from nextcloud/fix-anchor-change-when-clicking-on-sharing-page-menu
Fix anchor change when clicking on sharing page menu
2017-12-22 12:28:27 +01:00
John Molakvoæ (skjnldsv)
8cc90ab4de
Fixed breadcrumbs tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-21 16:22:54 +01:00
Arthur Schiwon
82fd09c294
don't show recurring msg when pages result was turned off
and only as debug level otherwise.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-21 14:29:56 +01:00
Daniel Calviño Sánchez
eb256b3ed5 Fix anchor change when clicking on sharing page menu
The share menu toggle and some share menu items included an 'href="#"'
attribute, so they were handled as internal links by the browser, which
changed the current anchor when they were clicked. However, there was no
real need to change the anchor in those cases, and it could interfere
with other apps (for example, the PDF viewer sets the current anchor to
"#pdfviewer" when it is shown and it hides itself when that anchor is
modified). According to the HTML 5 spec the "href" attribute is not
mandatory for "a" elements, so they were removed.

Other options would have been to change the elements from "a" to "div"
or something like that, but that would have required changes to the CSS
rules too, or to prevent the default event handling for those elements
through JavaScript, which would have been a workaround instead of the
proper solution.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-21 14:19:29 +01:00
Daniel Calviño Sánchez
372e7acfaf Fix closing menu on second click in sharing page
When a "mouseup" event was triggered on any element except on the share
menu or its descendants the share menu was closed. The share menu toggle
is not a descendant of the share menu, so clicking on it when the share
menu was shown closed it by removing its "open" CSS class. However, once
that happened the click event was then handled by the share menu toggle,
which toggled the "open" CSS class in the share menu and thus added it
again. So, from the user point of view, nothing happened when clicking
on the share menu toggle if the share menu was open.

Now a "mouseup" event on the share menu toggle no longer closes the
share menu, and thus toggling the "open" CSS class when handling the
"click" event works as expected.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-21 12:37:35 +01:00
John Molakvoæ (skjnldsv)
0cb45f681f
Update quota on file upload and deletion
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-21 10:48:43 +01:00
Daniel Calviño Sánchez
c059fbd409 Remove internal unused property
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-21 02:08:40 +01:00
Daniel Calviño Sánchez
96ed73343e Trigger the "Details" action when clicking on an empty file row space
Clicking on an empty space in a file row causes the details view to be
shown. As it is a user initiated action on the file list now it is done
by triggering the Details action instead of directly calling
"_updateDetailsView"; the result is the same in both cases, but using
the action is more consistent (clicking on the file name triggers the
default action, and clicking on the inline actions triggers those
actions) and also makes possible to use the "beforeTriggerAction" and
"afterTriggerAction" listeners.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-21 00:36:40 +01:00
Morris Jobke
9e6f9564ec
Properly show action icons
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-20 13:48:09 +01:00
Marin Treselj
eebc70cf1e
Make contorls stick to the top when scrolling
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2017-12-20 13:48:09 +01:00
John Molakvoæ (skjnldsv)
7a9e65ceed
Fixed breadcrumbs calculation and actions flow
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-20 13:48:09 +01:00
Daniel Calviño Sánchez
7760f16521 Trigger events before and after a file action is executed
In the same way that other elements can know when a FileAction is
registered or a default action is set this commit makes possible to be
notified before and after a FileAction is executed.

This is achieved by wrapping the registered action handler in a custom
function that notifies the listeners before and after executing the
handler itself. Due to this approach only FileActions registered through
"registerAction" trigger the events, although that is not a problem as
this is how the actions should be added to the FileActions anyway.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-19 18:33:34 +01:00
Robin Appelman
34ced4dd97
add option to use legacy v2 auth with s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-12-19 11:54:55 +01:00
Morris Jobke
b01d20c0d7
Merge pull request #7556 from nextcloud/smb-stat-exception
handle exceptions in SMB::stat
2017-12-18 22:31:05 +01:00
Roeland Jago Douma
094d41937a
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-18 21:06:52 +01:00
Morris Jobke
d2d73f1ce8
Also replace all other occurences
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-18 20:57:11 +01:00
Arthur Schiwon
5ce943aa85
don't use deprecated method for requesting memcache
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-18 20:57:11 +01:00
Robin Appelman
3fa13b48fc
handle exceptions in SMB::stat
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-12-18 15:55:46 +01:00
Robin Appelman
bdf4111013
Merge pull request #7555 from nextcloud/smb-copy-rename-log
additional debug logging on smb copy/rename failures
2017-12-18 15:02:18 +01:00
Robin Appelman
4f0d03e172
additional debug logging on smb copy/rename failures
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-12-18 13:59:58 +01:00
Vincent Petry
ec8bf53356 Only set X-OC-Mtime when browser provided lastModified on upload
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-15 14:46:53 +01:00
Thomas Müller
f39de4ab37 Transmit OC-Total-Length in browser as well
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-15 14:46:48 +01:00
Thomas Müller
8c5d656f3b Handle OC-Total-Length in new chunking
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-15 14:46:36 +01:00
Morris Jobke
19ffdecb4f
Merge pull request #7527 from nextcloud/fix-drag-shadow-not-visible-when-dragging-a-file-on-a-narrow-screen
Fix drag shadow not visible when dragging a file on a narrow screen
2017-12-15 13:52:09 +01:00
John Molakvoæ (skjnldsv)
0c38c1b2db
Fixed pinned state of quota if no apps registered an app nav item
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-14 12:06:28 +01:00
Roeland Jago Douma
49b095b78e
Use proper authorative-autoloader for app autoloaders
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-14 08:31:31 +01:00
Roeland Jago Douma
ce12763ab7
Merge pull request #7485 from nextcloud/fix_7001
Also cache invalid DiscoveryService response
2017-12-14 07:47:13 +01:00
Daniel Calviño Sánchez
39c549fa27 Fix drag shadow not visible when dragging a file on a narrow screen
When a file from the file list is dragged a drag shadow (a copy of the
file row that follows the cursor position) is created. The drag shadow
element is created as a direct child of the body element, so it needs a
higher "z-index" than the one used for the file list to be visible.

In narrow screens the "#app-content" uses a "z-index" of 1000 in order
to be visible over the "#navigation-bar" when they overlap, so the
"z-index" of the drag shadow must be at least 1000 to be visible over
the file list.

Instead of updating the hardcoded "z-index" it was removed and replaced
by CSS rules for ".dragshadow" elements to ease theming.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-14 04:05:49 +01:00
Roeland Jago Douma
3b343e287f
Also cache invalid DiscoveryService response
* Cache it for a day so we will retry eventually
* Cache the status.php response as well so we will try it once a day as
well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-13 15:50:53 +01:00
Morris Jobke
defac0ff0d
Fixes hex2bin() in LDAP
Untangles the two if-else clauses into a more readable format.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-13 11:57:49 +01:00
Morris Jobke
5a95260bf3
Show tha copy share link button properly inline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-13 10:32:13 +01:00
Arthur Schiwon
099a340bf5
The user displayNameResolver is specific to users, not the comments app
Other apps like spreed rely on it, and only can resolver per type can
be registered anyhow.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-12 17:36:31 +01:00
Bjoern Schiessle
caff52decd
fix dav unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-12-12 13:59:52 +01:00
Morris Jobke
1ceeab9229
Fix unit tests for CalendarManager
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-12 09:33:52 +01:00
Morris Jobke
d98dea1eb1
Merge pull request #6884 from nextcloud/feature/3003/opt_out_of_birthday_calendar
Opt out of birthday calendar
2017-12-12 08:29:26 +01:00
Roeland Jago Douma
179be8d95c
Merge pull request #6637 from nextcloud/contactsstore_public_api
Make ContactsStore a public API
2017-12-11 20:04:28 +01:00
Tobia De Koninck
f6ef779f97
Make ContactsStore a public API
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2017-12-11 18:18:58 +01:00
Roeland Jago Douma
2c2e1c4c7a
Catch the errors related to untrusted self signed certificates for federation
* Added tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-11 18:14:01 +01:00
Morris Jobke
ba3c608a00
Merge pull request #6590 from nextcloud/dav-create-activities-for-publishing
Create activities for (un)publishing calendar events
2017-12-11 17:13:11 +01:00
blizzz
4fc8984d89
Merge pull request #6079 from nextcloud/fix-antivirus
Parse Sabre Exception in OC.Files.Client and file-upload
2017-12-11 17:12:02 +01:00
Roeland Jago Douma
effde616eb
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-11 16:34:28 +01:00
Morris Jobke
c76c7a96fc
Update wording
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-11 16:28:40 +01:00
Thomas Citharel
4c32de22bb
Create activities for (un)publishing calendar events
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2017-12-11 16:28:40 +01:00
Georg Ehrke
728248bd8d
updated autoloaders for dav
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-12-11 16:04:55 +01:00
Georg Ehrke
6802e2b59a
Principal search: Take sharing settings into account
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-12-11 16:04:55 +01:00
Georg Ehrke
f543039858
exclude shared calendars from freeBusy
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-12-11 16:04:55 +01:00
Christoph Seitz
787e3d51b4
Fix functions to search for principals in the backend.
Add a "searchPrincipals" function to the NC principal backend.
Fix the "findByUri" function to respect the prefixPath.

Signed-off-by: Christoph Seitz <christoph.seitz@posteo.de>
2017-12-11 16:04:55 +01:00
blizzz
80b27fdb93
Merge pull request #7342 from nextcloud/fix_carddav_converter
CardDAV convertor check should not be to wide
2017-12-11 16:03:07 +01:00
Morris Jobke
7fdc4b5262
Merge pull request #7418 from nextcloud/ldap-fix-cache-retrieved-user
ensure that users are cached when they are retrieved
2017-12-11 15:39:24 +01:00
Roeland Jago Douma
e47137c7d4
Merge pull request #6682 from nextcloud/dav-mimetype-fallback
Fallback to filename based detection if the remote dav server doesn't…
2017-12-11 15:28:05 +01:00
Morris Jobke
7c39711798
Merge pull request #7427 from nextcloud/fix-white-color-in-emails
Fix email buttons for white theme
2017-12-11 15:16:28 +01:00
Morris Jobke
5b20600da9
Merge pull request #7313 from nextcloud/ensure-that-x-oc-mtime-header-is-an-integer-with-chunked-uploads
Ensure that X-OC-MTime header is an integer with chunked uploads
2017-12-11 15:07:05 +01:00
Morris Jobke
cce4c285db
Fix email buttons for white theme
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-11 14:33:54 +01:00
Roeland Jago Douma
40633c5e54
CardDAV convertor check should not be to wide
Case: email is set to null, but the avatar is set. In the old case the
email would set $emptyValue but $noImage would still be false. This we
would set the empty string as email.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-11 11:58:02 +01:00
Nextcloud bot
8ed728c1a2
[tx-robot] updated from transifex 2017-12-11 01:10:20 +00:00
Nextcloud bot
a684f033bd
[tx-robot] updated from transifex 2017-12-10 01:10:25 +00:00
Nextcloud bot
855acc727b
[tx-robot] updated from transifex 2017-12-09 01:10:24 +00:00
Morris Jobke
79ed0d105d
Merge pull request #7426 from nextcloud/Abijeet-master
Allows adding of hex color to the theme-color
2017-12-08 23:49:52 +01:00
Morris Jobke
3f34861d58
Merge pull request #7433 from nextcloud/fix-constructor-spy-in-unit-test-with-sinon-4.1.3
Fix constructor spy in unit test with Sinon 4.1.3
2017-12-08 23:49:11 +01:00
Daniel Calviño Sánchez
b70b38ce31 Fix constructor spy in unit test with Sinon 4.1.3
When a constructor is spied using Sinon it is wrapped by a proxy
function, which calls the original constructor when invoked. When "new
Foo()" is executed a "Foo" object is created, "Foo" is invoked with the
object as "this", and the object is returned as the result of the whole
"new" expression.

Before Sinon 4.1.3 the proxy called the original constructor directly
using the "thisValue" of the spied call; "thisValue" was the object
created by the "new" operator that called the proxy. The proxy assigned
"thisValue" to "returnValue", so it was also the value returned by the
proxy and, in turn, the value returned by the whole "new" expression.

Since Sinon 4.1.3 (see pull request 1626) the proxy calls the original
constructor using "new" instead of directly. The "thisValue" created by
the outermost "new" (the one that called the proxy) is no longer used by
the original constructor; the internal "new" creates a new object, which
is the one passed to the original constructor and returned by the
internal "new" expression. This object is also the value returned by the
proxy ("returnValue") and, in turn, the value returned by the whole
outermost "new" expression.

Thus, now "returnValue" should be used instead of "thisValue" to get the
object created by the spied constructor.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-08 21:26:45 +01:00
Morris Jobke
5724e75827
Merge pull request #7252 from nextcloud/send-comment-on-enter
Submit comments with Enter and use Shift+Enter for new lines
2017-12-08 15:31:10 +01:00
Lukas Reschke
bb8acc5824
Merge pull request #7321 from nextcloud/ldap-update-loginfilter
Update login filter when user filter was newly generated
2017-12-08 15:24:57 +01:00
Abijeet
81f34e224c
Allows adding of hex color to the theme-color
Fixes #7158. Adds a # on the color if missing.

Increased maxlength, added hash:true for jscolor, and adding a # if not present on the change event.

Since the input element now allows a hex code, changed values to hexcode.

In addition, added a function to get RGB array from hex or rgb values. Calling it in both methods and using it to perform comparison.

Also changed the way we were determining whether the jscolor component had loaded.

Changed the control to use data-jscolor rather than defining opts in the class.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2017-12-08 10:42:41 +01:00
Nextcloud bot
ef2b0969dd
[tx-robot] updated from transifex 2017-12-08 01:10:13 +00:00
Arthur Schiwon
27f14eee26
don't cache user, if no internal user id was retrieved/assigned
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-07 22:47:32 +01:00
Arthur Schiwon
991190b994
ensure that users are cached when they are retrieved
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-07 17:49:33 +01:00
Daniel Calviño Sánchez
9b1f3b969e Fix Enter sending comment instead of adding autocomplete item to message
When the autocomplete popover is shown the At.js plugin listens on the
message input field for key down events, and when Enter is pressed it
adds the selected item to the message. However, as "_onTypeComment" also
handles key down events for the message input field, when Enter was
pressed the comment was submitted and At.js had no chance to add the
item before that happened. Now when Enter is pressed and the
autocomplete popover is shown the comment is not submitted, and thus
At.js adds the selected item to the message as expected.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-07 15:38:46 +01:00
Nextcloud bot
7d529c081a
[tx-robot] updated from transifex 2017-12-07 01:10:37 +00:00
Tobias Kaminsky
430f60db21
Merge pull request #6670 from nextcloud/handle-encryption-state-in-web-interface
Handle encryption state in web interface
2017-12-06 16:19:17 +01:00
Morris Jobke
c32cb6b4b7
Merge pull request #7385 from nextcloud/shared-delay-root
delay calculating the shared cache root until it's used
2017-12-06 15:14:48 +01:00
Lukas Reschke
de8fefeb18
Merge pull request #7395 from nextcloud/remove-unused
Remove unused variables
2017-12-06 13:09:01 +01:00
Roeland Jago Douma
1287da8a38
Merge pull request #7348 from nextcloud/filterout_shares_of_nonexisting_users
Check if the owner of a share exists
2017-12-06 09:13:53 +01:00
Roeland Jago Douma
cde58610b4
Merge pull request #7387 from nextcloud/swift-retry
add retry wrapper when reading files from swift
2017-12-06 08:28:20 +01:00
Nextcloud bot
9505c56447
[tx-robot] updated from transifex 2017-12-06 01:10:23 +00:00
Morris Jobke
a73f86912f
Remove unused variables
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-05 09:58:15 +01:00
Nextcloud bot
f25d55c972
[tx-robot] updated from transifex 2017-12-05 01:10:20 +00:00
Robin Appelman
046eb0c635
add retry wrapper when reading files from swift
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-12-04 16:34:53 +01:00
Roeland Jago Douma
d2fe30d464
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-04 15:23:20 +01:00
Roeland Jago Douma
c8a29ec942
A failed storage is a not available storage
We have to double check. Since getting the info of the root returns a
generic entry. But actually the stroage is not available. Else we get
very weird sync and web behavior.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-04 15:23:11 +01:00
Robin Appelman
c87d689253
delay calculating the shared cache root until it's used
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-12-04 15:16:39 +01:00
Nextcloud bot
567757c793
[tx-robot] updated from transifex 2017-12-04 01:10:30 +00:00
Nextcloud bot
bd1e357eef
[tx-robot] updated from transifex 2017-12-03 01:10:22 +00:00
Nextcloud bot
cec236f0af
[tx-robot] updated from transifex 2017-12-02 01:10:32 +00:00
Arthur Schiwon
65d7468bf3
check userExists later, saves lookups for appData_INSTANCEID userids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-01 11:47:56 +01:00
Nextcloud bot
ffc627e18e
[tx-robot] updated from transifex 2017-12-01 01:10:20 +00:00
Daniel Calviño Sánchez
c43f64d56b Add unit tests for posting comments with enter key
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-30 19:30:27 +01:00
Daniel Calviño Sánchez
d03fcbca77 Set text only in the message div of the new comment form
When finding ".message" elements on "view.$el" the message area for the
new comment form and all the comments were matched. Now the selector was
restricted to match only the message area for the new comment form.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-30 19:29:19 +01:00
Morris Jobke
f22e02cd79
Refactor method to check if update is needed
There was only one call, that actually needed the parameter to be set to true. So this change moved the print of the page to that location and replaces all other occurences with a direct call to the underlying OCP API.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-30 16:04:07 +01:00
Nextcloud bot
49ec86a81f
[tx-robot] updated from transifex 2017-11-30 01:13:19 +00:00
Roeland Jago Douma
d24b6866b1
Actually set the status so we don't cause another exception
* And add tests so I don't mess up again

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-11-29 16:37:54 +01:00
Roeland Jago Douma
a9eb0d4a40
Merge pull request #7338 from nextcloud/fix_exception_on_unreachable_server
Do not log Exception if a connection error occured
2017-11-29 16:03:23 +01:00
Roeland Jago Douma
f03aa0480a
Merge pull request #7316 from nextcloud/fix-silent-conflicts-due-to-merging-7256-after-7251
Fix silent conflicts due to merging #7256 after #7251
2017-11-29 15:38:24 +01:00
Roeland Jago Douma
79554a29e0
Do not log Exception if a connection error occured
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-11-29 13:06:32 +01:00
Nextcloud bot
095eba0aa3
[tx-robot] updated from transifex 2017-11-29 01:10:12 +00:00
Arthur Schiwon
cfd1e04588
Update login filter when user filter was newly generated
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-11-28 12:41:36 +01:00
Daniel Calviño Sánchez
0c45778219 Fix silent conflicts due to merging #7256 after #7251
Although #7256 was merged cleanly some of the changes really conflicted
with those introduced by the last commit of #7251, and this broke the
appearance of the author row of comments. This commit fixes those silent
conflicts and restores the appearance of the author row.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-28 02:35:39 +01:00
Nextcloud bot
a0ce2c1204
[tx-robot] updated from transifex 2017-11-28 01:09:52 +00:00
Daniel Calviño Sánchez
2a7b1bae10 Reject X-OC-MTime header if given as a string with hexadecimal notation
In PHP 7.X hexadecimal notation support was removed from "is_numeric",
so "sanitizeMtime" directly rejected those values; in PHP 5.X, on the
other hand, "sanitizeMtime" returned 0 when a string with hexadecimal
notation was given (as it was the behaviour of "intval"). To provide a
consistent behaviour between PHP versions, and given that it does not
make much sense to send X-OC-MTime in hexadecimal notation, now
X-OC-MTime is always rejected if given as a string with hexadecimal
notation.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-28 01:08:52 +01:00
Thomas Müller
ffe034abb0 Don't use runInSeparateProcess
Directly calling "header" in the PHPUnit process causes the "Cannot
modify header information - headers already sent by" error to be thrown.
Instead of running the test in a separate process, which is slower, this
commit wraps the call to "header" in a method that can be mocked in the
tests.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 20:39:45 +01:00
Daniel Calviño Sánchez
a5e4c2ea11 Add tests for X-OC-MTime header handling
This commit is based on the commits from pull request 28066 (included in
018d45cad97e0) from ownCloud by Artur Neumann and Phil Davis.

Unit tests are currently run only on systems that support negative
mtimes, so no special handling of negative values was included in the
tests to keep the test code more manageable.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 20:39:45 +01:00
Daniel Calviño Sánchez
2af3d8a9b2 Make possible to provide a specific HTTP request object to File
This will be used in a following commit to test how the X-OC-MTime
header is handled.

This commit is based on the "make File::put() more testable" commit
(included in 018d45cad97e0) from ownCloud by Artur Neumann.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 20:39:41 +01:00
Daniel Calviño Sánchez
01e346b2ae Ensure that X-OC-MTime header is an integer also with chunked uploads
This commit extends the changes introduced in pull request #3793 also to
chunked uploads.

The "sanitizeMTime" method name is the same used in the equivalent pull
request to this one from ownCloud (28066).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 20:37:51 +01:00
Morris Jobke
3f7267e0e9
Merge pull request #6901 from nextcloud/bugfix/4014/catch_parsing_error
catch errors when parsing calendar data for calendar query requests
2017-11-27 17:50:37 +01:00
Morris Jobke
573551253e
Merge pull request #7308 from nextcloud/do-not-log-InvalidSyncToken
Log InvalidSyncToken on DAV in debug level
2017-11-27 17:27:41 +01:00
Lukas Reschke
5cc8ea8feb
Merge pull request #7307 from nextcloud/do-not-log-not-implemented-dav
Log NotImplementedException on DAV in debug level
2017-11-27 17:25:56 +01:00
Georg Ehrke
ea117bac31
catch errors when parsing calendar data for calendar query requests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-27 17:14:18 +01:00
blizzz
f700cd14fa
Merge pull request #7222 from nextcloud/fix-filerow-avatars
Fix filerow avatars
2017-11-27 16:46:11 +01:00
Morris Jobke
88905c6293
Log InvalidSyncToken on DAV in debug level
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 16:37:11 +01:00
Morris Jobke
26a5fff423
Log NotImplementedException on DAV in debug level
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 16:17:01 +01:00
blizzz
e428ef9d75
Merge pull request #7256 from nextcloud/fix-cursor-for-avatar-and-user-names-in-comments
Fix cursor for avatar and user names in comments
2017-11-27 15:14:40 +01:00
Morris Jobke
cfae590ac9
Merge pull request #7266 from nextcloud/fix-input-field-not-disabled-while-a-comment-is-being-sent
Fix input field not disabled while a comment is being sent
2017-11-27 13:40:03 +01:00
Lukas Reschke
e02229e412
Merge pull request #7246 from william-p/Add_html5_audioplayer_public
Add HTML5 audio player in public view
2017-11-27 12:32:21 +01:00
Morris Jobke
7bb42438fa
Merge pull request #7280 from nextcloud/fix-working-icon-position-when-sending-or-deleting-a-comment
Fix working icon position when sending or deleting a comment
2017-11-27 12:19:21 +01:00
Morris Jobke
c5446ebd9a
Merge pull request #7251 from nextcloud/contact-menu-position-fix
Fixed contact menu position on comments
2017-11-27 12:14:30 +01:00
Lukas Reschke
d15ca9ffaf
Replace with non-deprecated JS call
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-11-27 11:53:24 +01:00
Lukas Reschke
8ccb486876
Merge pull request #7264 from nextcloud/cache-fetched-apps
Cache fetched apps in update check
2017-11-27 11:48:59 +01:00
Marius Blüm
05039f1f71
Rename "LDAP" to "LDAP/AD-integration"
Signed-off-by: Marius Blüm <marius@lineone.io>
2017-11-27 09:49:28 +01:00
Morris Jobke
4af12dcab1
Fix unit tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 08:50:44 +01:00