wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28950 commits 157 branches 562 tags 714 MiB
Commit graph

28950 commits

This branch
This branch
All branches
Author SHA1 Message Date
Arthur Schiwon
9dc4171830 parameter checks for setting actor and object to happen only in one place 2015-12-09 14:34:23 +01:00
Arthur Schiwon
4273689e9f fix usage of empty 2015-12-09 14:34:23 +01:00
Arthur Schiwon
e3dbc3d40c different strategy in cleaning up after user was deleted 
we do not listen to deletion hooks anymore, because there is no guarantee that they
will be heard - requires that something fetches the CommentsManager first.

Instead, in the user deletion routine the clean up method will be called directly. Same way
as it happens for files, group memberships, config values.
 2015-12-09 14:34:23 +01:00
Arthur Schiwon
2ce2de0ae5 add icommentsmanger and icomment implementation 
register CommentsManager service, allow override, document in config.sample.php

don't insert autoincrement ids in tests, because of dislikes from oracle and pgsql

specify timezone in null date

only accepts strings for ID parameter that can be converted to int

replace forgotten hardcoded IDs in tests

react on deleted users

react on file deletion

Postgresql compatibility

lastInsertId needs *PREFIX* with the table name

do not listen for file deletion, because it is not reliable (trashbin, external storages)

add runtime cache for comments
 2015-12-09 14:34:23 +01:00
Thomas Müller
04f4565fcd Merge pull request #21060 from owncloud/support-for-read-only-config-dir 
Add support for read only config dir
 2015-12-09 14:32:00 +01:00
Thomas Müller
45400e9d4c Merge pull request #21019 from owncloud/occ-get-apppath 
Add occ command to get app path
 2015-12-09 13:15:16 +01:00
Thomas Müller
54dbe5b8d5 Merge pull request #20989 from owncloud/fix_20769 
Update parent when moving share into recieved share
 2015-12-09 13:07:57 +01:00
Thomas Müller
bffd7a1d93 Merge pull request #21059 from owncloud/remove-deaed-code-mount-config 
Remove dead code
 2015-12-09 13:05:14 +01:00
Thomas Müller
7fb2f7f5fe Merge pull request #21068 from owncloud/fix-exit-code-autotest-external 
Fix exit code autotest external
 2015-12-09 13:02:25 +01:00
Thomas Müller
4d86466aec Use default timeout on connection test 2015-12-09 12:18:51 +01:00
Thomas Müller
bb02488cc2 remove deprecated strict setting 2015-12-09 12:10:12 +01:00
Thomas Müller
e3b47e80f7 script shall exit with error in case the start file has issues - fixes #20798 2015-12-09 12:09:45 +01:00
Thomas Müller
5c95939bf3 Merge pull request #21061 from owncloud/fix-oracle-last-insert-id-test 
Fix the last insert id test by changing to an autoincremen…
 2015-12-09 11:53:43 +01:00
Thomas Müller
eb14c9dc1e Merge pull request #21056 from owncloud/check-return 
Verify return type
 2015-12-09 11:29:25 +01:00
Thomas Müller
74e7fb1438 Merge pull request #21055 from owncloud/fix-php-docs-for-console 
Fix PHPDoc and check if path does exists
 2015-12-09 11:28:53 +01:00
Thomas Müller
1dfa93367d Merge pull request #20995 from owncloud/fix-18734 
ensure multiselect always receives an array when setting its value, f…
 2015-12-09 11:27:46 +01:00
Victor Dubiniuk
b59285d0d0 Add occ command to get app path 2015-12-09 11:22:13 +01:00
Thomas Müller
ff656e31f1 Merge pull request #21064 from owncloud/fix-occ-install-on-os-x 
Allow occ install on OS X - same behaviour as web setup
 2015-12-09 11:12:53 +01:00
Joas Schilling
bef6344b27 Do not quote the table name for lastInsertId() 2015-12-09 11:09:02 +01:00
Morris Jobke
d39b018893 Allow occ install on OS X - same behaviour as web setup 2015-12-09 10:49:54 +01:00
Thomas Müller
51b5498be8 Merge pull request #21003 from owncloud/personal-mount-mountid 
Dont set the string storage id to the numeric storage id for personal mounts
 2015-12-09 10:05:36 +01:00
Thomas Müller
bb8dbc291b Merge pull request #21005 from owncloud/verify_password_before_unshare 
The ajax code path unshares a link share when updating the password
 2015-12-09 10:05:20 +01:00
Thomas Müller
bc744ff6de Merge pull request #21038 from owncloud/share-computesharepermissions-notstore 
Fix (re)share permission checks in a few code paths
 2015-12-09 10:04:56 +01:00
Thomas Müller
6ba22f0243 Merge pull request #21043 from owncloud/add-php-doc 
Add type description
 2015-12-09 10:04:30 +01:00
Joas Schilling
5c0be3b565 Fix the last insert id test by changing to an autoincrement table 2015-12-09 09:51:33 +01:00
Lukas Reschke
b50987165e Add support for read only config dir 
We already support the `config_is_read_only` for the config file itself. However not for the whole directory (which is a bug).

This unifies the check in the checkServer routine with the one in base.php. Now one can enable a read only config folder so that ownCloud is not allowed to overwrite it's own source code.

To test this set the whole config folder to read only, clear your session, refresh, see it fails, add the new code, refresh, see it works. Also verify that setup still works fine. (obviously setup does not work with a read only config Also verify that setup still works fine. (obviously setup does not work with a read only config))

Fixes https://github.com/owncloud/core/issues/14455
 2015-12-09 08:54:11 +01:00
Lukas Reschke
025f021fd4 Remove dead code 
Silences two other security warnings, also I cleaned up the PHPDoc a little bit.
 2015-12-09 08:18:47 +01:00
Jenkins for ownCloud
dda9525c4b [tx-robot] updated from transifex 2015-12-09 01:55:14 -05:00
Lukas Reschke
61da3d530d Verify return type 
Can also be null. Silences another security warning...
 2015-12-09 07:32:19 +01:00
Lukas Reschke
11e98e2de6 Fix PHPDoc and check if path does exists 
Mutes another security warning of some static scanners.
 2015-12-09 06:57:24 +01:00
Robin Appelman
8c1afb8fb9 Add tests 2015-12-08 18:01:44 +01:00
Vincent Petry
d0cca6c3ad Add explicit check for groups excluded from sharing 
Since isSharable() doesn't do the check for groups excluded from
sharing, adding an explicit check in the sharing code.
 2015-12-08 16:48:33 +01:00
Vincent Petry
28e9bc1156 Fix more unit tests to pass a mock storage instead of null to FileInfo 2015-12-08 16:33:39 +01:00
Thomas Müller
13993c4a6d Merge pull request #21037 from owncloud/fix-irritating-ldap-log-entry 
passing an empty base in this diagnosis call will not result  in LDAP…
 2015-12-08 16:24:50 +01:00
Lukas Reschke
7c45eaa70b Add type description 
Allows IDEs and static code analyzers. Would have saved me some minutes today :)
 2015-12-08 15:20:54 +01:00
Thomas Müller
0dd111ca2e Merge pull request #21018 from owncloud/scrutinizer-patch-1 
Scrutinizer Auto-Fixes
 2015-12-08 14:51:57 +01:00
Thomas Müller
49095fa4bb Merge pull request #21031 from owncloud/sanitize-findAppInDirectories 
Sanitize the appId passed to `findAppInDirectories`
 2015-12-08 13:52:04 +01:00
Thomas Müller
45fe8271ab Merge pull request #21030 from owncloud/querybuilder-new-features 
Querybuilder new features
 2015-12-08 13:51:45 +01:00
Thomas Müller
85409b6701 Merge pull request #20786 from owncloud/systemtags-dav 
DAV endpoint for system tags
 2015-12-08 13:51:25 +01:00
Vincent Petry
6e4006d139 Add reshare permission checks 
Added in isSharable() in incoming remote share.
Added in isSharable() in regular incoming share.
Added in FileInfo to make sure the proper attributes are returned to the
clients.
 2015-12-08 13:13:26 +01:00
Vincent Petry
e241d26316 Compute share permissions in the view 
The share permissions are now computed in the View/FileInfo instead of
storing them directly/permanently on the storage
 2015-12-08 13:04:22 +01:00
Arthur Schiwon
b91c9851a3 passing an empty base in this diagnosis call will not result in LDAP errors 
Neither in "Invalid DN syntax" nor in "Object not found"
 2015-12-08 12:32:02 +01:00
Joas Schilling
9f98849306 Add a method to the get "to use" table and column name 2015-12-08 11:04:28 +01:00
Thomas Müller
fe8dc0bd5e Merge pull request #21022 from owncloud/get-rid-of-by-reference 
Get rid of by reference
 2015-12-08 11:04:25 +01:00
Thomas Müller
c88438790c Merge pull request #20979 from owncloud/settings-groups-entry 
Add 'my groups' anchor to the personal page sidebar
 2015-12-08 11:04:09 +01:00
Thomas Müller
ae2287e255 Merge pull request #21025 from owncloud/remove-legacy-trusted-domain-support 
Remove legacy repair steps + do not cast trusted domains
 2015-12-08 11:03:33 +01:00
Thomas Müller
fd356eadc6 Merge pull request #20951 from owncloud/Make_showing_logs_optional 
Controlled arguments for run script
 2015-12-08 10:15:28 +01:00
Thomas Müller
c93664468c Merge pull request #21028 from owncloud/fix-php-doc-for-storage-config 
Use proper PHPDoc reference
 2015-12-08 10:04:41 +01:00
Lukas Reschke
715f89a9d9 Sanitize the appId passed to findAppInDirectories 
Would have prevented quite some security bugs in the past. Nice hardening for now.
 2015-12-08 10:03:22 +01:00
Joas Schilling
a3391248e4 Add select distinct to the query builder 2015-12-08 09:49:21 +01:00