wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
42684 commits 157 branches 562 tags 714 MiB
Commit graph

17584 commits

Author SHA1 Message Date
Roeland Jago Douma
9896b15ec8
Only handle encrypted property on folders 
Exposing the encrypted property is required for E2E. However, there is
no need to expose this on files as then it is server side encryption
(which the clients don't care about).

Better to not confuse the output.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-30 12:25:49 +01:00
Nextcloud bot
3867717107
[tx-robot] updated from transifex 2018-01-30 01:11:04 +00:00
Morris Jobke
4fcdfbf5de
Merge pull request #8078 from nextcloud/theming-validate-scss 
SCSS hardening
 2018-01-29 16:12:10 +01:00
Robin Appelman
84bd2b6bc9
fix invalidating folder cache for s3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-01-29 15:09:15 +01:00
Robin Appelman
7afd77604e
adjust s3 bulk delete to new sdk syntax 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-01-29 15:06:10 +01:00
Morris Jobke
eb51f06a3b
Use ::class statement instead of string 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-29 12:03:47 +01:00
Nextcloud bot
1d8b90b8d3
[tx-robot] updated from transifex 2018-01-29 01:10:53 +00:00
Morris Jobke
a661f043e1
Remove unneeded semicolon and parentheses 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 23:46:40 +01:00
Julius Härtl
5dbf733395
Fix theming tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-26 20:13:28 +01:00
Julius Härtl
6770213649
Do not rewrite absolute URLs 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-26 19:08:45 +01:00
Julius Härtl
60e601f4ab
Only override image styles if the theming values are set 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-26 19:05:10 +01:00
Morris Jobke
9be6050cc4
Merge pull request #8072 from nextcloud/type-casting 
Use type casting instead of *val() method
 2018-01-26 17:34:55 +01:00
Morris Jobke
97c216ea06
Merge pull request #8071 from nextcloud/remove-silly-code 
Cleanup unused code
 2018-01-26 15:47:06 +01:00
Morris Jobke
c67736a542
Merge pull request #7707 from nextcloud/bugfix/noid/birthdaycalendar-different-uids 
generate different UIDs for Birthday, Anniversary and Death event
 2018-01-26 15:46:46 +01:00
Morris Jobke
08d184816f
Merge pull request #8070 from nextcloud/remove-theming-migration 
Remove theming migration
 2018-01-26 15:46:29 +01:00
Morris Jobke
4c38d1ed01
Merge pull request #8054 from nextcloud/substr-use-index 
Use index based string access for substr with length of 1
 2018-01-26 15:40:44 +01:00
Morris Jobke
c005fc6755
Cleanup unused code 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 15:25:19 +01:00
Julius Härtl
5e325730d6
Remove theming migration 
Those images are alredy migrated after the instance has been updated to NC12

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-26 15:10:22 +01:00
Morris Jobke
2ad2eb38e8
Use type casting instead of *val() method 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 15:01:27 +01:00
Morris Jobke
ca493ab5b1
Merge pull request #8069 from nextcloud/no-catch-serverdown 
do not catch and ignore ServerNotAvailable in the wrong spot
 2018-01-26 14:01:07 +01:00
Morris Jobke
9ff51aafc5
Use index based string access for substr with length of 1 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 13:38:34 +01:00
Roeland Jago Douma
119896a8d7
Fix tests 
* Add factory for the federatedfilesharing app

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-26 12:49:11 +01:00
Arthur Schiwon
b61b906abe
do not catch ServerNotAvailable 
might cause the user to be unavailable (race condition).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-26 12:47:19 +01:00
Morris Jobke
6bbea33133
Simplify ternary operator statements 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 12:36:25 +01:00
Morris Jobke
c1e4f9f305
Use type casting instead of *val() method 
It should be up to 6x faster

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 11:35:42 +01:00
Roeland Jago Douma
f3723434ee
Don't expose language and password as editable 
* Password might not always be editable
  - Also chaging that will invalide apptokens etc which will directly
  lock out your phone
* Chaging the language also doesn't make that much sense to me currently

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-26 11:22:20 +01:00
Roeland Jago Douma
70b19761aa
Provide list of editable fields via OCS API 
Fixes #7983

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-26 11:20:58 +01:00
Joas Schilling
a7ad7cb08e
Merge pull request #8053 from nextcloud/simplify-substr 
Use short for of substr to not need strlen()
 2018-01-26 10:25:09 +01:00
Joas Schilling
c2b1bd92d6
Merge pull request #8063 from nextcloud/inline-value 
Return value immediately instead of assigning to a one-time variable
 2018-01-26 10:15:39 +01:00
Roeland Jago Douma
ec1d94c629
Merge pull request #8052 from nextcloud/fix-array-methods 
Fix array method usages with a proper call
 2018-01-26 09:53:13 +01:00
Roeland Jago Douma
5a7a5e5352
Merge pull request #8058 from nextcloud/useless-return 
Remove useless return statements
 2018-01-26 09:51:26 +01:00
Roeland Jago Douma
68f44a9a93
Merge pull request #8059 from nextcloud/use-stripos 
Use stripos instead of strpos(strtolower(), 'something')
 2018-01-26 09:50:31 +01:00
Roeland Jago Douma
43ed8b446c
Merge pull request #8060 from nextcloud/proper-codeflow 
Use proper code flow instead of not needed else branch
 2018-01-26 09:49:30 +01:00
Roeland Jago Douma
aebb443ca5
Merge pull request #8056 from nextcloud/array-push 
Use $var[] = $a instead of array_push - 2x faster
 2018-01-26 09:41:31 +01:00
Nextcloud bot
469b3724b5
[tx-robot] updated from transifex 2018-01-26 01:10:52 +00:00
Morris Jobke
0a56d2185e
Return value immediately instead of assigning to a one-time variable 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 00:02:03 +01:00
Morris Jobke
16a558871c
Use proper code flow instead of not needed else branch 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-25 23:01:03 +01:00
Morris Jobke
464f024fa9
Use stripos instead of strpos(strtolower(), 'something') 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-25 22:59:50 +01:00
Morris Jobke
4dbee99b7b
Remove useless return statements 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-25 22:50:40 +01:00
Morris Jobke
870fe20acc
Use $var[] = $a instead of array_push - 2x faster 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-25 22:36:03 +01:00
Morris Jobke
e6efa755c9
Use short for of substr to not need strlen() 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-25 22:23:48 +01:00
Morris Jobke
7800a9bc24
Fix array method usages with a proper call 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-25 22:20:10 +01:00
Morris Jobke
b9bbb894f8
Merge pull request #7916 from nextcloud/2fa_log 
Add 2FA to logfile
 2018-01-25 15:57:32 +01:00
Roeland Jago Douma
8160d0bc2a
Merge pull request #8036 from nextcloud/phpunit6 
Require PHPUnit 6.5 or higher
 2018-01-25 14:50:46 +01:00
Roeland Jago Douma
9e76577ead
Add tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-25 13:44:47 +01:00
Roeland Jago Douma
a5fe6a6118
Update autoloader 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-25 13:25:09 +01:00
Roeland Jago Douma
b2ca1d6553
Make admin_audit listen to 2fa events 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-25 13:25:09 +01:00
Joas Schilling
3917a54113
Class "ProgressBar" is declared "final" and cannot be mocked. 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-25 11:33:26 +01:00
Joas Schilling
bf2be08c9f
Fix risky tests without assertions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-25 11:33:25 +01:00
Joas Schilling
870023365c
Fix "Undefined method setExpectedException()" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-24 18:10:16 +01:00
Joas Schilling
c3424df1f0
Require PHPUnit 6.5 or higher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-24 17:23:59 +01:00
Daniel Calviño Sánchez
5d7eded809 Fix missing clipboard icon in shared links 
The clipboard icon in shared links appears either directly on the link
input field or, if any social sharing app is enabled, in a menu. The
clipboard icon uses the same CSS rules as other icons (like the
information icon) to be posioned on the end of the input field, and
those rules have to be "cancelled" when the icon is shown in the menu.

Fixes #7990

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-24 16:40:21 +01:00
Roeland Jago Douma
cda811b6b4
Make filelist and sidebar use the fileid preview endpoint 
This makes sure the preview is cached even after rename! yay!

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-24 11:24:18 +01:00
Roeland Jago Douma
4537faa5da
Merge pull request #7918 from nextcloud/properly-log-exceptions 
Properly log the full exception instead of only the message
 2018-01-23 11:56:02 +01:00
Morris Jobke
2a38605545
Properly log the full exception instead of only the message 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-23 10:57:21 +01:00
Nextcloud bot
cc4f9986cf
[tx-robot] updated from transifex 2018-01-23 01:10:50 +00:00
blizzz
c7d9e5fd63
Merge pull request #7354 from nextcloud/refacor-update-page-print 
Refactor method to check if update is needed
 2018-01-22 22:50:05 +01:00
Roeland Jago Douma
23768d5fea
Merge pull request #7985 from nextcloud/remove-public-video 
Remove video preview from files_sharing
 2018-01-22 21:05:41 +01:00
Roeland Jago Douma
97aff2dbe0
Merge pull request #7994 from nextcloud/smb-notify-test-timeout 
increase the time we wait for smb notifications in the test
 2018-01-22 19:54:00 +01:00
Robin Appelman
80aef8ed08
increase the time we wait for smb notifications in the test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-01-22 17:08:24 +01:00
Julius Härtl
4d3dbb345f
Remove video preview from files_sharing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-22 13:22:52 +01:00
Nextcloud bot
5845b177c7
[tx-robot] updated from transifex 2018-01-21 01:10:50 +00:00
Roeland Jago Douma
0599d9284d
Merge pull request #7961 from nextcloud/smb-2.0.4 
update icewind/smb to 2.0.4
 2018-01-19 20:23:14 +01:00
Robin Appelman
f6c95ca850
update icewind/smb to 2.0.4 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-01-19 16:22:36 +01:00
Julius Härtl
422e20569b
Theming: adjust background image resizing 
Support high resolution login images by resizing only images that are wider than 4096px

fixes #7459

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-19 13:34:43 +01:00
Nextcloud bot
fdd7a53250
[tx-robot] updated from transifex 2018-01-19 01:10:55 +00:00
Arthur Schiwon
116bcb9c60
remove hardcoded sharepoint icon path 
it does not exist and if it would, it was not themable

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-18 15:32:19 +01:00
Morris Jobke
d0c46ab45e
Merge pull request #7923 from nextcloud/files_external_ocscontroller 
[files_external] OCS endpoint to proper OCSController
 2018-01-18 12:17:46 +01:00
Morris Jobke
d78a4daf7e
Merge pull request #7924 from nextcloud/dep_iappconfig 
Remove deprecated function from IAppConfig
 2018-01-18 12:03:55 +01:00
Roeland Jago Douma
05f75f803a
[files_external] OCS endpoint to proper OCSController 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-18 11:15:03 +01:00
Joas Schilling
19f7cc9e92
Make Update notficiations strict and fix all inspections 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-18 10:55:44 +01:00
Morris Jobke
9296116297
Merge pull request #7863 from nextcloud/update-notifications-plusplus 
Update notifications ++
 2018-01-18 10:51:14 +01:00
Roeland Jago Douma
1e7b20f615
Remove IAppConfig::setValue 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-17 21:41:57 +01:00
Morris Jobke
24c58d39f4
Merge pull request #7909 from nextcloud/fix-migration-type-hints 
Fix the type hints of migrations and correctly inject the wrapped sch…
 2018-01-17 13:47:58 +01:00
Roeland Jago Douma
f8756d96bc
Merge pull request #7847 from nextcloud/avatarmanager_strict 
Fixes for avatarmanager
 2018-01-17 13:46:18 +01:00
Joas Schilling
4a5282ba21
Fix the type hints of migrations and correctly inject the wrapped schema into migrations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-17 11:37:36 +01:00
Morris Jobke
4ef302c0be
Request->getHeader() should always return a string 
PHPDoc (of the public API) says that this method returns string but it also returns null, which is not allowed in some method calls. This fixes that behaviour and returns an empty string and fixes all code paths that explicitly checked for null to be still compliant.

Found while enabling the strict_typing for lib/private for the PHP7+ migration.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-17 09:51:31 +01:00
Morris Jobke
22b3280ac2
Merge pull request #7897 from nextcloud/strict_lockingproviders 
Made locking providers strict
 2018-01-17 09:33:52 +01:00
Morris Jobke
0b464e5274
Merge pull request #7884 from nextcloud/cleanup-oc_user 
Cleanup OC_User and OCP\User
 2018-01-17 05:33:07 +01:00
Nextcloud bot
ca2904a017
[tx-robot] updated from transifex 2018-01-17 01:10:58 +00:00
Roeland Jago Douma
8edbfdb291
Made locking providers strict 
* Added typehints
* Added return types
* Made strict

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-16 21:54:20 +01:00
Roeland Jago Douma
fde1ada916
Fix federatedshareprovidertest 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-16 19:25:08 +01:00
Morris Jobke
55532f19d9
Cleanup OC_User and OCP\User 
* mainly removes deprecated methods and old static code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-16 18:39:11 +01:00
Morris Jobke
c2cc30741a
Fix systemtags/list to be compliant 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-16 15:55:01 +01:00
Roeland Jago Douma
8614eb91db
Fix avatarHome 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-16 15:37:47 +01:00
Joas Schilling
7deb76e405
Split controller and settings 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-16 11:34:16 +01:00
Nextcloud bot
a02a7593cf
[tx-robot] updated from transifex 2018-01-16 01:10:52 +00:00
Joas Schilling
088505058a
Refactor all the logic from app.php to Application class 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-15 09:55:03 +01:00
Joas Schilling
50e1cee5c7
Automatic DI for Controllers also works 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-15 09:55:03 +01:00
Joas Schilling
ffb3a3e33a
Improve ResetTokenBackgroundJob and unit test 
* Automatic DI is implemented since 11
* Correctly type hint parameters
* Optimise the tests

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-15 09:55:03 +01:00
Nextcloud bot
0f729e2cd3
[tx-robot] updated from transifex 2018-01-15 01:10:43 +00:00
Morris Jobke
c14dad90e8
Merge pull request #7857 from nextcloud/dep_template 
Remove deprecated template functions from OCP directly
 2018-01-15 00:01:49 +01:00
Roeland Jago Douma
419de27b6d
Merge pull request #7840 from nextcloud/dep_config 
Remove deprecated \OCP\Config
 2018-01-14 22:21:37 +01:00
Roeland Jago Douma
4b9890fefd
Remove deprecated template functions from OCP directly 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-14 21:39:36 +01:00
Morris Jobke
fcea6e1564
Merge pull request #7849 from nextcloud/strict_securerandom 
Strict ISecure random
 2018-01-14 21:05:19 +01:00
Roeland Jago Douma
6e1ee1e7a7
Fix tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-14 21:04:52 +01:00
Morris Jobke
7d9146db38
Merge pull request #7846 from nextcloud/this_is_14 
Bump version number
 2018-01-14 20:54:16 +01:00
Morris Jobke
3adda336a5
Merge pull request #7843 from nextcloud/dep_util 
Remove deprecated functions for OCP\Util
 2018-01-14 14:56:38 +01:00
Roeland Jago Douma
db411f8771
Bump apps 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-14 11:40:53 +01:00
Nextcloud bot
cbce239c8c
[tx-robot] updated from transifex 2018-01-14 01:10:43 +00:00
Roeland Jago Douma
dffa922c0b
Remove deprecated functions for OCP\Util 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-13 19:41:34 +01:00
Roeland Jago Douma
8a41d05761
Remove deprecated \OCP\Config 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-13 14:25:04 +01:00
Morris Jobke
f578b69729
Update composer 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-12 23:16:10 +01:00
Joas Schilling
91d3677446
Make sure the arrays are arrays 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-12 14:08:00 +01:00
Nextcloud bot
33a6e265b2
[tx-robot] updated from transifex 2018-01-12 01:11:34 +00:00
Morris Jobke
9898ec95c1
Merge pull request #7796 from nextcloud/ldap-sync-fixes 
LDAP Sync fixes: revert recursion resolution, fixed handling of pagingsize of 0
 2018-01-11 17:22:00 +01:00
Morris Jobke
33b82f34be
Merge pull request #7709 from nextcloud/fix-password-displayed-as-username-in-password-manager 
Fix password displayed as username in Firefox password manager dialog
 2018-01-11 15:21:35 +01:00
Arthur Schiwon
f84ec92563
revert resolving of recursion (3628d4d65d) 
without recursion we have issues with internal states. paged search status
are set to false, cookies are not being set. In the end we have  endless
requests which pile up enormously with a high initial offset.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-11 15:17:18 +01:00
Morris Jobke
aab39ba5bd
Merge pull request #7776 from nextcloud/theming-capabilties-enhancements 
More detailed theming capabilities
 2018-01-11 14:56:58 +01:00
Arthur Schiwon
9031ae0281
fix return value when ldapPagingSize returns null 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-11 14:47:51 +01:00
Morris Jobke
f3eb9eeb1d
Merge pull request #7791 from nextcloud/bugfix/noid/fix-update-notification 
Fix displaying of the HTML update notification
 2018-01-11 14:23:33 +01:00
Arthur Schiwon
15a3f4659f
enrich log message with backtrace, but level it down to DEBUG 
The message is not helpful anyway for an admin, and oftentimes is just
valid (e.g. when searching with an offset beyond users in LDAP).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-11 14:17:14 +01:00
Daniel Calviño Sánchez
b83204bf2c
Add strengthify bar after plain text input clone of password input 
To show the password in plain text "showPassword" adds a text input
after the password input and swaps their visibility depending on whether
the password has to be shown in plain text or not. In a similar way,
"strengthify" by default adds the strength bar after the input element
it was called on. Due to this, if "showPassword" is called before
"strengthify" on the same password input then the strength bar ends
between the password input and the text input, and when the text input
is shown it appears below the strength bar.

To fix this now the strength bar is added after the text input in those
places in which "strengthify" was called after "showPassword" on the
same element.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-11 14:08:47 +01:00
Arthur Schiwon
f292f98060
when paged results are turned off, all (max possible) users are returned 
thus hasMoreResult should return false

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-11 13:20:17 +01:00
Joas Schilling
fd19d944cc
Fix displaying of the HTML notification 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-11 13:04:56 +01:00
Julius Härtl
7de3cced7a
Merge pull request #7783 from nextcloud/fix-empty-details-view-after-renaming-a-file 
Fix empty details view after renaming a file
 2018-01-11 12:27:07 +01:00
Roeland Jago Douma
d56c566ff5
Merge pull request #7785 from nextcloud/mount-type-federated-shares 
return correct mount type for federated shares
 2018-01-11 11:45:29 +01:00
Bjoern Schiessle
286de0c239
return correct mount type for federated shares 
fix https://github.com/nextcloud/server/issues/6584

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-01-11 10:17:05 +01:00
Daniel Calviño Sánchez
f29c1cf13a Fix empty details view after renaming a file 
"FileList._updateDetailsView" expects either a file name (as a string)
or a file model (as an "OCA.File.FileInfoModel"), but when called
through "updateInList" an "OC.Files.FileInfo" object was given instead.
As the given attribute was not a model "_updateDetailsView" treated it
as a file name and tried to get the model for that file, which failed
and caused the details view to be emptied.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-11 02:47:11 +01:00
Daniel Calviño Sánchez
7a088cfcf5 Move adding test files to "beforeEach()" 
All the tests in the "Renaming files" section added the test files,
although those calling "doRename()" added them by setting a path for the
file too. However, the path is ignored in the other tests, so adding the
files can be unified and moved to "beforeEach()".

This would be needed, for example, to show the details view for a file
before calling "doRename()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-11 02:45:47 +01:00
Nextcloud bot
2a24f45b5f
[tx-robot] updated from transifex 2018-01-11 01:11:35 +00:00
Morris Jobke
00a823f62e
Merge pull request #7765 from nextcloud/fix_5574 
Don't encode paths that will be passed to the davclient
 2018-01-10 21:00:19 +01:00
Morris Jobke
9978cee1e3
Merge pull request #7773 from nextcloud/add-events-for-favorites 
Add events for favorites
 2018-01-10 14:42:31 +01:00
Julius Härtl
d4e106f2b3
More detailed theming capabilities 
This will allow clients to easily check if a custom background is used

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-10 13:23:22 +01:00
Joas Schilling
3af6d112ce
Add events for favorites 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-10 11:20:21 +01:00
Julius Härtl
927626cbaa
Fix appmenu svg double invert 
This fixes a regression caused by 9b668d0, where the css filters to
preview color inversion of the app menu was applied by default. This
commit makes the css filters sensitive on what the current state of the
app menu is.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-10 09:11:32 +01:00
Roeland Jago Douma
d4f163b230
Don't encode paths passed to the OC.Files.Client 
This is handled already in the client. So double encoding breaks things
in some situations.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-10 08:35:40 +01:00
Roeland Jago Douma
e5cc8ebe7a
Return proper principal on the uploads collection listing 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-10 08:35:20 +01:00
Nextcloud bot
e18c0b2ac3
[tx-robot] updated from transifex 2018-01-10 01:11:20 +00:00
Morris Jobke
8257689e35
Merge pull request #7705 from nextcloud/theming-calc-adjust 
Adjust theming color calculations using sRGB luma
 2018-01-09 23:04:30 +01:00
Morris Jobke
167f4624ce
Merge pull request #7713 from nextcloud/fix-sync-offset 
Fix LDAP Background Sync does not reset offset
 2018-01-09 18:39:31 +01:00
Julius Härtl
3379290a73
Fix SCSS processing when undoing theming values 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-09 14:18:03 +01:00
Nextcloud bot
4dd4e43320
[tx-robot] updated from transifex 2018-01-09 01:11:15 +00:00
Julius Härtl
9bb0299c98
Add colors to tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-08 16:50:03 +01:00
Morris Jobke
9c3ac19b33
Merge pull request #7716 from nextcloud/hide-favourite-icon-in-details-view-if-favourite-action-is-not-available 
Hide favourite icon in details view if favourite action is not available
 2018-01-08 15:42:58 +01:00
Arthur Schiwon
cf915b0f75
extend test for rotating prefixes 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-08 13:46:07 +01:00
Arthur Schiwon
7c3db54ff6
fix changing to next cycle 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-08 13:45:06 +01:00
Arthur Schiwon
0d3f945209
add tests for whole run command 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-08 13:44:45 +01:00
Arthur Schiwon
b17c5fec40
add unit test for qualifies to run 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-08 13:08:59 +01:00
Arthur Schiwon
e4310648df
add unit test for determining next cycle 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-08 12:57:14 +01:00
Julius Härtl
9b668d01f5
Fix preview when theming changes invertion of icons 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-08 10:32:25 +01:00
Julius Härtl
e4f9c75a05
Adjust theming color calculations using sRGB luma 
based on https://robots.thoughtbot.com/closer-look-color-lightness

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-08 10:31:34 +01:00
Nextcloud bot
75f3b605d3
[tx-robot] updated from transifex 2018-01-08 01:11:17 +00:00
Nextcloud bot
f25e51c369
[tx-robot] updated from transifex 2018-01-07 01:11:11 +00:00
Nextcloud bot
2e683d3502
[tx-robot] updated from transifex 2018-01-06 01:11:09 +00:00
Daniel Calviño Sánchez
3113ee1129 Hide favourite icon in details view if favourite action is not available 
When the favourite icon in the details view is clicked the "Favorite"
action is triggered. However, if the action name given to
"triggerAction" is not found then the "Download" action is triggered
instead. As the "Favorite" action is not available in some file lists
(like "Recents") the "Download" action was executed instead in those
cases, which was a strange behaviour. Now the favourite icon is
hidden if its action is not available.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-05 19:06:06 +01:00
Arthur Schiwon
a565bf0b9f
fix offset is never being reset 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-05 14:29:11 +01:00
Arthur Schiwon
82da4fde18
create failing test for this case 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-05 14:27:36 +01:00
Julius Härtl
24233162a0
Fix faulty path in theming scss generation 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-05 09:43:09 +01:00
Nextcloud bot
1f8896d8c9
[tx-robot] updated from transifex 2018-01-05 01:11:18 +00:00
Georg Ehrke
1b8fc260c6
generate different UIDs for Birthday, Anniversary and Death event 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2018-01-04 20:15:24 +01:00
Roeland Jago Douma
0280cff66f
Composer updated 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-04 16:31:16 +01:00
Morris Jobke
e655732458
Merge pull request #7570 from nextcloud/s3-legacy-auth 
add option to use legacy v2 auth with s3
 2018-01-04 13:17:58 +01:00
Nextcloud bot
298b79410d
[tx-robot] updated from transifex 2018-01-04 09:48:31 +00:00
Roeland Jago Douma
493c255f7f
Merge pull request #7686 from nextcloud/fix-quota-update-3 
Fixed quota update on upload and on delete
 2018-01-04 08:32:36 +01:00
Morris Jobke
19280adc0d
Merge pull request #7611 from nextcloud/fix-7445 
Don't attempt to translate login names to uids when uids are provided
 2018-01-03 23:45:31 +01:00
Arthur Schiwon
e9eccf34f9
removes invalid tests, adapts another one 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-03 21:44:30 +01:00
Roeland Jago Douma
5011142024
Merge pull request #7685 from nextcloud/link-to-update 
Make update notification open the new update view from apps management
 2018-01-03 21:30:52 +01:00
John Molakvoæ (skjnldsv)
88dd8e46f9
Fixup! removed unwanted line 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-01-03 17:55:53 +01:00
John Molakvoæ (skjnldsv)
ab1985b62b
Fixed quota update on upload and on delete 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-01-03 17:53:48 +01:00
Julius Härtl
bdea20330d
Make update notification open the new update view from apps management 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-03 17:21:41 +01:00
Roeland Jago Douma
62d71158a9
Merge pull request #7680 from nextcloud/fix-7609 
format links in comments
 2018-01-03 16:59:08 +01:00
Morris Jobke
722097f7a0
Merge pull request #7669 from nextcloud/ie-fix-invert 
Fix inverted app icons on IE11
 2018-01-03 16:58:11 +01:00
Morris Jobke
0bc6a7d7fd
Merge pull request #7681 from nextcloud/fix-quota-update-2 
Update quotas on each upload
 2018-01-03 16:30:19 +01:00
Morris Jobke
876238ce8b
Merge pull request #7533 from nextcloud/oc-28545-handle-oc-total-length-in-new-chunking 
[oc] Handle OC-Total-Length in new chunking
 2018-01-03 16:18:24 +01:00
Julius Härtl
63b4d7e183
Remove css invert since we are using svg filters for now 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-03 14:42:08 +01:00
Morris Jobke
ee0653d68b
Merge pull request #7678 from nextcloud/fix-share-logo 
Use guest css on sharing authentication page
 2018-01-03 14:18:17 +01:00
John Molakvoæ (skjnldsv)
51eb26e183
Fix unwanted var 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-01-03 14:01:47 +01:00
John Molakvoæ (skjnldsv)
c4490c6ba8
Update quotas on each upload 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-01-03 13:59:36 +01:00
Arthur Schiwon
282567fced
format links in comments 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-03 13:11:20 +01:00
Julius Härtl
aed7052a38
Use guest css on sharing authentication page 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-03 12:03:26 +01:00
Morris Jobke
0b4d18673e
Do not log user errors as log level 4 
* hides log entries for the case the parent folder does not exist

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-03 11:58:55 +01:00
Morris Jobke
31c0efc299
Show warning if slash is entered as filename 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-03 11:42:49 +01:00
Roeland Jago Douma
f159d8d835
Merge pull request #7634 from Abijeet/bug-7539 
Fixes the delete button not appearing on certain lower resolutions
 2018-01-03 08:28:26 +01:00
Daniel Calviño Sánchez
c500b19762 Remove margin for selected files summary 
The selected files summary shown in the multiselect header has a margin
to align it with the names of the files in the contents of the file
list. However, on very narrow screens, and depending on the verbosity of
the language, the summary can overlap with the actions when the
selection contains files and folders. To try to mitigate this, besides
showing only the icons for the actions, the summary margin is removed
too in very narrow screens.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-03 02:22:00 +01:00
Daniel Calviño Sánchez
64c0874a15 Increase touch area for header icons 
On narrow screens only the action icons are shown in the multiselect
header of the file list. In that case the padding of those icons is
increased to provide a larger touch area (the padding used is the same
as in the inline actions of the file list).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-03 01:32:39 +01:00
Morris Jobke
4d0315ceae
Merge pull request #7599 from nextcloud/quieter-debug-log 
don't show recurring log msg when paged result was turned off
 2018-01-03 00:40:46 +01:00
Morris Jobke
7be9b38e51
Merge pull request #7658 from nextcloud/update-external-storages-to-current-file-list-layout 
Update "External storages" to current file list layout
 2018-01-03 00:37:41 +01:00
Abijeet
361aaf0c95 Fixes the delete icon not appearing on certain resolutions. 
Fixes #7539

Also fixes overlap of text on mobile devices by resorting to just icons on lower resolutions.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
 2018-01-02 23:24:43 +01:00
Roeland Jago Douma
7fdd9097bb
Merge pull request #7663 from nextcloud/fix-file-list-visible-behind-the-multiselect-header 
Fix file list visible behind the multiselect header
 2018-01-02 19:58:17 +01:00
Roeland Jago Douma
194e955c88
Merge pull request #7662 from nextcloud/ldap-shutdown 
throw ServerNotAvailableException when LDAP is caught shutting down
 2018-01-02 19:57:11 +01:00
Morris Jobke
588b0085dd
Merge pull request #7598 from nextcloud/fix-closing-menu-on-second-click-in-sharing-page 
Fix closing menu on second click in sharing page
 2018-01-02 15:11:30 +01:00
Daniel Calviño Sánchez
0b494b1f20 Fix file list visible behind the multiselect header 
Some parts of the file list contents (file name and actions) had a
higher z-index than the file list multiselect header. That header is
fixed in place, so when the file list contents were scrolled and those
parts with a higher z-index overlapped the multiselect header they were
fully visible. Now the z-index for the multiselect header has a higher
value (the same used in the controls bar) to ensure that the contents
are shown behind the header.

Fixes #7540

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-01-02 14:05:15 +01:00
Arthur Schiwon
c8851e24a8
throw ServerNotAvailableException when LDAP is caught shutting down 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-01-02 12:20:44 +01:00
Roeland Jago Douma
75d4f0bcda
Merge pull request #7644 from nextcloud/fix_7184 
Do not run SyncJob in cron
 2018-01-02 11:12:14 +01:00
Roeland Jago Douma
4c0c3c0bef
Show max warning comment lenth again 
Fixes #7414

Since we no longer use an input field we have to use text instead of
val.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-02 10:28:09 +01:00
Morris Jobke
fa2fe34b7a
Merge pull request #7624 from nextcloud/fix-fileActions-currentFile-not-set-before-using-it 
Fix "fileActions.currentFile" not set before using it
 2018-01-02 10:28:04 +01:00
Roeland Jago Douma
0585b776fb
Do no run SyncJob in cron 
Fixes #7184

The SyncJob can be very resource intensive. Since it requests all users
on the system to create the system addressbook. In order to do this it
creates a vcard for every user and updates the addressbook.

There is no need for this job since the proper signals are emitted and
handled in the carddav backend to update the addressbook live.

Worst comes to worst there is always the occ command to bring the
address book in sync again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-02 10:00:01 +01:00
Roeland Jago Douma
ea858fcb55
Merge pull request #7626 from nextcloud/fixed-files-multiselect-top-margin 
Fixed top position of multiselected files table
 2017-12-28 11:22:44 +01:00
Roeland Jago Douma
08cbfb6c6b
Merge pull request #7592 from nextcloud/update-quota-on-files-upload 
Update quota on files upload
 2017-12-28 10:53:14 +01:00
Daniel Calviño Sánchez
11125164be Disable selection in "External storages" file list 
When the checkbox was moved to where the favourite icon was shown before
the layout of the file list was modified. The checkbox is no longer a
descendant of the ".filename" element, so it is no longer removed by the
"External storages" file list.

However, even before the checkbox was moved, explicitly removing it was
not the best approach, as file list rows could still be selected using
"Ctrl/Shift+click". This did not provide much value, as the selection
header has no actions; it simply states the number of selected elements.
The proper way to disable the selection is by setting "_allowSelection"
to false in the file list instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2017-12-27 16:31:22 +01:00
Daniel Calviño Sánchez
78891ac320 Fix selectors for file list elements 
When the checkbox was moved to where the favourite icon was shown before
the layout of the file list was modified. The first column is no longer
the file name, so neither the thumbnail nor the name link were found.
Due to this the thumbnail was not set to the appropriate icon, and the
dummy event handler was not removed from the name link, so clicks on the
name were basically ignored. Now the selectors are based on the
".filename" CSS class instead of relying on the column position.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2017-12-27 16:17:00 +01:00
John Molakvoæ (skjnldsv)
84c961919b
Fixed top position of multiselected files table 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2017-12-26 17:22:18 +01:00
John Molakvoæ (skjnldsv)
c8db1ed741
Fixed tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2017-12-26 16:37:34 +01:00
Daniel Calviño Sánchez
ea40ade8ad Fix "fileActions.currentFile" not set before using it 
When an empty area of a file row was clicked and the "Details" action
was executed "fileActions.currentFile" was not guaranteed to be set to
the appropriate object (it depended on the previous actions of the
user), so when it was used by "getCurrentMimeType()" and other
FileActions functions they may not work as expected. Now it is
explicitly set to the appropriate value before its use.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2017-12-26 04:56:25 +01:00
Morris Jobke
e37fa60784
Merge pull request #7591 from nextcloud/trigger-events-before-and-after-a-file-action-is-executed 
Trigger events before and after a file action is executed
 2017-12-22 12:31:55 +01:00
Roeland Jago Douma
e40d6f6d8c
Merge pull request #7597 from nextcloud/fix-anchor-change-when-clicking-on-sharing-page-menu 
Fix anchor change when clicking on sharing page menu
 2017-12-22 12:28:27 +01:00
John Molakvoæ (skjnldsv)
8cc90ab4de
Fixed breadcrumbs tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2017-12-21 16:22:54 +01:00
Arthur Schiwon
82fd09c294
don't show recurring msg when pages result was turned off 
and only as debug level otherwise.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2017-12-21 14:29:56 +01:00
Daniel Calviño Sánchez
eb256b3ed5 Fix anchor change when clicking on sharing page menu 
The share menu toggle and some share menu items included an 'href="#"'
attribute, so they were handled as internal links by the browser, which
changed the current anchor when they were clicked. However, there was no
real need to change the anchor in those cases, and it could interfere
with other apps (for example, the PDF viewer sets the current anchor to
"#pdfviewer" when it is shown and it hides itself when that anchor is
modified). According to the HTML 5 spec the "href" attribute is not
mandatory for "a" elements, so they were removed.

Other options would have been to change the elements from "a" to "div"
or something like that, but that would have required changes to the CSS
rules too, or to prevent the default event handling for those elements
through JavaScript, which would have been a workaround instead of the
proper solution.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2017-12-21 14:19:29 +01:00