wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
45341 commits 157 branches 562 tags 714 MiB
Commit graph

482 commits

Author SHA1 Message Date
Morris Jobke
e4077672e1
Use empty array as group list in OC_App::enable 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-02-17 16:05:23 +01:00
Morris Jobke
2e15c0d871
Refactor dependencies in setAppTypes 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-02-17 16:05:23 +01:00
Morris Jobke
9dc3b04802
Fix app version to be always string and neither array nor null 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-02-17 16:05:13 +01:00
Morris Jobke
edee243b27
OC_App::loadApps now only accepts an array as type list 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-02-17 15:27:43 +01:00
Morris Jobke
2a2833e30f
Migrate to short array syntax 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-02-17 15:18:34 +01:00
Morris Jobke
14bc9b1714
Merge pull request #8095 from nextcloud/webapps-capabilities 
Expose navigation entries as API endpoint
 2018-02-15 16:55:12 +01:00
Julius Härtl
f36e8313ff
Add throws annotation 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-15 12:23:49 +01:00
Julius Härtl
04053311ee
Properly encapsulate require_once for app.php 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-15 11:20:22 +01:00
Julius Härtl
ada5aed35e
Deprecate static methods and use Navigation manager 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-12 17:22:33 +01:00
Julius Härtl
864474b858
Move navigation processing to the NavigationManager 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-12 17:22:32 +01:00
Arno Welzel
e7c35d720d Avoid error messages for restricted opcache API 2018-02-05 19:45:06 +01:00
Joas Schilling
c314a07e7f
Merge pull request #8134 from coliff/patch-2 
Update iOS link to geo-detect & show correct store listing
 2018-02-02 12:43:10 +01:00
Christian Oliff
18898383c5
Update defaults.php 2018-02-02 20:37:58 +09:00
Morris Jobke
cbbc6187c2
Update doc link version to 14 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-02-01 13:52:11 +01:00
Julius Härtl
efbdad2d0c
Remove OC_App::removeApp 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-31 14:15:12 +01:00
Julius Härtl
a68895e334
Remove OC_App::installApp since it is not used anymore 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-31 14:15:10 +01:00
Julius Härtl
19a0a9a4e7
Move getAppInfo and getAppVersion to IAppManager 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-01-31 14:13:15 +01:00
Joas Schilling
d971b104ed
Do not cache the settings/sections in the database anymore 
This caused more troubles then it had benefits, especially
when an app got disabled or was removed without being disabled.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-29 15:47:37 +01:00
Morris Jobke
a661f043e1
Remove unneeded semicolon and parentheses 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 23:46:40 +01:00
Morris Jobke
4c38d1ed01
Merge pull request #8054 from nextcloud/substr-use-index 
Use index based string access for substr with length of 1
 2018-01-26 15:40:44 +01:00
Morris Jobke
9ff51aafc5
Use index based string access for substr with length of 1 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 13:38:34 +01:00
Morris Jobke
6bbea33133
Simplify ternary operator statements 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 12:36:25 +01:00
Morris Jobke
c1e4f9f305
Use type casting instead of *val() method 
It should be up to 6x faster

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 11:35:42 +01:00
Joas Schilling
a7ad7cb08e
Merge pull request #8053 from nextcloud/simplify-substr 
Use short for of substr to not need strlen()
 2018-01-26 10:25:09 +01:00
Morris Jobke
0a56d2185e
Return value immediately instead of assigning to a one-time variable 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-26 00:02:03 +01:00
Morris Jobke
e6efa755c9
Use short for of substr to not need strlen() 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-25 22:23:48 +01:00
Julius Härtl
f0b7b2dedf
Merge pull request #7911 from nextcloud/improve-oc_image 
Improve OC_Image code to not guess the type of input
 2018-01-18 14:39:08 +01:00
Morris Jobke
3d4c698f44
Improve OC_Image code to not guess the type of input, but actually request the specific methods to be called 
Followup to #7836

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-18 13:40:55 +01:00
Roeland Jago Douma
1e7b20f615
Remove IAppConfig::setValue 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-17 21:41:57 +01:00
Roeland Jago Douma
09f8a755ec
Remove IAppConfig::getValue 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-17 21:41:56 +01:00
Morris Jobke
9222dcd940
Merge pull request #7836 from nextcloud/image-type-hinting 
Fix float/integer handling in image API
 2018-01-17 11:40:35 +01:00
Morris Jobke
e4b3ee8d8f
Fix float/integer handling in image API 
* IImage::crop/preciseResize now have type hinting for integers
* found while testing strict typing for PHP 7+

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-17 10:00:33 +01:00
Morris Jobke
55532f19d9
Cleanup OC_User and OCP\User 
* mainly removes deprecated methods and old static code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-16 18:39:11 +01:00
Joas Schilling
c95890f9b0
Keep all shipped apps enabled because they should be okay 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-16 11:39:48 +01:00
Roeland Jago Douma
8a41d05761
Remove deprecated \OCP\Config 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-13 14:25:04 +01:00
Morris Jobke
e4e39910f3
Merge pull request #7819 from nextcloud/fix-explode-in-legacy-helper.php 
Fix explode() call in legacy/helper.php to have correct types
 2018-01-12 17:59:15 +01:00
Morris Jobke
b356d0dfc4
Fix explode() call in legacy/helper.php to have correct types 
Found while enabling strict_typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-12 15:26:49 +01:00
Morris Jobke
e3c0fd6882
Fix strpos if needle is not found 
Found while testing strict_typing for PHP 7+. If `$script` does not contain a `/` then it should extract a string of the length 0.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-01-12 15:01:45 +01:00
Roeland Jago Douma
faa68b28cb
Only return 1 type 
Throw proper exception if we can't get the mimetype for a preview. Catch
it later on so we can just return a not found for the preview.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-07 14:36:37 +01:00
Roeland Jago Douma
5b21650097
Don't lie about the preview mimetype 
For legacy reasons we stored all the previews with a png extention.
However we did not put png data in them all the time.

This caused the preview endpoints to always report that a preview is a
png file. Which was a lie.

Since we abstract away from the storage etc in the previewmanager. There
is no need anymore to store them as .png files and instead we can use
the actual file extention.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-07 11:41:54 +01:00
Morris Jobke
d2d73f1ce8
Also replace all other occurences 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-12-18 20:57:11 +01:00
Morris Jobke
d19dcfd0eb
Fix default parameter of OC_DB::executeAudited() 
* fixes #7546

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-12-18 13:58:54 +01:00
Morris Jobke
7c39711798
Merge pull request #7427 from nextcloud/fix-white-color-in-emails 
Fix email buttons for white theme
 2017-12-11 15:16:28 +01:00
Morris Jobke
cce4c285db
Fix email buttons for white theme 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-12-11 14:33:54 +01:00
blizzz
83509b0fd3
Merge pull request #7334 from nextcloud/feature/noid/language-depending-skeleton-directory 
Allow `{lang}` as a placeholder in the skeleton directory
 2017-12-08 18:19:01 +01:00
Morris Jobke
8ffd4428bb
Fallback to "default" and check if directory exists 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-12-08 12:28:41 +01:00
Arthur Schiwon
1b7dfd73af
Allow to skip data dir permission checks by config 
Enables installation on services that don't allow/support permission
changes.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2017-11-30 11:16:00 +01:00
Joas Schilling
8e684f76e5
Allow {lang} as a placeholder in the skeleton directory 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-11-29 10:04:53 +01:00
Lukas Reschke
fb1a92b07d
Merge pull request #7295 from nextcloud/remove-unused-method 
Remove unused mimetype detection method in OC_Image
 2017-11-27 11:55:20 +01:00
Morris Jobke
dbb034f903
Remove unused mimetype detection method in OC_Image 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-27 07:46:32 +01:00
Morris Jobke
0e2f00ec59
Get the Installer via DI 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-25 12:00:57 +01:00
Morris Jobke
be4e921306
Use basename() instead of self implementation 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-23 12:35:47 +01:00
Lukas Reschke
8c915baa34
Merge pull request #6788 from staabm/master 
Prevent XSS in links which open a new browser window
 2017-11-08 18:55:35 +01:00
Roeland Jago Douma
f55732a18f
Merge pull request #7075 from nextcloud/remove-unused-variables 
Remove unused variables
 2017-11-07 16:18:40 +01:00
Morris Jobke
31c5c2a592
Change @georgehrke's email 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-06 20:38:59 +01:00
Morris Jobke
0eebff152a
Update license headers 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-06 16:56:19 +01:00
Morris Jobke
5445b1ff17
Remove unused variables 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-06 09:43:45 +01:00
Arthur Schiwon
e2805f02aa
Merge branch 'master' into autocomplete-gui 2017-11-01 15:37:29 +01:00
Morris Jobke
f368481c23 Merge pull request #6928 from nextcloud/remove-unneeded-method 
Remove unused method of OC_App
 2017-10-24 17:50:43 +02:00
Morris Jobke
7b7bf73670
Deprecate OC_App:isEnabled 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-10-24 14:05:46 +02:00
Morris Jobke
df85b13296
Remove unused method of OC_App 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-10-24 14:04:09 +02:00
Morris Jobke
3eaf23f29f Merge pull request #6920 from nextcloud/appmanager-usage 
Use appmanager instead of OC_App for check for enabled app
 2017-10-24 13:53:17 +02:00
Morris Jobke
f884e762bc
Use appmanager instead of OC_App for check for enabled app 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-10-23 23:31:17 +02:00
Julius Härtl
4cfa1c66b8
Doc: Fix phpDoc issues 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2017-10-23 23:23:56 +02:00
Arthur Schiwon
fd6daf8d19
AutoCompletion backend 
* introduce a Controller for requests
* introduce result sorting mechanism
* extend Comments to retrieve commentors (actors) in a tree
* add commenters sorter
* add share recipients sorter

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2017-10-22 14:13:32 +02:00
Markus Staab
db34b59238 Prevent XSS in links which open a new browser window 2017-10-19 12:16:04 +02:00
Roeland Jago Douma
3a9c24c04f
Allow apps to have their own autoloader 
This will allow apps to also have a proper classmap and authorative
autoloader.

Currently if a file: <appdir>/composer/autoload.php exists we will use
it. Else we keep the current behavior.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-10-17 21:35:49 +02:00
Julius Härtl
ec0091d499
Do not return app names multiple times 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2017-10-10 12:34:38 +02:00
Arthur Schiwon
a579f8aa37
adapt attribute name (changed letter case style) 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2017-09-27 13:22:59 +02:00
Arthur Schiwon
937a80c941
reduce nesting of the required app XML 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2017-09-27 01:22:17 +02:00
Arthur Schiwon
f7713e5f3f
make it possible to register plugins and kick out the circle one 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2017-09-26 23:10:23 +02:00
Roeland Jago Douma
2207fdcd8c
Remove private legacy OC_OCS_Response 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-09-21 17:56:56 +02:00
Roeland Jago Douma
87e10f9e6a
OC_OCS_Response is deprecated 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-09-21 17:56:00 +02:00
Roeland Jago Douma
6d7ca1092d
Read appinfo from a local cache 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-09-19 14:34:11 +02:00
Arthur Schiwon
0837745477
don't pass User object when uid string is expected 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2017-09-18 13:19:47 +02:00
Lukas Reschke
2e4cd44556
Inject \OCP\IURLGenerator to make tests work 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-18 15:32:40 +02:00
Lukas Reschke
a04feff9a7
Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 
Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string.
This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result
in `<a href="foo">`.

This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with
054e161eb5 inside the navigation manager where one cannot simply inject attributes.

Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112,
people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects
you to the IdP and properly logs you out there as well.

Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to
use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout
URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but
I'm not aware of any and there's simply no way to fix this properly otherwise.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-18 12:22:44 +02:00
Morris Jobke
585e5c6ea5
Logo claim is not used anymore 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-02 23:08:45 +02:00
Morris Jobke
cd02b2205e Use public methods for OC_App::isShipped 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-01 18:57:00 +02:00
Morris Jobke
050fa63380 Merge pull request #5939 from nextcloud/dont-have-set-uid-as-displayname 
Remove setUidAsDisplayName
 2017-08-01 13:28:27 +02:00
Lukas Reschke
0fa49db770
Some more invalid PHPDocs in legacy classes 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-01 08:20:16 +02:00
Lukas Reschke
dfd8125aeb
Replace wrong PHPDocs 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-01 08:20:16 +02:00
Lukas Reschke
b53c4c0db9
Fix template functions 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-01 08:20:16 +02:00
Lukas Reschke
28098a7602
Fix \OCP\Util 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-01 08:20:15 +02:00
Lukas Reschke
5424d6a40d
Add proper PHPDoc 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-01 08:20:15 +02:00
Lukas Reschke
bef4f015ee
Remove setUidAsDisplayName 
This code is a leftover from the old Shibboleth implementation from ownCloud days, nowadays it causes more issues than it does good (such as https://github.com/nextcloud/user_saml/pull/137). Let's remove it for the future thus.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-07-31 15:52:53 +02:00
Morris Jobke
c27498db71 Use IConfig instead of static OCP\Config 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-07-27 13:43:18 +02:00
Lukas Reschke
3faef644a1 Merge pull request #5864 from nextcloud/legacy_user 
Remove legacy OC_User_Backend and OC_User_Interface
 2017-07-25 17:15:11 +02:00
Roeland Jago Douma
b930f32e89
Remove legacy OC_User_Backend and OC_User_Interface 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-07-24 20:42:55 +02:00
Roeland Jago Douma
a907720817
Move \OC_L10N_String to proper \OC\L10N\L10NString 
* Proper namespacing
* Fixed phpdocs

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-07-24 20:17:20 +02:00
Morris Jobke
5dc480a38c Merge pull request #5857 from nextcloud/database-exception-cleanup 
Remove unneeded parameter in DatabaseException
 2017-07-24 16:14:53 +02:00
Morris Jobke
c43d479372 Merge pull request #5855 from nextcloud/cleanup-legacy-user-class 
Cleanup legacy user class from unused methods
 2017-07-24 14:39:18 +02:00
Morris Jobke
184f25c0d6 Merge pull request #5854 from nextcloud/improve-personal-page-code 
Cleanup code of personal page to use public interfaces
 2017-07-24 14:38:05 +02:00
Morris Jobke
b8ed028870 Remove unneeded parameter in DatabaseException 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-07-24 13:44:12 +02:00
Morris Jobke
188b87e03b Cleanup legacy user class from unused methods 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-07-24 12:17:53 +02:00
Morris Jobke
7790017a14 Cleanup code of personal page to use public interfaces 
* public interfaces instead of static code calls
* drop static private namespace methods

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-07-24 12:11:24 +02:00
Roeland Jago Douma
5f227bd93b
More phpstorm inspection fixes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-07-24 11:39:29 +02:00
Marin Treselj
586eb3ed0a
Redesign jQuery UI datepicker 
Signed-off-by: Marin Treselj <marin@pixelipo.com>
 2017-07-23 14:06:04 +02:00
Roeland Jago Douma
7753b93aa6
PrivateData to app 
* PrivateData is an app now: https://github.com/nextcloud/privatedata
* No need to load the OCS routes.php (as there is none!)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2017-07-21 08:51:14 +02:00
Morris Jobke
c2ba5e2884 Merge pull request #5529 from michaelletzgus/optimize_js_order 
Optimize performance / Load CSS and JS in parallel on firefox
 2017-07-07 11:16:31 +02:00