Commit graph

41973 commits

Author SHA1 Message Date
Daniel Calviño Sánchez
dab4a70bcf Add acceptance test for renaming a file with the details view open
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 04:30:52 +01:00
Daniel Calviño Sánchez
f29c1cf13a Fix empty details view after renaming a file
"FileList._updateDetailsView" expects either a file name (as a string)
or a file model (as an "OCA.File.FileInfoModel"), but when called
through "updateInList" an "OC.Files.FileInfo" object was given instead.
As the given attribute was not a model "_updateDetailsView" treated it
as a file name and tried to get the model for that file, which failed
and caused the details view to be emptied.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 02:47:11 +01:00
Daniel Calviño Sánchez
7a088cfcf5 Move adding test files to "beforeEach()"
All the tests in the "Renaming files" section added the test files,
although those calling "doRename()" added them by setting a path for the
file too. However, the path is ignored in the other tests, so adding the
files can be unified and moved to "beforeEach()".

This would be needed, for example, to show the details view for a file
before calling "doRename()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 02:45:47 +01:00
Morris Jobke
00a823f62e
Merge pull request #7765 from nextcloud/fix_5574
Don't encode paths that will be passed to the davclient
2018-01-10 21:00:19 +01:00
Roeland Jago Douma
03a7d9bbfa
Merge pull request #7635 from Abijeet/bug-7106
Fixes password input being prompted every time.
2018-01-10 20:10:40 +01:00
Daniel Calviño Sánchez
9c22e99331 Add extra test cases for password confirmation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-10 16:42:25 +01:00
Abijeet
b246ca96ff Added test cases for the fix for the password confirmation box appearing repeatedly.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-01-10 16:41:27 +01:00
Morris Jobke
4823ac969a
Merge pull request #7763 from nextcloud/pos_fix_7751
Do not instantiate node when not needed
2018-01-10 15:40:10 +01:00
Morris Jobke
9978cee1e3
Merge pull request #7773 from nextcloud/add-events-for-favorites
Add events for favorites
2018-01-10 14:42:31 +01:00
Roeland Jago Douma
9c017084e5
Merge pull request #7767 from nextcloud/fix-theming-regression
Fix appmenu svg double invert
2018-01-10 13:10:20 +01:00
Morris Jobke
4f561e2bca
Merge pull request #7769 from nextcloud/fix-ie-svg-size
Set height for sidebar icons
2018-01-10 12:36:02 +01:00
blizzz
fe12b2b05d
Merge pull request #7766 from nextcloud/log_properly_7755
Log a missing setting as INFO not as WARNING
2018-01-10 12:25:49 +01:00
Morris Jobke
1f85b98b1d
Merge pull request #7772 from nextcloud/coc_ci
Fix CI after Code of Conduct merge
2018-01-10 11:29:52 +01:00
Joas Schilling
3af6d112ce
Add events for favorites
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-10 11:20:21 +01:00
Roeland Jago Douma
c715045749
Fix CI after Code of Conduct merge
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 11:03:12 +01:00
Julius Härtl
e8399953df
Set height for sidebar icons
This makes sure they are properly scaled in IE11

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-10 09:51:48 +01:00
Morris Jobke
da030b667d
Merge pull request #7768 from nextcloud/code-of-conduct
Create CODE_OF_CONDUCT.md
2018-01-10 09:48:49 +01:00
Jos Poortvliet
89d3c5e5b9
Create CODE_OF_CONDUCT.md
By adding (a link to) our code of conduct to the github repo, Github will be able to show it to people. Yay!
2018-01-10 09:32:58 +01:00
Julius Härtl
927626cbaa
Fix appmenu svg double invert
This fixes a regression caused by 9b668d0, where the css filters to
preview color inversion of the app menu was applied by default. This
commit makes the css filters sensitive on what the current state of the
app menu is.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-10 09:11:32 +01:00
Roeland Jago Douma
f6d84bdb23
Log a missing setting as INFO not as WARNING
It can happen for all kinds of reasons that a setting is not available.
(A user removes a folder, a setting got deleted). So don't polute the
log on default settings.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 09:02:01 +01:00
Roeland Jago Douma
88388cadb0
Merge pull request #7760 from nextcloud/remove-useless-output
Remove "DEBUG OUTPUT:" from failing OCS API requests
2018-01-10 08:45:15 +01:00
Roeland Jago Douma
d4f163b230
Don't encode paths passed to the OC.Files.Client
This is handled already in the client. So double encoding breaks things
in some situations.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 08:35:40 +01:00
Roeland Jago Douma
e5cc8ebe7a
Return proper principal on the uploads collection listing
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 08:35:20 +01:00
Nextcloud bot
e18c0b2ac3
[tx-robot] updated from transifex 2018-01-10 01:11:20 +00:00
Morris Jobke
8257689e35
Merge pull request #7705 from nextcloud/theming-calc-adjust
Adjust theming color calculations using sRGB luma
2018-01-09 23:04:30 +01:00
Roeland Jago Douma
4596423b14
Do not instantiate node when not needed
Use the lazy functions is possible. This avoids getting the node if not
required.

Possible fix for #7751

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-09 19:51:50 +01:00
Morris Jobke
167f4624ce
Merge pull request #7713 from nextcloud/fix-sync-offset
Fix LDAP Background Sync does not reset offset
2018-01-09 18:39:31 +01:00
Morris Jobke
ca74a54dfa
Remove "DEBUG OUTPUT:" from failing OCS API requests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-09 18:34:25 +01:00
Morris Jobke
8c9e584c6b
Merge pull request #7756 from nextcloud/fix-theming-rebase-url
Fix SCSS processing when undoing theming values
2018-01-09 17:40:34 +01:00
Julius Härtl
3379290a73
Fix SCSS processing when undoing theming values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-09 14:18:03 +01:00
Jan-Christoph Borchardt
9386b07ed8
Merge pull request #7731 from nextcloud/preview_size_inc
Max preview size to 4096x4096
2018-01-09 11:07:02 +01:00
Jan-Christoph Borchardt
c747d6c95d
Merge pull request #7729 from nextcloud/fix-tooltip-shadow
Improve shadow of tooltips
2018-01-09 11:05:51 +01:00
Nextcloud bot
4dd4e43320
[tx-robot] updated from transifex 2018-01-09 01:11:15 +00:00
Roeland Jago Douma
0fb1c986de
Merge pull request #7739 from nextcloud/_blank
opens comments links in _blank 🙊
2018-01-08 20:42:37 +01:00
Roeland Jago Douma
7d87e8305d
Merge pull request #7692 from nextcloud/dont_lie_preview_mimetype
Don't lie about the preview mimetype
2018-01-08 20:38:12 +01:00
Abijeet
de5467811a Fixes password input being prompted every time.
Fixes #7106

- Echoing the current server time via a JS variable and storing the current time on page load in JS.
- Calculating the diff and taking it into account when deciding whether to show the password confirmation.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-01-08 23:47:52 +05:30
Julius Härtl
9bb0299c98
Add colors to tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-08 16:50:03 +01:00
Arthur Schiwon
770c744e45
opens comments links in _blank 🙊
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 16:06:24 +01:00
Morris Jobke
9c3ac19b33
Merge pull request #7716 from nextcloud/hide-favourite-icon-in-details-view-if-favourite-action-is-not-available
Hide favourite icon in details view if favourite action is not available
2018-01-08 15:42:58 +01:00
Roeland Jago Douma
e2352cc06f
Max preview size to 4096x4096
With HiDPI screens. And even normal HD screens you want more detail from
your pictures. Or the ability to somewhat zoom on you previews. For this
we need somewhat larger previews.

Moving the default to 4096x4096 is a step up. Users that want the old
behavior can still set the values in config.php

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-08 15:35:55 +01:00
Morris Jobke
db7bde6ae6
Merge pull request #7733 from nextcloud/no_max_sf
The max_scale_factor is not used anymore.
2018-01-08 14:10:46 +01:00
Arthur Schiwon
cf915b0f75
extend test for rotating prefixes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:46:07 +01:00
Arthur Schiwon
7c3db54ff6
fix changing to next cycle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:45:06 +01:00
Arthur Schiwon
0d3f945209
add tests for whole run command
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:44:45 +01:00
Arthur Schiwon
b17c5fec40
add unit test for qualifies to run
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:08:59 +01:00
Arthur Schiwon
e4310648df
add unit test for determining next cycle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 12:57:14 +01:00
Roeland Jago Douma
1e74c8fba9
The max_scale_factor is not used anymore.
We never generate previews larger than the original. So the config
setting can be removed.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-08 11:42:36 +01:00
Julius Härtl
27f00bf7fe
Improve shadow of tooltips
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-08 11:40:50 +01:00
Morris Jobke
a30dfc5b50
Merge pull request #7711 from nextcloud/fix-avatar-behaviour
Fix avatar display to not overwrite display style
2018-01-08 11:36:57 +01:00
Julius Härtl
fd8f0788b1
Fix tests
The avatar plugin should not change the display element, since the
avatar is always shown by default and the display value is up to the
developers

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-08 10:36:06 +01:00