wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11237 commits 1 branch 0 tags 100 MiB
Commit graph

189 commits

Author SHA1 Message Date
cketti
d13352a4cd Use new SmtpResponseParser in SmtpTransport 2022-04-11 17:24:55 +02:00
cketti
a7562fe3f3 Add a new parser for SMTP responses 2022-04-11 17:24:55 +02:00
cketti
556188efcc Properly report progress when receiving multiple FETCH responses per message 2022-03-05 02:04:14 +01:00
cketti
9dd076686b Remove unnecessary/unused method parameters 2022-03-05 01:20:23 +01:00
cketti
4bed7a595b Remove unused method parameters 2022-02-24 19:56:50 +01:00
cketti
e59f57f602 Remove unused callbacks from MessageRetrievalListener 2022-02-24 19:42:01 +01:00
cketti
251a221b3b Stop using AUTH without arguments (POP3) 
At least one server software closes the connection right away after receiving the AUTH command without arguments. Since using the AUTH command without arguments never made it into a standard, I decided to completely remove this functionality.
 2022-01-25 17:41:48 +01:00
cketti
61046ef0fd Update Mockito (Kotlin) to version 4.0.0 2021-10-30 05:32:51 +02:00
cketti
6084321bde Update Kotlin to 1.5.30 
Replace calls to deprecated stdlib functions
 2021-08-26 17:44:49 +02:00
cketti
652d52b6a6 Add setting to suppress notifications for chat messages 
Messages containing a 'Chat-Version' header field will not generate notifications when this setting is enabled.
 2021-08-18 11:17:06 +02:00
cketti
7874fe7e11 Properly handle responses to the IDLE command 
When waiting for the command continuation request response ignore irrelevant responses and keep track of relevant untagged responses.
 2021-08-13 16:32:30 +02:00
cketti
03caacc1a7 Make RealImapConnection (somewhat) thread-safe 2021-07-13 16:01:24 +02:00
cketti
5232a1a962 Ignore IOExceptions when sending DONE (Push) 
Errors with the connection are dealt with in the receiver thread.
 2021-07-13 15:09:09 +02:00
cketti
d96641d7a0 Remove optimization to reduce the number of times a wakelock is acquired 
ImapConnection.isDataAvailable() didn't reliably work on all devices (returned true when no complete IMAP response was available). This lead to situations where a wakelock was being held the whole time the IDLE command was active. At the same time no alarm was set to refresh the IDLE connection. So most of the time the blocking read would time out.
 2021-07-09 18:06:13 +02:00
cketti
152424b20c Add a way to close all open IMAP connections 
Use a "connection generation" value to mark all connections that have been created since the last closeAllConnections() call. Using that value we can recognize "old" connections that have not been in the connection pool at the time closeAllConnections() was called. We close them as soon as they are passed to releaseConnection().
 2021-07-03 20:04:05 +02:00
cketti
ebbe02c057 Add ImapPushConfigProvider 2021-06-23 15:34:31 +02:00
cketti
aa9f6eaefa Add IdleRefreshTimeoutProvider 2021-06-23 14:02:07 +02:00
cketti
ca13a32fec Add ImapFolderPusher to listen for changes to an IMAP folder 2021-06-12 21:09:30 +02:00
cketti
db2b9c746f Add ImapFolderIdler that uses IMAP's IDLE command to listen for changes 2021-06-10 21:40:36 +02:00
cketti
63d9872755 Introduce additional interfaces so RealImapFolder is decoupled from RealImapStore 2021-06-10 21:00:58 +02:00
cketti
94f630cf88 Introduce ImapStore interface 2021-06-10 21:00:58 +02:00
cketti
55c54555ff Introduce ImapFolder interface 2021-06-09 16:15:12 +02:00
cketti
d0fa865e1f Rename ImapFolder.kt to RealImapFolder.kt 2021-06-09 16:15:12 +02:00
cketti
ededa33ff2 Use enum class for ImapFolder.open() argument 2021-06-09 16:15:12 +02:00
cketti
3041a787d6 Introduce ImapConnection interface 
The implementation is now called RealImapConnection.
 2021-06-09 16:15:12 +02:00
cketti
d5c8c35fec Remove ImapFolder caching 
The cache was causing problems when a folder was accessed in two threads at the same time. There was also no invalidation mechanism that removed folders that had been removed from the server.

The easy fix is to get rid of this cache. There's no state in ImapFolder that survives closing the folder anyway.
 2021-05-10 17:47:54 +02:00
cketti
d25d451201 Remove unused ImapFolder properties 2021-05-10 01:32:04 +02:00
cketti
5444d8be3a Remove explicit dependency on Kotlin's standard library 2021-04-22 03:54:15 +02:00
cketti
632d8f3cb7 Upgrade Mockito-Kotlin to 3.1.0 2021-04-22 03:54:15 +02:00
cketti
987325d226 SMTP: Read all responses before issuing DATA command 2021-02-16 13:34:46 +01:00
cketti
1f2404557b Migrate storeUri/transportUri to new server settings format 2021-02-01 17:30:21 +01:00
cketti
08d6d9bebc Delete remaining store/transport URI functionality 2021-02-01 17:30:21 +01:00
cketti
69ed32ff8a Convert 'ServerSettings' to Kotlin 2021-02-01 10:39:19 +01:00
cketti
97051f3f7c Make WebDavStore use ServerSettings directly 
Instead of using WebDavStoreSettings as a ServerSettings subclass make it a helper to extract WebDav-specific settings.
 2021-01-31 18:50:14 +01:00
cketti
42e180d6fa Make ImapStore use ServerSettings directly 
Instead of using ImapStoreSettings as a ServerSettings subclass make it a helper to extract IMAP-specific settings.
 2021-01-31 18:50:14 +01:00
cketti
7ae88bb61d Treat FolderNotFoundException as permanent error 2020-12-23 01:23:24 +01:00
cketti
1873593dc5 Format Kotlin code 2020-10-16 16:41:19 +02:00
cketti
ed8009d9fa Update ktlint-gradle to 9.4.1, ktlint to 0.39.0 
Apply ktlint-gradle plugin to all Gradle subprojects.
 2020-10-16 14:27:23 +02:00
cketti
9234b16c13 Convert 'ImapSync' to Kotlin 2020-08-27 22:35:36 +02:00
Tobias Preuss
f8e6e59fd6 Use io extension functions to make code more concise. 
+ This change replaces a few usages of BufferedWriter, ByteArrayInputStream,
  OutputStreamWriter with their equivalent Kotlin extension functions.
 2020-08-24 19:22:29 +02:00
cketti
e42e0fa8b9 IMAP: Support negative responses to APPEND command 2020-06-19 18:55:04 +02:00
cketti
dc119f9068 Convert 'ImapFolder' to Kotlin 2020-06-18 14:44:26 +02:00
cketti
be7849eb5d Rename 'ImapFolder' prior to conversion to Kotlin 2020-06-18 14:44:22 +02:00
cketti
84ffe7b3cd Convert 'ImapFolderTest' to Kotlin 2020-06-18 14:44:20 +02:00
cketti
3d97acde5c Rename 'ImapFolderTest' prior to conversion to Kotlin 2020-06-18 14:44:18 +02:00
cketti
4e2ae11238 Don't select charset depending on the recipient address 
It's 2020. We now always use UTF-8 for outgoing emails.
 2020-05-27 03:07:29 +02:00
cketti
789769ef39 Replace Account.getOutboxFolder() with Account.getOutboxFolderId() 2020-05-04 16:31:00 +02:00
cketti
767f7e0efe Remove StoreConfig 2020-05-01 05:42:50 +02:00
cketti
02049c5882 Create DraftsFolderProvider 2020-05-01 05:38:37 +02:00
cketti
82db38bd08 Create ImapStoreConfig 2020-05-01 05:30:34 +02:00
cketti
a6f75dc587 Remove StoreConfig.getMaximumAutoDownloadMessageSize() 2020-05-01 05:15:51 +02:00
cketti
d7d1fe0c0e Remove StoreConfig.isRemoteSearchFullText() 2020-05-01 04:18:16 +02:00
cketti
1858986fc4 Remove StoreConfig.isAllowRemoteSearch() 2020-05-01 04:03:02 +02:00
cketti
88bcea1552 Remove StoreConfig.getOutboxFolder() 2020-05-01 03:36:42 +02:00
cketti
fcfc7e6a22 Remove unused method StoreConfig.getInboxFolder() 2020-05-01 03:31:11 +02:00
cketti
94489bf55a Change List<? extends Message> to List<Message> where appropriate 2020-04-27 18:37:10 +02:00
cketti
7ac210956a Change List<? extends Message> to List<WebDavMessage> where appropriate 2020-04-27 18:37:10 +02:00
cketti
db7760a9e2 Change List<? extends Message> to List<Pop3Message> where appropriate 2020-04-27 18:37:10 +02:00
cketti
d3bdebccf3 Change List<? extends Message> to List<ImapMessage> where appropriate 2020-04-27 18:37:10 +02:00
cketti
8abac750af Make ImapStore.getFolders() return the proper server ID 2020-04-24 22:00:10 +02:00
cketti
37eea88f82 Refactor ImapStore.getPersonalNamespaces() 2020-04-24 20:33:22 +02:00
cketti
d70564e423 Remove unused code 2020-04-18 19:51:48 +02:00
cketti
2a78418911 Remove old Push code 2020-04-05 20:08:29 +02:00
cketti
0554dfcd04 Clear local message cache when UIDVALIDITY value changes 2020-03-31 22:20:46 +02:00
cketti
5791253122 Add support for UIDVALIDITY to ImapFolder 2020-03-31 16:42:38 +02:00
cketti
35da218170 Make WebDavFolder no longer extend Folder 
This highlighted that a bunch of code in backend-webdav was unused.
 2020-01-28 16:22:09 +01:00
cketti
579027e66c Make Pop3Folder no longer extend Folder 
This highlighted that a bunch of code in backend-pop3 was unused.
 2020-01-26 23:35:25 +01:00
cketti
76bc52beef Make ImapFolder no longer extend Folder 2020-01-26 23:35:25 +01:00
cketti
9335080545 Get rid of common base class RemoteStore 
This also allows removing some unnecessary methods in former subclasses.
 2020-01-26 05:16:01 +01:00
cketti
2d470c73a0 Move FolderType and FolderClass out of Folder 2020-01-09 14:08:41 +01:00
cketti
13bc16caf8 Remove Message.getFolder() 2020-01-08 23:30:03 +01:00
cketti
aa13a46e3e Don't pass Folder instance to PushReceiver 2019-12-18 01:05:28 +01:00
cketti
88d863c4c2 Add ktlint and Kotlin code style settings for Android Studio 2019-11-29 13:39:16 +01:00
cketti
d4def08551 Filter duplicate folder names in IMAP LIST response 2019-11-19 23:15:31 +01:00
cketti
57ff989edd Add kotlinOptions.jvmTarget to Gradle projects using Kotlin 2019-11-17 14:45:05 +01:00
cketti
b241201e88 Fix check for invalid IMAP capability response 2019-11-15 14:37:47 +01:00
cketti
e3973096d3 Remove Checkstyle 2019-11-13 16:51:52 +01:00
cketti
56a37d9e14 Remove FindBugs 
It's not maintained anymore and we're not currently using it.
 2019-11-13 16:41:51 +01:00
cketti
105622a999 Use variable for 'sourceCompatibility' and 'targetCompatibility' values 2019-11-13 16:26:29 +01:00
cketti
6f0bae80b9 Fix test in 'SmtpTransportTest' 
We tested whether the connection was still open. But we should test
whether the connection was closed. The test passed most of the time
because closing a connection takes some time.
 2019-05-24 13:45:29 +02:00
cketti
3ccabbf95f Remove unused code 2019-03-09 19:31:54 +01:00
cketti
7c7ce6eb84 Remove Message.setRecipients() and manually set recipient headers 
Use AddressHeaderBuilder to encode the recipient addresses and fold the
header value.
 2019-02-14 02:28:36 +01:00
cketti
47deb4e5ba Switch to androidx artifacts 2019-02-09 22:08:25 +01:00
cketti
eeb820b958 Remove Folder.delete(boolean) 2019-01-10 00:15:35 +01:00
cketti
e4d7482bef Add test to make sure hasCapability() opens a connection if necessary 2019-01-09 19:06:47 +01:00
cketti
2a4f1c4314 Don't only list special folders when SPECIAL-USE capability is present 2019-01-07 02:02:46 +01:00
cketti
0422268efc Make sure connection has been opened before checking capability 2019-01-06 23:32:17 +01:00
cketti
2861d93a7f Check for LIST-EXTENDED capability before issuing LIST with SPECIAL-USE 2018-12-21 18:57:16 +01:00
Vincent Breitmoser
af09f7b02e
Merge pull request #3799 from k9mail/smtp-pipeline-first-error 
Return first, rather than last, response for pipelined SMTP commands
 2018-12-12 12:05:29 +01:00
Vincent Breitmoser
fda70cbea7 respect first overall negative reply in smtp pipelining 2018-12-10 17:21:10 +01:00
Vincent Breitmoser
d1c4701256
Merge pull request #3808 from artbristol/remove-exception-todo 
Remove TODO
 2018-12-10 12:55:12 +01:00
Art O Cathain
5e3141d236 Remove TODO 2018-12-09 14:06:17 +01:00
Vincent Breitmoser
3c663098b3 Use local ip statically for SMTP HELO/EHLO 2018-12-05 22:26:17 +01:00
Vincent Breitmoser
bad3f20852 add unit test for negative response in smtp pipeline 2018-12-05 15:58:23 +01:00
Vincent Breitmoser
64c6a14e77 Return first, rather than last, response for pipelined SMTP commands 2018-12-05 14:50:57 +01:00
Vincent Breitmoser
4333a3a16f remove "hideHostnameWhenConnecting" from global settings 2018-12-05 14:39:08 +01:00
Vincent Breitmoser
c06e1a9d9b always just send IP instead of hostname in SMTP EHLO message 
Clients are very often behind NATs, which makes the hostname in
HELO/EHLO messages virtually useless these days. Attempting to figure
out a hostname we could use also led to issues with some strict Postfix
configurations (see https://github.com/k9mail/k-9/issues/3387). This
commit changes our behavior to simply send the local IP always, getting
rid of this metadata.

Fixes #3387
 2018-12-05 14:36:06 +01:00
Vincent Breitmoser
e6e0d7c1c2
Merge pull request #3772 from k9mail/cleanup-localkeystore 
Clean up LocalKeyStore and related
 2018-12-02 05:08:03 +01:00
Vincent Breitmoser
268ccfc0ff Stop ImapFolderPusher on CertificateValidationException 
This is a permanent error, but apparently not treated as one. I got
a certificate error notification every two seconds just now (because
LocalKeyStore is broken, see #3772). This PR simply stops the pusher on
a certificate error.
 2018-12-01 14:15:42 +01:00
Vincent Breitmoser
df85d7b0f3 Clean up TrustManager, KeyStore and SocketFactory use 2018-11-30 15:47:57 +01:00