Commit graph

2590 commits

Author SHA1 Message Date
cketti
ba9d9cd612 Get rid of (deprecation) warnings 2022-09-12 14:06:50 +02:00
cketti
20e70f8f20 Try to avoid using the list position whenever possible 2022-09-12 13:51:47 +02:00
cketti
8a73c93134 Move code to select message list items to MessageListAdapter 2022-09-12 13:51:47 +02:00
cketti
7545ed85b4
Merge branch 'main' into view_pager_margin 2022-09-12 13:08:52 +02:00
cketti
9cc455c208
Merge branch 'main' into more_MessageStore 2022-09-12 13:07:18 +02:00
cketti
af9c598f31 Change the separator between message view pages 2022-09-11 16:10:43 +02:00
cketti
cd621d047f Rewrite MessagingController.deleteDraft() to not use LocalStore 2022-09-10 01:53:53 +02:00
cketti
0591ff7822 Rewrite MessagingController.loadMessageRemoteSynchronous() to not use LocalStore 2022-09-10 01:42:04 +02:00
cketti
95cfc85858 Use MessageStore to set folder status 2022-09-10 00:57:38 +02:00
cketti
60e33e529d Save/restore search view state in MessageList 2022-09-09 23:27:54 +02:00
cketti
f3c3b579fe Reuse existing SearchView when recreating the toolbar menu 2022-09-09 23:00:15 +02:00
cketti
df50ff5033 Prepare for version 6.304 2022-09-08 13:01:30 +02:00
cketti
6d904b6647 Version 6.303 2022-09-08 12:08:11 +02:00
cketti
7128013981
Merge pull request #6286 from thundernest/disable_actions_before_message_is_loaded
Ignore toolbar actions in message view while message is still loading
2022-09-08 11:57:50 +02:00
cketti
0e56eb8072
Merge pull request #6283 from thundernest/outbox_logging
Fix error reporting for send failures
2022-09-08 11:57:29 +02:00
cketti
5e977f3aeb
Merge pull request #6282 from thundernest/fix_search_bug
Fix bug in SQL query used for search
2022-09-08 11:56:22 +02:00
cketti
48431e2c40 Ignore toolbar actions in message view while message is still loading 2022-09-08 11:39:10 +02:00
cketti
c80254f3a5 Remove unnecessary code 2022-09-07 17:45:21 +02:00
cketti
53a08bcdee Fix mechanism to notify about messages that failed to send 2022-09-07 17:44:08 +02:00
cketti
2c94dc6d08 Use proper table name in SqlQueryBuilder 2022-09-07 17:10:05 +02:00
cketti
2fe289875e Add support for removing K-9 Mail signatures from HTML message parts 2022-09-07 16:29:15 +02:00
cketti
451f4df4b2 Convert HtmlSignatureRemoverTest to Kotlin 2022-09-07 13:37:34 +02:00
cketti
13a83d0be0 Rename .java to .kt 2022-09-07 13:36:33 +02:00
cketti
e74f0a5780 Convert HtmlSignatureRemover to Kotlin 2022-09-07 13:07:44 +02:00
cketti
fb44ff8f1f Rename .java to .kt 2022-09-07 13:07:44 +02:00
PatrickMis
dfec81c877 Make ktlint happy 2022-09-05 16:04:52 +02:00
cketti
cd95aa233b Prepare for version 6.303 2022-09-05 13:58:22 +02:00
cketti
0286afa6c8 Version 6.302 2022-09-05 13:33:10 +02:00
cketti
eb2ba52e1a
Merge pull request #6272 from thundernest/update_translations
Update translations
2022-09-05 12:17:18 +02:00
cketti
944547a532 Defer sorting opened messages to their new position in the message list
For the last N displayed messages we remember the original 'read' and 'starred' state of the messages. We pass this information to `MessageListLoader` so messages can be sorted according to these remembered values and not the current state. This way messages, that are marked as read/unread or starred/not starred while being displayed, won't immediately change position in the message list if the list is sorted by these fields.
The main benefit is that the swipe to next/previous message feature will work in a less surprising way.
2022-09-03 16:48:35 +02:00
cketti
83b50c6edb Update translations 2022-09-03 15:24:03 +02:00
cketti
ab9ac67a57 Remove redundant calls to MessageListFragment.setActiveMessage() 2022-09-02 15:28:00 +02:00
cketti
bdef79a6fc Be more selective when setting the "active message" for the message list 2022-09-02 15:17:21 +02:00
cketti
034eac8847 Add fast path to MessageListRepository to bypass an empty cache 2022-09-01 16:12:25 +02:00
cketti
5418f71fc5 Change API of MessageListCache to better match how it is used 2022-08-31 17:50:00 +02:00
cketti
cfa01261ae Rename EmailProviderCache to MessageListCache 2022-08-31 17:50:00 +02:00
cketti
7ea928bba5 Finally get rid of EmailProvider 2022-08-31 17:50:00 +02:00
cketti
6be1eb11dc Use MessageRepository instead of EmailProvider in MessageListLoader 2022-08-31 17:50:00 +02:00
cketti
dabb398e65 Add MessageListRepository.getThread() 2022-08-31 17:50:00 +02:00
cketti
4b03f99ff7 Add MessageListRepository.getThreadedMessages() 2022-08-31 17:50:00 +02:00
cketti
170f0dbecc Add MessageListRepository.getMessages() 2022-08-31 17:50:00 +02:00
cketti
b89f8c0e57 Convert EmailProviderCache to Kotlin 2022-08-31 17:50:00 +02:00
cketti
3345701471 Rename .java to .kt 2022-08-31 17:50:00 +02:00
cketti
a9d03a147d Fix EmailProviderCacheTest 2022-08-31 17:50:00 +02:00
cketti
4210237dff Rename .java to .kt 2022-08-31 17:50:00 +02:00
cketti
e9b91f3654 Add MessageListRepository
Remove the "message list changed" notification mechanism provided by `EmailProvider` and use a simple callback mechanism instead.
2022-08-31 17:50:00 +02:00
cketti
18b177e18e Remove MessageListItem.position 2022-08-30 16:32:41 +02:00
cketti
e14ce585a5 Add MessageStore.getThread()
This is more or less a copy of `EmailProvider.getThread()`.
2022-08-30 14:49:30 +02:00
cketti
9b90d18051 Add MessageStore.getMessages()
This is more or less a copy of `EmailProvider.getMessages()`.
2022-08-30 13:43:30 +02:00
cketti
be5867de83 Add MessageStore.getThreadedMessages()
This is more or less a copy of `EmailProvider.getThreadedMessages()`.
2022-08-30 12:39:57 +02:00
cketti
77396629cb Add MessageStore.hasMoreMessages() 2022-08-29 16:40:49 +02:00
cketti
e209e8f746
Merge pull request #6256 from thundernest/html_sanitizer_updates
HTML sanitizer updates
2022-08-29 14:05:15 +02:00
cketti
c0be8a8000 Keep 'name' attribute of 'a' elements 2022-08-25 16:35:48 +02:00
cketti
27d1dd3828 Keep 'align' attribute of 'div' elements 2022-08-25 16:32:52 +02:00
cketti
fd396b183d Don't crash when trying to access attachment (meta) data 2022-08-25 16:01:17 +02:00
cketti
72e3ee3a21 Clean up DependencyInjectionTest 2022-08-09 18:43:00 +02:00
cketti
03189fae46 Replace usages of the deprecated RuntimeEnvironment.application 2022-08-09 18:33:18 +02:00
cketti
46ca47facd Remove unused parameter 2022-08-09 18:18:31 +02:00
cketti
713082fe55 Remove unnecessary elvis operator 2022-08-09 17:50:46 +02:00
cketti
eb12ad538d Remove unused functionality 2022-08-09 17:45:03 +02:00
cketti
9f0d2ada3c Remove unnecessary else cases in when expressions 2022-08-09 17:42:30 +02:00
cketti
28f7318649 Remove unused parameter 2022-08-09 17:37:36 +02:00
cketti
29a530a6fb Remove unused method 2022-08-09 17:36:20 +02:00
cketti
997d993413 Remove unnecessary safe calls 2022-08-09 17:33:54 +02:00
cketti
a807373e99 Make sure overridden methods use same parameter names as super class 2022-08-09 17:28:43 +02:00
cketti
867733c25d Update translations 2022-08-09 17:02:01 +02:00
cketti
7fb14730fa
Merge pull request #6233 from thundernest/fix_build_warnings
Fix some build warnings
2022-08-09 16:35:46 +02:00
cketti
62b7051e30 Add position information to format string parameters 2022-08-09 15:59:58 +02:00
cketti
a5c5278c71 Add 'com.android.lint' Gradle plugin to JVM projects 2022-08-09 13:55:01 +02:00
cketti
9328bd5dc7 Switch from using declaringClass to declaringJavaClass 2022-08-09 13:37:31 +02:00
cketti
9800f8e933 Prepare for version 6.302 2022-08-09 12:14:05 +02:00
cketti
77f9404c47 Version 6.301 2022-08-09 11:59:35 +02:00
cketti
098e89b297 Update translations 2022-08-09 11:42:36 +02:00
cketti
1a27cfa475
Merge pull request #6231 from thundernest/autodiscovery_jvm_modules
Convert most of :app:autodiscovery to JVM projects
2022-08-09 11:34:11 +02:00
cketti
fd65e6e06e
Merge pull request #6228 from thundernest/convert_consecutive_spaces_to_html_done
Fix converting consecutive spaces to HTML
2022-08-09 11:31:04 +02:00
cketti
f4a47858da Convert :app:autodiscovery:thunderbird to a JVM project 2022-08-08 23:38:27 +02:00
cketti
694b79ab7b Convert :app:autodiscovery:srvrecords to a JVM project 2022-08-08 21:42:57 +02:00
cketti
8156a3832b Move EmailHelper from :app:core to :mail:common 2022-08-08 20:58:54 +02:00
cketti
d3262629a4 Convert :app:autodiscovery:api to a JVM project 2022-08-08 20:41:57 +02:00
cketti
10b7969181
Merge pull request #6225 from thundernest/update_leakcanary
Update LeakCanary to version 2.9.1
2022-08-08 15:04:03 +02:00
cketti
aed6b6bb7f Code style fixes 2022-08-08 13:23:15 +02:00
cketti
2d896196ad Add support for converting consecutive spaces to HTML
We use non-breaking space characters when necessary.
2022-08-08 11:56:20 +02:00
cketti
0c449eb70a Add (failing) tests for converting consecutive spaces to HTML
The tests demonstrate the behavior used by Thunderbird.
2022-08-08 11:23:28 +02:00
啊o额iu鱼
7783cc3074
move fulltext entry when message moving
Otherwise, the moved messages cannot be searched,
2022-08-08 16:24:23 +08:00
cketti
9eb081e51b Update LeakCanary to version 2.9.1 2022-08-07 20:10:29 +02:00
cketti
14d5ce7ee3 Revert "Update MaterialDrawer to version 9.0.1"
This reverts commit 8b2fbd0060.
2022-08-07 19:57:31 +02:00
cketti
be649e3ba0 Update Koin to version 3.2.0 2022-08-05 23:51:32 +02:00
cketti
8b2fbd0060 Update MaterialDrawer to version 9.0.1 2022-08-05 22:56:48 +02:00
cketti
5751d4c08b Update SearchPreference to version 2.2.1 2022-08-05 22:43:43 +02:00
cketti
c2aea63223 Update Turbine to version 0.9.0 2022-08-05 21:40:19 +02:00
cketti
2bdc92b6df Update kotlinx.coroutines to version 1.6.4 2022-08-05 16:40:49 +02:00
cketti
d26921e99c Add manifest placeholder to :app:ui:legacy module 2022-08-05 15:59:16 +02:00
cketti
38019dc531
Merge pull request #6222 from thundernest/update_kotlin
Update Kotlin to version 1.7.10
2022-08-05 15:58:19 +02:00
cketti
cb9103448a
Merge pull request #6221 from thundernest/fix_onPendingIntentResult
Fix crash in `MessageViewContainerFragment.onPendingIntentResult()`
2022-08-05 15:57:56 +02:00
cketti
f2ff826675 Update Kotlin to version 1.7.10 2022-08-05 14:19:17 +02:00
cketti
bf41af8cae Fix crash in MessageViewContainerFragment.onPendingIntentResult()
`onPendingIntentResult()` is called before the fragment is in the RESUMED state. This lead to an exception in the `messageViewFragment` property getter when it was checking the value of `isResumed`.
2022-08-05 13:52:10 +02:00
cketti
6ca6c32c91 Clear folder_extra_values when using "clear local messages" 2022-08-05 12:01:18 +02:00
cketti
853c07e8f2 Prepare for version 6.301 2022-08-04 17:40:15 +02:00
cketti
ee7dcd07c6 Version 6.300 2022-08-04 17:27:43 +02:00
cketti
8b546cadd6 Scroll message list to active message 2022-08-03 21:44:35 +02:00
cketti
6992cc732f Handle view pager swipe vs. WebView horizontal scrolling 2022-08-03 21:37:05 +02:00
cketti
3e90e92b2e Only mark a message as read when it is the active message
Previously we marked a message as read when loading it for viewing. But with swiping between messages we could now load a message before it is considered the active message.
2022-08-03 21:37:05 +02:00
cketti
de6d4197f2 Add basic support for swiping between messages 2022-08-03 21:37:05 +02:00
cketti
16ae99ac09 Fix initialization problems with MessageListFragment and MessageViewFragment 2022-08-03 17:30:07 +02:00
cketti
114af53c84 Convert HtmlConverterTest to Kotlin 2022-08-02 16:47:22 +02:00
cketti
7bed9b05b6 Rename .java to .kt 2022-08-02 16:42:58 +02:00
cketti
d014c2f7f3 Fix nullability of parameter 2022-07-29 15:29:32 +02:00
cketti
bfdc0eb04c Convert MessageContainerView to Kotlin 2022-07-29 11:34:52 +02:00
cketti
87dbcfecc5 Rename .java to .kt 2022-07-28 18:44:34 +02:00
cketti
ec80646b6c Simplify message_container layout 2022-07-28 18:02:22 +02:00
cketti
66ebddbd1a Remove unused code 2022-07-28 17:41:16 +02:00
cketti
b05309f316 Convert MessageWebView to Kotlin 2022-07-28 16:05:32 +02:00
cketti
b35e6ac269 Rename .java to .kt 2022-07-28 16:05:32 +02:00
cketti
f16522cdc4 Remove unused code 2022-07-28 15:46:39 +02:00
cketti
4b2c1d9961
Merge pull request #6192 from thundernest/more_notification_fixes
Fix bug when tapping a single message notification
2022-07-27 22:25:27 +02:00
cketti
d11972231a
Merge pull request #6190 from thundernest/fix_duplicate_notifications
Fix removing multiple notifications at once
2022-07-27 22:11:16 +02:00
cketti
1c1dbfbb1e
Merge pull request #6187 from Croydon/url-updates
Update GitHub URLs to new location
2022-07-27 16:13:08 +02:00
cketti
f60f573f07 Don't auto-cancel new message notifications
On one of my test devices (Android 12), tapping a single message notification opens the message view, which leads to the notification being removed. If there's an inactive notification it will be promoted to an active notification and use the notification ID of the notification that was just removed. Due to auto-cancel being used, the delete intent of the first notification is then triggered. However, the system seems to use the notification ID to retrieve the delete intent. Because it will fetch the delete intent from the new notification, not the old one. (I made sure to check that it's not a PendingIntent reuse issue)

Since we remove the notification ourselves, we can simply stop using the (apparently buggy) auto-cancel mechanism.
2022-07-27 00:21:07 +02:00
cketti
bc7758b9cf Remove notificationId parameters from methods in NotificationActionCreator 2022-07-26 23:31:20 +02:00
cketti
147945f757 Make sure Intents used by K9NotificationActionCreator are unique 2022-07-26 23:31:20 +02:00
cketti
7dbae49c8e Fix removing multiple notifications at once 2022-07-26 20:35:32 +02:00
cketti
b1083bef93 Merge branch '6.2-MAINT' into main 2022-07-26 17:15:54 +02:00
cketti
6454d350fb Version Version 6.202 2022-07-26 17:01:41 +02:00
r.zarchi
8fc3e4b1b9 Cc and Bcc text fields checked when handling hide empty field 2022-07-26 16:26:47 +02:00
r.zarchi
f45c5024ca searchEnabled set to false when expanding the search view after the rotate 2022-07-26 16:26:42 +02:00
cketti
fd006bdb2f Add Western Frisian translation 2022-07-26 12:51:17 +02:00
Croydon
c8db3b350a Update GitHub URLs to new location 2022-07-25 20:07:23 +02:00
cketti
351874b9b0
Merge pull request #6185 from arissystem/Issue-6184
Cc and Bcc text fields checked when handling hide empty field
2022-07-25 11:03:56 +02:00
r.zarchi
d27a566a32 Cc and Bcc text fields checked when handling hide empty field 2022-07-25 13:06:03 +04:30
r.zarchi
70f5a589fa searchEnabled set to false when expanding the search view after the rotate 2022-07-25 10:27:40 +04:30
cketti
cc5fc8e2b0 Remove unused code 2022-07-21 13:23:23 +02:00
cketti
3fce00902a Don't invalidate the menu in MessageList 2022-07-21 13:23:23 +02:00
cketti
8214ef3fb7 Move code to disable the delete menu item to MessageViewFragment 2022-07-21 12:21:46 +02:00
cketti
1cb0d15398 Move "search everywhere" menu handling to MessageListFragment 2022-07-21 12:03:53 +02:00
cketti
213cda8881 Rename MessageListFragment.onListVisible() to isActive
Use the same name for the same concept in `MessageListFragment` and `MessageViewFragment`.
2022-07-21 11:50:26 +02:00
cketti
17c51a4900 Remove next/previous entries from message view menu 2022-07-21 11:11:22 +02:00
cketti
995703cc5f Set the "message list visible" flag when the back stack has changed 2022-07-21 11:11:22 +02:00
cketti
d9803c5987 Fix visibility of compose action during transitions 2022-07-21 11:11:22 +02:00
cketti
9c8ac61ed6 Set MessageViewFragment to "active" when its menu should be displayed 2022-07-21 11:11:22 +02:00
cketti
59aac05a8c Initialize MessageViewFragment.messageReference earlier 2022-07-20 20:27:33 +02:00
cketti
0bb4695d4b Move message view menu item handling code to MessageViewFragment 2022-07-20 20:27:33 +02:00
cketti
4d7a40b520 Reformat message_list_option.xml 2022-07-20 20:27:33 +02:00
cketti
03de64e84c Move code to prepare the message view menu to MessageViewFragment 2022-07-20 20:27:33 +02:00
cketti
87dbccdb51 Convert MessageViewFragment to Kotlin 2022-07-20 19:57:05 +02:00
cketti
48847e17ea Rename .java to .kt 2022-07-20 14:19:31 +02:00
cketti
8c6b37cba9
Merge pull request #6172 from thundernest/allow_all_schemes_in_links
Allow all URI schemes in links
2022-07-20 14:19:03 +02:00
cketti
0cae71e53e Allow all URI schemes in links 2022-07-20 14:00:55 +02:00
cketti
42daa056fd Move message list menu item handling code to MessageListFragment 2022-07-19 15:33:32 +02:00
cketti
9f45fe1d46 Refactor MessageListFragment.onOptionsItemSelected() 2022-07-19 15:13:29 +02:00
cketti
4486782166 Move code to prepare the message list menu to MessageListFragment 2022-07-19 14:58:13 +02:00