wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7534 commits 1 branch 0 tags 100 MiB
Commit graph

1617 commits

Author SHA1 Message Date
cketti
4b83da75ee Merge pull request #2068 from k9mail/fix-alternate-selection 
Fix broken referencing of recipient token in RecipientSelectView
 2017-01-26 10:38:37 +01:00
cketti
c478f64a13 Merge pull request #2126 from philipwhiuk/notificationCategory 
Set appropriate categories for notifications
 2017-01-26 10:31:55 +01:00
Philip Whitehouse
65c4f86105 Set appropriate categories for notifications 2017-01-26 00:30:42 +00:00
Vincent Breitmoser
7bf9d7ec08 Merge pull request #2131 from k9mail/settings-cleanup 
Settings classes cleanup
 2017-01-25 17:36:35 +01:00
cketti
bf881cd3c2 Merge pull request #2124 from philipwhiuk/summaryNotificationFix 
Fix behavior of summary notifications
 2017-01-25 16:25:27 +01:00
cketti
9254e7a052 Add database migration to clean up orphaned data 
Also extend database trigger to remove entries from messages_fulltext.
 2017-01-25 16:11:44 +01:00
cketti
1697be33fa Remove mostly useless JavaDoc comments 2017-01-25 00:04:18 +01:00
cketti
38a19dbd28 Reformat code 2017-01-24 23:52:03 +01:00
cketti
24a4e3a4fb Fix typo 2017-01-24 23:43:49 +01:00
cketti
23603278ea Remove 'm' prefix from fields 2017-01-24 23:41:28 +01:00
cketti
62acbfcd81 Use T as type parameter name 2017-01-24 23:11:08 +01:00
cketti
2710fd3d8d Remove unnecessary line breaks 2017-01-24 23:00:53 +01:00
Vincent Breitmoser
f5b8a56c8a add non-null assertion to Settings.upgrade 2017-01-24 19:47:18 +01:00
Vincent Breitmoser
7e1482636d clean up SettingsImporter 2017-01-24 19:47:18 +01:00
Vincent Breitmoser
2583a5336b clean up SettingsExporter 2017-01-24 19:17:47 +01:00
Vincent Breitmoser
a9a69a031e break down Settings.upgrade method into submethods 2017-01-24 19:17:47 +01:00
Vincent Breitmoser
045fd63760 clean up more warnings (no semantic changes) 2017-01-24 16:46:53 +01:00
Vincent Breitmoser
cad7da10d6 use generics for all SettingsDescription subclasses 2017-01-24 16:45:32 +01:00
Vincent Breitmoser
a6dfa14af2 refactor settings (no semantic changes) 2017-01-24 15:42:22 +01:00
Vincent Breitmoser
434cd7735a add missing pgpSignOnlyDialogCounter to GlobalSettings 2017-01-24 13:39:04 +01:00
Vincent Breitmoser
48e3b4293e fix broken referencing of recipient token in RecipientSelectView 
Passing through the actual recipient object was broken in
a2674efff1. I changed the code to no
longer rely on the actual object being passed through correctly, but
just one that fulfills `equals`.
 2017-01-24 13:06:49 +01:00
Vincent Breitmoser
a14cd9f0e0 Merge pull request #2047 from k9mail/apg-deprecation-warning 
show warning about APG being deprecated if still selected
 2017-01-24 11:55:47 +01:00
cketti
330aef8577 Fix dialog handling 2017-01-24 07:14:54 +01:00
Philip Whitehouse
4ae85ddd38 Fix behaviour of summary notifications 2017-01-23 22:03:13 +00:00
Vincent Breitmoser
e49bfec2d4 other way to prevent activity leak in apg deprecation dialog 2017-01-23 14:05:22 +01:00
Vincent Breitmoser
407d6d7ec9 incorporate feedback 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
485029c5c2 get rid of magic and inline strings 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
ce6f080e83 dismiss apg deprecation dialog on pause, to avoid potential memory leak 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
164f38c5b0 display apg in list of choices, show warning dialog when selected 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
152d1cd2c1 change link to point to blog post 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
3adc981e51 extract method for making links clickable 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
9f51ab627e show warning about APG being deprecated if still selected 2017-01-23 13:18:44 +01:00
Philip
0dd7a4aafe Merge pull request #2118 from philipwhiuk/handleInvalidHtmlBetter 
Handle invalid HTML better
 2017-01-22 20:40:22 +00:00
Philip Whitehouse
b15636a3ca Tidying up existing HtmlSanitizer tests to use standard style 2017-01-22 19:50:45 +00:00
Philip Whitehouse
5301639045 Handle invalid HTML better 2017-01-22 19:50:30 +00:00
cketti
cf15e8a2c5 Merge pull request #2104 from philipwhiuk/fixFetchNull 
Fix 'Fetching headers null:Folder'
 2017-01-22 04:56:11 +01:00
Philip Whitehouse
21a684b243 Update labels used for application permissions - shown to the end user in later versions of Android 2017-01-21 20:42:08 +00:00
Philip Whitehouse
0383fbe4fa Fix 'Fetching headers null:Folder' 2017-01-21 15:28:05 +00:00
Philip Whitehouse
b77dfa0004 Don't bother handling an intent if we're finishing anyway 2017-01-21 04:01:35 +01:00
Vincent Breitmoser
c94804df26 use CHILD_PART_CONTAINS_DATA as data location for multipart (fixes #1899) 2017-01-19 16:18:30 +01:00
Vincent Breitmoser
c2cf9c8772 fix NPE introduced in #2036 2017-01-19 16:03:06 +01:00
cketti
dbc62e38f5 Merge pull request #2082 from bertob/material-icon 
Replace icon with new material design icon
 2017-01-19 13:12:28 +01:00
Tobias Bernard
e00cc9f629 revert to old k9small icon 2017-01-18 18:22:19 +01:00
cketti
4b745ca62e Merge pull request #2084 from philipwhiuk/fixRemoveIcon_InDarkTheme 
Use attribute for delete icon so it works in dark theme
 2017-01-18 01:57:58 +01:00
Philip Whitehouse
78f99c314d Use attribute for delete icon so it works in dark theme 2017-01-18 00:49:34 +00:00
cketti
bdf21431f7 Merge pull request #2062 from philipwhiuk/stopOutboxFlagSyncAttempt 
Stop trying to process flags on messages in the outbox
 2017-01-18 01:10:36 +01:00
cketti
fb1de9453a Merge pull request #2076 from jca02266/master 
Don't use default charset to pass the test
 2017-01-17 14:56:11 +01:00
Koji Arai
5633ddbeaf Don't use default charset to pass the test 2017-01-17 22:10:39 +09:00
cketti
6b06b75224 Avoid NullPointerException 2017-01-16 23:36:36 +01:00
Tobias Bernard
6391766aa7 replace icon with new material design icon 2017-01-16 19:49:52 +01:00
Philip Whitehouse
d0511c676a Stop trying to process flags on messages in the outbox 2017-01-15 23:20:05 +00:00
cketti
6d104bd860 Merge pull request #2035 from GoneUp/importNameFix2 
Fixed empty account name at import dialog
 2017-01-15 23:16:16 +01:00
cketti
f5e837cc21 Merge pull request #2036 from k9mail/encrypted-multipart-alternative 
Handle encrypted parts in multipart/alternative
 2017-01-15 22:57:24 +01:00
cketti
d51b90f307 Merge pull request #2059 from philipwhiuk/autocompleteFix 
Autocomplete fix v2
 2017-01-15 22:44:25 +01:00
Philip Whitehouse
02eb84a1f0 Don't prevent sending due to address conversion 2017-01-15 20:10:24 +00:00
cketti
1a74420eb7 Extract method to construct account display name 2017-01-12 06:42:03 +01:00
cketti
25d977a813 Code style fixes 2017-01-12 06:29:45 +01:00
cketti
dbb5180e1e Merge pull request #1983 from k9mail/draft-fixes 
Don't upload draft if PgpMessageBuilder is used
 2017-01-12 06:19:40 +01:00
cketti
76b66472d4 Fix failing tests 2017-01-12 05:04:36 +01:00
cketti
da7ea43f77 Add some tests for MessageDecryptVerifier 2017-01-12 04:49:42 +01:00
GoneUp
bb514f7140 Just convert the actual address and not perform wild guesses #1950 2017-01-11 00:16:20 +01:00
GoneUp
f457de3821 Added tests 2017-01-10 21:10:44 +01:00
GoneUp
7df4ad00ad Fixed empty account name at import dialog 2017-01-10 21:10:29 +01:00
Vincent Breitmoser
95f6fba382 handle encrypted parts in multipart/alternative 2017-01-10 18:08:58 +01:00
Vincent Breitmoser
085debbb5b don't save draft iff PgpMessageBuilder is used 2017-01-10 15:12:44 +01:00
Vincent Breitmoser
0644fa0481 more tests for RecipientPresenter 2017-01-10 15:12:44 +01:00
cketti
92196c0128 Merge pull request #2025 from k9mail/GH-1908_fix_pinch_to_zoom 
Extend NonLockingScrollView to support adding/removing views
 2017-01-10 12:11:13 +01:00
cketti
c7c0ad0b7b Extend NonLockingScrollView to support adding/removing views 
Fixes #1908
 2017-01-10 12:05:17 +01:00
cketti
217c61430d Merge pull request #2005 from philipwhiuk/clearFullTextSearch 
Delete data from Full-Text-Search table
 2017-01-10 11:52:17 +01:00
cketti
bf0fe6e25a Merge pull request #2022 from philipwhiuk/addToolsText 
Add some useful tools text to the custom actionbar
 2017-01-10 11:45:03 +01:00
Philip Whitehouse
2de1a0c79c Add some useful tools text to the custom actionbar 2017-01-09 23:52:22 +00:00
cketti
d344a6898d Merge pull request #2014 from philipwhiuk/rework2004 
Rework where we wrap message content
 2017-01-09 21:33:47 +01:00
cketti
3490a7f38a Merge pull request #2021 from philipwhiuk/obeyAPIrequirements 
Call base implementation as per API requirements
 2017-01-09 01:54:16 +01:00
Vincent Breitmoser
6064204d7b Merge pull request #1995 from k9mail/readd-clearsign 
Allow pgp/inline with sign-only again
 2017-01-09 01:19:56 +01:00
Philip Whitehouse
897520477c Call base implementation as per API requirements 2017-01-09 00:04:49 +00:00
Philip
aef446f1c8 Merge pull request #1987 from GoneUp/fix1981widgetSize 
Changing unread widget size to match App Widget Design Guidelines.
 2017-01-08 13:24:50 +00:00
Philip Whitehouse
fe6f6caa5f Rework where we wrap message content 2017-01-08 13:19:14 +00:00
cketti
f3e5534797 Clean up FTS table on update 2017-01-08 08:50:10 +01:00
cketti
071f88e96e Delete data from FTS table when deleting message data 2017-01-08 07:46:24 +01:00
cketti
1af2f23f50 Merge pull request #2004 from philipwhiuk/styleQuotedContent 
Style quoted content

Fixes #1930
 2017-01-08 03:17:14 +01:00
cketti
985cd8593c Merge pull request #2003 from philipwhiuk/dontHideCC 
Don't hide CC and BCC if 'Always show' enabled
 2017-01-08 03:06:05 +01:00
Philip Whitehouse
8337c16935 Delete data from Full-Text-Search table on clear() 2017-01-07 17:42:36 +00:00
Philip Whitehouse
17dc1c52bc Style quoted content 2017-01-07 17:26:27 +00:00
Philip Whitehouse
963645cad6 Don't hide CC and BCC if 'Always show' enabled 2017-01-07 17:02:20 +00:00
Vincent Breitmoser
afb5e49351 prefer sign-only dialog over pgp/inline dialog for icon click, and disable together 2017-01-06 15:02:17 +01:00
Vincent Breitmoser
0ecf5bcfc7 allow combined pgp/inline + sign-only == clearsign mode 2017-01-06 02:47:23 +01:00
Vincent Breitmoser
a44129b7a9 Revert "remove support for clearsigned messages in PgpMessageBuilder" 
This reverts commit ef3cda97e2.
 2017-01-06 02:28:51 +01:00
GoneUp
78b7061061 Adjusted the widgets minHeight/mindWidth values to google's recommendation 2017-01-05 22:20:13 +01:00
GoneUp
42a2402347 Unrestricted the message subject since it's in a scrollcontainer 2017-01-05 21:40:43 +01:00
GoneUp
4e3b913522 Add setting for disabling 'mark all as read' confirmation dialog 2017-01-05 18:28:55 +01:00
Vincent Breitmoser
580a828b58 Merge pull request #1969 from k9mail/less_strict_export_version_check 
Don't hardcode check for version in SettingsExporterTest
 2017-01-05 17:36:19 +01:00
cketti
ea699b3dac Merge pull request #1955 from k9mail/GH-1915_always_show_subject_in_split_mode 
Always show subject in message header when split mode is active
 2017-01-05 01:42:06 +01:00
cketti
a452ded9cb Merge pull request #1954 from k9mail/GH-1938_fix_bcc_visible_in_sent_message 
Fix BCC recipients visible in sent message
 2017-01-05 01:40:08 +01:00
cketti
0fe74e59cc Don't hardcode check for version in SettingsExporterTest 
Otherwise every time we add a setting this test needs to be touched.
 2017-01-04 23:56:59 +01:00
cketti
4323ca3419 Update header before writing a modified LocalMessage 
Without this the changes SmtpTransport makes to the message before sending,
e.g. removing the BCC recipients, are not reflected in the writeTo() output.
 2017-01-04 19:44:21 +01:00
cketti
b516af2af0 Merge pull request #1948 from philipwhiuk/fix1914untested 
Hide the entire crypto component for alternate recipients when disabled

Fixes #1914
 2017-01-04 07:42:34 +01:00
cketti
10a252e6b9 Always show subject in message header when split mode is active 2017-01-04 07:20:30 +01:00
cketti
5c06bc01da Add missing fields to LocalMessage.clone() 2017-01-04 05:43:13 +01:00
Philip Whitehouse
55978e6322 Hide the entire crypto component for alternate recipients when disabled 2017-01-04 00:35:44 +00:00
cketti
406fd6b93d Merge pull request #1900 from k9mail/fix_format_string_bug 
Don't use unchecked input in format string
 2017-01-02 15:31:16 +01:00
Vincent Breitmoser
acfa5d248c Merge pull request #1907 from k9mail/GH-1898_fix_crash_in_MessageCompose_onCreateOptionsMenu 
Don't create options menu when Activity is finishing anyway
 2017-01-02 12:22:28 +01:00
cketti
9e66bce601 Don't create options menu when Activity is finishing anyway 
Fixes #1898
 2017-01-01 21:09:47 +01:00
cketti
de60e0e8c4 Merge pull request #1835 from k9mail/flowed-display 
Support display of format=flowed (rfc2646)
 2017-01-01 02:47:40 +01:00
cketti
693449235f Don't use unchecked input in format string 2016-12-31 20:13:18 +01:00
Vincent Breitmoser
df9009e1ea Merge pull request #1894 from philipwhiuk/fixCcExpanderOnDarkTheme 
Use theme-able icon for CC/BCC expander
 2016-12-31 13:46:16 +01:00
Philip Whitehouse
f0ac353a21 Use themeable icon for CC/BCC expander - fixes #1893 2016-12-31 12:42:33 +00:00
cketti
b9147f119e Merge pull request #1891 from k9mail/fix-crypto-cancelled-npe 
Fix NPE in MessageCryptoHelper.addCryptoResultAnnotationToMessage()
 2016-12-30 21:31:51 +01:00
cketti
3bee80a6a4 Merge pull request #1890 from k9mail/fix-fts-oom 
Fix OutOfMemoryError during database migration
 2016-12-30 21:21:52 +01:00
cketti
b057480481 Simplify LocalFolder.getAllMessageUids() 2016-12-30 20:53:30 +01:00
Vincent Breitmoser
97e9e3267f make MessageCryptoHelper slightly more fail-fast in weird states 2016-12-28 17:50:15 +01:00
Vincent Breitmoser
17647a6fac don't crash in onCryptoOperationCancelled if no part is being processed 2016-12-28 17:40:20 +01:00
Vincent Breitmoser
2279526e0d small cleanup in MessageCryptoHelper 2016-12-28 17:39:01 +01:00
Vincent Breitmoser
e7653c4725 iterate messages by uid, don't keep messages around longer than necessary (fixes #1879) 2016-12-28 16:47:41 +01:00
Philip Whitehouse
36da79d60c Check recipientPresenter exists before destroying it - #1876 2016-12-28 15:11:18 +00:00
Vincent Breitmoser
217b5bf9f4 fix switch/case screwup for signature handling 2016-12-16 00:51:17 +01:00
Vincent Breitmoser
a055ed42a8 don't handle format parameter in setBody(), style fixes 2016-12-12 14:24:30 +01:00
Vincent Breitmoser
dc3d1f0e87 support display of format=flowed (rfc2646) 2016-12-12 14:24:30 +01:00
Vincent Breitmoser
2b4d6d7750 Merge pull request #1850 from k9mail/remove_unused_resources 
Remove unused resources
 2016-12-12 13:52:02 +01:00
cketti
db1b97d23f Fix tests 2016-12-12 06:51:28 +01:00
cketti
a59aea200f Merge pull request #1804 from sedrubal/swipe-to-refresh 
Replace Android-PullToRefresh with android.support SwipeRefreshLayout
 2016-12-12 06:32:08 +01:00
cketti
0d77e8ea3a Merge pull request #1844 from supersn0b/master 
Added config for fairnatics.net, a soon upcoming service.
 2016-12-12 04:00:14 +01:00
cketti
ceb0523fc9 Remove unused layout 2016-12-12 03:28:43 +01:00
cketti
22b07827fc Remove unused strings 2016-12-12 03:26:15 +01:00
cketti
29dc3dd03c Merge pull request #1808 from philipwhiuk/testingSettingsImportExport 
Testing for settings import and export
 2016-12-12 01:04:58 +01:00
cketti
708b79d859 Merge pull request #1828 from k9mail/nicer_npe_fix_for_database_upgrade_ui 
Nicer NullPointerException fix for database upgrade UI
 2016-12-12 00:47:53 +01:00
cketti
5fca3c871d Merge pull request #1847 from k9mail/multipart-attachments 
Handle attachments with CHILD_PART_CONTAINS_DATA data location
 2016-12-11 02:45:00 +01:00
Vincent Breitmoser
0ecbf441c1 handle attachments with CHILD_PART_CONTAINS_DATA data location (message/rfc822) 2016-12-11 02:33:56 +01:00
cketti
6bfb50859e Display empty preview when we couldn't extract preview text 2016-12-09 22:08:10 +01:00
Fair Natics
7230980ecb Removed :993 as this is the default port for imap+ssl+ 2016-12-09 16:56:15 +01:00
Fair Natics
92356e3cee Added config for fairnatics.net, a soon upcoming service. 2016-12-09 14:53:54 +01:00
cketti
ac55279b8e Update translations from Transifex 2016-12-09 00:56:41 +01:00
cketti
2611e9a65d Merge pull request #1833 from k9mail/GH-1832_hide_unsigned_text_divider 
Hide "Unsigned Text" divider
 2016-12-09 00:19:16 +01:00
cketti
87e13ef800 Merge pull request #1836 from k9mail/multipart-digest-content-type 
Properly handle multipart/digest content type
 2016-12-09 00:18:59 +01:00
cketti
78b030a32c Hide unsigned text container in clearDisplayedContent() 2016-12-08 00:03:17 +01:00
Vincent Breitmoser
7bd85189ce add test for multipart/digest message 2016-12-07 00:23:28 +01:00
cketti
636098553d Hide "Unsigned Text" divider when support for signed-only messages is disabled 2016-12-05 19:05:56 +01:00
cketti
575d33c12f Extract string resource 2016-12-05 18:44:30 +01:00
cketti
0d3a24df2c Merge pull request #1824 from k9mail/fix-pgp-inline 
Ignore leading whitespace for PGP/INLINE messages
 2016-12-05 17:55:19 +01:00
cketti
1f9fc44f72 Fix JavaDoc 2016-12-02 17:04:13 +01:00
cketti
c7c21cb602 Avoid NPE by proper initialization instead of null check later on 2016-12-02 17:04:13 +01:00
Vincent Breitmoser
afb63d351b use PendingIntent from encapsulated result if available for showing key info 2016-11-30 18:35:08 +01:00
Vincent Breitmoser
422806f622 ignore leading whitespace for pgp/inline messages in MessageDecryptVerifier (fixes #1823) 2016-11-29 19:22:31 +01:00
Philip Whitehouse
f03a01f6dc BDD new lines 2016-11-27 02:16:15 +00:00
cketti
833adc732e Merge pull request #1806 from k9mail/openpgp-signature-result-enums 
Update OpenPgpSignatureResult to use enums
 2016-11-24 00:55:58 +01:00
Vincent Breitmoser
de13e10be1 update OpenPgpSignatureResult to use enums 2016-11-23 16:08:25 +01:00
Philip Whitehouse
6f82dea315 Testing for SettingsExporter 2016-11-22 01:52:57 +00:00
Philip Whitehouse
68b670e7d8 Testing for SettingsImporter 2016-11-22 01:24:41 +00:00
Philip Whitehouse
2f6a2e7c5f Fix multi-run upgrade bug in Migration 2016-11-20 23:48:49 +00:00
sedrubal
dab9f39ff6
Fix selection offset and cleanup 
When selecting or opening a message (not a thread) there was an offset
of 1 selecting the message above. When selecting the first message, it
crashed. Now this seems to be fixed.
 2016-11-20 17:41:35 +01:00
sedrubal
08daf2dffb
Replace Android-PullToRefresh with android.support SwipeRefreshLayout 2016-11-20 07:55:29 +01:00
cketti
4d61ca8f40 Version 5.115 2016-11-18 16:48:43 +01:00
Vincent Breitmoser
7daf639b75 whoops, forgot a backslash there 2016-11-16 15:09:29 +01:00
Vincent Breitmoser
be1dd1cc3a minor wording changes for CryptoSettingsDialog (related #1774) 2016-11-16 15:05:51 +01:00
Vincent Breitmoser
ef3cda97e2 remove support for clearsigned messages in PgpMessageBuilder 2016-11-14 18:56:26 +01:00
Vincent Breitmoser
0378f1a812 Prevent pgp/inline in sign-only mode and vice versa 2016-11-14 14:18:23 +01:00
Vincent Breitmoser
b72a3ce8a0 display sign-only as a special mode like pgp/inline 2016-11-14 13:56:15 +01:00
Vincent Breitmoser
3d434786af update layout and wording for sign-only mode 2016-11-14 13:55:46 +01:00
Vincent Breitmoser
640322d46d add "name" parameter to signature content-type header 2016-11-12 22:08:43 +01:00
Vincent Breitmoser
4e17fdf1a6 remove "always sign, encrypt if possible" mode of operation from PgpMessageBuilder 2016-11-12 21:53:02 +01:00
Vincent Breitmoser
6ae8845992 clean up some strings 2016-11-12 21:33:32 +01:00
Vincent Breitmoser
d40a046bf6 move sign-only into a mode of its own 2016-11-11 15:41:37 +01:00
Vincent Breitmoser
cedaecb38e Merge pull request #1769 from k9mail/attachment-ninjafix 
use AttachmentTempFileProvider to expose file-backed content uris
 2016-11-08 11:21:39 +01:00
cketti
bc41d9124e Merge pull request #1714 
Added some more coverage to the MessageReferenceTest
 2016-11-08 11:16:39 +01:00
cketti
5b0544cbab Clean up new tests 2016-11-08 11:13:57 +01:00
cketti
502bb6570f Don't use 'exit-early' pattern for non-error cases 2016-11-08 09:07:52 +01:00
cketti
47a5401ca7 Introduce local variable to make code easier to read 2016-11-08 09:07:52 +01:00
cketti
fbecc40d01 Use okio with AttachmentTempFileProvider 2016-11-08 09:07:52 +01:00
Vincent Breitmoser
75b2cafddc fix context menu for inline attachments 2016-11-03 13:57:19 +01:00
Vincent Breitmoser
be45380415 use AttachmentTempFileProvider to expose file-backed content uris 2016-11-03 13:57:19 +01:00
cketti
0617d4250f Merge pull request #1759 from k9mail/mch-fix-broken-signature-behavior 
Improve behavior for broken signatures
 2016-11-03 02:04:18 +01:00
cketti
59dcdf6b68 Merge pull request #1766 from k9mail/expert-signatures 
Turn support for signed-only mails into an opt-in feature
 2016-11-03 01:29:04 +01:00
Vincent Breitmoser
58eb9b52ca remove unused lastAutomaticCheckTime attribute from Account 2016-11-02 14:30:58 +01:00
Vincent Breitmoser
f5f3208b2d incorporate requested changes by cketti 2016-11-02 14:30:58 +01:00
Vincent Breitmoser
380fd94b22 some more tests for PgpMessageBuilder 2016-11-02 14:30:51 +01:00
Vincent Breitmoser
54c0ac6e7b disabled lock status icon is dark grey 2016-10-31 07:57:08 +01:00
Vincent Breitmoser
c7a637f21b don't sign in opportunistic mode if sign-only isn't supported 2016-10-31 07:57:08 +01:00
Vincent Breitmoser
98286fd7fb split off sign-only variant of CryptoSettingsDialog 2016-10-31 07:29:05 +01:00
cketti
d0b3caf976 Merge pull request #1755 from k9mail/GH-1741_notification_actions 
Add notification actions to "stacked notifications"
 2016-10-31 06:15:09 +01:00
Vincent Breitmoser
395f37ea1c add account setting to support unencrypted authentication 2016-10-31 04:30:14 +01:00
Vincent Breitmoser
7fe6a90396 clean up warnings in Account (no semantic changes) 2016-10-31 04:14:12 +01:00
Vincent Breitmoser
80d7ce4887 messageview: if OpenPGP-API throws on signature verification, don't treat data as undisplayable 2016-10-26 18:44:45 +02:00
Vincent Breitmoser
136ee8e34f fix possible NPE in message crypto helper 2016-10-26 17:37:38 +02:00
cketti
a434f37320 Add notification actions to "stacked notifications" 
On Android 7.0 notifications that previously only showed on Android Wear
 devices are also displayed on the phone/tablet. To be able to use notification
 actions there and have a separate set of actions for Wear devices we need to
 do some extra work.
 2016-10-25 14:58:14 +02:00
Jan Berkel
8b1c768483 Inject config from properties file 2016-10-19 12:35:28 +02:00
cketti
44b4984f97 Merge pull request #1717 from jonas-lundqvist/messagebrowse 
Enable directional pads for next/previous message
 2016-10-19 10:38:12 +02:00
cketti
ffd051b0ec Don't use same notification group key for all accounts 2016-10-18 06:21:25 +02:00
Jonas Lundqvist
c06721f977
Enable directional pads for next/previous message 2016-10-14 23:26:02 +02:00
cketti
067ba7930c Version 5.114 2016-10-13 20:24:16 +02:00
cketti
2bebb90d4c Update translations 2016-10-13 18:22:21 +02:00
Jonas Lundqvist
21df74f7f4
Added test for MessageReference.withModifiedFlag() 2016-10-12 23:45:59 +02:00
Jonas Lundqvist
6ab4c3b3e6
Added test for MessageReference.withModifiedUid() 2016-10-12 23:45:55 +02:00
Vincent Breitmoser
aaa904e075 When moving temporary files, try to copy if rename fails, and throw if that fails too (#1686) 
Fixes #1243
 2016-10-12 16:47:23 +02:00
cketti
2087f0476c Merge pull request #1691 
Improve Activity operation text

Fixes #1685
 2016-10-12 16:23:57 +02:00
cketti
e511b8b7c1 Further clean up of ActivityListenerTest 
* \u0020 is a hack required to have spaces at the beginning of resource
  strings. But there's no need to replicate this inside our tests.
* Dependencies shouldn't be static finals.
* Initialization of dependencies is usually boring. I like to extract that
  code to methods and put them at the end of the file.
* Using different values for 'current progress' and 'total' has the
  advantage of breaking tests when the two accidentally get mixed up.
 2016-10-12 16:18:23 +02:00
cketti
1415261fdd Merge pull request #1705 from k9mail/no-crypto-hide-recipient-dots 
hide recipient dots if no crypto provider is configured
 2016-10-12 15:53:16 +02:00
cketti
4eb7c41f61 Merge pull request #1703 from k9mail/compose-fix-indeterminate 
compose: hide indeterminate progress bar after onCreate (fix for api level 15)
 2016-10-12 15:51:16 +02:00
Jonas Lundqvist
2c81e11c1d
JavaDoc fix in LocalSearch 
Minor JavaDoc fix to get rid of a warning.
 2016-10-12 00:10:03 +02:00
cketti
0dfa6345b3 Merge pull request #1702 from k9mail/fix-old-api-npe 
Avoid indirect call to invalidateOptionsMenu() before recipientPresenter is initialized
 2016-10-11 18:52:29 +02:00
Vincent Breitmoser
9fb91a0afc use Compat classes to access deprecated methods 2016-10-11 14:44:09 +02:00
Vincent Breitmoser
89fe5d790e hide dots in recipient list if no crypto provider is configured 2016-10-11 14:44:09 +02:00
Vincent Breitmoser
dae6be34df fix NPE in MessageProvider 2016-10-11 13:55:25 +02:00
Vincent Breitmoser
76b2339b69 compose: hide indeterminate progress bar after initialization (fix for api level 15) 2016-10-11 12:22:53 +02:00
Vincent Breitmoser
a88ccfd9e8 avoid indirect call to invalidateOptionsMenu() before recipientPresenter is initialized 2016-10-11 11:42:20 +02:00
cketti
54bf6f7bd5 Merge pull request #1695 from jonas-lundqvist/backstackid 
Save state for back stack id in MessageList
 2016-10-11 03:54:40 +02:00
cketti
7a0bacff41 Merge pull request #1689 from k9mail/fix-line-endings-for-pgp-inline 
convert LF newlines to CRLF before converting to quoted-printable for clearsigned messages
 2016-10-11 03:30:58 +02:00
Jonas Lundqvist
dc876d9cc5
Save state for back stack id in MessageList 2016-10-09 13:32:17 +02:00
Philip Whitehouse
0fff2ffd08 Update to Robolectric 3.1.1 and tidy up code 2016-10-09 02:21:14 +01:00
Vincent Breitmoser
ce249bf07e convert LF newlines to CRLF in crypto provider output 
OpenKeychain/BouncyCastle at this point use the system newline for
formatting, which is LF on android.  We need this to be CRLF, so we
convert the data after receiving (and possibly before quoted-printable
encoding).
 2016-10-08 12:23:54 +02:00
cketti
fc79b290d0 Merge pull request #1692 
Handle download of attachment correctly when saving requested

Fixes #1629
 2016-10-08 11:00:26 +02:00
Philip Whitehouse
1f26663ed1 Handle download of attachment correctly when saving requested 2016-10-08 10:57:47 +02:00
cketti
327a47d2ef Merge pull request #1688 from k9mail/limit-pgp-inline-dialog-displays 
Limit number of times the PGP/Inline info dialog is displayed

Fixes #1595
 2016-10-08 02:35:54 +02:00
cketti
88eb0f663a Merge pull request #1687 from k9mail/fix-message-view-theme-switch 
Don't cache decoded message over configurations

Fixes #1666
 2016-10-08 01:18:16 +02:00
Philip
302b668d58 On removing notification, mark it's ID no longer in use (#1677) 
On removing notification, mark it's ID no longer in use

Fixes #1662
 2016-10-08 00:54:15 +02:00
Philip Whitehouse
4c7f80161e Change folder_progress to correctly expect a decimal number instead of a string 2016-10-07 23:15:10 +01:00
Philip Whitehouse
53f3d549f7 Set account name when syncing headers & use correct folder name to generate display name 2016-10-07 23:14:54 +01:00
Vincent Breitmoser
a8d4655e56 limit number of times the pgp inline info dialog is displayed (closes #1595) 2016-10-07 19:09:26 +02:00
Vincent Breitmoser
22e8f4cedb don't cache decoded message over configurations 
Since 773600c717, the message decoding
process might actually depend on theming parameters.  The MessageList
activity assumes that the theme will be reapplied during a call to
`recreate()`, so we better drop that cache on configuration changes.
 2016-10-07 18:43:33 +02:00
cketti
c7b5a50636 Merge pull request #1680 from philipwhiuk/GH-1597-activeNeverSign 
Use a darker grey to highlight the Never Sign/Encrypt as active
 2016-10-07 06:45:14 +02:00
cketti
dcb6890550 Merge pull request #1679 from philipwhiuk/GH-1598-updateCryptoModeOnProceed 
Move update of crypto settings to submit button and add Cancel
 2016-10-07 06:27:02 +02:00
cketti
91c0b4274b Clean up MessageBuilderTest 2016-10-07 05:40:20 +02:00
Philip Whitehouse
0f84953f94 Use a darker grey to highlight the Never Sign/Encrypt as active 2016-10-07 03:49:45 +01:00
Philip Whitehouse
5271977f76 Move update of crypto settings to submit button and add Cancel 2016-10-07 03:23:58 +01:00
Philip Whitehouse
0cd52bc26b Use the correct order for alternatives when building HTML messages 
Fixes #1625
 2016-10-07 01:09:31 +01:00
cketti
dbb6cc4d88 Version 5.113 2016-10-06 19:13:30 +02:00
cketti
b6dcb72c7a Fix dark theme 2016-10-05 16:47:25 +02:00
cketti
59cbdcc559 Version 5.112 2016-10-05 14:03:43 +02:00
cketti
c905b303d6 Merge pull request #1617 from helmo/update-tld-str 
Update TOP_LEVEL_DOMAIN_STR_FOR_WEB_URL to match more new TLDs
 2016-10-05 13:33:47 +02:00
cketti
5c0a7f6d95 Merge pull request #1613 from k9mail/GH-1604_message_format_fix 
Use correct message format when replying
 2016-10-05 13:23:45 +02:00
cketti
5f7bc080f9 Make code more readable 2016-10-04 12:29:54 +02:00
Herman van Rink
8f8188cba5 Update TOP_LEVEL_DOMAIN_STR_FOR_WEB_URL to match more new TLDs 
new regex produced by https://github.com/irccloud/android/blob/master/make-iana-tld-pattern.py cbe04ae
 2016-09-18 16:18:36 +02:00
Jacco
9065b9fb66 Added provider settings for Ziggo and Virgin Media 
We (Liberty Global) would like to extend the automatic configuration support with settings for Ziggo (The Netherlands) and Virgin Media (UK). You can validate these settings at:

https://www.ziggo.nl/klantenservice/internet/e-mail/imap/

http://help.virginmedia.com/system/selfservice.controller?CONFIGURATION=1001&PARTITION_ID=1&TIMEZONE_OFFSET=&USERTYPE=1&VM_CUSTOMER_TYPE=Cable&CMD=VIEW_ARTICLE&ARTICLE_ID=2743
 2016-09-14 16:59:28 +02:00
cketti
97960ec57c Update message format when enabling/disabling PGP/INLINE 2016-09-13 06:23:06 +02:00
cketti
4430abaf30 Don't force plain text when PGP/INLINE is not enabled 2016-09-13 05:38:20 +02:00
cketti
78d3b011e6 Merge pull request #1612 from k9mail/update_provider_settings 
Update server settings for Comcast
 2016-09-13 05:35:29 +02:00
cketti
521c9129a5 Merge pull request #1608 
Don't try to show invalid mail addresses in recipient selector

Fixes #1607
 2016-09-13 04:16:45 +02:00
cketti
e40bac35a8 Fix indentation 2016-09-13 03:55:50 +02:00
cketti
dbde17108b Update server settings for Comcast 2016-09-12 06:41:17 +02:00
morckx
192ce7e770 Fix code style and log spam 2016-09-11 13:36:44 +02:00
cketti
4d591a79ee Merge pull request #1593 from k9mail/GH-1581_context_menu_position_fix 
Custom contextPopupMenuStyle on Android N to fix context menu position
 2016-09-10 23:30:00 +02:00
morckx
ca2e96eb45 Don't try to show invalid mail addresses in recipient selector 
(fixes #1607)
 2016-09-09 22:54:39 +02:00
cketti
c8c33f4710 Custom contextPopupMenuStyle on Android N to fix context menu position 
See https://code.google.com/p/android/issues/detail?id=221643

Fixes #1581
 2016-09-04 09:40:55 +02:00
cketti
cd4ea8ed40 Hide crypto status icon if no crypto provider is configured 
Also, disable crypto status icon when clicking it does nothing.
 2016-09-04 06:40:15 +02:00
Vincent Breitmoser
82f5fc6b30 fix status_lock_closed icon 2016-09-01 21:08:17 +02:00
cketti
dcd27d9f56 Merge pull request #1584 from k9mail/fix-messageview-onactivityresult 
fix crash in onActivityResult (fixes #1582)
 2016-08-30 14:53:52 +02:00
Vincent Breitmoser
5a1776890e fix crash in onActivityResult (fixes #1582) 2016-08-30 13:18:39 +02:00
cketti
4e7f93c3e3 Version 5.111 2016-08-27 23:49:04 +02:00
Vincent Breitmoser
e9e5411c06 adjust colors for dark theme 2016-08-27 21:19:02 +02:00
Vincent Breitmoser
406334086c use stylable attributes for openpgp_ colors 2016-08-27 21:19:02 +02:00
Vincent Breitmoser
f6e19680b0 add test for message/rfc822 attachment 2016-08-19 22:21:43 +02:00
Vincent Breitmoser
77a3892b0f fix unit tests for 7bit/quoted-printable encoding 2016-08-19 22:21:43 +02:00
Vincent Breitmoser
674cd3bf5a remove 7 bit reencoding routines 2016-08-19 22:21:42 +02:00
Vincent Breitmoser
03a09c9b90 use application/octet-stream for message attachments 2016-08-16 12:23:43 +02:00
Vincent Breitmoser
08ef3d5ce5 clean up TextBody, make it slightly more failfast 
Previously, TextBody supported only 8bit or quoted printable encodings,
defaulting to quoted printable if the encoding was not equal to "8bit".
This behavior is now changed to throw a runtime exception when an
unsupported encoding has been selected. The `setEncoding` method also
throws if an unsupported encoding is selected.
 2016-08-16 12:21:09 +02:00
cketti
b0e5912891 Merge pull request #1414 from k9mail/build_speed_improvements 
Build speed improvements
 2016-08-16 01:38:13 +02:00
cketti
0bc5b49bb5 Fix MessageBuilderTest 2016-08-16 00:40:23 +02:00
cketti
77f9e82b41 Merge pull request #1559 from k9mail/deferred-file-body-fix 
Fix DeferredFileBody
 2016-08-16 00:07:41 +02:00
cketti
52e593e597 Merge pull request #1558 from k9mail/hide-keyboard-on-view 
Hide keyboard when message is displayed
 2016-08-16 00:03:54 +02:00
cketti
411ec0ec34 Use 'newInstance' as name for static factory methods 2016-08-15 11:48:36 +02:00
cketti
84cef1d8b1 Get rid of trivial static factory methods 2016-08-15 11:42:47 +02:00
cketti
c234578271 Don't inject BoundaryGenerator into MimeMultipart 2016-08-15 11:14:38 +02:00
cketti
7719153cc0 Extract code to generate Message-Id header value 
This moves Message closer to being a dumb data class and avoids having to
pass around a UuidGenerator reference.
 2016-08-15 10:22:17 +02:00
Vincent Breitmoser
f5656c331d add tests for DeferredFileBody 2016-08-11 15:54:25 +02:00
Vincent Breitmoser
c7a86e8000 fix writeMemoryToFile in DeferredFileBody 2016-08-11 15:45:21 +02:00
Vincent Breitmoser
f097c44580 messageview: hide keyboard when message is displayed, not only after interaction pending intent 2016-08-10 14:58:31 +02:00
Vincent Breitmoser
4d9283f124 construct MessageBuilder classes in factory methods 2016-08-10 14:49:12 +02:00
Vincent Breitmoser
1e97f1ce16 inject UuidGenerator into MimeMessage via constructor instead of parameter 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
bb8e5a68df rename UUIDGenerator to UuidGenerator 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
1c28e1c601 add MessageBuilder test for message with attachment 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
cd011349fe make send date and timezone hiding build parameters in MessageBuilder 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
874b981ba6 get message boundaries from injected BoundaryGenerator in MessageBuilder 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
f4b0521bbb get uuid from injected generator in message builder 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
902506b2b8 move legacy utility method into migration class 2016-08-10 13:50:25 +02:00
Vincent Breitmoser
d6c50b4db6 add unit tests for PendingCommand serialization 2016-08-10 13:45:02 +02:00
Vincent Breitmoser
73c2b1e9ad add unit tests for PendingCommand migration 2016-08-10 13:45:02 +02:00
Vincent Breitmoser
fb1dfd5786 add migration for new pending commands 2016-08-10 13:45:02 +02:00
Vincent Breitmoser
3eb949e674 use lists instead of arrays in PendingCommands 2016-08-10 13:45:02 +02:00
Vincent Breitmoser
c4ab70ca0b reorder methods in MemorizingMessagingListener (no semantic changes) 2016-08-10 13:44:57 +02:00
Vincent Breitmoser
15f3ba6219 serialize PendingCommands as JSON 2016-08-10 13:43:26 +02:00
Vincent Breitmoser
438576b547 minimize visibility in MessagingController (and some small code style fixes) 2016-08-10 10:41:39 +02:00
Vincent Breitmoser
8647b4c8dd minor fixes for clarity of foreground priority commands 2016-08-10 10:41:39 +02:00
Vincent Breitmoser
0dfcdbdfc4 hide the Runnable interface as an implementation detail of MessagingController 2016-08-10 10:41:39 +02:00
Vincent Breitmoser
6596c85a9f clean up fields a bit in MessagingController 2016-08-10 10:41:39 +02:00
Vincent Breitmoser
03baf1afc2 make memorizingMessagingListener final, and respect that it can't actually be null 2016-08-10 10:41:32 +02:00
Vincent Breitmoser
a0a341e479 move MemorizingListener into its own class 2016-08-10 10:41:32 +02:00
Vincent Breitmoser
8d24e036b7 fix a bunch of warnings in MessagingController (no semantic changes) 2016-08-10 10:41:32 +02:00
cketti
904c80dd22 Merge pull request #1555 from k9mail/alternate-recip-fix 
Small fix for alternate recipient adapter
 2016-08-10 05:33:15 +02:00
cketti
b40d64eee4 Merge pull request #1545 from k9mail/safecontentresolver_update 
Update SafeContentResolver to 0.9.0
 2016-08-10 05:14:18 +02:00
Vincent Breitmoser
a2674efff1 compose: small fixes for alternate recipient adapter 
this slightly alters behavior when a non-contact address is picked, to
make sure a crypto status is shown in the alternate dropdown.
 2016-08-09 13:36:19 +02:00
cketti
ecb0044cc4 Merge pull request #1527 from k9mail/message-reference-ops 
pass MessageReference instead of LocalMessage to MessagingController operations
 2016-08-05 05:56:07 +02:00
cketti
915f44ab14 Merge pull request #1537 from k9mail/compose-attachments-from-viewinfo 
Load attachments from AttachmentViewInfo in AttachmentPresenter
 2016-08-05 04:33:03 +02:00
cketti
07a99137d1 Update SafeContentResolver to 0.9.0 2016-08-05 02:22:42 +02:00
Vincent Breitmoser
ed84f2958c remove a couple of unused icons 
I kept the sources around, so they can more easily be restored should we
need some of those again.
 2016-08-03 17:11:22 +02:00
Vincent Breitmoser
4449e5c0d7 use vector drawables for all openpgp icons 2016-08-03 16:46:53 +02:00
Vincent Breitmoser
0f3ce1bf1c pass MessageReference instead of LocalMessage to MessagingController operations 
The most significant change here is that LocalMessage data is loaded in
MessagingController, instead of every calling site individually.
 2016-08-02 18:47:04 +02:00
cketti
403323c94f Merge pull request #1529 from k9mail/fix-crash-on-no-headers 
Don't crash if headers aren't available
 2016-08-02 18:23:47 +02:00
cketti
a47e5bf3d2 Merge pull request #1536 from k9mail/compose-complete-on-send 
Try performing recipient completion on send
 2016-08-02 18:07:24 +02:00
cketti
9fd2cf3bf1 Merge pull request #1535 from k9mail/compose-non-ascii-error 
Show parse error for non-ASCII characters in address
 2016-08-02 18:05:12 +02:00
cketti
54b3bac672 Merge pull request #1528 from k9mail/fix-mlh-loadMessageRemoteFinished 
Fix logic in MessageLoaderHelper
 2016-08-02 17:22:15 +02:00
cketti
2626cb1115 Merge pull request #1523 from k9mail/server_name_suggestion 
Suggest server name based on server type
 2016-08-02 15:40:01 +02:00
Vincent Breitmoser
d276bbda3e load draft attachments from AttachmentViewInfo 2016-08-01 16:53:12 +02:00
Vincent Breitmoser
450356b577 add flag whether data is available to AttachmentViewInfo 2016-08-01 16:03:22 +02:00
Vincent Breitmoser
b3f2974962 compose: try performing recipient completion on send (fixes #1495) 
This commit performs completion on recipient fields when the send button
is clicked (uncompleted text is usually present if the cursor is on the
recipient field at that time).

If any completion was performed, sending is quietly aborted. This avoids
sending mail to the wrong recipient if the uncompleted text doesn't
resolve to what the user thought.
 2016-08-01 15:33:05 +02:00
Vincent Breitmoser
43cd25cfa3 compose: show parse error for non-ascii characters in address 2016-08-01 15:04:27 +02:00
Vincent Breitmoser
8399c9f161 don't crash if headers aren't available 2016-07-29 20:57:26 +02:00
Vincent Breitmoser
0b0a8a46ef fix logic in MessageLoaderHelper 2016-07-29 20:56:14 +02:00
Vincent Breitmoser
a40a33e1da delete abandoned CryptoHelper class 2016-07-28 14:53:58 +02:00
Vincent Breitmoser
f87a9cad49 don't throw MessagingExceptions for getting headers from parts 2016-07-28 14:53:58 +02:00
Vincent Breitmoser
2b5064ea55 always load headers immediately for LocalMessage 2016-07-28 14:53:57 +02:00
Vincent Breitmoser
3f0fb9fd3e change tests to use more actual Part/Body classes instead of mocks 2016-07-28 14:53:57 +02:00
cketti
1cb32b0ce5 Suggest server name based on server type 2016-07-25 05:45:07 +02:00
Vincent Breitmoser
fa998981f7 add handling for LocalMessage parts to AttachmentInfoExtractor 2016-07-25 01:39:06 +02:00
Vincent Breitmoser
e03df3d991 improve error handling when opening missing parts (don't crash at least) 2016-07-25 01:39:06 +02:00
cketti
d80a1d415a Merge pull request #1510 
Loader helper fixes
 2016-07-25 01:01:34 +02:00
Vincent Breitmoser
af5856d28f avoid leaking data to MessagingController via MessageLoaderHelper after detach 
null handling is already present: no ui methods should ever be called
after onDestroy or onDetachChangingConfigurations, and pending result
callbacks are handled by a null-check for the callback field.
 2016-07-25 00:59:07 +02:00
Vincent Breitmoser
0993d91473 only care for our own MessageReference in MessageLoaderHelper 2016-07-25 00:59:07 +02:00
Vincent Breitmoser
471754241d Merge pull request #1514 from k9mail/dont-trust-downloaded-flag 
don't trust X_DOWNLOADED_FULL flag, consider messages with missing data incomplete (WIP)
 2016-07-24 23:43:02 +02:00
Vincent Breitmoser
489cf354fd don't pass LocalMessage from onMessageViewInfoLoadFinished/Failed 2016-07-24 23:40:12 +02:00
Vincent Breitmoser
174f99b94c don't trust X_DOWNLOADED_FULL flag, consider messages with missing on-disk data incomplete 2016-07-24 23:40:12 +02:00
cketti
9c46f68b7f Merge pull request #1515 from k9mail/hidden-attachments 
Ditch "hidden attachments"
 2016-07-24 22:54:32 +02:00
Vincent Breitmoser
b7bcaf8deb rename firstClassAttachment to inlineAttachment (with reversed logic) 2016-07-24 22:08:16 +02:00
cketti
d8f5de0013 Merge pull request #1522 from k9mail/confirm-mark-all-as-read 
Ask for confirmation on "mark all as read"
 2016-07-24 21:59:17 +02:00
Vincent Breitmoser
a3ce1adf6e only first class attachments should be actually displayed 2016-07-24 21:05:52 +02:00
Vincent Breitmoser
c1d57aa324 parts without name are still first class attachments 2016-07-24 21:05:13 +02:00
Vincent Breitmoser
bd925567e4 messageview: remove support for "hidden" attachments 2016-07-24 21:05:13 +02:00
Vincent Breitmoser
035aba1c1e fix button to display hidden attachments 2016-07-24 21:05:13 +02:00
Vincent Breitmoser
7826febedb Merge pull request #1511 from k9mail/sanitize-in-extract 
Sanitize HTML in MessageViewExtractor instead of MessageWebView
 2016-07-24 20:51:47 +02:00
Vincent Breitmoser
526448d18b incorporate tests feedback 2016-07-24 20:51:37 +02:00
Vincent Breitmoser
773600c717 sanitize html in MessageViewInfoExtractor 
also, inject HtmlSanitizer to keep MessageViewInfoExtractor testable and
pass Context through Globals
 2016-07-24 20:51:37 +02:00
Vincent Breitmoser
65f2539e0b move MessageViewInfoExtractorTest to unit tests 
(Yes, I made sure these still run successfully!)
 2016-07-24 20:50:35 +02:00
cketti
8df6a56a6f Merge pull request #1521 from k9mail/attachment-count-encrypted 
Set attachment count to zero for encrypted messages
 2016-07-24 20:37:16 +02:00
cketti
8b1c13d697 Merge pull request #1520 from k9mail/recipient-view-longclick 
compose: enable long click on recipient select view
 2016-07-24 20:05:49 +02:00
cketti
807f0418d8 Merge pull request #1519 from k9mail/recipient-inject-loaderman 
Inject LoaderManager to RecipientSelectView via presenter
 2016-07-24 20:05:20 +02:00
cketti
2abcbf9ca2 Merge pull request #1512 from k9mail/use-mime4j-bodydescriptor 
Use MIME4J's BodyDescriptor instead of reading Content-Type header ourselves
 2016-07-24 18:45:52 +02:00
Vincent Breitmoser
c65f54d396 ask for confirmation on "mark all as read" (closes #1509) 2016-07-22 18:25:31 +02:00
Vincent Breitmoser
5c638dd205 use MessageDecryptVerifier methods in EncryptionDetector 2016-07-22 15:17:43 +02:00
Vincent Breitmoser
22b72a5824 don't count attachments in encrypted messages 2016-07-22 15:17:43 +02:00
Vincent Breitmoser
d1620f3fc7 compose: enable long click on recipient select view 
this leads to some problems if more than one token is actually parsed.
however, for the common use case of parsing a single address, it seems
to work just fine, so this hopefully does more good than harm.

see also https://github.com/splitwise/TokenAutoComplete/issues/95
 2016-07-22 15:12:58 +02:00
Vincent Breitmoser
034b1eda41 compose: inject loader manager to RecipientSelectView via presenter (fixes #1251) 
Conflicts:
	k9mail/src/main/java/com/fsck/k9/view/RecipientSelectView.java
 2016-07-22 15:03:59 +02:00
Vincent Breitmoser
600537f5fb use mimeType and boundary values from BodyDescriptor rather than header values 2016-07-19 17:14:46 +02:00
Vincent Breitmoser
19cd7b997e add some @WorkerThread annotations 2016-07-18 15:38:21 +02:00
Vincent Breitmoser
9f58de5909 compose: use MessageViewInfo.rootPart for content extraction 2016-07-18 15:38:21 +02:00
Vincent Breitmoser
99f65f338e compose: hand cached decryption result back to OpenKeychain 2016-07-18 15:38:21 +02:00
Vincent Breitmoser
0a43b36ac5 compose: use attachment info from loaded AttachmentViewInfo 2016-07-18 15:38:21 +02:00
Vincent Breitmoser
62361da104 compose: pass MessageViewInfo around instead of just the Message 2016-07-18 13:53:01 +02:00
cketti
a58ca4624b Merge pull request #1488 from k9mail/GH-1483_remove_settings_import_via_intent 
Disable settings import via VIEW Intent
 2016-07-18 00:18:42 +02:00
cketti
2622b08767 Merge pull request #1484 from k9mail/decrypted-file-provider 
decrypted file provider
 2016-07-18 00:01:59 +02:00
cketti
d096261c56 Make use of Globals to simplify code 2016-07-17 23:02:10 +02:00
cketti
f6fe28d3a8 Add Globals class so we can avoid passing Context through layers of code 
If your class requires a Context instance make it a constructor argument. Then
create a static factory method that calls Globals.getContext(). The result can
then be passed to the constructor.
This allows testing individual classes using test doubles by directly invoking
the constructor and not having to deal with Globals. For integrated tests
spanning multiple classes you might have to use Globals.setContext().
 2016-07-17 23:02:10 +02:00
Vincent Breitmoser
8b719a3274 prefer real objects for Part in tests over mocks 2016-07-17 23:02:10 +02:00
Vincent Breitmoser
44c6fccc0e synchronize cleanupReceiver access 2016-07-17 23:02:10 +02:00
Vincent Breitmoser
c4cb83d370 rename some classes from service to mailstore 2016-07-17 23:02:10 +02:00
Vincent Breitmoser
351737512b fix deferred file body test 2016-07-17 23:02:10 +02:00
Vincent Breitmoser
69b0b3a763 split FileProvider logic, incorporate some other feedback 2016-07-17 23:02:09 +02:00
Vincent Breitmoser
f33c083539 don't allow file deletion in DecryptedFileProvider 2016-07-17 23:00:58 +02:00
Vincent Breitmoser
3b0c1979f1 move file cleanup into AsyncTask in onTrimMemory 2016-07-17 23:00:58 +02:00
Vincent Breitmoser
2993078bf2 keep raw data for decrypted bodies around, decode in DecryptedFileProvider if necessary 2016-07-17 23:00:57 +02:00
Vincent Breitmoser
ed628ae67b make FileProviderDeferredFileOutputStream fail faster 2016-07-11 16:14:41 +02:00
cketti
e858ca9e2c Remove intent filter for settings file MIME type 
Importing by URI isn't properly supported. We want to fix this eventually, but
for now we just remove the functionality.

Fixes #1483
 2016-07-07 00:03:04 +02:00
cketti
06e4ca1945 Version 5.110 2016-07-06 22:23:53 +02:00
cketti
95c546d992 Merge pull request #1485 from k9mail/notifications_only_from_contacts 
Setting: only show notifications for messages from contacts
 2016-07-06 21:55:32 +02:00
Vincent Breitmoser
0e3d18e7f7 we don't use displayName from database either (for now), fix tests to reflect that 2016-07-06 21:48:39 +02:00
Vincent Breitmoser
7cb6fa102f stream performance optimizations 2016-07-06 21:48:38 +02:00
Vincent Breitmoser
032b1fb833 add some debug logging to cleanup receiver 2016-07-06 21:48:38 +02:00
Vincent Breitmoser
bb9f857d86 add Attachment* tests, and some annotations 2016-07-06 21:48:38 +02:00
Vincent Breitmoser
be3543c78d also clean up decrypted temp files on low memory 2016-07-06 21:48:38 +02:00
Vincent Breitmoser
1eca794346 add DecryptedFileProviderCleanupReceiver to clean up temp files on screen off 2016-07-06 21:48:38 +02:00
Vincent Breitmoser
e102a1d474 introduce FileProviderInterface, specialize K9FileProvider for decrypted 2016-07-06 21:48:38 +02:00
Vincent Breitmoser
36a3a8bb20 rename DecryptedStreamParser and DecryptedTempFileBody 2016-07-06 21:48:38 +02:00
cketti
1d471a8633 Rename method for consistency 2016-07-06 21:25:20 +02:00
Vincent Breitmoser
cd4be0e466 fix translation issues 2016-07-05 12:05:18 +02:00
cketti
202595c605 Make 'notify for contact only' setting available for import/export 2016-07-05 01:40:51 +02:00
cketti
ee8dd311df Pass Contacts via constructor into MessagingController 2016-07-05 01:34:40 +02:00
cketti
1d2509e98f Change wording in settings screen 2016-07-05 01:27:28 +02:00
Christian Grubert
e2e3da262c new option: just show notification for contacts 2016-07-05 01:25:08 +02:00
Vincent Breitmoser
4d3bc41c0a unfold+decode header value in getContentType() and getDisposition() 2016-07-01 18:40:48 +02:00
Vincent Breitmoser
1c8a6f05d0 make Attachment class immutable 2016-07-01 18:40:48 +02:00
Vincent Breitmoser
099d03f46a compose: extract AttachmentPresenter 2016-07-01 18:40:48 +02:00
Vincent Breitmoser
b4bd645eaa fix copy paste string error 2016-06-30 11:21:29 +02:00
Vincent Breitmoser
84c0e4c730 improve variable naming and some magic constants 2016-06-30 11:11:15 +02:00
Vincent Breitmoser
1bae68169f messageview: move more control flow for display of crypto data into MessageCryptoPresenter 2016-06-30 11:11:15 +02:00
Vincent Breitmoser
fccb4a4b24 messageview: simplify handling of external pictures, ditch ShowPicturesController 2016-06-30 11:11:15 +02:00
Vincent Breitmoser
b5b603001b messageview: move setShowDownloadButton into setMessage 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
f6f4805076 messageview: move MessageCryptoMvpView into a var instead of implementing directly 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
837aa70486 messageview: match signature user id with sender address 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
2e9184f8e2 compose: use MessageLoaderHelper for quoted message loading (fixes MessageCompose) 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
b72dba67df messageview: move all loading logic into MessageLoaderHelper (breaks MessageCompose) 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
0df44a1457 messageview: strip pgp markers for partially downloaded clearsigned messages before view 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
58daf68503 messageview: handle crypto error states 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
c12ce95941 messageview: add "View Key" button to crypto info dialog 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
675b167320 messageview: retain MessageCryptoHelper over configuration changes 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
573bfc4b59 messageview: make MessageCryptoHelper detachable 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
68e31a985f messageview: cancel operation when fragment is destroyed 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
9b1e51c559 messageview: draw progress bar while crypto is processing 2016-06-30 11:08:44 +02:00
Vincent Breitmoser
293e23d04a messageview: display support for encapsulated signed parts 2016-06-30 11:01:05 +02:00
Vincent Breitmoser
c640e4a680 messageview: display unsigned text in additional textview 2016-06-30 11:01:05 +02:00
Vincent Breitmoser
61232cb631 messageview: display unsigned attachments in LockedAttachmentView 2016-06-30 11:00:00 +02:00
Vincent Breitmoser
d98f579b34 messageview: move some logic into MessageCryptoPresenter, refresh after key import (solves #732) 2016-06-30 10:59:19 +02:00
Vincent Breitmoser
4da1a01130 messageview: add crypto info dialog 2016-06-30 10:59:19 +02:00
Vincent Breitmoser
d92155e2b5 messageview: show crypto status icon in header 2016-06-30 10:59:19 +02:00
Vincent Breitmoser
8f568867a6 messageview: remove all openpgp info in message view 2016-06-30 10:59:19 +02:00
Vincent Breitmoser
6371cde568 messageview: nicer handling of pendingintent in MessageList and MessageCryptoHelper 2016-06-30 10:49:05 +02:00
Vincent Breitmoser
b0b269a736 messageview: add canceled CryptoError state 
Conflicts:
	k9mail/src/main/java/com/fsck/k9/ui/crypto/MessageCryptoHelper.java
	k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageTopView.java
 2016-06-30 10:49:05 +02:00
Vincent Breitmoser
b57ef10e90 messageview: add support for encapsulated signed parts (fixes #576) 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
6ceec725cb messageview: use memory-backed body for decrpyted parts which are small and not attachments 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
a55db0f3cf messageview: start parsing input only if it's not immediate EOF or EPIPE 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
04e17564a8 messageview: add logic for display of crypto progress 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
0402eda968 messageview: use OpenPgpDataSink and -Source for threads (contains api-lib update) 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
240c5c8ea8 messageview: support mutt's application/pgp mimetype for pgp/inline messages (fixes #1271) 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
8f04d60249 messageview: for pgp/inline, only check BEGIN PGP MESSAGE marker 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
b73805c598 first steps towards primary-part-centered MessageViewInfo structure 
This most importantly means moving away from the find*Parts family of
methods in MessageDecryptVerifier. at the moment, the initial detection
of parts to process in MessageCryptoHelper still uses the old methods,
which are strictly more inclusive about what is processed.
 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
43efd6db0b add some unit tests to MessageDecryptVerifier 2016-06-30 10:25:26 +02:00
Vincent Breitmoser
7305a20b8b messageview: handling for unsupported multipart/(signed|encrypted) 2016-06-30 10:25:26 +02:00
Vincent Breitmoser
e71cff565e messageview: ditch support for multiple root parts with different crypto status 2016-06-30 10:25:26 +02:00
cketti
9d1970d79f Merge pull request #1465 from k9mail/extract-webview-resource-handling 
Encapsulate attachment resource handling into AttachmentResolver
 2016-06-30 03:58:47 +02:00
Vincent Breitmoser
2c4f698192 split up displayHtmlContentWithInlineAttachments into set, clear and refresh methods 2016-06-28 10:59:27 +02:00
cketti
dca9d20f99 Merge pull request #1416 from k9mail/messageview-fix-flicker 
Fix flicker of subject line in MessageHeader
 2016-06-28 04:02:33 +02:00
cketti
2f4d0a8204 Merge pull request #1459 from k9mail/fix-hidden-attachments 
Don't rely on cached metadata from database for attachment info
 2016-06-28 04:01:37 +02:00
cketti
6f46a53861 Merge pull request #1424 from OllieTerrance-forks/outlook-uk-providers 
Add UK variants of Hotmail addresses to providers
 2016-06-28 03:25:18 +02:00
Vincent Breitmoser
c2bb16a760 Encapsulate attachment resource handling into AttachmentResourceProvider 
This commit introduces the AttachmentResourceProvider as a layer of
abstraction between K9WebViewClient and the message Part structure,
which allows moving all K9WebViewClient handling into MessageWebView
itself (making the class package-local).

It also fixes display of uncached inline attachments, e.g. in a Forward
operation called from the context menu.
 2016-06-23 20:25:00 +02:00
Vincent Breitmoser
8f4ac55d6c don't rely on cached metadata from database for attachment info 
This commit removes use of LocalFolder.MessagePartType as an indication
of part types in AttachmentInfoExtractor. The enum was intended as a
caching mechanism to skip loading unimportant parts from the database,
but only the reading side was implemented. As the expected performance
gain is negligible, I disabled the reading side for now (computing the
data instead) and more explicitly disabled the writing side as well.
 2016-06-13 17:11:47 +02:00
Philip Whitehouse
b7c3e5296b Update web page URL to GitHub website 2016-06-06 16:28:04 +01:00
Ollie Terrance
7651fe02e7 Add UK variants of Hotmail addresses to providers 2016-06-02 18:37:17 +01:00
Vincent Breitmoser
27a3add959 fix flicker of subject line in MessageHeader 
MessageHeader rendered the subject line by default, and only after
MessageTitleView decided it was large enough to display the entire
subject line, the subject line was hidden again. This caused a noticable
flicker during message rendering while navigating with next/previous
message buttons.

This commit flips the logic, only displaying the subject view once the
title view finds it can't display it all.
 2016-05-28 22:44:38 +02:00
cketti
eca66c1a34 Don't load Gradle plugins for code quality during development 2016-05-28 15:18:11 +02:00
Vincent Breitmoser
59a818490f do not purge messages when downloading missing body for view 2016-05-25 16:32:42 +02:00
Vincent Breitmoser
f0e64a33a4 drop message_parts table before creation in dbCreateDatabaseFromScratch 2016-05-23 21:53:38 +02:00
cketti
2ccbf581ab Version 5.109 2016-05-21 06:37:29 +02:00
cketti
1eb0ef4a6b Merge pull request #1390 
Fix reply to all, and some refactorings for initFromReplyTo
 2016-05-21 00:00:37 +02:00
cketti
3762e1561f Only test one thing per test method 2016-05-20 23:55:45 +02:00
cketti
56e8fc1d77 Remove redundant checks and ones that make tests needlessly brittle 2016-05-20 23:52:21 +02:00
cketti
7e829bbfb7 Fix test instead of adding null check to ListHeaders 2016-05-20 23:39:55 +02:00
Vincent Breitmoser
43899da77c same signature to get replyTo and replyToAll addresses in ReplyToParser 2016-05-20 11:26:13 +02:00
Vincent Breitmoser
9a1dcd5a83 debug: add debug operation to clear a message locally 2016-05-19 22:37:48 +02:00
Vincent Breitmoser
31f6deb474 small performance optimizations 2016-05-19 15:49:33 +02:00
cketti
120c72a0fc Merge pull request #1386 from k9mail/download-messagebody 
Fetch message on view if body unavailable
 2016-05-19 15:18:31 +02:00
Vincent Breitmoser
e3593a14bf ensure that multipart/* parts always have a non-null boundary field 2016-05-19 14:56:40 +02:00
cketti
f4628d2a24 Merge pull request #1383 from k9mail/fts-fix 
fts: more resource friendly migration
 2016-05-19 14:53:15 +02:00
cketti
af0c8aab75 Merge pull request #1337 from k9mail/webDavPollingFix 
WebDav polling fix
 2016-05-19 14:51:31 +02:00
Vincent Breitmoser
8de494412e messageview: refactor OpenPgpResultAnnotation into immutable CryptoResultAnnotation 2016-05-19 14:27:58 +02:00
Vincent Breitmoser
e002451296 move ViewableContainer into MessageViewInfoExtractor 2016-05-19 14:27:58 +02:00
Vincent Breitmoser
e57c82238d some refactorings for Message*Extractor classes 
This commit contains no semantic changes. One significant change is the
return type of MessageExtractor.findViewablesAndAttachments, which was
changed from a mixed return type (viewables as return value, attachments
as output parameter) to two output parameters, both for consistency and
performance.
 2016-05-19 14:27:55 +02:00
Vincent Breitmoser
fb6816173c get rid of deprecated PgpData class 2016-05-19 14:13:29 +02:00
cketti
7e82e38247 Merge pull request #1380 
Different fix for decrypted part double decode problem
 2016-05-19 14:06:38 +02:00
cketti
2ee7f29b95 Remove unused imports 2016-05-19 14:05:43 +02:00
Vincent Breitmoser
3de2360a43 inject ReplyToParser and test for use in initFromReplyTo 2016-05-17 16:39:27 +02:00
Vincent Breitmoser
f85bef1261 move reply to all logic into ReplyToParser and add tests 2016-05-17 16:00:40 +02:00
Vincent Breitmoser
4c6bc1a81b compose: copy other to and and cc addresses only on reply all 2016-05-17 15:52:19 +02:00
Vincent Breitmoser
8d631fd905 compose: small refactorings for readability in RecipientPresenter 2016-05-17 15:52:16 +02:00
Vincent Breitmoser
2811b09da2 messageview: fetch message on view if body is not available 2016-05-16 23:22:03 +02:00
Vincent Breitmoser
7644abb142 messagingcontroller: optimize imports, remove unused parameter 2016-05-16 23:22:03 +02:00
Vincent Breitmoser
a2a4f59bb0 messagingcontroller: fix loadPartialForSearch parameter in loadMessageForRemoteView 2016-05-16 23:21:57 +02:00
Vincent Breitmoser
7614c8fd5e make DecryptedTempFileBody a Body instead of RawDataBody (fixes #1252) 2016-05-15 10:35:54 +02:00
Vincent Breitmoser
9d3a735cea fts: more resource friendly migration 2016-05-13 16:29:05 +02:00
Vincent
94b9da3d16 Merge pull request #1331 from k9mail/compose-mime-combined 
PGP/INLINE and build in combined mime format
 2016-05-13 14:44:40 +02:00
Vincent Breitmoser
36f890f436 Revert "fix double application of transfer decoding for decrypted parts" 
This reverts commit e3cd40ea4e.
See https://github.com/k9mail/k-9/issues/1252
 2016-05-13 11:05:12 +02:00
Vincent Breitmoser
e3cd40ea4e fix double application of transfer decoding for decrypted parts 2016-05-12 17:55:16 +02:00
Vincent Breitmoser
f0d09b91a9 clarify code for LocalMessage.equals() 2016-05-11 11:42:22 +02:00
Vincent Breitmoser
3a5d9b71a4 compose: move bullet point appearance into styles, and tintColor into theme 2016-05-09 10:11:09 +02:00
Vincent Breitmoser
7e8e82f200 remove "this is a bug" from some AssertionErrors 2016-05-09 09:54:07 +02:00
cketti
1f9cd50076 Use constructor injection for ComposePgpInlineDecider 2016-05-09 09:54:07 +02:00
cketti
287b649ed4 Remove unnecessary complexity 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
b6cd69f247 compose: check that message is simple before applying PGP/INLINE encoding 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
b6f540bfd9 compose: apply transfer encoding *after* PGP/INLINE signing 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
8a58398cb8 add first tests for MessageBuilder 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
10ab9c7a9e compose: small fixes for PgpMessageBuilder 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
665feffe70 add some tests for PgpMessageBuilder 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
a4fda06dae compose: switch from encapsulated to combined pgp/mime format (solves #1289) 
Conflicts:
	k9mail/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java
 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
41d5098c45 compose: automatically use pgp/inline if replied-to msg is pgp/inline 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
4fc1f448db compose: show warning when trying to attach file in pgp/inline mode 2016-05-09 09:54:05 +02:00
Vincent Breitmoser
84aba8506b compose: highlight pgp/inline icon in background with showcase lib 2016-05-09 09:54:05 +02:00
Vincent Breitmoser
e0cb12709a compose: add pgp/inline indicator and dialog 2016-05-09 09:54:03 +02:00
Philip Whitehouse
dfe3372447 WebDAV: Stop notifying of message retrieval when flags are fetched 2016-05-05 21:45:23 +01:00
Vincent Breitmoser
e92bb14d0b compose: save inline mode setting as flag for drafts 2016-05-03 21:24:10 +02:00
Vincent Breitmoser
029b04a1db compose: extract putEncryptionIntentExtras method in PgpMessageBuilder 2016-05-03 21:23:13 +02:00
Vincent Breitmoser
fe4429416a compose: add logic for pgp/inline compatibility mode 2016-05-03 21:23:13 +02:00
Vincent Breitmoser
7f606c6794 compose: add pgp/inline compat flag to crypto status 2016-05-03 21:23:13 +02:00
Vincent
28232ed108 Merge pull request #1340 from k9mail/crash_on_migration_error 
Crash app when migrations fail in debug build
 2016-05-02 14:55:43 +02:00
cketti
e90af0fc2b Merge pull request #1320 from k9mail/build_system_updates 
Build system updates
 2016-05-01 06:50:03 +02:00
cketti
9d55b6c957 Merge pull request #1335 from k9mail/compose-quoted-presenter 
Refactor quoting logic into QuotedMessagePresenter
 2016-04-30 21:28:38 +02:00
cketti
0640a60362 Introduce hack to remove flakiness from MigrationTest 2016-04-30 02:33:39 +02:00
cketti
e6d84afacc Merge pull request #1317 from philipwhiuk/messagingControllerImprovement 
Tests for MessagingController
 2016-04-29 03:25:00 +02:00
cketti
57551b3825 Crash app when migrations fail in debug build 2016-04-28 23:38:30 +02:00
Philip Whitehouse
fecfac3913 Fix column reference for fulltext message table 2016-04-28 09:36:09 +01:00
Vincent Breitmoser
b4b7a9f566 compose: some more QuotedMessagePresenter refactorings 2016-04-28 10:35:16 +02:00
Vincent Breitmoser
02cde7fb77 compose: refactor quoting logic into QuotedMessagePresenter 2016-04-28 10:35:13 +02:00
Philip Whitehouse
7b70636240 Correct reference to fulltext messages table 2016-04-27 21:51:24 +01:00
Vincent Breitmoser
9112ca2567 drop messages_fulltext table before creating, too 2016-04-27 22:20:48 +02:00
Vincent Breitmoser
5a374c062e create messages_fulltext table when creating db from scratch 2016-04-27 22:15:31 +02:00
Philip Whitehouse
4bb116f2f4 Add tests for remote search 2016-04-23 01:20:01 +01:00
Vincent Breitmoser
27b1105ed9 fts: delete from fulltext index when message is destroy()ed 2016-04-22 13:22:17 +02:00
Vincent Breitmoser
24dd63e0fe fts: add simple migration path 2016-04-22 13:22:17 +02:00
Vincent Breitmoser
8c4fcaec4b fts: working fts, first iteration 2016-04-22 13:22:17 +02:00
Vincent Breitmoser
e888ab8b4a rename preview package to extractors 2016-04-22 13:22:17 +02:00
Vincent Breitmoser
126a75c12f use BoundedInputStream to limit checked preview length 2016-04-22 13:22:17 +02:00
cketti
e8d04338e2 Merge pull request #1310 from k9mail/trimMessageCompose 
Move static methods and classes out of MessageCompose
 2016-04-22 05:59:00 +02:00
cketti
b160e21e13 Merge pull request #1307 from k9mail/GH-1275_threaded_message_list_display_error 
Fix duplicate thread bug (take 2)
 2016-04-22 05:57:39 +02:00
cketti
4c56bb7660 Remove android-sdk-manager 2016-04-22 03:42:06 +02:00
Philip Whitehouse
bb8042669b Add tests for searchLocalMessagesSynchronous 2016-04-21 20:52:38 +01:00
cketti
8e7d3f8447 Merge pull request #1311 from k9mail/messageListFragmentTrim 
Pull the comparators out of MessageListFragment
 2016-04-21 21:42:05 +02:00
Philip Whitehouse
da8b0c56e4 Tests for MessagingController 2016-04-21 01:51:02 +01:00
ligi
34a513f079 Shorten code (#1308) 2016-04-20 00:23:53 +02:00
Philip Whitehouse
42698b40a3 Repackage new classes 2016-04-19 23:21:21 +01:00
Philip Whitehouse
78b1de8db4 Pull the comparators out of MessageListFragment 2016-04-19 23:05:45 +01:00
Philip Whitehouse
9b2746fb9b Move IdentityAdapter and Action creation static methods and classes out of MessageCompose 2016-04-19 22:42:27 +01:00
Philip
86374b25fa Merge pull request #1309 from ligi/fix_cperr 
Fix error when setting body from mailto: link
 2016-04-19 22:13:15 +01:00
ligi
aede223301 Fix Copy and Paste error 2016-04-19 22:50:08 +02:00
cketti
c709c9d987 Fix duplicate thread bug 
This time hopefully without introducing a new bug.
 2016-04-19 01:29:36 +02:00
cketti
60f6af03bf Fix EmailProviderTest to actually test for issue #1275 2016-04-19 01:29:36 +02:00
ligi
f9a42037c3 Replace Thread.sleep() with SystemClock.sleep() 2016-04-19 01:15:05 +02:00
cketti
9ab2029c27 Revert "Fix duplicate thread bug" 
This reverts commit 050316ea91.
 2016-04-18 23:31:21 +02:00
cketti
6ab90e5805 Merge branch 'GH-1275_threaded_message_list_display_error' 2016-04-15 19:47:27 +02:00
Philip Whitehouse
b6b1e64f55 Fix for a concurrent modification exception on provided account list 2016-04-15 19:37:15 +02:00
Philip Whitehouse
289c93d9d1 General testing for the EmailProvider and verification of fix for #1275 2016-04-15 19:37:10 +02:00
cketti
855f1c3d5d Merge pull request #1279 from philipwhiuk/GH-1277-themeRecipientToken 
Move recipient token to theme file define for dark theme - fixes #1277
 2016-04-13 12:37:29 +02:00
Philip Whitehouse
ef04d07af0 Use themable colour for emphasized notifications - fixes #746 2016-04-13 01:47:53 +01:00
Philip Whitehouse
2d67b499f2 Move recipient token to theme file and define different for dark theme - fixes #1277 2016-04-12 21:59:58 +01:00
cketti
78715ed29f Merge pull request #1248 from k9mail/GH-879_notify_on_authentication_failure 
Notify user on authentication failure
 2016-04-11 22:57:00 +02:00
cketti
050316ea91 Fix duplicate thread bug 
Fixes #1275
 2016-04-11 22:04:07 +02:00
cketti
ba4121aa25 Merge pull request #1262 from k9mail/gh-1250-backportUpdateMessageRef 
Backport updating message reference flags from earlier commit - fixes #1250
 2016-04-09 11:20:55 +02:00
cketti
218ac4be6c Merge pull request #1205 
Handle unsupported message types - display a toast if we fail create the message
 2016-04-09 11:11:16 +02:00
cketti
cb260d0f9e Minor code cleanup 2016-04-09 11:10:45 +02:00
Philip Whitehouse
7f724e9e04 Move message reference update to SendMessageTask 2016-04-08 21:28:26 +01:00
cketti
c7562a9ff2 Merge pull request #1197 
Add debugging for when file I/O fails
 2016-04-08 12:53:43 +02:00
cketti
35c8ef2a37 Code style fixes 2016-04-08 12:51:20 +02:00
cketti
46dd8c7a12 Merge pull request #1229 from k9mail/compose-status-animation-cancel 
ditch crypto status icon animation
 2016-04-08 12:16:31 +02:00
Vincent Breitmoser
a042b78ec5 compose: add ToolableViewAnimator widget for easier previewing 2016-04-07 16:14:48 +02:00
Vincent Breitmoser
27768d30b5 compose: ditch crypto status icon animation 2016-04-07 16:14:46 +02:00
Philip Whitehouse
51b310c6e7 Backport updating message reference flags from earlier commit - fixes #1250 2016-04-06 00:27:09 +01:00
cketti
f794cc1f89 Merge branch 'safe_content_resolver' 2016-04-04 07:37:32 +02:00
cketti
7560856d8c Use SafeContentResolver to retrieve content when attaching files 2016-04-04 07:24:16 +02:00
cketti
15a44ce57b Merge pull request #1233 from k9mail/accountMoveBug 
No longer adding a new account twice to the list of ordered accounts
 2016-04-02 23:24:35 +02:00
Philip Whitehouse
9284243fb4 No longer adding a new account twice to the list of ordered accounts 2016-04-02 22:14:56 +01:00
cketti
e738e4b28d Merge pull request #1239 from k9mail/gh-1238-contactname 
Sender name is auto-populated for new contacts
 2016-04-02 22:57:39 +02:00
cketti
a1d8c8a393 Stop ImapFolderPusher when authentication fails 2016-04-01 23:14:30 +02:00
cketti
866cc08ff0 Show notification on authentication failures 2016-04-01 22:07:00 +02:00
Philip Whitehouse
fd89879f38 Add call to destroy finished message loader - fixes #1227 2016-04-01 15:48:20 +01:00
Philip Whitehouse
da90fda19c Sender name is auto-populated for new contacts 2016-03-31 11:33:14 +01:00
cketti
74c6e76433 Merge pull request #1210 from k9mail/GH-1164_fix_preview_extraction_failure 
Handle preview extraction failures
 2016-03-29 08:01:03 +02:00
cketti
9bacb2d5bc Merge pull request #1196 
Testing improvements for various components
 2016-03-24 09:16:02 +01:00
cketti
59e604077e Remove inaccurate TODO comments 2016-03-24 09:12:48 +01:00
cketti
f6b32f2983 Code cleanup 2016-03-24 09:12:48 +01:00
Philip Whitehouse
8ffd250f47 Add test coverage to POP3 store and Account Creator. Document some area to improve 2016-03-24 05:42:41 +01:00
cketti
d93a7de367 Merge pull request #1174 
Handle synchronizing empty folders

Fixes #1139
 2016-03-24 05:22:04 +01:00
cketti
cd79f7e225 Code style fixes 2016-03-24 05:18:50 +01:00
Philip Whitehouse
fd0ea66ebe Improve testing of synchronizeMailboxSynchronous 2016-03-24 05:18:41 +01:00
cketti
31235ae3cf Flag preview extraction errors in the database 
We can later use this information to try again extracting a preview snippet
from an affected message, e.g. after an app update that fixed a preview-related
bug.
 2016-03-24 03:22:41 +01:00
cketti
245deef57c Change PreviewTextExtractor to better handle error conditions 
Fixes #1164
 2016-03-24 03:22:34 +01:00
cketti
c75bd58f95 Merge pull request #1209 from k9mail/migrate-npe-fix 
Migration: Avoid NPE when textContent is null
 2016-03-24 01:58:59 +01:00
Vincent Breitmoser
91c60a4639 update TokenAutoComplete to 2.0.7 (fixes #1204) 2016-03-23 22:39:59 +01:00
Vincent Breitmoser
f902aef8c0 migration: fix NPE if textContent is null 2016-03-23 19:47:36 +01:00