Commit graph

1124 commits

Author SHA1 Message Date
Vincent Breitmoser
0ecf5bcfc7 allow combined pgp/inline + sign-only == clearsign mode 2017-01-06 02:47:23 +01:00
Vincent Breitmoser
a44129b7a9 Revert "remove support for clearsigned messages in PgpMessageBuilder"
This reverts commit ef3cda97e2.
2017-01-06 02:28:51 +01:00
GoneUp
78b7061061 Adjusted the widgets minHeight/mindWidth values to google's recommendation 2017-01-05 22:20:13 +01:00
GoneUp
42a2402347 Unrestricted the message subject since it's in a scrollcontainer 2017-01-05 21:40:43 +01:00
GoneUp
4e3b913522 Add setting for disabling 'mark all as read' confirmation dialog 2017-01-05 18:28:55 +01:00
Vincent Breitmoser
580a828b58 Merge pull request #1969 from k9mail/less_strict_export_version_check
Don't hardcode check for version in SettingsExporterTest
2017-01-05 17:36:19 +01:00
cketti
ea699b3dac Merge pull request #1955 from k9mail/GH-1915_always_show_subject_in_split_mode
Always show subject in message header when split mode is active
2017-01-05 01:42:06 +01:00
cketti
a452ded9cb Merge pull request #1954 from k9mail/GH-1938_fix_bcc_visible_in_sent_message
Fix BCC recipients visible in sent message
2017-01-05 01:40:08 +01:00
cketti
0fe74e59cc Don't hardcode check for version in SettingsExporterTest
Otherwise every time we add a setting this test needs to be touched.
2017-01-04 23:56:59 +01:00
cketti
4323ca3419 Update header before writing a modified LocalMessage
Without this the changes SmtpTransport makes to the message before sending,
e.g. removing the BCC recipients, are not reflected in the writeTo() output.
2017-01-04 19:44:21 +01:00
cketti
b516af2af0 Merge pull request #1948 from philipwhiuk/fix1914untested
Hide the entire crypto component for alternate recipients when disabled

Fixes #1914
2017-01-04 07:42:34 +01:00
cketti
10a252e6b9 Always show subject in message header when split mode is active 2017-01-04 07:20:30 +01:00
cketti
5c06bc01da Add missing fields to LocalMessage.clone() 2017-01-04 05:43:13 +01:00
Philip Whitehouse
55978e6322 Hide the entire crypto component for alternate recipients when disabled 2017-01-04 00:35:44 +00:00
cketti
406fd6b93d Merge pull request #1900 from k9mail/fix_format_string_bug
Don't use unchecked input in format string
2017-01-02 15:31:16 +01:00
Vincent Breitmoser
acfa5d248c Merge pull request #1907 from k9mail/GH-1898_fix_crash_in_MessageCompose_onCreateOptionsMenu
Don't create options menu when Activity is finishing anyway
2017-01-02 12:22:28 +01:00
cketti
9e66bce601 Don't create options menu when Activity is finishing anyway
Fixes #1898
2017-01-01 21:09:47 +01:00
cketti
de60e0e8c4 Merge pull request #1835 from k9mail/flowed-display
Support display of format=flowed (rfc2646)
2017-01-01 02:47:40 +01:00
cketti
693449235f Don't use unchecked input in format string 2016-12-31 20:13:18 +01:00
Vincent Breitmoser
df9009e1ea Merge pull request #1894 from philipwhiuk/fixCcExpanderOnDarkTheme
Use theme-able icon for CC/BCC expander
2016-12-31 13:46:16 +01:00
Philip Whitehouse
f0ac353a21 Use themeable icon for CC/BCC expander - fixes #1893 2016-12-31 12:42:33 +00:00
cketti
b9147f119e Merge pull request #1891 from k9mail/fix-crypto-cancelled-npe
Fix NPE in MessageCryptoHelper.addCryptoResultAnnotationToMessage()
2016-12-30 21:31:51 +01:00
cketti
3bee80a6a4 Merge pull request #1890 from k9mail/fix-fts-oom
Fix OutOfMemoryError during database migration
2016-12-30 21:21:52 +01:00
cketti
b057480481 Simplify LocalFolder.getAllMessageUids() 2016-12-30 20:53:30 +01:00
Vincent Breitmoser
97e9e3267f make MessageCryptoHelper slightly more fail-fast in weird states 2016-12-28 17:50:15 +01:00
Vincent Breitmoser
17647a6fac don't crash in onCryptoOperationCancelled if no part is being processed 2016-12-28 17:40:20 +01:00
Vincent Breitmoser
2279526e0d small cleanup in MessageCryptoHelper 2016-12-28 17:39:01 +01:00
Vincent Breitmoser
e7653c4725 iterate messages by uid, don't keep messages around longer than necessary (fixes #1879) 2016-12-28 16:47:41 +01:00
Philip Whitehouse
36da79d60c Check recipientPresenter exists before destroying it - #1876 2016-12-28 15:11:18 +00:00
Vincent Breitmoser
217b5bf9f4 fix switch/case screwup for signature handling 2016-12-16 00:51:17 +01:00
Vincent Breitmoser
a055ed42a8 don't handle format parameter in setBody(), style fixes 2016-12-12 14:24:30 +01:00
Vincent Breitmoser
dc3d1f0e87 support display of format=flowed (rfc2646) 2016-12-12 14:24:30 +01:00
Vincent Breitmoser
2b4d6d7750 Merge pull request #1850 from k9mail/remove_unused_resources
Remove unused resources
2016-12-12 13:52:02 +01:00
cketti
db1b97d23f Fix tests 2016-12-12 06:51:28 +01:00
cketti
a59aea200f Merge pull request #1804 from sedrubal/swipe-to-refresh
Replace Android-PullToRefresh with android.support SwipeRefreshLayout
2016-12-12 06:32:08 +01:00
cketti
0d77e8ea3a Merge pull request #1844 from supersn0b/master
Added config for fairnatics.net, a soon upcoming service.
2016-12-12 04:00:14 +01:00
cketti
ceb0523fc9 Remove unused layout 2016-12-12 03:28:43 +01:00
cketti
22b07827fc Remove unused strings 2016-12-12 03:26:15 +01:00
cketti
29dc3dd03c Merge pull request #1808 from philipwhiuk/testingSettingsImportExport
Testing for settings import and export
2016-12-12 01:04:58 +01:00
cketti
708b79d859 Merge pull request #1828 from k9mail/nicer_npe_fix_for_database_upgrade_ui
Nicer NullPointerException fix for database upgrade UI
2016-12-12 00:47:53 +01:00
cketti
5fca3c871d Merge pull request #1847 from k9mail/multipart-attachments
Handle attachments with CHILD_PART_CONTAINS_DATA data location
2016-12-11 02:45:00 +01:00
Vincent Breitmoser
0ecbf441c1 handle attachments with CHILD_PART_CONTAINS_DATA data location (message/rfc822) 2016-12-11 02:33:56 +01:00
cketti
6bfb50859e Display empty preview when we couldn't extract preview text 2016-12-09 22:08:10 +01:00
Fair Natics
7230980ecb Removed :993 as this is the default port for imap+ssl+ 2016-12-09 16:56:15 +01:00
Fair Natics
92356e3cee Added config for fairnatics.net, a soon upcoming service. 2016-12-09 14:53:54 +01:00
cketti
ac55279b8e Update translations from Transifex 2016-12-09 00:56:41 +01:00
cketti
2611e9a65d Merge pull request #1833 from k9mail/GH-1832_hide_unsigned_text_divider
Hide "Unsigned Text" divider
2016-12-09 00:19:16 +01:00
cketti
87e13ef800 Merge pull request #1836 from k9mail/multipart-digest-content-type
Properly handle multipart/digest content type
2016-12-09 00:18:59 +01:00
cketti
78b030a32c Hide unsigned text container in clearDisplayedContent() 2016-12-08 00:03:17 +01:00
Vincent Breitmoser
7bd85189ce add test for multipart/digest message 2016-12-07 00:23:28 +01:00
cketti
636098553d Hide "Unsigned Text" divider when support for signed-only messages is disabled 2016-12-05 19:05:56 +01:00
cketti
575d33c12f Extract string resource 2016-12-05 18:44:30 +01:00
cketti
0d3a24df2c Merge pull request #1824 from k9mail/fix-pgp-inline
Ignore leading whitespace for PGP/INLINE messages
2016-12-05 17:55:19 +01:00
cketti
1f9fc44f72 Fix JavaDoc 2016-12-02 17:04:13 +01:00
cketti
c7c21cb602 Avoid NPE by proper initialization instead of null check later on 2016-12-02 17:04:13 +01:00
Vincent Breitmoser
afb63d351b use PendingIntent from encapsulated result if available for showing key info 2016-11-30 18:35:08 +01:00
Vincent Breitmoser
422806f622 ignore leading whitespace for pgp/inline messages in MessageDecryptVerifier (fixes #1823) 2016-11-29 19:22:31 +01:00
Philip Whitehouse
f03a01f6dc BDD new lines 2016-11-27 02:16:15 +00:00
cketti
833adc732e Merge pull request #1806 from k9mail/openpgp-signature-result-enums
Update OpenPgpSignatureResult to use enums
2016-11-24 00:55:58 +01:00
Vincent Breitmoser
de13e10be1 update OpenPgpSignatureResult to use enums 2016-11-23 16:08:25 +01:00
Philip Whitehouse
6f82dea315 Testing for SettingsExporter 2016-11-22 01:52:57 +00:00
Philip Whitehouse
68b670e7d8 Testing for SettingsImporter 2016-11-22 01:24:41 +00:00
sedrubal
dab9f39ff6
Fix selection offset and cleanup
When selecting or opening a message (not a thread) there was an offset
of 1 selecting the message above. When selecting the first message, it
crashed. Now this seems to be fixed.
2016-11-20 17:41:35 +01:00
sedrubal
08daf2dffb
Replace Android-PullToRefresh with android.support SwipeRefreshLayout 2016-11-20 07:55:29 +01:00
cketti
4d61ca8f40 Version 5.115 2016-11-18 16:48:43 +01:00
Vincent Breitmoser
7daf639b75 whoops, forgot a backslash there 2016-11-16 15:09:29 +01:00
Vincent Breitmoser
be1dd1cc3a minor wording changes for CryptoSettingsDialog (related #1774) 2016-11-16 15:05:51 +01:00
Vincent Breitmoser
ef3cda97e2 remove support for clearsigned messages in PgpMessageBuilder 2016-11-14 18:56:26 +01:00
Vincent Breitmoser
0378f1a812 Prevent pgp/inline in sign-only mode and vice versa 2016-11-14 14:18:23 +01:00
Vincent Breitmoser
b72a3ce8a0 display sign-only as a special mode like pgp/inline 2016-11-14 13:56:15 +01:00
Vincent Breitmoser
3d434786af update layout and wording for sign-only mode 2016-11-14 13:55:46 +01:00
Vincent Breitmoser
640322d46d add "name" parameter to signature content-type header 2016-11-12 22:08:43 +01:00
Vincent Breitmoser
4e17fdf1a6 remove "always sign, encrypt if possible" mode of operation from PgpMessageBuilder 2016-11-12 21:53:02 +01:00
Vincent Breitmoser
6ae8845992 clean up some strings 2016-11-12 21:33:32 +01:00
Vincent Breitmoser
d40a046bf6 move sign-only into a mode of its own 2016-11-11 15:41:37 +01:00
Vincent Breitmoser
cedaecb38e Merge pull request #1769 from k9mail/attachment-ninjafix
use AttachmentTempFileProvider to expose file-backed content uris
2016-11-08 11:21:39 +01:00
cketti
bc41d9124e Merge pull request #1714
Added some more coverage to the MessageReferenceTest
2016-11-08 11:16:39 +01:00
cketti
5b0544cbab Clean up new tests 2016-11-08 11:13:57 +01:00
cketti
502bb6570f Don't use 'exit-early' pattern for non-error cases 2016-11-08 09:07:52 +01:00
cketti
47a5401ca7 Introduce local variable to make code easier to read 2016-11-08 09:07:52 +01:00
cketti
fbecc40d01 Use okio with AttachmentTempFileProvider 2016-11-08 09:07:52 +01:00
Vincent Breitmoser
75b2cafddc fix context menu for inline attachments 2016-11-03 13:57:19 +01:00
Vincent Breitmoser
be45380415 use AttachmentTempFileProvider to expose file-backed content uris 2016-11-03 13:57:19 +01:00
cketti
0617d4250f Merge pull request #1759 from k9mail/mch-fix-broken-signature-behavior
Improve behavior for broken signatures
2016-11-03 02:04:18 +01:00
cketti
59dcdf6b68 Merge pull request #1766 from k9mail/expert-signatures
Turn support for signed-only mails into an opt-in feature
2016-11-03 01:29:04 +01:00
Vincent Breitmoser
58eb9b52ca remove unused lastAutomaticCheckTime attribute from Account 2016-11-02 14:30:58 +01:00
Vincent Breitmoser
f5f3208b2d incorporate requested changes by cketti 2016-11-02 14:30:58 +01:00
Vincent Breitmoser
380fd94b22 some more tests for PgpMessageBuilder 2016-11-02 14:30:51 +01:00
Vincent Breitmoser
54c0ac6e7b disabled lock status icon is dark grey 2016-10-31 07:57:08 +01:00
Vincent Breitmoser
c7a637f21b don't sign in opportunistic mode if sign-only isn't supported 2016-10-31 07:57:08 +01:00
Vincent Breitmoser
98286fd7fb split off sign-only variant of CryptoSettingsDialog 2016-10-31 07:29:05 +01:00
cketti
d0b3caf976 Merge pull request #1755 from k9mail/GH-1741_notification_actions
Add notification actions to "stacked notifications"
2016-10-31 06:15:09 +01:00
Vincent Breitmoser
395f37ea1c add account setting to support unencrypted authentication 2016-10-31 04:30:14 +01:00
Vincent Breitmoser
7fe6a90396 clean up warnings in Account (no semantic changes) 2016-10-31 04:14:12 +01:00
Vincent Breitmoser
80d7ce4887 messageview: if OpenPGP-API throws on signature verification, don't treat data as undisplayable 2016-10-26 18:44:45 +02:00
Vincent Breitmoser
136ee8e34f fix possible NPE in message crypto helper 2016-10-26 17:37:38 +02:00
cketti
a434f37320 Add notification actions to "stacked notifications"
On Android 7.0 notifications that previously only showed on Android Wear
 devices are also displayed on the phone/tablet. To be able to use notification
 actions there and have a separate set of actions for Wear devices we need to
 do some extra work.
2016-10-25 14:58:14 +02:00
Jan Berkel
8b1c768483 Inject config from properties file 2016-10-19 12:35:28 +02:00
cketti
44b4984f97 Merge pull request #1717 from jonas-lundqvist/messagebrowse
Enable directional pads for next/previous message
2016-10-19 10:38:12 +02:00
cketti
ffd051b0ec Don't use same notification group key for all accounts 2016-10-18 06:21:25 +02:00
Jonas Lundqvist
c06721f977
Enable directional pads for next/previous message 2016-10-14 23:26:02 +02:00
cketti
067ba7930c Version 5.114 2016-10-13 20:24:16 +02:00
cketti
2bebb90d4c Update translations 2016-10-13 18:22:21 +02:00
Jonas Lundqvist
21df74f7f4
Added test for MessageReference.withModifiedFlag() 2016-10-12 23:45:59 +02:00
Jonas Lundqvist
6ab4c3b3e6
Added test for MessageReference.withModifiedUid() 2016-10-12 23:45:55 +02:00
Vincent Breitmoser
aaa904e075 When moving temporary files, try to copy if rename fails, and throw if that fails too (#1686)
Fixes #1243
2016-10-12 16:47:23 +02:00
cketti
2087f0476c Merge pull request #1691
Improve Activity operation text

Fixes #1685
2016-10-12 16:23:57 +02:00
cketti
e511b8b7c1 Further clean up of ActivityListenerTest
* \u0020 is a hack required to have spaces at the beginning of resource
  strings. But there's no need to replicate this inside our tests.
* Dependencies shouldn't be static finals.
* Initialization of dependencies is usually boring. I like to extract that
  code to methods and put them at the end of the file.
* Using different values for 'current progress' and 'total' has the
  advantage of breaking tests when the two accidentally get mixed up.
2016-10-12 16:18:23 +02:00
cketti
1415261fdd Merge pull request #1705 from k9mail/no-crypto-hide-recipient-dots
hide recipient dots if no crypto provider is configured
2016-10-12 15:53:16 +02:00
cketti
4eb7c41f61 Merge pull request #1703 from k9mail/compose-fix-indeterminate
compose: hide indeterminate progress bar after onCreate (fix for api level 15)
2016-10-12 15:51:16 +02:00
Jonas Lundqvist
2c81e11c1d
JavaDoc fix in LocalSearch
Minor JavaDoc fix to get rid of a warning.
2016-10-12 00:10:03 +02:00
cketti
0dfa6345b3 Merge pull request #1702 from k9mail/fix-old-api-npe
Avoid indirect call to invalidateOptionsMenu() before recipientPresenter is initialized
2016-10-11 18:52:29 +02:00
Vincent Breitmoser
9fb91a0afc use Compat classes to access deprecated methods 2016-10-11 14:44:09 +02:00
Vincent Breitmoser
89fe5d790e hide dots in recipient list if no crypto provider is configured 2016-10-11 14:44:09 +02:00
Vincent Breitmoser
dae6be34df fix NPE in MessageProvider 2016-10-11 13:55:25 +02:00
Vincent Breitmoser
76b2339b69 compose: hide indeterminate progress bar after initialization (fix for api level 15) 2016-10-11 12:22:53 +02:00
Vincent Breitmoser
a88ccfd9e8 avoid indirect call to invalidateOptionsMenu() before recipientPresenter is initialized 2016-10-11 11:42:20 +02:00
cketti
54bf6f7bd5 Merge pull request #1695 from jonas-lundqvist/backstackid
Save state for back stack id in MessageList
2016-10-11 03:54:40 +02:00
cketti
7a0bacff41 Merge pull request #1689 from k9mail/fix-line-endings-for-pgp-inline
convert LF newlines to CRLF before converting to quoted-printable for clearsigned messages
2016-10-11 03:30:58 +02:00
Jonas Lundqvist
dc876d9cc5
Save state for back stack id in MessageList 2016-10-09 13:32:17 +02:00
Philip Whitehouse
0fff2ffd08 Update to Robolectric 3.1.1 and tidy up code 2016-10-09 02:21:14 +01:00
Vincent Breitmoser
ce249bf07e convert LF newlines to CRLF in crypto provider output
OpenKeychain/BouncyCastle at this point use the system newline for
formatting, which is LF on android.  We need this to be CRLF, so we
convert the data after receiving (and possibly before quoted-printable
encoding).
2016-10-08 12:23:54 +02:00
cketti
fc79b290d0 Merge pull request #1692
Handle download of attachment correctly when saving requested

Fixes #1629
2016-10-08 11:00:26 +02:00
Philip Whitehouse
1f26663ed1 Handle download of attachment correctly when saving requested 2016-10-08 10:57:47 +02:00
cketti
327a47d2ef Merge pull request #1688 from k9mail/limit-pgp-inline-dialog-displays
Limit number of times the PGP/Inline info dialog is displayed

Fixes #1595
2016-10-08 02:35:54 +02:00
cketti
88eb0f663a Merge pull request #1687 from k9mail/fix-message-view-theme-switch
Don't cache decoded message over configurations

Fixes #1666
2016-10-08 01:18:16 +02:00
Philip
302b668d58 On removing notification, mark it's ID no longer in use (#1677)
On removing notification, mark it's ID no longer in use

Fixes #1662
2016-10-08 00:54:15 +02:00
Philip Whitehouse
4c7f80161e Change folder_progress to correctly expect a decimal number instead of a string 2016-10-07 23:15:10 +01:00
Philip Whitehouse
53f3d549f7 Set account name when syncing headers & use correct folder name to generate display name 2016-10-07 23:14:54 +01:00
Vincent Breitmoser
a8d4655e56 limit number of times the pgp inline info dialog is displayed (closes #1595) 2016-10-07 19:09:26 +02:00
Vincent Breitmoser
22e8f4cedb don't cache decoded message over configurations
Since 773600c717, the message decoding
process might actually depend on theming parameters.  The MessageList
activity assumes that the theme will be reapplied during a call to
`recreate()`, so we better drop that cache on configuration changes.
2016-10-07 18:43:33 +02:00
cketti
c7b5a50636 Merge pull request #1680 from philipwhiuk/GH-1597-activeNeverSign
Use a darker grey to highlight the Never Sign/Encrypt as active
2016-10-07 06:45:14 +02:00
cketti
dcb6890550 Merge pull request #1679 from philipwhiuk/GH-1598-updateCryptoModeOnProceed
Move update of crypto settings to submit button and add Cancel
2016-10-07 06:27:02 +02:00
cketti
91c0b4274b Clean up MessageBuilderTest 2016-10-07 05:40:20 +02:00
Philip Whitehouse
0f84953f94 Use a darker grey to highlight the Never Sign/Encrypt as active 2016-10-07 03:49:45 +01:00
Philip Whitehouse
5271977f76 Move update of crypto settings to submit button and add Cancel 2016-10-07 03:23:58 +01:00
Philip Whitehouse
0cd52bc26b Use the correct order for alternatives when building HTML messages
Fixes #1625
2016-10-07 01:09:31 +01:00
cketti
dbb6cc4d88 Version 5.113 2016-10-06 19:13:30 +02:00
cketti
b6dcb72c7a Fix dark theme 2016-10-05 16:47:25 +02:00
cketti
59cbdcc559 Version 5.112 2016-10-05 14:03:43 +02:00
cketti
c905b303d6 Merge pull request #1617 from helmo/update-tld-str
Update TOP_LEVEL_DOMAIN_STR_FOR_WEB_URL to match more new TLDs
2016-10-05 13:33:47 +02:00
cketti
5c0a7f6d95 Merge pull request #1613 from k9mail/GH-1604_message_format_fix
Use correct message format when replying
2016-10-05 13:23:45 +02:00
cketti
5f7bc080f9 Make code more readable 2016-10-04 12:29:54 +02:00
Herman van Rink
8f8188cba5 Update TOP_LEVEL_DOMAIN_STR_FOR_WEB_URL to match more new TLDs
new regex produced by https://github.com/irccloud/android/blob/master/make-iana-tld-pattern.py cbe04ae
2016-09-18 16:18:36 +02:00
Jacco
9065b9fb66 Added provider settings for Ziggo and Virgin Media
We (Liberty Global) would like to extend the automatic configuration support with settings for Ziggo (The Netherlands) and Virgin Media (UK). You can validate these settings at:

https://www.ziggo.nl/klantenservice/internet/e-mail/imap/

http://help.virginmedia.com/system/selfservice.controller?CONFIGURATION=1001&PARTITION_ID=1&TIMEZONE_OFFSET=&USERTYPE=1&VM_CUSTOMER_TYPE=Cable&CMD=VIEW_ARTICLE&ARTICLE_ID=2743
2016-09-14 16:59:28 +02:00
cketti
97960ec57c Update message format when enabling/disabling PGP/INLINE 2016-09-13 06:23:06 +02:00
cketti
4430abaf30 Don't force plain text when PGP/INLINE is not enabled 2016-09-13 05:38:20 +02:00
cketti
78d3b011e6 Merge pull request #1612 from k9mail/update_provider_settings
Update server settings for Comcast
2016-09-13 05:35:29 +02:00
cketti
521c9129a5 Merge pull request #1608
Don't try to show invalid mail addresses in recipient selector

Fixes #1607
2016-09-13 04:16:45 +02:00
cketti
e40bac35a8 Fix indentation 2016-09-13 03:55:50 +02:00