Commit graph

1625 commits

Author SHA1 Message Date
Vincent Breitmoser
06b0f7d851 Merge pull request #2472 from devRohanGarg/master
Issue #1857 : Fix bcc field hidden in drafts
2017-04-02 17:54:00 +02:00
Rohan Garg
3552ed40a6 Issue #1857 : Fix bcc field hidden in drafts 2017-04-01 00:47:47 +05:30
Vincent Breitmoser
b461ce4092 Merge pull request #2464 from k9mail/fix_timber_args
Clean up Timber string format arguments
2017-03-31 12:21:19 +02:00
cketti
52f3007f3e Clean up Timber string format arguments 2017-03-30 20:15:59 +02:00
Vincent Breitmoser
60f378b58f fix prefilled name in RecipientLoader 2017-03-30 15:28:03 +02:00
Vincent Breitmoser
62df90d13b Merge pull request #2449 from k9mail/root-classes-cleanup
Root classes cleanup
2017-03-30 13:20:49 +02:00
Jacco de Leeuw
1752932656 Virgin Media now recommends a single set of email server settings for all four domains.
See:
https://help.virginmedia.com/system/templates/selfservice/vm/help/customer/locale/en-GB/portal/200300000001000/article/HELP-2203/Email-Settings-for-all-Virgin-Media-domains
http://community.virginmedia.com/t5/Email/Email-settings-change/m-p/3369438
2017-03-28 22:04:20 +02:00
Philip
879aa72bb6 Merge pull request #2455 from philipwhiuk/issue-2271
Fixes to various lint-detected issues
2017-03-28 02:16:15 +01:00
joelowj
7e29a7eac3 Fixes to various lint-detected issues 2017-03-28 02:08:21 +01:00
Philip
f04421f105 Merge pull request #2454 from philipwhiuk/xoriginalto
Auto select identity based X-Original-To / Delivered-To / X-Envelope-To / TO / CC
2017-03-28 02:01:10 +01:00
yesalam
06e5f790bb Auto select identity based on X-Original-To / Delivered-To / X-Envelope-To / TO / CC 2017-03-28 01:53:15 +01:00
Philip
55401ef7a9 Merge pull request #2453 from philipwhiuk/fix2323
Change title and explanation for read message colour change
2017-03-28 01:49:02 +01:00
Subhaprada Chand
aa80465a69 Change title and explanation for read message colour change
Fixes issue #1232
2017-03-28 01:47:13 +01:00
Vincent Breitmoser
b1edd02c08 clean up Throttle 2017-03-27 15:58:49 +02:00
Vincent Breitmoser
910ee75798 clean up Preferences 2017-03-27 15:57:59 +02:00
Vincent Breitmoser
f67a5f53a6 clean up AccountSettings 2017-03-27 15:57:59 +02:00
Vincent Breitmoser
3bb3a5bdbd clean up NotificationSetting 2017-03-27 15:57:59 +02:00
Vincent Breitmoser
dd5a0cce98 rename some more fields and reduce comment spam 2017-03-27 15:57:59 +02:00
Vincent Breitmoser
ac6221f4fa rename fields in Account 2017-03-27 15:57:59 +02:00
Vincent Breitmoser
437764ad5c Merge pull request #2264 from daquexian/issue_2240
search nicknames (issue 2240)
2017-03-27 07:32:57 +02:00
Vincent Breitmoser
b5cf015ed8 Merge pull request #2315 from daquexian/issue_2057
Load all contact pictures by Glide
2017-03-27 07:28:39 +02:00
cketti
6520f3ac61 Merge pull request #2322 from philipwhiuk/fix1418
Display subject correctly in expanded notifications
2017-03-26 22:37:57 +02:00
cketti
e601cb2fa2 Merge pull request #2444 from ndew623/Hide-Timezone-in-Reply-Quote
Use UTC time in quote header

Fixes #2403
2017-03-26 22:33:13 +02:00
cketti
756863c731 Cleanup 2017-03-26 22:23:23 +02:00
ndew623
b1f9b9ac6c Changed string in options to say "reply header" instead of "reply quotes". Normalized locale in reply header when Hide timezone option is selected. 2017-03-26 13:52:12 -05:00
cketti
ba21aaf412 Merge pull request #2352 from YESALAM/2237
Support "delSp" for format=flowed 

Fixes issue #2237
2017-03-26 06:00:43 +02:00
yesalam
dbc614769a Support "delSp" for format=flowed #2237 2017-03-26 05:37:26 +02:00
cketti
3cd7e26bb9 Merge pull request #2423 from k9mail/timberLibrary
Move k9mail-library to Timber
2017-03-26 05:29:03 +02:00
ndew623
aac3b69c4f UTC time in quotes (Issue #2403)
Before, the time in the quoted message of a reply was always in the
local timezone, even when the "Hide timezone" setting was selected. Now,
when the option is enabled, that is changed to UTC just like the time in
headers. I also changed the description for the option in the English
strings.xml to better describe the new different behavior.
2017-03-25 14:51:40 -05:00
daquexian
2cd31048ac Load all contact pictures by Glide, and fix the wrong getPhotoUri method 2017-03-25 07:56:40 +08:00
Allan Wang
d1eef1485e close AccountSetup activity immediately after cancellation, fixes #2425 2017-03-22 23:15:16 -04:00
daquexian
0881b2457b search nicknames 2017-03-23 01:06:00 +08:00
Philip Whitehouse
878fdc0a79 Timber library p1 2017-03-22 16:33:07 +01:00
cketti
cf02795d5e Merge pull request #2389 from vatsalsura/Issue#2318
Use SystremClock.elapsedRealtime() to measure durations
2017-03-22 05:41:18 +01:00
cketti
32212a4e23 Merge pull request #2392 from itiboi/generic-uri-parsing
Linkifying framework
2017-03-22 02:22:04 +01:00
Tim Bolender
b0682018e2 Fixed invalid domain character and some restructuring. 2017-03-21 22:49:52 +01:00
Tim Bolender
9d3cc8ed00 Switched to "classic" domain name detection and added multiple tests. 2017-03-21 12:01:04 +01:00
cketti
cf9c3d078e Use regexp to skip schema matches not preceded by allowed separator 2017-03-17 15:28:51 +01:00
cketti
98974a7699 Fix bug with advancing the position when linkifying failed 2017-03-17 15:19:16 +01:00
Philip Whitehouse
4eb431b170 Remove emphasised span entirely 2017-03-17 13:57:38 +00:00
Philip Whitehouse
44b42747f4 Display subject correctly in expanded notifications 2017-03-17 13:55:17 +00:00
Philip
0763b09c83 Merge pull request #2347 from philipwhiuk/tidyUpMessageListFragment
Tidying up MessageListFragment
2017-03-17 13:36:49 +00:00
Philip Whitehouse
77860a4f7c Tidy up MessageListFragment 2017-03-17 13:26:30 +00:00
Philip Whitehouse
c9d5a776fe Adjust long Privacy settings 2017-03-17 10:29:47 +00:00
cketti
0f9bc4867a Clean up URI parsing code and tests 2017-03-17 03:18:51 +01:00
Tim Bolender
0d3d9aab32 Add one pass URI parser/linkifier 2017-03-16 22:10:47 +01:00
Vatsal Sura
ede2b0fb17 Use SystemClock.elapsedRealtime() to measure durations 2017-03-15 13:05:23 +05:30
cketti
9b49f08b60 Merge pull request #2387 from ployt0/HtmlConverterTestForHR
Make <hr> tags from their plain text equivalents

Fixes #2259
2017-03-15 05:16:24 +01:00
cketti
6a318bdc6a Merge pull request #2382 from k9mail/saf_exporter
Use Storage Access Framework for settings export
2017-03-15 05:08:00 +01:00
cketti
b901b81882 Merge pull request #2380 from k9mail/GH-2282_fix_crash_with_old_intent_extra
Continue to support old 'search' extra in MessageList Intent
2017-03-14 14:21:07 +01:00
leon
24f4f86755 Make <hr> tags from their plain text equivalents. #2259 including tests. 2017-03-13 11:48:18 +00:00
cketti
5fa77adfcb Fix settings export on API 19+ 2017-03-12 19:29:17 +01:00
GoneUp
17ebb4c613 Changed settings export to use the storage access framework 2017-03-12 17:16:59 +01:00
cketti
0252db0992 Add "SNAPSHOT" suffix to version number
Some people build from master and report bugs with the version number found
in the About dialog. This change should make it easier to identify such cases.
2017-03-11 22:23:36 +01:00
cketti
5485f7a1bb Continue to support old unread widget PendingIntents 2017-03-11 21:00:39 +01:00
Daniel Wainwright
7867f37a16 Fix boolean format error
considerLastCheckEnd is a boolean.
2017-03-05 18:18:20 +00:00
Sergei Novikov
b811bd6048 Add 'up' button to message composition screen 2017-03-04 09:43:28 +01:00
Vincent Breitmoser
05df114eb1 Merge pull request #2309 from k9mail/log-timber
Use Timber for Logging
2017-03-03 14:04:20 +01:00
Subhaprada Chand
0b2c2e4692 Replace instances of new Date().getTime() with System.currentTimeMillis() 2017-03-03 05:25:22 +05:30
Vincent Breitmoser
05bd6e0a5b plant DebugTree if K9.DEBUG || BuildConfig.DEBUG 2017-03-02 20:15:00 +01:00
cketti
021b24c93f Remove conditional logging from call sites 2017-03-02 19:43:33 +01:00
cketti
eb61829003 Use format strings with Timber 2017-03-02 19:42:20 +01:00
Vincent Breitmoser
b49e699d92 plant DebugTree in K9.onCreate() 2017-03-02 19:42:20 +01:00
Vincent Breitmoser
7309132659 remove accidental static imports 2017-03-02 19:42:20 +01:00
Vincent Breitmoser
ff274e2978 use Timber for logging 2017-03-02 19:42:19 +01:00
cketti
88a86a14c3 Merge pull request #2304 from k9mail/GH-2262_remove_language_selection
Remove language selection setting
2017-03-02 02:05:17 +01:00
cketti
b99b539c20 Merge pull request #2306
Add provider settings for mail.com

Closes #2306
2017-03-02 01:38:20 +01:00
leon
7af7d8a3d7 Add provider provider settings for mail.com 2017-03-02 01:37:35 +01:00
cketti
5816f84df0 Remove language selection setting 2017-03-01 16:58:36 +01:00
cketti
82f3c67ff0 Remove MessagingListener methods that are never used 2017-02-28 14:46:24 +01:00
cketti
93aaa85c14 Make MessagingListener an interface 2017-02-28 14:36:26 +01:00
cketti
d4d796010c Merge pull request #2281 from k9mail/GH-2280_fix_settings_configuration
Update existing Configuration instance instead of creating new one
2017-02-28 12:17:59 +01:00
cketti
9d079bd5b1 Merge pull request #2276 from rhari991/attachment-diskfull
Show error toast when trying to save attachment and external storage is full
2017-02-28 12:14:58 +01:00
cketti
206e168a78 Merge pull request #2275 from k9mail/madrat--CustomContactBadge
Replace QuickContactBadge with custom widget
2017-02-28 12:13:33 +01:00
Hari
f3dcb729a7 Added sender field to message view 2017-02-28 12:06:23 +01:00
cketti
0a473e481b Merge pull request #1815 from philipwhiuk/syncDetail
Provide a better explanation as to why sync is disabled
2017-02-28 08:11:24 +01:00
Vincent Breitmoser
ec7e24767b incorporate feedback 2017-02-27 14:33:46 +01:00
cketti
212ee91422 Update existing Configuration instance instead of creating new one 2017-02-25 16:25:21 +01:00
Hari
f4e84c302b Show toast when there is not enough space 2017-02-24 11:45:45 +05:30
Vincent Breitmoser
110179deb5 remove more unused code 2017-02-23 13:25:10 +01:00
Philip Whitehouse
b54f6ee11b Provide a better explanation as to why sync is disabled 2017-02-23 12:14:56 +00:00
Vincent Breitmoser
e18466c290 code reformatting 2017-02-23 13:13:40 +01:00
madRat
923d91b012 Replace QuickContactBadge with custom widget 2017-02-23 13:10:56 +01:00
cketti
e70295efec Merge pull request #2220 from k9mail/no-provider
Handle unconfigured OpenPGP provider in MessageView
2017-02-20 00:43:18 +01:00
cketti
0a3a91436e Incorporate feedback 2017-02-17 22:49:50 +01:00
cketti
fb5fb2553b Update message list widget preview image 2017-02-17 21:39:16 +01:00
cketti
81a8b3fc3b Tweak message list item layout 2017-02-17 21:15:21 +01:00
cketti
cb52a6f4f6 Rename message list widget classes 2017-02-17 19:39:53 +01:00
cketti
303be49889 Make message list widget start activities directly 2017-02-17 19:39:53 +01:00
cketti
ef9275d084 Extract message list widget text colors to colors.xml 2017-02-17 19:39:53 +01:00
cketti
e201478f43 Extract string to strings.xml 2017-02-17 19:39:53 +01:00
cketti
13922f0ae6 Clean up code 2017-02-17 19:39:53 +01:00
cketti
800bfead67 Display sender and subject of unread messages in bold 2017-02-17 19:39:53 +01:00
cketti
cffe255dc8 Honor "sender above subject" setting in message list widget 2017-02-17 19:39:53 +01:00
cketti
50c382c779 Tweak message list widget layout 2017-02-17 19:39:53 +01:00
cketti
27ec98b1d0 Remove configuration for mail list widget
Right now MessageProvider only supports the Unified Inbox.
2017-02-17 19:39:53 +01:00
cketti
57612c317e Code style fixes 2017-02-17 19:39:53 +01:00
denis mone
6415f0c186 Add mail list widget 2017-02-17 19:39:53 +01:00
cketti
fc90a8eadb Merge pull request #2234 from philipwhiuk/testSendPendingMessages
MessagingController improvements
2017-02-17 16:18:48 +01:00
Philip Whitehouse
e852b975ad Move operator 2017-02-16 23:23:34 +00:00
Philip Whitehouse
0ac1d3f4cf Re-format MessagingController 2017-02-16 23:22:32 +00:00
Philip Whitehouse
c45251f66e Rename getInstance() to getTransport() 2017-02-16 23:17:30 +00:00
cketti
2ac9de8c4e Merge pull request #2221 from philipwhiuk/testAndFixCPLforSurrogatePairs
Test and fix CPL for surrogate pairs
2017-02-14 23:45:05 +01:00
cketti
99472ce26e Merge pull request #2226 from RobinBossart/issue_2213
Make all keys in global_preferences.xml lowercase
2017-02-14 23:41:43 +01:00
Robin Bossart
82b6f457c9 Make all keys in global_preferences.xml and Prefs.java lowercase 2017-02-14 15:21:22 +01:00
Philip Whitehouse
b97cbba320 Tidy-up MessagingController - checkstyle fixes 2017-02-14 00:28:29 +00:00
Philip Whitehouse
2e01043a28 Test sending of pending messages 2017-02-13 23:52:31 +00:00
Philip Whitehouse
3d2345cae3 Add support for surrogate pairs when getting the icon for the contact picture 2017-02-13 20:15:33 +00:00
Vincent Breitmoser
ae55c85612 show crypto pref screen on click 2017-02-13 15:32:50 +01:00
Vincent Breitmoser
e2186058bc add screen to display when no crypto provider is configured 2017-02-13 15:32:50 +01:00
cketti
8ee9b2c591 Merge pull request #2203 from philipwhiuk/clearFolderNotOnUiThread
Clear folder using the MessagingController instead of on the UI thread
2017-02-13 03:50:10 +01:00
Philip Whitehouse
4161b91441 Tidy up and test clearFolder method 2017-02-12 22:42:41 +00:00
cketti
c150bafac3 Merge pull request #2223 from daquexian/issue_979
Dismiss alternate email address popup on typing
2017-02-12 19:44:55 +01:00
cketti
d3b4809e5b Merge pull request #2219 from korelstar/test-sql-create
Enhance test for database upgrade process
2017-02-12 13:11:33 +01:00
cketti
ac6a1ea213 Clean up StoreSchemaDefinitionTest 2017-02-12 12:42:12 +01:00
korelstar
83951c087e Refactoring: Make code more readable. 2017-02-12 11:35:26 +01:00
cketti
0387b253ba Merge pull request #2130 from k9mail/global-crypto-provider
Global crypto provider
2017-02-10 06:15:04 +01:00
cketti
cbbab8b920 Merge pull request #2218 from JoelTroch/issue-2208
Make Hex.encodeHex returns a String (was char[])
2017-02-10 06:12:00 +01:00
daquexian
7617269a2c dismiss alternate email address popup on typing 2017-02-10 11:25:20 +08:00
Philip
5104278c70 Merge pull request #2176 from philipwhiuk/messageProviderFixAndTest
MessageProvider related fixes and testing
2017-02-10 00:01:49 +00:00
Philip
1be97b85f3 Merge pull request #2217 from daquexian/issue_740
Allow any unicode letter to act as a placeholder for contacts with no photo.
2017-02-09 23:36:51 +00:00
Philip
fc6d5188f7 Merge pull request #2206 from k9mail/fix-cancel-crypto
Fix consecutive retrying of crypto operations
2017-02-09 23:28:39 +00:00
korelstar
44e9960dc6 Fix missing default value in table "folders" 2017-02-09 16:14:09 +01:00
Joël Troch
7d628cf719 Make Hex.encodeHex returns a String (was char[]) 2017-02-09 14:54:27 +01:00
korelstar
d084fdbc11 Test for equal SQL create queries 2017-02-09 12:39:23 +01:00
daquexian
a978fd0f40 capture all unicode letters for unknown contact picture 2017-02-09 18:03:43 +08:00
Vincent Breitmoser
884b12a48b consistently name openpgp provider setting 2017-02-08 13:16:10 +01:00
Vincent Breitmoser
6e982690d2 move sign-only support settings to global 2017-02-08 03:56:01 +01:00
Vincent Breitmoser
46046f8926 openpgp-setup: move crypto provider to global settings 2017-02-08 03:56:01 +01:00
Vincent Breitmoser
955d994bce never return cleared RetainFragments 2017-02-08 03:16:12 +01:00
Vincent Breitmoser
01df652dc7 don't create superfluous RetainFragments 2017-02-08 03:16:12 +01:00
Philip Whitehouse
6ebe298fa0 Clear folder using the MessagingController instead of on the UI thread 2017-02-07 21:37:21 +00:00
cketti
47a5b5288f Avoid NULL values in result set of sub-query 2017-02-07 21:12:05 +01:00
cketti
19b7d4491d Merge pull request #2193 from k9mail/robolectric-update
Update robolectric, use Runner class instead of annotations
2017-02-07 05:06:39 +01:00
cketti
4c8dd420cf Merge pull request #2194 from philipwhiuk/removeNewLinesFromSubject
Remove trailing new lines from subject
2017-02-07 04:54:14 +01:00
cketti
17863cfeaf Merge pull request #2196 from k9mail/rework_AttachmentInfoExtractor
Avoid static reference to AttachmentInfoExtractor
2017-02-07 04:23:22 +01:00
cketti
7aa784f16d Merge pull request #2195 from k9mail/rework_ClipboardManager
Rework ClipboardManager to avoid leaking Context
2017-02-07 04:23:01 +01:00
Philip Whitehouse
be67e849c2 Remove new lines and rich-text formatting from subject field 2017-02-06 21:38:18 +00:00
cketti
5d52fb0bb7 Merge pull request #2198 from bug-bulletin-forks/fix-parsing-errors
Fix two unparsable Javadoc comments
2017-02-06 14:49:51 +01:00
Dominik Schürmann
e829196034 Set robolectric sdk to 22 2017-02-06 11:25:02 +01:00
Sebastian Kürten
f4b3ef3b41 Fix a few Javadoc typos 2017-02-06 08:48:24 +01:00
Sebastian Kürten
fca9eaf113 Fix two unparsable Javadoc comments 2017-02-06 08:16:04 +01:00
cketti
e96718f3a0 Avoid static reference to AttachmentInfoExtractor 2017-02-06 03:55:31 +01:00
cketti
15b6a91914 Clean up ClipboardManager 2017-02-06 03:30:34 +01:00
cketti
f82beb4287 Change ClipboardManager to no longer be a singleton
This avoids holding onto a Context instance in a static field.
2017-02-06 03:28:09 +01:00
cketti
da2012be1d Merge pull request #2186 from philipwhiuk/json-pending-command-rebase
Use json for serializing pending commands
2017-02-06 02:04:57 +01:00
cketti
78c7f01719 Clean up MigrationTo60Test 2017-02-06 01:41:03 +01:00
Dominik Schürmann
874943885f Update robolectric, use Runner classes 2017-02-05 23:44:35 +01:00
Dominik Schürmann
513a29ad3a Add encrypted.asc filename to PGP/MIME emails 2017-02-05 23:13:18 +01:00
Philip Whitehouse
af0c47c325 Additional tests for migration 2017-02-05 21:25:50 +00:00
cketti
5d2e28e8ed Avoid runtime type checks/casts 2017-02-05 07:13:25 +01:00
cketti
8179d88113 Clean up MigrationTo60 2017-02-05 06:05:28 +01:00
Philip Whitehouse
a2e33fcc23 Merge branch 'upstream-master' into json-pending-command-rebase 2017-02-05 01:21:36 +00:00
cketti
1c1be7ff8e Merge pull request #2178 from philipwhiuk/fixArrayResourceLintWarning
SliderPreference - Fix lint warning
2017-02-05 01:40:44 +01:00
cketti
8c55e571f8 Merge pull request #2169 from k9mail/GH-1822_remove_parcelable_from_intent
Fix notification actions
2017-02-05 01:39:11 +01:00
Philip
f491e00bc5 Merge pull request #2158 from philipwhiuk/databaseMigrationVerification
Test and fix database upgrade process
2017-02-04 23:36:27 +00:00
Philip
b79673bf6f Merge pull request #2174 from philipwhiuk/addDebugToMessagingController
Add additional debug to diagnose message sync issues
2017-02-04 23:25:22 +00:00
Philip
4564f57f01 Merge pull request #2182 from philipwhiuk/fixHardcodedText
Move hardcoded text to string resources
2017-02-04 23:25:02 +00:00
Philip
7aa4462115 Merge pull request #2184 from philipwhiuk/abstractK9Activity
Make base activities abstract
2017-02-04 23:24:12 +00:00
Philip
d5a6286cb7 Merge pull request #2172 from philipwhiuk/emailHelperTest
Tests for EmailHelper
2017-02-04 22:49:35 +00:00
Philip
981ef44b55 Merge pull request #2171 from philipwhiuk/openPgpApiHelperTest
Tests for OpenPgpApiHelper
2017-02-04 22:49:10 +00:00
Philip
929f91ab56 Merge pull request #2170 from philipwhiuk/cacheTests
Basic behavioural tests of the EmailProviderCache
2017-02-04 22:48:51 +00:00
cketti
2d84b41e5c Merge pull request #2159 from k9mail/jsoup_preparation
Code refactoring in preparation of HtmlCleaner replacement
2017-02-04 23:36:26 +01:00
Philip Whitehouse
5efe6b2cf7 Make base activities abstract 2017-02-04 22:04:32 +00:00
cketti
a52e0bd60a Avoid exception in MigrationTo43 during database tests 2017-02-04 22:50:06 +01:00
cketti
c3b4e0cfc2 Clean up StoreSchemaDefinitionTest 2017-02-04 22:34:31 +01:00
Philip Whitehouse
b7ed3b9d88 Move hardcoded text to string resources 2017-02-04 21:21:19 +00:00
cketti
4805af02bf Code style fixes 2017-02-04 21:43:25 +01:00
Philip Whitehouse
4cd7fd6e47 MessageProviderTest - Clean up cursor usage 2017-02-04 18:01:27 +00:00
Philip Whitehouse
76b9860e09 SliderPreference - Fix lint warning 2017-02-04 17:56:24 +00:00
Philip Whitehouse
859db0ce10 MessageProvider - Test basic behaviour 2017-02-04 15:56:42 +00:00
Philip Whitehouse
15f199de36 MessageProvider - Refactor declaration of projections and ensure accounts are listed in unread queries 2017-02-04 15:56:14 +00:00
Philip Whitehouse
07416badc8 Fix issue performing searches when a special folder is null 2017-02-04 15:55:02 +00:00
Philip Whitehouse
8512b23633 Update Espresso-Core test library to v2.2.2 2017-02-04 15:54:01 +00:00
Philip Whitehouse
8e06956d98 Tests for OpenPgpApiHelper 2017-02-04 11:21:15 +00:00
Philip Whitehouse
67e304a42a Add additional debug to diagnose message sync issues 2017-02-04 11:06:45 +00:00
cketti
0a76ea609c Simplify MessageReference.equals() and hashCode() and add tests 2017-02-04 02:03:18 +01:00
Philip Whitehouse
0b9fb4c2ad Tests for EmailHelper 2017-02-04 00:25:22 +00:00
Philip Whitehouse
39804b8e3c Basic behavioural tests of the EmailProviderCache 2017-02-03 23:41:05 +00:00
cketti
957b618092 Don't use Parcelable in Intents that can be launched from notifications 2017-02-03 06:05:45 +01:00
cketti
9b7ed6e9a6 Make MessageReference not implement Parcelable anymore 2017-02-03 06:00:36 +01:00
cketti
8760849f79 Refactor MessageReference 2017-02-03 03:12:32 +01:00
cketti
7fd404c1dd Remove unused method 2017-02-02 20:56:01 +01:00
cketti
f1457d58f6 Remove unused imports 2017-02-02 19:37:28 +01:00
cketti
3380ea986e Fix order of modifiers 2017-02-02 19:36:38 +01:00
cketti
c60f97fb7e Merge pull request #2069 from k9mail/optimize-message-sync
Don't load all local message metadata into memory during synchronize
2017-01-31 20:24:53 +01:00
cketti
e8cddf6a28 Remove unnecessary import 2017-01-31 17:29:28 +01:00
Philip Whitehouse
4a8d93b572 Add missing indexes in new database migration step 2017-01-31 12:51:47 +00:00
cketti
1ffaf1d392 Move classes related to message quoting to dedicated package 2017-01-31 05:58:24 +01:00
cketti
695432f6cf Add tests for signature removers 2017-01-31 05:58:24 +01:00
Philip Whitehouse
0c5fedb504 Add tests for database migration 2017-01-30 23:49:44 +00:00
Philip Whitehouse
67ade96101 Better determination of whether a draft needs saving 2017-01-30 21:22:07 +00:00
cketti
fc0e83cca2 Extract code to remove a message signature 2017-01-30 03:32:03 +01:00
cketti
d5194a1c34 Extract BodyTextExtractor from QuotedMessageHelper 2017-01-29 23:19:43 +01:00
cketti
2c04f66346 Move HTML-related classes to 'html' package 2017-01-29 23:04:36 +01:00
cketti
f228abd348 Avoid NullPointerException and creation of Date instances 2017-01-29 20:43:14 +01:00
Vincent Breitmoser
79c65d4cff don't load all local message metadata into memory during synchronize 2017-01-27 19:33:17 +01:00
cketti
2f14e6fcbc Reorder methods 2017-01-26 21:21:49 +01:00
cketti
646893f5fb Clean up MessageProvider 2017-01-26 21:16:41 +01:00
cketti
2825f88520 Code style fixes 2017-01-26 21:02:07 +01:00
cketti
86ca14558b Remove unused parameter 2017-01-26 20:29:40 +01:00
cketti
0d4d39acaa Code style fixes 2017-01-26 20:27:38 +01:00
cketti
a357963d32 Code style fixes 2017-01-26 19:45:32 +01:00
cketti
9180c2c1e3 Clean up switch statements 2017-01-26 19:45:32 +01:00
cketti
417f273bac Remove unused parameters 2017-01-26 19:45:32 +01:00
Vincent Breitmoser
7a39e7c48b clean up compose and related classes (no semantic changes) 2017-01-26 19:45:32 +01:00
Vincent Breitmoser
a77a632b72 Display warning on encrypted-only messages 2017-01-26 18:01:02 +01:00
cketti
9e102a571b Merge pull request #2137 from k9mail/GH-2103_fix_database_trigger
Add database migration to clean up orphaned data
2017-01-26 14:41:14 +01:00
cketti
4b83da75ee Merge pull request #2068 from k9mail/fix-alternate-selection
Fix broken referencing of recipient token in RecipientSelectView
2017-01-26 10:38:37 +01:00
cketti
c478f64a13 Merge pull request #2126 from philipwhiuk/notificationCategory
Set appropriate categories for notifications
2017-01-26 10:31:55 +01:00
Philip Whitehouse
65c4f86105 Set appropriate categories for notifications 2017-01-26 00:30:42 +00:00
Vincent Breitmoser
7bf9d7ec08 Merge pull request #2131 from k9mail/settings-cleanup
Settings classes cleanup
2017-01-25 17:36:35 +01:00
cketti
bf881cd3c2 Merge pull request #2124 from philipwhiuk/summaryNotificationFix
Fix behavior of summary notifications
2017-01-25 16:25:27 +01:00
cketti
9254e7a052 Add database migration to clean up orphaned data
Also extend database trigger to remove entries from messages_fulltext.
2017-01-25 16:11:44 +01:00
cketti
1697be33fa Remove mostly useless JavaDoc comments 2017-01-25 00:04:18 +01:00
cketti
38a19dbd28 Reformat code 2017-01-24 23:52:03 +01:00
cketti
24a4e3a4fb Fix typo 2017-01-24 23:43:49 +01:00
cketti
23603278ea Remove 'm' prefix from fields 2017-01-24 23:41:28 +01:00
cketti
62acbfcd81 Use T as type parameter name 2017-01-24 23:11:08 +01:00
cketti
2710fd3d8d Remove unnecessary line breaks 2017-01-24 23:00:53 +01:00
Vincent Breitmoser
f5b8a56c8a add non-null assertion to Settings.upgrade 2017-01-24 19:47:18 +01:00
Vincent Breitmoser
7e1482636d clean up SettingsImporter 2017-01-24 19:47:18 +01:00
Vincent Breitmoser
2583a5336b clean up SettingsExporter 2017-01-24 19:17:47 +01:00
Vincent Breitmoser
a9a69a031e break down Settings.upgrade method into submethods 2017-01-24 19:17:47 +01:00
Vincent Breitmoser
045fd63760 clean up more warnings (no semantic changes) 2017-01-24 16:46:53 +01:00
Vincent Breitmoser
cad7da10d6 use generics for all SettingsDescription subclasses 2017-01-24 16:45:32 +01:00
Vincent Breitmoser
a6dfa14af2 refactor settings (no semantic changes) 2017-01-24 15:42:22 +01:00
Vincent Breitmoser
434cd7735a add missing pgpSignOnlyDialogCounter to GlobalSettings 2017-01-24 13:39:04 +01:00
Vincent Breitmoser
48e3b4293e fix broken referencing of recipient token in RecipientSelectView
Passing through the actual recipient object was broken in
a2674efff1. I changed the code to no
longer rely on the actual object being passed through correctly, but
just one that fulfills `equals`.
2017-01-24 13:06:49 +01:00
Vincent Breitmoser
a14cd9f0e0 Merge pull request #2047 from k9mail/apg-deprecation-warning
show warning about APG being deprecated if still selected
2017-01-24 11:55:47 +01:00
cketti
330aef8577 Fix dialog handling 2017-01-24 07:14:54 +01:00
Philip Whitehouse
4ae85ddd38 Fix behaviour of summary notifications 2017-01-23 22:03:13 +00:00
Vincent Breitmoser
e49bfec2d4 other way to prevent activity leak in apg deprecation dialog 2017-01-23 14:05:22 +01:00
Vincent Breitmoser
407d6d7ec9 incorporate feedback 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
485029c5c2 get rid of magic and inline strings 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
ce6f080e83 dismiss apg deprecation dialog on pause, to avoid potential memory leak 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
164f38c5b0 display apg in list of choices, show warning dialog when selected 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
152d1cd2c1 change link to point to blog post 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
3adc981e51 extract method for making links clickable 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
9f51ab627e show warning about APG being deprecated if still selected 2017-01-23 13:18:44 +01:00
Philip
0dd7a4aafe Merge pull request #2118 from philipwhiuk/handleInvalidHtmlBetter
Handle invalid HTML better
2017-01-22 20:40:22 +00:00
Philip Whitehouse
b15636a3ca Tidying up existing HtmlSanitizer tests to use standard style 2017-01-22 19:50:45 +00:00
Philip Whitehouse
5301639045 Handle invalid HTML better 2017-01-22 19:50:30 +00:00
cketti
cf15e8a2c5 Merge pull request #2104 from philipwhiuk/fixFetchNull
Fix 'Fetching headers null:Folder'
2017-01-22 04:56:11 +01:00
Philip Whitehouse
21a684b243 Update labels used for application permissions - shown to the end user in later versions of Android 2017-01-21 20:42:08 +00:00
Philip Whitehouse
0383fbe4fa Fix 'Fetching headers null:Folder' 2017-01-21 15:28:05 +00:00
Philip Whitehouse
b77dfa0004 Don't bother handling an intent if we're finishing anyway 2017-01-21 04:01:35 +01:00
Vincent Breitmoser
c94804df26 use CHILD_PART_CONTAINS_DATA as data location for multipart (fixes #1899) 2017-01-19 16:18:30 +01:00
Vincent Breitmoser
c2cf9c8772 fix NPE introduced in #2036 2017-01-19 16:03:06 +01:00
cketti
dbc62e38f5 Merge pull request #2082 from bertob/material-icon
Replace icon with new material design icon
2017-01-19 13:12:28 +01:00
Tobias Bernard
e00cc9f629 revert to old k9small icon 2017-01-18 18:22:19 +01:00
cketti
4b745ca62e Merge pull request #2084 from philipwhiuk/fixRemoveIcon_InDarkTheme
Use attribute for delete icon so it works in dark theme
2017-01-18 01:57:58 +01:00
Philip Whitehouse
78f99c314d Use attribute for delete icon so it works in dark theme 2017-01-18 00:49:34 +00:00
cketti
bdf21431f7 Merge pull request #2062 from philipwhiuk/stopOutboxFlagSyncAttempt
Stop trying to process flags on messages in the outbox
2017-01-18 01:10:36 +01:00
cketti
fb1de9453a Merge pull request #2076 from jca02266/master
Don't use default charset to pass the test
2017-01-17 14:56:11 +01:00
Koji Arai
5633ddbeaf Don't use default charset to pass the test 2017-01-17 22:10:39 +09:00
cketti
6b06b75224 Avoid NullPointerException 2017-01-16 23:36:36 +01:00
Tobias Bernard
6391766aa7 replace icon with new material design icon 2017-01-16 19:49:52 +01:00
Philip Whitehouse
d0511c676a Stop trying to process flags on messages in the outbox 2017-01-15 23:20:05 +00:00
cketti
6d104bd860 Merge pull request #2035 from GoneUp/importNameFix2
Fixed empty account name at import dialog
2017-01-15 23:16:16 +01:00
cketti
f5e837cc21 Merge pull request #2036 from k9mail/encrypted-multipart-alternative
Handle encrypted parts in multipart/alternative
2017-01-15 22:57:24 +01:00
cketti
d51b90f307 Merge pull request #2059 from philipwhiuk/autocompleteFix
Autocomplete fix v2
2017-01-15 22:44:25 +01:00
Philip Whitehouse
02eb84a1f0 Don't prevent sending due to address conversion 2017-01-15 20:10:24 +00:00
cketti
1a74420eb7 Extract method to construct account display name 2017-01-12 06:42:03 +01:00
cketti
25d977a813 Code style fixes 2017-01-12 06:29:45 +01:00
cketti
dbb5180e1e Merge pull request #1983 from k9mail/draft-fixes
Don't upload draft if PgpMessageBuilder is used
2017-01-12 06:19:40 +01:00
cketti
76b66472d4 Fix failing tests 2017-01-12 05:04:36 +01:00
cketti
da7ea43f77 Add some tests for MessageDecryptVerifier 2017-01-12 04:49:42 +01:00
GoneUp
bb514f7140 Just convert the actual address and not perform wild guesses #1950 2017-01-11 00:16:20 +01:00
GoneUp
f457de3821 Added tests 2017-01-10 21:10:44 +01:00
GoneUp
7df4ad00ad Fixed empty account name at import dialog 2017-01-10 21:10:29 +01:00
Vincent Breitmoser
95f6fba382 handle encrypted parts in multipart/alternative 2017-01-10 18:08:58 +01:00
Vincent Breitmoser
085debbb5b don't save draft iff PgpMessageBuilder is used 2017-01-10 15:12:44 +01:00
Vincent Breitmoser
0644fa0481 more tests for RecipientPresenter 2017-01-10 15:12:44 +01:00
cketti
92196c0128 Merge pull request #2025 from k9mail/GH-1908_fix_pinch_to_zoom
Extend NonLockingScrollView to support adding/removing views
2017-01-10 12:11:13 +01:00
cketti
c7c0ad0b7b Extend NonLockingScrollView to support adding/removing views
Fixes #1908
2017-01-10 12:05:17 +01:00
cketti
217c61430d Merge pull request #2005 from philipwhiuk/clearFullTextSearch
Delete data from Full-Text-Search table
2017-01-10 11:52:17 +01:00
cketti
bf0fe6e25a Merge pull request #2022 from philipwhiuk/addToolsText
Add some useful tools text to the custom actionbar
2017-01-10 11:45:03 +01:00
Philip Whitehouse
2de1a0c79c Add some useful tools text to the custom actionbar 2017-01-09 23:52:22 +00:00
cketti
d344a6898d Merge pull request #2014 from philipwhiuk/rework2004
Rework where we wrap message content
2017-01-09 21:33:47 +01:00
cketti
3490a7f38a Merge pull request #2021 from philipwhiuk/obeyAPIrequirements
Call base implementation as per API requirements
2017-01-09 01:54:16 +01:00
Vincent Breitmoser
6064204d7b Merge pull request #1995 from k9mail/readd-clearsign
Allow pgp/inline with sign-only again
2017-01-09 01:19:56 +01:00
Philip Whitehouse
897520477c Call base implementation as per API requirements 2017-01-09 00:04:49 +00:00
Philip
aef446f1c8 Merge pull request #1987 from GoneUp/fix1981widgetSize
Changing unread widget size to match App Widget Design Guidelines.
2017-01-08 13:24:50 +00:00
Philip Whitehouse
fe6f6caa5f Rework where we wrap message content 2017-01-08 13:19:14 +00:00
cketti
f3e5534797 Clean up FTS table on update 2017-01-08 08:50:10 +01:00
cketti
071f88e96e Delete data from FTS table when deleting message data 2017-01-08 07:46:24 +01:00
cketti
1af2f23f50 Merge pull request #2004 from philipwhiuk/styleQuotedContent
Style quoted content

Fixes #1930
2017-01-08 03:17:14 +01:00
cketti
985cd8593c Merge pull request #2003 from philipwhiuk/dontHideCC
Don't hide CC and BCC if 'Always show' enabled
2017-01-08 03:06:05 +01:00
Philip Whitehouse
8337c16935 Delete data from Full-Text-Search table on clear() 2017-01-07 17:42:36 +00:00
Philip Whitehouse
17dc1c52bc Style quoted content 2017-01-07 17:26:27 +00:00
Philip Whitehouse
963645cad6 Don't hide CC and BCC if 'Always show' enabled 2017-01-07 17:02:20 +00:00
Vincent Breitmoser
afb5e49351 prefer sign-only dialog over pgp/inline dialog for icon click, and disable together 2017-01-06 15:02:17 +01:00
Vincent Breitmoser
0ecf5bcfc7 allow combined pgp/inline + sign-only == clearsign mode 2017-01-06 02:47:23 +01:00
Vincent Breitmoser
a44129b7a9 Revert "remove support for clearsigned messages in PgpMessageBuilder"
This reverts commit ef3cda97e2.
2017-01-06 02:28:51 +01:00
GoneUp
78b7061061 Adjusted the widgets minHeight/mindWidth values to google's recommendation 2017-01-05 22:20:13 +01:00
GoneUp
42a2402347 Unrestricted the message subject since it's in a scrollcontainer 2017-01-05 21:40:43 +01:00
GoneUp
4e3b913522 Add setting for disabling 'mark all as read' confirmation dialog 2017-01-05 18:28:55 +01:00
Vincent Breitmoser
580a828b58 Merge pull request #1969 from k9mail/less_strict_export_version_check
Don't hardcode check for version in SettingsExporterTest
2017-01-05 17:36:19 +01:00
cketti
ea699b3dac Merge pull request #1955 from k9mail/GH-1915_always_show_subject_in_split_mode
Always show subject in message header when split mode is active
2017-01-05 01:42:06 +01:00
cketti
a452ded9cb Merge pull request #1954 from k9mail/GH-1938_fix_bcc_visible_in_sent_message
Fix BCC recipients visible in sent message
2017-01-05 01:40:08 +01:00
cketti
0fe74e59cc Don't hardcode check for version in SettingsExporterTest
Otherwise every time we add a setting this test needs to be touched.
2017-01-04 23:56:59 +01:00
cketti
4323ca3419 Update header before writing a modified LocalMessage
Without this the changes SmtpTransport makes to the message before sending,
e.g. removing the BCC recipients, are not reflected in the writeTo() output.
2017-01-04 19:44:21 +01:00
cketti
b516af2af0 Merge pull request #1948 from philipwhiuk/fix1914untested
Hide the entire crypto component for alternate recipients when disabled

Fixes #1914
2017-01-04 07:42:34 +01:00
cketti
10a252e6b9 Always show subject in message header when split mode is active 2017-01-04 07:20:30 +01:00
cketti
5c06bc01da Add missing fields to LocalMessage.clone() 2017-01-04 05:43:13 +01:00
Philip Whitehouse
55978e6322 Hide the entire crypto component for alternate recipients when disabled 2017-01-04 00:35:44 +00:00
cketti
406fd6b93d Merge pull request #1900 from k9mail/fix_format_string_bug
Don't use unchecked input in format string
2017-01-02 15:31:16 +01:00
Vincent Breitmoser
acfa5d248c Merge pull request #1907 from k9mail/GH-1898_fix_crash_in_MessageCompose_onCreateOptionsMenu
Don't create options menu when Activity is finishing anyway
2017-01-02 12:22:28 +01:00
cketti
9e66bce601 Don't create options menu when Activity is finishing anyway
Fixes #1898
2017-01-01 21:09:47 +01:00
cketti
de60e0e8c4 Merge pull request #1835 from k9mail/flowed-display
Support display of format=flowed (rfc2646)
2017-01-01 02:47:40 +01:00
cketti
693449235f Don't use unchecked input in format string 2016-12-31 20:13:18 +01:00
Vincent Breitmoser
df9009e1ea Merge pull request #1894 from philipwhiuk/fixCcExpanderOnDarkTheme
Use theme-able icon for CC/BCC expander
2016-12-31 13:46:16 +01:00
Philip Whitehouse
f0ac353a21 Use themeable icon for CC/BCC expander - fixes #1893 2016-12-31 12:42:33 +00:00
cketti
b9147f119e Merge pull request #1891 from k9mail/fix-crypto-cancelled-npe
Fix NPE in MessageCryptoHelper.addCryptoResultAnnotationToMessage()
2016-12-30 21:31:51 +01:00
cketti
3bee80a6a4 Merge pull request #1890 from k9mail/fix-fts-oom
Fix OutOfMemoryError during database migration
2016-12-30 21:21:52 +01:00
cketti
b057480481 Simplify LocalFolder.getAllMessageUids() 2016-12-30 20:53:30 +01:00
Vincent Breitmoser
97e9e3267f make MessageCryptoHelper slightly more fail-fast in weird states 2016-12-28 17:50:15 +01:00
Vincent Breitmoser
17647a6fac don't crash in onCryptoOperationCancelled if no part is being processed 2016-12-28 17:40:20 +01:00
Vincent Breitmoser
2279526e0d small cleanup in MessageCryptoHelper 2016-12-28 17:39:01 +01:00
Vincent Breitmoser
e7653c4725 iterate messages by uid, don't keep messages around longer than necessary (fixes #1879) 2016-12-28 16:47:41 +01:00
Philip Whitehouse
36da79d60c Check recipientPresenter exists before destroying it - #1876 2016-12-28 15:11:18 +00:00
Vincent Breitmoser
217b5bf9f4 fix switch/case screwup for signature handling 2016-12-16 00:51:17 +01:00
Vincent Breitmoser
a055ed42a8 don't handle format parameter in setBody(), style fixes 2016-12-12 14:24:30 +01:00
Vincent Breitmoser
dc3d1f0e87 support display of format=flowed (rfc2646) 2016-12-12 14:24:30 +01:00
Vincent Breitmoser
2b4d6d7750 Merge pull request #1850 from k9mail/remove_unused_resources
Remove unused resources
2016-12-12 13:52:02 +01:00
cketti
db1b97d23f Fix tests 2016-12-12 06:51:28 +01:00
cketti
a59aea200f Merge pull request #1804 from sedrubal/swipe-to-refresh
Replace Android-PullToRefresh with android.support SwipeRefreshLayout
2016-12-12 06:32:08 +01:00
cketti
0d77e8ea3a Merge pull request #1844 from supersn0b/master
Added config for fairnatics.net, a soon upcoming service.
2016-12-12 04:00:14 +01:00
cketti
ceb0523fc9 Remove unused layout 2016-12-12 03:28:43 +01:00
cketti
22b07827fc Remove unused strings 2016-12-12 03:26:15 +01:00
cketti
29dc3dd03c Merge pull request #1808 from philipwhiuk/testingSettingsImportExport
Testing for settings import and export
2016-12-12 01:04:58 +01:00
cketti
708b79d859 Merge pull request #1828 from k9mail/nicer_npe_fix_for_database_upgrade_ui
Nicer NullPointerException fix for database upgrade UI
2016-12-12 00:47:53 +01:00
cketti
5fca3c871d Merge pull request #1847 from k9mail/multipart-attachments
Handle attachments with CHILD_PART_CONTAINS_DATA data location
2016-12-11 02:45:00 +01:00
Vincent Breitmoser
0ecbf441c1 handle attachments with CHILD_PART_CONTAINS_DATA data location (message/rfc822) 2016-12-11 02:33:56 +01:00
cketti
6bfb50859e Display empty preview when we couldn't extract preview text 2016-12-09 22:08:10 +01:00
Fair Natics
7230980ecb Removed :993 as this is the default port for imap+ssl+ 2016-12-09 16:56:15 +01:00
Fair Natics
92356e3cee Added config for fairnatics.net, a soon upcoming service. 2016-12-09 14:53:54 +01:00
cketti
ac55279b8e Update translations from Transifex 2016-12-09 00:56:41 +01:00
cketti
2611e9a65d Merge pull request #1833 from k9mail/GH-1832_hide_unsigned_text_divider
Hide "Unsigned Text" divider
2016-12-09 00:19:16 +01:00
cketti
87e13ef800 Merge pull request #1836 from k9mail/multipart-digest-content-type
Properly handle multipart/digest content type
2016-12-09 00:18:59 +01:00
cketti
78b030a32c Hide unsigned text container in clearDisplayedContent() 2016-12-08 00:03:17 +01:00
Vincent Breitmoser
7bd85189ce add test for multipart/digest message 2016-12-07 00:23:28 +01:00
cketti
636098553d Hide "Unsigned Text" divider when support for signed-only messages is disabled 2016-12-05 19:05:56 +01:00
cketti
575d33c12f Extract string resource 2016-12-05 18:44:30 +01:00
cketti
0d3a24df2c Merge pull request #1824 from k9mail/fix-pgp-inline
Ignore leading whitespace for PGP/INLINE messages
2016-12-05 17:55:19 +01:00
cketti
1f9fc44f72 Fix JavaDoc 2016-12-02 17:04:13 +01:00
cketti
c7c21cb602 Avoid NPE by proper initialization instead of null check later on 2016-12-02 17:04:13 +01:00
Vincent Breitmoser
afb63d351b use PendingIntent from encapsulated result if available for showing key info 2016-11-30 18:35:08 +01:00
Vincent Breitmoser
422806f622 ignore leading whitespace for pgp/inline messages in MessageDecryptVerifier (fixes #1823) 2016-11-29 19:22:31 +01:00