cketti
da2012be1d
Merge pull request #2186 from philipwhiuk/json-pending-command-rebase
...
Use json for serializing pending commands
2017-02-06 02:04:57 +01:00
cketti
78c7f01719
Clean up MigrationTo60Test
2017-02-06 01:41:03 +01:00
Dominik Schürmann
874943885f
Update robolectric, use Runner classes
2017-02-05 23:44:35 +01:00
Dominik Schürmann
513a29ad3a
Add encrypted.asc filename to PGP/MIME emails
2017-02-05 23:13:18 +01:00
Philip Whitehouse
af0c47c325
Additional tests for migration
2017-02-05 21:25:50 +00:00
cketti
5d2e28e8ed
Avoid runtime type checks/casts
2017-02-05 07:13:25 +01:00
cketti
8179d88113
Clean up MigrationTo60
2017-02-05 06:05:28 +01:00
Philip Whitehouse
a2e33fcc23
Merge branch 'upstream-master' into json-pending-command-rebase
2017-02-05 01:21:36 +00:00
cketti
1c1be7ff8e
Merge pull request #2178 from philipwhiuk/fixArrayResourceLintWarning
...
SliderPreference - Fix lint warning
2017-02-05 01:40:44 +01:00
cketti
8c55e571f8
Merge pull request #2169 from k9mail/GH-1822_remove_parcelable_from_intent
...
Fix notification actions
2017-02-05 01:39:11 +01:00
Philip
f491e00bc5
Merge pull request #2158 from philipwhiuk/databaseMigrationVerification
...
Test and fix database upgrade process
2017-02-04 23:36:27 +00:00
Philip
b79673bf6f
Merge pull request #2174 from philipwhiuk/addDebugToMessagingController
...
Add additional debug to diagnose message sync issues
2017-02-04 23:25:22 +00:00
Philip
4564f57f01
Merge pull request #2182 from philipwhiuk/fixHardcodedText
...
Move hardcoded text to string resources
2017-02-04 23:25:02 +00:00
Philip
7aa4462115
Merge pull request #2184 from philipwhiuk/abstractK9Activity
...
Make base activities abstract
2017-02-04 23:24:12 +00:00
Philip
d5a6286cb7
Merge pull request #2172 from philipwhiuk/emailHelperTest
...
Tests for EmailHelper
2017-02-04 22:49:35 +00:00
Philip
981ef44b55
Merge pull request #2171 from philipwhiuk/openPgpApiHelperTest
...
Tests for OpenPgpApiHelper
2017-02-04 22:49:10 +00:00
Philip
929f91ab56
Merge pull request #2170 from philipwhiuk/cacheTests
...
Basic behavioural tests of the EmailProviderCache
2017-02-04 22:48:51 +00:00
cketti
2d84b41e5c
Merge pull request #2159 from k9mail/jsoup_preparation
...
Code refactoring in preparation of HtmlCleaner replacement
2017-02-04 23:36:26 +01:00
Philip Whitehouse
5efe6b2cf7
Make base activities abstract
2017-02-04 22:04:32 +00:00
cketti
a52e0bd60a
Avoid exception in MigrationTo43 during database tests
2017-02-04 22:50:06 +01:00
cketti
c3b4e0cfc2
Clean up StoreSchemaDefinitionTest
2017-02-04 22:34:31 +01:00
Philip Whitehouse
b7ed3b9d88
Move hardcoded text to string resources
2017-02-04 21:21:19 +00:00
cketti
4805af02bf
Code style fixes
2017-02-04 21:43:25 +01:00
Philip Whitehouse
4cd7fd6e47
MessageProviderTest - Clean up cursor usage
2017-02-04 18:01:27 +00:00
Philip Whitehouse
76b9860e09
SliderPreference - Fix lint warning
2017-02-04 17:56:24 +00:00
Philip Whitehouse
859db0ce10
MessageProvider - Test basic behaviour
2017-02-04 15:56:42 +00:00
Philip Whitehouse
15f199de36
MessageProvider - Refactor declaration of projections and ensure accounts are listed in unread queries
2017-02-04 15:56:14 +00:00
Philip Whitehouse
07416badc8
Fix issue performing searches when a special folder is null
2017-02-04 15:55:02 +00:00
Philip Whitehouse
8e06956d98
Tests for OpenPgpApiHelper
2017-02-04 11:21:15 +00:00
Philip Whitehouse
67e304a42a
Add additional debug to diagnose message sync issues
2017-02-04 11:06:45 +00:00
cketti
0a76ea609c
Simplify MessageReference.equals() and hashCode() and add tests
2017-02-04 02:03:18 +01:00
Philip Whitehouse
0b9fb4c2ad
Tests for EmailHelper
2017-02-04 00:25:22 +00:00
Philip Whitehouse
39804b8e3c
Basic behavioural tests of the EmailProviderCache
2017-02-03 23:41:05 +00:00
cketti
957b618092
Don't use Parcelable in Intents that can be launched from notifications
2017-02-03 06:05:45 +01:00
cketti
9b7ed6e9a6
Make MessageReference not implement Parcelable anymore
2017-02-03 06:00:36 +01:00
cketti
8760849f79
Refactor MessageReference
2017-02-03 03:12:32 +01:00
cketti
7fd404c1dd
Remove unused method
2017-02-02 20:56:01 +01:00
cketti
f1457d58f6
Remove unused imports
2017-02-02 19:37:28 +01:00
cketti
3380ea986e
Fix order of modifiers
2017-02-02 19:36:38 +01:00
cketti
c60f97fb7e
Merge pull request #2069 from k9mail/optimize-message-sync
...
Don't load all local message metadata into memory during synchronize
2017-01-31 20:24:53 +01:00
cketti
e8cddf6a28
Remove unnecessary import
2017-01-31 17:29:28 +01:00
Philip Whitehouse
4a8d93b572
Add missing indexes in new database migration step
2017-01-31 12:51:47 +00:00
cketti
1ffaf1d392
Move classes related to message quoting to dedicated package
2017-01-31 05:58:24 +01:00
cketti
695432f6cf
Add tests for signature removers
2017-01-31 05:58:24 +01:00
Philip Whitehouse
0c5fedb504
Add tests for database migration
2017-01-30 23:49:44 +00:00
Philip Whitehouse
67ade96101
Better determination of whether a draft needs saving
2017-01-30 21:22:07 +00:00
cketti
fc0e83cca2
Extract code to remove a message signature
2017-01-30 03:32:03 +01:00
cketti
d5194a1c34
Extract BodyTextExtractor from QuotedMessageHelper
2017-01-29 23:19:43 +01:00
cketti
2c04f66346
Move HTML-related classes to 'html' package
2017-01-29 23:04:36 +01:00
cketti
f228abd348
Avoid NullPointerException and creation of Date instances
2017-01-29 20:43:14 +01:00
Vincent Breitmoser
79c65d4cff
don't load all local message metadata into memory during synchronize
2017-01-27 19:33:17 +01:00
cketti
2f14e6fcbc
Reorder methods
2017-01-26 21:21:49 +01:00
cketti
646893f5fb
Clean up MessageProvider
2017-01-26 21:16:41 +01:00
cketti
2825f88520
Code style fixes
2017-01-26 21:02:07 +01:00
cketti
86ca14558b
Remove unused parameter
2017-01-26 20:29:40 +01:00
cketti
0d4d39acaa
Code style fixes
2017-01-26 20:27:38 +01:00
cketti
a357963d32
Code style fixes
2017-01-26 19:45:32 +01:00
cketti
9180c2c1e3
Clean up switch statements
2017-01-26 19:45:32 +01:00
cketti
417f273bac
Remove unused parameters
2017-01-26 19:45:32 +01:00
Vincent Breitmoser
7a39e7c48b
clean up compose and related classes (no semantic changes)
2017-01-26 19:45:32 +01:00
Vincent Breitmoser
a77a632b72
Display warning on encrypted-only messages
2017-01-26 18:01:02 +01:00
cketti
9e102a571b
Merge pull request #2137 from k9mail/GH-2103_fix_database_trigger
...
Add database migration to clean up orphaned data
2017-01-26 14:41:14 +01:00
cketti
4b83da75ee
Merge pull request #2068 from k9mail/fix-alternate-selection
...
Fix broken referencing of recipient token in RecipientSelectView
2017-01-26 10:38:37 +01:00
cketti
c478f64a13
Merge pull request #2126 from philipwhiuk/notificationCategory
...
Set appropriate categories for notifications
2017-01-26 10:31:55 +01:00
Philip Whitehouse
65c4f86105
Set appropriate categories for notifications
2017-01-26 00:30:42 +00:00
Vincent Breitmoser
7bf9d7ec08
Merge pull request #2131 from k9mail/settings-cleanup
...
Settings classes cleanup
2017-01-25 17:36:35 +01:00
cketti
bf881cd3c2
Merge pull request #2124 from philipwhiuk/summaryNotificationFix
...
Fix behavior of summary notifications
2017-01-25 16:25:27 +01:00
cketti
9254e7a052
Add database migration to clean up orphaned data
...
Also extend database trigger to remove entries from messages_fulltext.
2017-01-25 16:11:44 +01:00
cketti
1697be33fa
Remove mostly useless JavaDoc comments
2017-01-25 00:04:18 +01:00
cketti
38a19dbd28
Reformat code
2017-01-24 23:52:03 +01:00
cketti
24a4e3a4fb
Fix typo
2017-01-24 23:43:49 +01:00
cketti
23603278ea
Remove 'm' prefix from fields
2017-01-24 23:41:28 +01:00
cketti
62acbfcd81
Use T as type parameter name
2017-01-24 23:11:08 +01:00
cketti
2710fd3d8d
Remove unnecessary line breaks
2017-01-24 23:00:53 +01:00
Vincent Breitmoser
f5b8a56c8a
add non-null assertion to Settings.upgrade
2017-01-24 19:47:18 +01:00
Vincent Breitmoser
7e1482636d
clean up SettingsImporter
2017-01-24 19:47:18 +01:00
Vincent Breitmoser
2583a5336b
clean up SettingsExporter
2017-01-24 19:17:47 +01:00
Vincent Breitmoser
a9a69a031e
break down Settings.upgrade method into submethods
2017-01-24 19:17:47 +01:00
Vincent Breitmoser
045fd63760
clean up more warnings (no semantic changes)
2017-01-24 16:46:53 +01:00
Vincent Breitmoser
cad7da10d6
use generics for all SettingsDescription subclasses
2017-01-24 16:45:32 +01:00
Vincent Breitmoser
a6dfa14af2
refactor settings (no semantic changes)
2017-01-24 15:42:22 +01:00
Vincent Breitmoser
434cd7735a
add missing pgpSignOnlyDialogCounter to GlobalSettings
2017-01-24 13:39:04 +01:00
Vincent Breitmoser
48e3b4293e
fix broken referencing of recipient token in RecipientSelectView
...
Passing through the actual recipient object was broken in
a2674efff1
2017-01-24 13:06:49 +01:00
Vincent Breitmoser
a14cd9f0e0
Merge pull request #2047 from k9mail/apg-deprecation-warning
...
show warning about APG being deprecated if still selected
2017-01-24 11:55:47 +01:00
cketti
330aef8577
Fix dialog handling
2017-01-24 07:14:54 +01:00
Philip Whitehouse
4ae85ddd38
Fix behaviour of summary notifications
2017-01-23 22:03:13 +00:00
Vincent Breitmoser
e49bfec2d4
other way to prevent activity leak in apg deprecation dialog
2017-01-23 14:05:22 +01:00
Vincent Breitmoser
407d6d7ec9
incorporate feedback
2017-01-23 13:18:44 +01:00
Vincent Breitmoser
485029c5c2
get rid of magic and inline strings
2017-01-23 13:18:44 +01:00
Vincent Breitmoser
ce6f080e83
dismiss apg deprecation dialog on pause, to avoid potential memory leak
2017-01-23 13:18:44 +01:00
Vincent Breitmoser
164f38c5b0
display apg in list of choices, show warning dialog when selected
2017-01-23 13:18:44 +01:00
Vincent Breitmoser
152d1cd2c1
change link to point to blog post
2017-01-23 13:18:44 +01:00
Vincent Breitmoser
3adc981e51
extract method for making links clickable
2017-01-23 13:18:44 +01:00
Vincent Breitmoser
9f51ab627e
show warning about APG being deprecated if still selected
2017-01-23 13:18:44 +01:00
Philip
0dd7a4aafe
Merge pull request #2118 from philipwhiuk/handleInvalidHtmlBetter
...
Handle invalid HTML better
2017-01-22 20:40:22 +00:00
Philip Whitehouse
b15636a3ca
Tidying up existing HtmlSanitizer tests to use standard style
2017-01-22 19:50:45 +00:00
Philip Whitehouse
5301639045
Handle invalid HTML better
2017-01-22 19:50:30 +00:00
cketti
cf15e8a2c5
Merge pull request #2104 from philipwhiuk/fixFetchNull
...
Fix 'Fetching headers null:Folder'
2017-01-22 04:56:11 +01:00
Philip Whitehouse
21a684b243
Update labels used for application permissions - shown to the end user in later versions of Android
2017-01-21 20:42:08 +00:00
Philip Whitehouse
0383fbe4fa
Fix 'Fetching headers null:Folder'
2017-01-21 15:28:05 +00:00
Philip Whitehouse
b77dfa0004
Don't bother handling an intent if we're finishing anyway
2017-01-21 04:01:35 +01:00
Vincent Breitmoser
c94804df26
use CHILD_PART_CONTAINS_DATA as data location for multipart ( fixes #1899 )
2017-01-19 16:18:30 +01:00
Vincent Breitmoser
c2cf9c8772
fix NPE introduced in #2036
2017-01-19 16:03:06 +01:00
cketti
dbc62e38f5
Merge pull request #2082 from bertob/material-icon
...
Replace icon with new material design icon
2017-01-19 13:12:28 +01:00
Tobias Bernard
e00cc9f629
revert to old k9small icon
2017-01-18 18:22:19 +01:00
cketti
4b745ca62e
Merge pull request #2084 from philipwhiuk/fixRemoveIcon_InDarkTheme
...
Use attribute for delete icon so it works in dark theme
2017-01-18 01:57:58 +01:00
Philip Whitehouse
78f99c314d
Use attribute for delete icon so it works in dark theme
2017-01-18 00:49:34 +00:00
cketti
bdf21431f7
Merge pull request #2062 from philipwhiuk/stopOutboxFlagSyncAttempt
...
Stop trying to process flags on messages in the outbox
2017-01-18 01:10:36 +01:00
cketti
fb1de9453a
Merge pull request #2076 from jca02266/master
...
Don't use default charset to pass the test
2017-01-17 14:56:11 +01:00
Koji Arai
5633ddbeaf
Don't use default charset to pass the test
2017-01-17 22:10:39 +09:00
cketti
6b06b75224
Avoid NullPointerException
2017-01-16 23:36:36 +01:00
Tobias Bernard
6391766aa7
replace icon with new material design icon
2017-01-16 19:49:52 +01:00
Philip Whitehouse
d0511c676a
Stop trying to process flags on messages in the outbox
2017-01-15 23:20:05 +00:00
cketti
6d104bd860
Merge pull request #2035 from GoneUp/importNameFix2
...
Fixed empty account name at import dialog
2017-01-15 23:16:16 +01:00
cketti
f5e837cc21
Merge pull request #2036 from k9mail/encrypted-multipart-alternative
...
Handle encrypted parts in multipart/alternative
2017-01-15 22:57:24 +01:00
cketti
d51b90f307
Merge pull request #2059 from philipwhiuk/autocompleteFix
...
Autocomplete fix v2
2017-01-15 22:44:25 +01:00
Philip Whitehouse
02eb84a1f0
Don't prevent sending due to address conversion
2017-01-15 20:10:24 +00:00
cketti
1a74420eb7
Extract method to construct account display name
2017-01-12 06:42:03 +01:00
cketti
25d977a813
Code style fixes
2017-01-12 06:29:45 +01:00
cketti
dbb5180e1e
Merge pull request #1983 from k9mail/draft-fixes
...
Don't upload draft if PgpMessageBuilder is used
2017-01-12 06:19:40 +01:00
cketti
76b66472d4
Fix failing tests
2017-01-12 05:04:36 +01:00
cketti
da7ea43f77
Add some tests for MessageDecryptVerifier
2017-01-12 04:49:42 +01:00
GoneUp
bb514f7140
Just convert the actual address and not perform wild guesses #1950
2017-01-11 00:16:20 +01:00
GoneUp
f457de3821
Added tests
2017-01-10 21:10:44 +01:00
GoneUp
7df4ad00ad
Fixed empty account name at import dialog
2017-01-10 21:10:29 +01:00
Vincent Breitmoser
95f6fba382
handle encrypted parts in multipart/alternative
2017-01-10 18:08:58 +01:00
Vincent Breitmoser
085debbb5b
don't save draft iff PgpMessageBuilder is used
2017-01-10 15:12:44 +01:00
Vincent Breitmoser
0644fa0481
more tests for RecipientPresenter
2017-01-10 15:12:44 +01:00
cketti
92196c0128
Merge pull request #2025 from k9mail/GH-1908_fix_pinch_to_zoom
...
Extend NonLockingScrollView to support adding/removing views
2017-01-10 12:11:13 +01:00
cketti
c7c0ad0b7b
Extend NonLockingScrollView to support adding/removing views
...
Fixes #1908
2017-01-10 12:05:17 +01:00
cketti
217c61430d
Merge pull request #2005 from philipwhiuk/clearFullTextSearch
...
Delete data from Full-Text-Search table
2017-01-10 11:52:17 +01:00
cketti
bf0fe6e25a
Merge pull request #2022 from philipwhiuk/addToolsText
...
Add some useful tools text to the custom actionbar
2017-01-10 11:45:03 +01:00
Philip Whitehouse
2de1a0c79c
Add some useful tools text to the custom actionbar
2017-01-09 23:52:22 +00:00
cketti
d344a6898d
Merge pull request #2014 from philipwhiuk/rework2004
...
Rework where we wrap message content
2017-01-09 21:33:47 +01:00
cketti
3490a7f38a
Merge pull request #2021 from philipwhiuk/obeyAPIrequirements
...
Call base implementation as per API requirements
2017-01-09 01:54:16 +01:00
Vincent Breitmoser
6064204d7b
Merge pull request #1995 from k9mail/readd-clearsign
...
Allow pgp/inline with sign-only again
2017-01-09 01:19:56 +01:00
Philip Whitehouse
897520477c
Call base implementation as per API requirements
2017-01-09 00:04:49 +00:00
Philip
aef446f1c8
Merge pull request #1987 from GoneUp/fix1981widgetSize
...
Changing unread widget size to match App Widget Design Guidelines.
2017-01-08 13:24:50 +00:00
Philip Whitehouse
fe6f6caa5f
Rework where we wrap message content
2017-01-08 13:19:14 +00:00
cketti
f3e5534797
Clean up FTS table on update
2017-01-08 08:50:10 +01:00
cketti
071f88e96e
Delete data from FTS table when deleting message data
2017-01-08 07:46:24 +01:00
cketti
1af2f23f50
Merge pull request #2004 from philipwhiuk/styleQuotedContent
...
Style quoted content
Fixes #1930
2017-01-08 03:17:14 +01:00
cketti
985cd8593c
Merge pull request #2003 from philipwhiuk/dontHideCC
...
Don't hide CC and BCC if 'Always show' enabled
2017-01-08 03:06:05 +01:00
Philip Whitehouse
8337c16935
Delete data from Full-Text-Search table on clear()
2017-01-07 17:42:36 +00:00
Philip Whitehouse
17dc1c52bc
Style quoted content
2017-01-07 17:26:27 +00:00
Philip Whitehouse
963645cad6
Don't hide CC and BCC if 'Always show' enabled
2017-01-07 17:02:20 +00:00
Vincent Breitmoser
afb5e49351
prefer sign-only dialog over pgp/inline dialog for icon click, and disable together
2017-01-06 15:02:17 +01:00
Vincent Breitmoser
0ecf5bcfc7
allow combined pgp/inline + sign-only == clearsign mode
2017-01-06 02:47:23 +01:00
Vincent Breitmoser
a44129b7a9
Revert "remove support for clearsigned messages in PgpMessageBuilder"
...
This reverts commit ef3cda97e2
2017-01-06 02:28:51 +01:00
GoneUp
78b7061061
Adjusted the widgets minHeight/mindWidth values to google's recommendation
2017-01-05 22:20:13 +01:00
GoneUp
42a2402347
Unrestricted the message subject since it's in a scrollcontainer
2017-01-05 21:40:43 +01:00
GoneUp
4e3b913522
Add setting for disabling 'mark all as read' confirmation dialog
2017-01-05 18:28:55 +01:00
Vincent Breitmoser
580a828b58
Merge pull request #1969 from k9mail/less_strict_export_version_check
...
Don't hardcode check for version in SettingsExporterTest
2017-01-05 17:36:19 +01:00
cketti
ea699b3dac
Merge pull request #1955 from k9mail/GH-1915_always_show_subject_in_split_mode
...
Always show subject in message header when split mode is active
2017-01-05 01:42:06 +01:00
cketti
a452ded9cb
Merge pull request #1954 from k9mail/GH-1938_fix_bcc_visible_in_sent_message
...
Fix BCC recipients visible in sent message
2017-01-05 01:40:08 +01:00
cketti
0fe74e59cc
Don't hardcode check for version in SettingsExporterTest
...
Otherwise every time we add a setting this test needs to be touched.
2017-01-04 23:56:59 +01:00
cketti
4323ca3419
Update header before writing a modified LocalMessage
...
Without this the changes SmtpTransport makes to the message before sending,
e.g. removing the BCC recipients, are not reflected in the writeTo() output.
2017-01-04 19:44:21 +01:00
cketti
b516af2af0
Merge pull request #1948 from philipwhiuk/fix1914untested
...
Hide the entire crypto component for alternate recipients when disabled
Fixes #1914
2017-01-04 07:42:34 +01:00
cketti
10a252e6b9
Always show subject in message header when split mode is active
2017-01-04 07:20:30 +01:00
cketti
5c06bc01da
Add missing fields to LocalMessage.clone()
2017-01-04 05:43:13 +01:00
Philip Whitehouse
55978e6322
Hide the entire crypto component for alternate recipients when disabled
2017-01-04 00:35:44 +00:00
cketti
406fd6b93d
Merge pull request #1900 from k9mail/fix_format_string_bug
...
Don't use unchecked input in format string
2017-01-02 15:31:16 +01:00
Vincent Breitmoser
acfa5d248c
Merge pull request #1907 from k9mail/GH-1898_fix_crash_in_MessageCompose_onCreateOptionsMenu
...
Don't create options menu when Activity is finishing anyway
2017-01-02 12:22:28 +01:00
cketti
9e66bce601
Don't create options menu when Activity is finishing anyway
...
Fixes #1898
2017-01-01 21:09:47 +01:00
cketti
de60e0e8c4
Merge pull request #1835 from k9mail/flowed-display
...
Support display of format=flowed (rfc2646)
2017-01-01 02:47:40 +01:00
cketti
693449235f
Don't use unchecked input in format string
2016-12-31 20:13:18 +01:00
Vincent Breitmoser
df9009e1ea
Merge pull request #1894 from philipwhiuk/fixCcExpanderOnDarkTheme
...
Use theme-able icon for CC/BCC expander
2016-12-31 13:46:16 +01:00
Philip Whitehouse
f0ac353a21
Use themeable icon for CC/BCC expander - fixes #1893
2016-12-31 12:42:33 +00:00
cketti
b9147f119e
Merge pull request #1891 from k9mail/fix-crypto-cancelled-npe
...
Fix NPE in MessageCryptoHelper.addCryptoResultAnnotationToMessage()
2016-12-30 21:31:51 +01:00
cketti
3bee80a6a4
Merge pull request #1890 from k9mail/fix-fts-oom
...
Fix OutOfMemoryError during database migration
2016-12-30 21:21:52 +01:00
cketti
b057480481
Simplify LocalFolder.getAllMessageUids()
2016-12-30 20:53:30 +01:00
Vincent Breitmoser
97e9e3267f
make MessageCryptoHelper slightly more fail-fast in weird states
2016-12-28 17:50:15 +01:00
Vincent Breitmoser
17647a6fac
don't crash in onCryptoOperationCancelled if no part is being processed
2016-12-28 17:40:20 +01:00
Vincent Breitmoser
2279526e0d
small cleanup in MessageCryptoHelper
2016-12-28 17:39:01 +01:00
Vincent Breitmoser
e7653c4725
iterate messages by uid, don't keep messages around longer than necessary ( fixes #1879 )
2016-12-28 16:47:41 +01:00
Philip Whitehouse
36da79d60c
Check recipientPresenter exists before destroying it - #1876
2016-12-28 15:11:18 +00:00
Vincent Breitmoser
217b5bf9f4
fix switch/case screwup for signature handling
2016-12-16 00:51:17 +01:00
Vincent Breitmoser
a055ed42a8
don't handle format parameter in setBody(), style fixes
2016-12-12 14:24:30 +01:00
Vincent Breitmoser
dc3d1f0e87
support display of format=flowed (rfc2646)
2016-12-12 14:24:30 +01:00
Vincent Breitmoser
2b4d6d7750
Merge pull request #1850 from k9mail/remove_unused_resources
...
Remove unused resources
2016-12-12 13:52:02 +01:00
cketti
db1b97d23f
Fix tests
2016-12-12 06:51:28 +01:00
cketti
a59aea200f
Merge pull request #1804 from sedrubal/swipe-to-refresh
...
Replace Android-PullToRefresh with android.support SwipeRefreshLayout
2016-12-12 06:32:08 +01:00
cketti
0d77e8ea3a
Merge pull request #1844 from supersn0b/master
...
Added config for fairnatics.net, a soon upcoming service.
2016-12-12 04:00:14 +01:00
cketti
ceb0523fc9
Remove unused layout
2016-12-12 03:28:43 +01:00
cketti
22b07827fc
Remove unused strings
2016-12-12 03:26:15 +01:00
cketti
29dc3dd03c
Merge pull request #1808 from philipwhiuk/testingSettingsImportExport
...
Testing for settings import and export
2016-12-12 01:04:58 +01:00
cketti
708b79d859
Merge pull request #1828 from k9mail/nicer_npe_fix_for_database_upgrade_ui
...
Nicer NullPointerException fix for database upgrade UI
2016-12-12 00:47:53 +01:00
cketti
5fca3c871d
Merge pull request #1847 from k9mail/multipart-attachments
...
Handle attachments with CHILD_PART_CONTAINS_DATA data location
2016-12-11 02:45:00 +01:00
Vincent Breitmoser
0ecbf441c1
handle attachments with CHILD_PART_CONTAINS_DATA data location (message/rfc822)
2016-12-11 02:33:56 +01:00
cketti
6bfb50859e
Display empty preview when we couldn't extract preview text
2016-12-09 22:08:10 +01:00
Fair Natics
7230980ecb
Removed :993 as this is the default port for imap+ssl+
2016-12-09 16:56:15 +01:00
Fair Natics
92356e3cee
Added config for fairnatics.net, a soon upcoming service.
2016-12-09 14:53:54 +01:00
cketti
ac55279b8e
Update translations from Transifex
2016-12-09 00:56:41 +01:00
cketti
2611e9a65d
Merge pull request #1833 from k9mail/GH-1832_hide_unsigned_text_divider
...
Hide "Unsigned Text" divider
2016-12-09 00:19:16 +01:00
cketti
87e13ef800
Merge pull request #1836 from k9mail/multipart-digest-content-type
...
Properly handle multipart/digest content type
2016-12-09 00:18:59 +01:00
cketti
78b030a32c
Hide unsigned text container in clearDisplayedContent()
2016-12-08 00:03:17 +01:00
Vincent Breitmoser
7bd85189ce
add test for multipart/digest message
2016-12-07 00:23:28 +01:00
cketti
636098553d
Hide "Unsigned Text" divider when support for signed-only messages is disabled
2016-12-05 19:05:56 +01:00
cketti
575d33c12f
Extract string resource
2016-12-05 18:44:30 +01:00
cketti
0d3a24df2c
Merge pull request #1824 from k9mail/fix-pgp-inline
...
Ignore leading whitespace for PGP/INLINE messages
2016-12-05 17:55:19 +01:00
cketti
1f9fc44f72
Fix JavaDoc
2016-12-02 17:04:13 +01:00
cketti
c7c21cb602
Avoid NPE by proper initialization instead of null check later on
2016-12-02 17:04:13 +01:00
Vincent Breitmoser
afb63d351b
use PendingIntent from encapsulated result if available for showing key info
2016-11-30 18:35:08 +01:00
Vincent Breitmoser
422806f622
ignore leading whitespace for pgp/inline messages in MessageDecryptVerifier ( fixes #1823 )
2016-11-29 19:22:31 +01:00
Philip Whitehouse
f03a01f6dc
BDD new lines
2016-11-27 02:16:15 +00:00
cketti
833adc732e
Merge pull request #1806 from k9mail/openpgp-signature-result-enums
...
Update OpenPgpSignatureResult to use enums
2016-11-24 00:55:58 +01:00
Vincent Breitmoser
de13e10be1
update OpenPgpSignatureResult to use enums
2016-11-23 16:08:25 +01:00
Philip Whitehouse
6f82dea315
Testing for SettingsExporter
2016-11-22 01:52:57 +00:00
Philip Whitehouse
68b670e7d8
Testing for SettingsImporter
2016-11-22 01:24:41 +00:00
Philip Whitehouse
2f6a2e7c5f
Fix multi-run upgrade bug in Migration
2016-11-20 23:48:49 +00:00
sedrubal
dab9f39ff6
Fix selection offset and cleanup
...
When selecting or opening a message (not a thread) there was an offset
of 1 selecting the message above. When selecting the first message, it
crashed. Now this seems to be fixed.
2016-11-20 17:41:35 +01:00
sedrubal
08daf2dffb
Replace Android-PullToRefresh with android.support SwipeRefreshLayout
2016-11-20 07:55:29 +01:00
cketti
4d61ca8f40
Version 5.115
2016-11-18 16:48:43 +01:00
Vincent Breitmoser
7daf639b75
whoops, forgot a backslash there
2016-11-16 15:09:29 +01:00
Vincent Breitmoser
be1dd1cc3a
minor wording changes for CryptoSettingsDialog (related #1774 )
2016-11-16 15:05:51 +01:00
Vincent Breitmoser
ef3cda97e2
remove support for clearsigned messages in PgpMessageBuilder
2016-11-14 18:56:26 +01:00
Vincent Breitmoser
0378f1a812
Prevent pgp/inline in sign-only mode and vice versa
2016-11-14 14:18:23 +01:00
Vincent Breitmoser
b72a3ce8a0
display sign-only as a special mode like pgp/inline
2016-11-14 13:56:15 +01:00
Vincent Breitmoser
3d434786af
update layout and wording for sign-only mode
2016-11-14 13:55:46 +01:00
Vincent Breitmoser
640322d46d
add "name" parameter to signature content-type header
2016-11-12 22:08:43 +01:00
Vincent Breitmoser
4e17fdf1a6
remove "always sign, encrypt if possible" mode of operation from PgpMessageBuilder
2016-11-12 21:53:02 +01:00
Vincent Breitmoser
6ae8845992
clean up some strings
2016-11-12 21:33:32 +01:00
Vincent Breitmoser
d40a046bf6
move sign-only into a mode of its own
2016-11-11 15:41:37 +01:00
Vincent Breitmoser
cedaecb38e
Merge pull request #1769 from k9mail/attachment-ninjafix
...
use AttachmentTempFileProvider to expose file-backed content uris
2016-11-08 11:21:39 +01:00
cketti
bc41d9124e
Merge pull request #1714
...
Added some more coverage to the MessageReferenceTest
2016-11-08 11:16:39 +01:00
cketti
5b0544cbab
Clean up new tests
2016-11-08 11:13:57 +01:00
cketti
502bb6570f
Don't use 'exit-early' pattern for non-error cases
2016-11-08 09:07:52 +01:00
cketti
47a5401ca7
Introduce local variable to make code easier to read
2016-11-08 09:07:52 +01:00
cketti
fbecc40d01
Use okio with AttachmentTempFileProvider
2016-11-08 09:07:52 +01:00
Vincent Breitmoser
75b2cafddc
fix context menu for inline attachments
2016-11-03 13:57:19 +01:00
Vincent Breitmoser
be45380415
use AttachmentTempFileProvider to expose file-backed content uris
2016-11-03 13:57:19 +01:00
cketti
0617d4250f
Merge pull request #1759 from k9mail/mch-fix-broken-signature-behavior
...
Improve behavior for broken signatures
2016-11-03 02:04:18 +01:00
cketti
59dcdf6b68
Merge pull request #1766 from k9mail/expert-signatures
...
Turn support for signed-only mails into an opt-in feature
2016-11-03 01:29:04 +01:00
Vincent Breitmoser
58eb9b52ca
remove unused lastAutomaticCheckTime attribute from Account
2016-11-02 14:30:58 +01:00
Vincent Breitmoser
f5f3208b2d
incorporate requested changes by cketti
2016-11-02 14:30:58 +01:00
Vincent Breitmoser
380fd94b22
some more tests for PgpMessageBuilder
2016-11-02 14:30:51 +01:00
Vincent Breitmoser
54c0ac6e7b
disabled lock status icon is dark grey
2016-10-31 07:57:08 +01:00
Vincent Breitmoser
c7a637f21b
don't sign in opportunistic mode if sign-only isn't supported
2016-10-31 07:57:08 +01:00
Vincent Breitmoser
98286fd7fb
split off sign-only variant of CryptoSettingsDialog
2016-10-31 07:29:05 +01:00
Vincent Breitmoser
395f37ea1c
add account setting to support unencrypted authentication
2016-10-31 04:30:14 +01:00
Vincent Breitmoser
7fe6a90396
clean up warnings in Account (no semantic changes)
2016-10-31 04:14:12 +01:00
Vincent Breitmoser
80d7ce4887
messageview: if OpenPGP-API throws on signature verification, don't treat data as undisplayable
2016-10-26 18:44:45 +02:00
Vincent Breitmoser
136ee8e34f
fix possible NPE in message crypto helper
2016-10-26 17:37:38 +02:00
cketti
a434f37320
Add notification actions to "stacked notifications"
...
On Android 7.0 notifications that previously only showed on Android Wear
devices are also displayed on the phone/tablet. To be able to use notification
actions there and have a separate set of actions for Wear devices we need to
do some extra work.
2016-10-25 14:58:14 +02:00
cketti
44b4984f97
Merge pull request #1717 from jonas-lundqvist/messagebrowse
...
Enable directional pads for next/previous message
2016-10-19 10:38:12 +02:00
cketti
ffd051b0ec
Don't use same notification group key for all accounts
2016-10-18 06:21:25 +02:00
Jonas Lundqvist
c06721f977
Enable directional pads for next/previous message
2016-10-14 23:26:02 +02:00
cketti
067ba7930c
Version 5.114
2016-10-13 20:24:16 +02:00
cketti
2bebb90d4c
Update translations
2016-10-13 18:22:21 +02:00
Jonas Lundqvist
21df74f7f4
Added test for MessageReference.withModifiedFlag()
2016-10-12 23:45:59 +02:00
Jonas Lundqvist
6ab4c3b3e6
Added test for MessageReference.withModifiedUid()
2016-10-12 23:45:55 +02:00
Vincent Breitmoser
aaa904e075
When moving temporary files, try to copy if rename fails, and throw if that fails too ( #1686 )
...
Fixes #1243
2016-10-12 16:47:23 +02:00
cketti
2087f0476c
Merge pull request #1691
...
Improve Activity operation text
Fixes #1685
2016-10-12 16:23:57 +02:00
cketti
e511b8b7c1
Further clean up of ActivityListenerTest
...
* \u0020 is a hack required to have spaces at the beginning of resource
strings. But there's no need to replicate this inside our tests.
* Dependencies shouldn't be static finals.
* Initialization of dependencies is usually boring. I like to extract that
code to methods and put them at the end of the file.
* Using different values for 'current progress' and 'total' has the
advantage of breaking tests when the two accidentally get mixed up.
2016-10-12 16:18:23 +02:00
cketti
1415261fdd
Merge pull request #1705 from k9mail/no-crypto-hide-recipient-dots
...
hide recipient dots if no crypto provider is configured
2016-10-12 15:53:16 +02:00
cketti
4eb7c41f61
Merge pull request #1703 from k9mail/compose-fix-indeterminate
...
compose: hide indeterminate progress bar after onCreate (fix for api level 15)
2016-10-12 15:51:16 +02:00
Jonas Lundqvist
2c81e11c1d
JavaDoc fix in LocalSearch
...
Minor JavaDoc fix to get rid of a warning.
2016-10-12 00:10:03 +02:00
cketti
0dfa6345b3
Merge pull request #1702 from k9mail/fix-old-api-npe
...
Avoid indirect call to invalidateOptionsMenu() before recipientPresenter is initialized
2016-10-11 18:52:29 +02:00
Vincent Breitmoser
9fb91a0afc
use Compat classes to access deprecated methods
2016-10-11 14:44:09 +02:00
Vincent Breitmoser
89fe5d790e
hide dots in recipient list if no crypto provider is configured
2016-10-11 14:44:09 +02:00
Vincent Breitmoser
dae6be34df
fix NPE in MessageProvider
2016-10-11 13:55:25 +02:00
Vincent Breitmoser
76b2339b69
compose: hide indeterminate progress bar after initialization (fix for api level 15)
2016-10-11 12:22:53 +02:00
Vincent Breitmoser
a88ccfd9e8
avoid indirect call to invalidateOptionsMenu() before recipientPresenter is initialized
2016-10-11 11:42:20 +02:00
cketti
54bf6f7bd5
Merge pull request #1695 from jonas-lundqvist/backstackid
...
Save state for back stack id in MessageList
2016-10-11 03:54:40 +02:00
cketti
7a0bacff41
Merge pull request #1689 from k9mail/fix-line-endings-for-pgp-inline
...
convert LF newlines to CRLF before converting to quoted-printable for clearsigned messages
2016-10-11 03:30:58 +02:00
Jonas Lundqvist
dc876d9cc5
Save state for back stack id in MessageList
2016-10-09 13:32:17 +02:00
Philip Whitehouse
0fff2ffd08
Update to Robolectric 3.1.1 and tidy up code
2016-10-09 02:21:14 +01:00
Vincent Breitmoser
ce249bf07e
convert LF newlines to CRLF in crypto provider output
...
OpenKeychain/BouncyCastle at this point use the system newline for
formatting, which is LF on android. We need this to be CRLF, so we
convert the data after receiving (and possibly before quoted-printable
encoding).
2016-10-08 12:23:54 +02:00
cketti
fc79b290d0
Merge pull request #1692
...
Handle download of attachment correctly when saving requested
Fixes #1629
2016-10-08 11:00:26 +02:00
Philip Whitehouse
1f26663ed1
Handle download of attachment correctly when saving requested
2016-10-08 10:57:47 +02:00
cketti
327a47d2ef
Merge pull request #1688 from k9mail/limit-pgp-inline-dialog-displays
...
Limit number of times the PGP/Inline info dialog is displayed
Fixes #1595
2016-10-08 02:35:54 +02:00
cketti
88eb0f663a
Merge pull request #1687 from k9mail/fix-message-view-theme-switch
...
Don't cache decoded message over configurations
Fixes #1666
2016-10-08 01:18:16 +02:00
Philip
302b668d58
On removing notification, mark it's ID no longer in use ( #1677 )
...
On removing notification, mark it's ID no longer in use
Fixes #1662
2016-10-08 00:54:15 +02:00
Philip Whitehouse
4c7f80161e
Change folder_progress to correctly expect a decimal number instead of a string
2016-10-07 23:15:10 +01:00
Philip Whitehouse
53f3d549f7
Set account name when syncing headers & use correct folder name to generate display name
2016-10-07 23:14:54 +01:00
Vincent Breitmoser
a8d4655e56
limit number of times the pgp inline info dialog is displayed ( closes #1595 )
2016-10-07 19:09:26 +02:00
Vincent Breitmoser
22e8f4cedb
don't cache decoded message over configurations
...
Since 773600c717
2016-10-07 18:43:33 +02:00
cketti
c7b5a50636
Merge pull request #1680 from philipwhiuk/GH-1597-activeNeverSign
...
Use a darker grey to highlight the Never Sign/Encrypt as active
2016-10-07 06:45:14 +02:00
cketti
dcb6890550
Merge pull request #1679 from philipwhiuk/GH-1598-updateCryptoModeOnProceed
...
Move update of crypto settings to submit button and add Cancel
2016-10-07 06:27:02 +02:00
cketti
91c0b4274b
Clean up MessageBuilderTest
2016-10-07 05:40:20 +02:00
Philip Whitehouse
0f84953f94
Use a darker grey to highlight the Never Sign/Encrypt as active
2016-10-07 03:49:45 +01:00
Philip Whitehouse
5271977f76
Move update of crypto settings to submit button and add Cancel
2016-10-07 03:23:58 +01:00
Philip Whitehouse
0cd52bc26b
Use the correct order for alternatives when building HTML messages
...
Fixes #1625
2016-10-07 01:09:31 +01:00
cketti
dbb6cc4d88
Version 5.113
2016-10-06 19:13:30 +02:00
cketti
b6dcb72c7a
Fix dark theme
2016-10-05 16:47:25 +02:00
cketti
59cbdcc559
Version 5.112
2016-10-05 14:03:43 +02:00
cketti
c905b303d6
Merge pull request #1617 from helmo/update-tld-str
...
Update TOP_LEVEL_DOMAIN_STR_FOR_WEB_URL to match more new TLDs
2016-10-05 13:33:47 +02:00
cketti
5c0a7f6d95
Merge pull request #1613 from k9mail/GH-1604_message_format_fix
...
Use correct message format when replying
2016-10-05 13:23:45 +02:00
cketti
5f7bc080f9
Make code more readable
2016-10-04 12:29:54 +02:00
Herman van Rink
8f8188cba5
Update TOP_LEVEL_DOMAIN_STR_FOR_WEB_URL to match more new TLDs
...
new regex produced by https://github.com/irccloud/android/blob/master/make-iana-tld-pattern.py cbe04ae
2016-09-18 16:18:36 +02:00
Jacco
9065b9fb66
Added provider settings for Ziggo and Virgin Media
...
We (Liberty Global) would like to extend the automatic configuration support with settings for Ziggo (The Netherlands) and Virgin Media (UK). You can validate these settings at:
https://www.ziggo.nl/klantenservice/internet/e-mail/imap/
http://help.virginmedia.com/system/selfservice.controller?CONFIGURATION=1001&PARTITION_ID=1&TIMEZONE_OFFSET=&USERTYPE=1&VM_CUSTOMER_TYPE=Cable&CMD=VIEW_ARTICLE&ARTICLE_ID=2743
2016-09-14 16:59:28 +02:00
cketti
97960ec57c
Update message format when enabling/disabling PGP/INLINE
2016-09-13 06:23:06 +02:00
cketti
4430abaf30
Don't force plain text when PGP/INLINE is not enabled
2016-09-13 05:38:20 +02:00
cketti
78d3b011e6
Merge pull request #1612 from k9mail/update_provider_settings
...
Update server settings for Comcast
2016-09-13 05:35:29 +02:00
cketti
521c9129a5
Merge pull request #1608
...
Don't try to show invalid mail addresses in recipient selector
Fixes #1607
2016-09-13 04:16:45 +02:00
cketti
e40bac35a8
Fix indentation
2016-09-13 03:55:50 +02:00
cketti
dbde17108b
Update server settings for Comcast
2016-09-12 06:41:17 +02:00
morckx
192ce7e770
Fix code style and log spam
2016-09-11 13:36:44 +02:00
cketti
4d591a79ee
Merge pull request #1593 from k9mail/GH-1581_context_menu_position_fix
...
Custom contextPopupMenuStyle on Android N to fix context menu position
2016-09-10 23:30:00 +02:00
morckx
ca2e96eb45
Don't try to show invalid mail addresses in recipient selector
...
(fixes #1607 )
2016-09-09 22:54:39 +02:00
cketti
c8c33f4710
Custom contextPopupMenuStyle on Android N to fix context menu position
...
See https://code.google.com/p/android/issues/detail?id=221643
Fixes #1581
2016-09-04 09:40:55 +02:00
cketti
cd4ea8ed40
Hide crypto status icon if no crypto provider is configured
...
Also, disable crypto status icon when clicking it does nothing.
2016-09-04 06:40:15 +02:00
Vincent Breitmoser
82f5fc6b30
fix status_lock_closed icon
2016-09-01 21:08:17 +02:00
cketti
dcd27d9f56
Merge pull request #1584 from k9mail/fix-messageview-onactivityresult
...
fix crash in onActivityResult (fixes #1582 )
2016-08-30 14:53:52 +02:00
Vincent Breitmoser
5a1776890e
fix crash in onActivityResult ( fixes #1582 )
2016-08-30 13:18:39 +02:00
cketti
4e7f93c3e3
Version 5.111
2016-08-27 23:49:04 +02:00
Vincent Breitmoser
e9e5411c06
adjust colors for dark theme
2016-08-27 21:19:02 +02:00
Vincent Breitmoser
406334086c
use stylable attributes for openpgp_ colors
2016-08-27 21:19:02 +02:00
Vincent Breitmoser
f6e19680b0
add test for message/rfc822 attachment
2016-08-19 22:21:43 +02:00
Vincent Breitmoser
77a3892b0f
fix unit tests for 7bit/quoted-printable encoding
2016-08-19 22:21:43 +02:00
Vincent Breitmoser
674cd3bf5a
remove 7 bit reencoding routines
2016-08-19 22:21:42 +02:00
Vincent Breitmoser
03a09c9b90
use application/octet-stream for message attachments
2016-08-16 12:23:43 +02:00
Vincent Breitmoser
08ef3d5ce5
clean up TextBody, make it slightly more failfast
...
Previously, TextBody supported only 8bit or quoted printable encodings,
defaulting to quoted printable if the encoding was not equal to "8bit".
This behavior is now changed to throw a runtime exception when an
unsupported encoding has been selected. The `setEncoding` method also
throws if an unsupported encoding is selected.
2016-08-16 12:21:09 +02:00
cketti
0bc5b49bb5
Fix MessageBuilderTest
2016-08-16 00:40:23 +02:00
cketti
77f9e82b41
Merge pull request #1559 from k9mail/deferred-file-body-fix
...
Fix DeferredFileBody
2016-08-16 00:07:41 +02:00
cketti
52e593e597
Merge pull request #1558 from k9mail/hide-keyboard-on-view
...
Hide keyboard when message is displayed
2016-08-16 00:03:54 +02:00
cketti
411ec0ec34
Use 'newInstance' as name for static factory methods
2016-08-15 11:48:36 +02:00
cketti
84cef1d8b1
Get rid of trivial static factory methods
2016-08-15 11:42:47 +02:00
cketti
c234578271
Don't inject BoundaryGenerator into MimeMultipart
2016-08-15 11:14:38 +02:00
cketti
7719153cc0
Extract code to generate Message-Id header value
...
This moves Message closer to being a dumb data class and avoids having to
pass around a UuidGenerator reference.
2016-08-15 10:22:17 +02:00
Vincent Breitmoser
f5656c331d
add tests for DeferredFileBody
2016-08-11 15:54:25 +02:00
Vincent Breitmoser
c7a86e8000
fix writeMemoryToFile in DeferredFileBody
2016-08-11 15:45:21 +02:00
Vincent Breitmoser
f097c44580
messageview: hide keyboard when message is displayed, not only after interaction pending intent
2016-08-10 14:58:31 +02:00
Vincent Breitmoser
4d9283f124
construct MessageBuilder classes in factory methods
2016-08-10 14:49:12 +02:00
Vincent Breitmoser
1e97f1ce16
inject UuidGenerator into MimeMessage via constructor instead of parameter
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
bb8e5a68df
rename UUIDGenerator to UuidGenerator
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
1c28e1c601
add MessageBuilder test for message with attachment
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
cd011349fe
make send date and timezone hiding build parameters in MessageBuilder
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
874b981ba6
get message boundaries from injected BoundaryGenerator in MessageBuilder
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
f4b0521bbb
get uuid from injected generator in message builder
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
902506b2b8
move legacy utility method into migration class
2016-08-10 13:50:25 +02:00
Vincent Breitmoser
d6c50b4db6
add unit tests for PendingCommand serialization
2016-08-10 13:45:02 +02:00
Vincent Breitmoser
73c2b1e9ad
add unit tests for PendingCommand migration
2016-08-10 13:45:02 +02:00
Vincent Breitmoser
fb1dfd5786
add migration for new pending commands
2016-08-10 13:45:02 +02:00
Vincent Breitmoser
3eb949e674
use lists instead of arrays in PendingCommands
2016-08-10 13:45:02 +02:00
Vincent Breitmoser
c4ab70ca0b
reorder methods in MemorizingMessagingListener (no semantic changes)
2016-08-10 13:44:57 +02:00
Vincent Breitmoser
15f3ba6219
serialize PendingCommands as JSON
2016-08-10 13:43:26 +02:00
Vincent Breitmoser
438576b547
minimize visibility in MessagingController (and some small code style fixes)
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
8647b4c8dd
minor fixes for clarity of foreground priority commands
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
0dfcdbdfc4
hide the Runnable interface as an implementation detail of MessagingController
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
6596c85a9f
clean up fields a bit in MessagingController
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
03baf1afc2
make memorizingMessagingListener final, and respect that it can't actually be null
2016-08-10 10:41:32 +02:00
Vincent Breitmoser
a0a341e479
move MemorizingListener into its own class
2016-08-10 10:41:32 +02:00
Vincent Breitmoser
8d24e036b7
fix a bunch of warnings in MessagingController (no semantic changes)
2016-08-10 10:41:32 +02:00
cketti
904c80dd22
Merge pull request #1555 from k9mail/alternate-recip-fix
...
Small fix for alternate recipient adapter
2016-08-10 05:33:15 +02:00
cketti
b40d64eee4
Merge pull request #1545 from k9mail/safecontentresolver_update
...
Update SafeContentResolver to 0.9.0
2016-08-10 05:14:18 +02:00
Vincent Breitmoser
a2674efff1
compose: small fixes for alternate recipient adapter
...
this slightly alters behavior when a non-contact address is picked, to
make sure a crypto status is shown in the alternate dropdown.
2016-08-09 13:36:19 +02:00
cketti
ecb0044cc4
Merge pull request #1527 from k9mail/message-reference-ops
...
pass MessageReference instead of LocalMessage to MessagingController operations
2016-08-05 05:56:07 +02:00
cketti
915f44ab14
Merge pull request #1537 from k9mail/compose-attachments-from-viewinfo
...
Load attachments from AttachmentViewInfo in AttachmentPresenter
2016-08-05 04:33:03 +02:00
cketti
07a99137d1
Update SafeContentResolver to 0.9.0
2016-08-05 02:22:42 +02:00
Vincent Breitmoser
ed84f2958c
remove a couple of unused icons
...
I kept the sources around, so they can more easily be restored should we
need some of those again.
2016-08-03 17:11:22 +02:00
Vincent Breitmoser
4449e5c0d7
use vector drawables for all openpgp icons
2016-08-03 16:46:53 +02:00
Vincent Breitmoser
0f3ce1bf1c
pass MessageReference instead of LocalMessage to MessagingController operations
...
The most significant change here is that LocalMessage data is loaded in
MessagingController, instead of every calling site individually.
2016-08-02 18:47:04 +02:00
cketti
403323c94f
Merge pull request #1529 from k9mail/fix-crash-on-no-headers
...
Don't crash if headers aren't available
2016-08-02 18:23:47 +02:00
cketti
a47e5bf3d2
Merge pull request #1536 from k9mail/compose-complete-on-send
...
Try performing recipient completion on send
2016-08-02 18:07:24 +02:00
cketti
9fd2cf3bf1
Merge pull request #1535 from k9mail/compose-non-ascii-error
...
Show parse error for non-ASCII characters in address
2016-08-02 18:05:12 +02:00
cketti
54b3bac672
Merge pull request #1528 from k9mail/fix-mlh-loadMessageRemoteFinished
...
Fix logic in MessageLoaderHelper
2016-08-02 17:22:15 +02:00
cketti
2626cb1115
Merge pull request #1523 from k9mail/server_name_suggestion
...
Suggest server name based on server type
2016-08-02 15:40:01 +02:00
Vincent Breitmoser
d276bbda3e
load draft attachments from AttachmentViewInfo
2016-08-01 16:53:12 +02:00
Vincent Breitmoser
450356b577
add flag whether data is available to AttachmentViewInfo
2016-08-01 16:03:22 +02:00
Vincent Breitmoser
b3f2974962
compose: try performing recipient completion on send ( fixes #1495 )
...
This commit performs completion on recipient fields when the send button
is clicked (uncompleted text is usually present if the cursor is on the
recipient field at that time).
If any completion was performed, sending is quietly aborted. This avoids
sending mail to the wrong recipient if the uncompleted text doesn't
resolve to what the user thought.
2016-08-01 15:33:05 +02:00
Vincent Breitmoser
43cd25cfa3
compose: show parse error for non-ascii characters in address
2016-08-01 15:04:27 +02:00
Vincent Breitmoser
8399c9f161
don't crash if headers aren't available
2016-07-29 20:57:26 +02:00
Vincent Breitmoser
0b0a8a46ef
fix logic in MessageLoaderHelper
2016-07-29 20:56:14 +02:00
Vincent Breitmoser
a40a33e1da
delete abandoned CryptoHelper class
2016-07-28 14:53:58 +02:00
Vincent Breitmoser
f87a9cad49
don't throw MessagingExceptions for getting headers from parts
2016-07-28 14:53:58 +02:00
Vincent Breitmoser
2b5064ea55
always load headers immediately for LocalMessage
2016-07-28 14:53:57 +02:00
Vincent Breitmoser
3f0fb9fd3e
change tests to use more actual Part/Body classes instead of mocks
2016-07-28 14:53:57 +02:00
cketti
1cb32b0ce5
Suggest server name based on server type
2016-07-25 05:45:07 +02:00
Vincent Breitmoser
fa998981f7
add handling for LocalMessage parts to AttachmentInfoExtractor
2016-07-25 01:39:06 +02:00
Vincent Breitmoser
e03df3d991
improve error handling when opening missing parts (don't crash at least)
2016-07-25 01:39:06 +02:00
cketti
d80a1d415a
Merge pull request #1510
...
Loader helper fixes
2016-07-25 01:01:34 +02:00
Vincent Breitmoser
af5856d28f
avoid leaking data to MessagingController via MessageLoaderHelper after detach
...
null handling is already present: no ui methods should ever be called
after onDestroy or onDetachChangingConfigurations, and pending result
callbacks are handled by a null-check for the callback field.
2016-07-25 00:59:07 +02:00
Vincent Breitmoser
0993d91473
only care for our own MessageReference in MessageLoaderHelper
2016-07-25 00:59:07 +02:00
Vincent Breitmoser
471754241d
Merge pull request #1514 from k9mail/dont-trust-downloaded-flag
...
don't trust X_DOWNLOADED_FULL flag, consider messages with missing data incomplete (WIP)
2016-07-24 23:43:02 +02:00
Vincent Breitmoser
489cf354fd
don't pass LocalMessage from onMessageViewInfoLoadFinished/Failed
2016-07-24 23:40:12 +02:00
Vincent Breitmoser
174f99b94c
don't trust X_DOWNLOADED_FULL flag, consider messages with missing on-disk data incomplete
2016-07-24 23:40:12 +02:00
cketti
9c46f68b7f
Merge pull request #1515 from k9mail/hidden-attachments
...
Ditch "hidden attachments"
2016-07-24 22:54:32 +02:00
Vincent Breitmoser
b7bcaf8deb
rename firstClassAttachment to inlineAttachment (with reversed logic)
2016-07-24 22:08:16 +02:00
cketti
d8f5de0013
Merge pull request #1522 from k9mail/confirm-mark-all-as-read
...
Ask for confirmation on "mark all as read"
2016-07-24 21:59:17 +02:00
Vincent Breitmoser
a3ce1adf6e
only first class attachments should be actually displayed
2016-07-24 21:05:52 +02:00
Vincent Breitmoser
c1d57aa324
parts without name are still first class attachments
2016-07-24 21:05:13 +02:00
Vincent Breitmoser
bd925567e4
messageview: remove support for "hidden" attachments
2016-07-24 21:05:13 +02:00
Vincent Breitmoser
035aba1c1e
fix button to display hidden attachments
2016-07-24 21:05:13 +02:00
Vincent Breitmoser
7826febedb
Merge pull request #1511 from k9mail/sanitize-in-extract
...
Sanitize HTML in MessageViewExtractor instead of MessageWebView
2016-07-24 20:51:47 +02:00
Vincent Breitmoser
526448d18b
incorporate tests feedback
2016-07-24 20:51:37 +02:00
Vincent Breitmoser
773600c717
sanitize html in MessageViewInfoExtractor
...
also, inject HtmlSanitizer to keep MessageViewInfoExtractor testable and
pass Context through Globals
2016-07-24 20:51:37 +02:00
Vincent Breitmoser
65f2539e0b
move MessageViewInfoExtractorTest to unit tests
...
(Yes, I made sure these still run successfully!)
2016-07-24 20:50:35 +02:00
cketti
8df6a56a6f
Merge pull request #1521 from k9mail/attachment-count-encrypted
...
Set attachment count to zero for encrypted messages
2016-07-24 20:37:16 +02:00
cketti
8b1c13d697
Merge pull request #1520 from k9mail/recipient-view-longclick
...
compose: enable long click on recipient select view
2016-07-24 20:05:49 +02:00
cketti
807f0418d8
Merge pull request #1519 from k9mail/recipient-inject-loaderman
...
Inject LoaderManager to RecipientSelectView via presenter
2016-07-24 20:05:20 +02:00
cketti
2abcbf9ca2
Merge pull request #1512 from k9mail/use-mime4j-bodydescriptor
...
Use MIME4J's BodyDescriptor instead of reading Content-Type header ourselves
2016-07-24 18:45:52 +02:00
Vincent Breitmoser
c65f54d396
ask for confirmation on "mark all as read" ( closes #1509 )
2016-07-22 18:25:31 +02:00
Vincent Breitmoser
5c638dd205
use MessageDecryptVerifier methods in EncryptionDetector
2016-07-22 15:17:43 +02:00
Vincent Breitmoser
22b72a5824
don't count attachments in encrypted messages
2016-07-22 15:17:43 +02:00
Vincent Breitmoser
d1620f3fc7
compose: enable long click on recipient select view
...
this leads to some problems if more than one token is actually parsed.
however, for the common use case of parsing a single address, it seems
to work just fine, so this hopefully does more good than harm.
see also https://github.com/splitwise/TokenAutoComplete/issues/95
2016-07-22 15:12:58 +02:00
Vincent Breitmoser
034b1eda41
compose: inject loader manager to RecipientSelectView via presenter ( fixes #1251 )
...
Conflicts:
k9mail/src/main/java/com/fsck/k9/view/RecipientSelectView.java
2016-07-22 15:03:59 +02:00
Vincent Breitmoser
600537f5fb
use mimeType and boundary values from BodyDescriptor rather than header values
2016-07-19 17:14:46 +02:00
Vincent Breitmoser
19cd7b997e
add some @WorkerThread annotations
2016-07-18 15:38:21 +02:00
Vincent Breitmoser
9f58de5909
compose: use MessageViewInfo.rootPart for content extraction
2016-07-18 15:38:21 +02:00
