Commit graph

44 commits

Author SHA1 Message Date
cketti
d69c1f4c46 Add simple logging abstraction
Once there's a JVM artifact for Timber, hopefully all we have to do is replace the imports again.
2022-05-02 02:44:35 +02:00
cketti
1280f43cba Fix STARTTLS bug in SmtpTransport 2022-05-01 01:31:46 +02:00
cketti
0a05802843 Use our standard read/connect timeouts in SmtpTransport 2022-05-01 01:25:05 +02:00
cketti
6ea0bab0cf Remove SuppressLint annotations 2022-04-28 22:42:44 +02:00
Bastian Wilhelm
d71e5b40ac Replace AndroidX annotations with the ones from JetBrains 2022-04-28 14:52:48 +02:00
cketti
0934f274b7 Get rid of EnhancedNegativeSmtpReplyException 2022-04-20 18:01:36 +02:00
cketti
e9369e1b04 Convert NegativeSmtpReplyException to Kotlin 2022-04-20 18:01:36 +02:00
cketti
0aaa0a9a82 Rename .java to .kt 2022-04-20 18:01:36 +02:00
cketti
0c5a9a678a Convert StatusCodeClass to Kotlin 2022-04-20 18:01:36 +02:00
cketti
198f04359c Rename .java to .kt 2022-04-20 18:01:36 +02:00
cketti
56da545493 Convert SmtpTransport to Kotlin 2022-04-20 18:01:36 +02:00
cketti
2f258d6886 Rename .java to .kt 2022-04-20 17:08:40 +02:00
cketti
cf2979e9fb Convert SmtpTransportTest to Kotlin 2022-04-20 17:08:40 +02:00
cketti
c25884314f Rename .java to .kt 2022-04-20 17:08:40 +02:00
cketti
d13352a4cd Use new SmtpResponseParser in SmtpTransport 2022-04-11 17:24:55 +02:00
cketti
a7562fe3f3 Add a new parser for SMTP responses 2022-04-11 17:24:55 +02:00
cketti
61046ef0fd Update Mockito (Kotlin) to version 4.0.0 2021-10-30 05:32:51 +02:00
cketti
987325d226 SMTP: Read all responses before issuing DATA command 2021-02-16 13:34:46 +01:00
cketti
1f2404557b Migrate storeUri/transportUri to new server settings format 2021-02-01 17:30:21 +01:00
cketti
08d6d9bebc Delete remaining store/transport URI functionality 2021-02-01 17:30:21 +01:00
cketti
4e2ae11238 Don't select charset depending on the recipient address
It's 2020. We now always use UTF-8 for outgoing emails.
2020-05-27 03:07:29 +02:00
cketti
e3973096d3 Remove Checkstyle 2019-11-13 16:51:52 +01:00
cketti
56a37d9e14 Remove FindBugs
It's not maintained anymore and we're not currently using it.
2019-11-13 16:41:51 +01:00
cketti
105622a999 Use variable for 'sourceCompatibility' and 'targetCompatibility' values 2019-11-13 16:26:29 +01:00
cketti
6f0bae80b9 Fix test in 'SmtpTransportTest'
We tested whether the connection was still open. But we should test
whether the connection was closed. The test passed most of the time
because closing a connection takes some time.
2019-05-24 13:45:29 +02:00
cketti
7c7ce6eb84 Remove Message.setRecipients() and manually set recipient headers
Use AddressHeaderBuilder to encode the recipient addresses and fold the
header value.
2019-02-14 02:28:36 +01:00
cketti
47deb4e5ba Switch to androidx artifacts 2019-02-09 22:08:25 +01:00
Vincent Breitmoser
af09f7b02e
Merge pull request #3799 from k9mail/smtp-pipeline-first-error
Return first, rather than last, response for pipelined SMTP commands
2018-12-12 12:05:29 +01:00
Vincent Breitmoser
fda70cbea7 respect first overall negative reply in smtp pipelining 2018-12-10 17:21:10 +01:00
Vincent Breitmoser
d1c4701256
Merge pull request #3808 from artbristol/remove-exception-todo
Remove TODO
2018-12-10 12:55:12 +01:00
Art O Cathain
5e3141d236 Remove TODO 2018-12-09 14:06:17 +01:00
Vincent Breitmoser
3c663098b3 Use local ip statically for SMTP HELO/EHLO 2018-12-05 22:26:17 +01:00
Vincent Breitmoser
bad3f20852 add unit test for negative response in smtp pipeline 2018-12-05 15:58:23 +01:00
Vincent Breitmoser
64c6a14e77 Return first, rather than last, response for pipelined SMTP commands 2018-12-05 14:50:57 +01:00
Vincent Breitmoser
4333a3a16f remove "hideHostnameWhenConnecting" from global settings 2018-12-05 14:39:08 +01:00
Vincent Breitmoser
c06e1a9d9b always just send IP instead of hostname in SMTP EHLO message
Clients are very often behind NATs, which makes the hostname in
HELO/EHLO messages virtually useless these days. Attempting to figure
out a hostname we could use also led to issues with some strict Postfix
configurations (see https://github.com/k9mail/k-9/issues/3387). This
commit changes our behavior to simply send the local IP always, getting
rid of this metadata.

Fixes #3387
2018-12-05 14:36:06 +01:00
cketti
56882dc6c3 Fix unresolved references in Javadoc comments 2018-09-03 00:13:58 +02:00
cketti
0af83029cc Change ServerSettings#type to a String 2018-07-19 12:40:57 +02:00
cketti
50e955d2da Remove default port information from ServerSettings.Type 2018-07-18 19:25:43 +02:00
cketti
902d959c10 Remove knowledge of transport URI from SmtpTransport 2018-07-17 21:53:30 +02:00
cketti
ec9ba959f8 Remove TransportUris 2018-07-15 20:08:11 +02:00
cketti
e2c09e4155 Make account setup code use Backend to check outgoing server settings 2018-07-11 19:57:51 +02:00
cketti
47520d7ae1 Clean up 2018-05-24 13:57:36 +02:00
cketti
fd7a21bec6 Create :mail:protocols:smtp Gradle module 2018-05-24 13:57:35 +02:00