Commit graph

6013 commits

Author SHA1 Message Date
cketti
f88a915a5d Don't hang on to ImapConnection for too long 2016-02-18 00:28:43 +01:00
cketti
ca4a6b6cfc Close connection when IDLE command fails 2016-02-17 20:14:01 +01:00
cketti
200ee27980 Don't hold 'connections' monitor while checking retrieved connection 2016-02-17 20:04:08 +01:00
cketti
b34f3ad669 Make sure ImapFolderPusher is not started or stopped twice 2016-02-12 06:27:14 +01:00
cketti
01a14b9f1f Synchronize access to storedUntaggedResponses 2016-02-12 06:13:03 +01:00
cketti
41ca6b7899 Use volatile booleans for 'stop' and 'idling'
We don't use compound actions that would need to be protected.
2016-02-12 05:57:09 +01:00
cketti
42e07d0355 Move fields that are only used by listener thread into PushRunnable
Also, there's no need for them to use Atomic* instances.
2016-02-12 05:52:17 +01:00
cketti
b8957f6fee Move all messages that are only called from listener thread into PushRunnable 2016-02-12 05:44:49 +01:00
cketti
ca4e6c2139 Remove unnecessary method 2016-02-12 05:36:19 +01:00
cketti
1db9fc169e Make wakeLock final 2016-02-12 05:30:00 +01:00
cketti
af941396bc Make sure that stopping, then starting ImapPusher is atomic 2016-02-12 04:11:48 +01:00
cketti
2c5bcac66f Exclude CRLF when logging sent commands
Android Studio 2.0 beta 3 skips those log messages in its logcat view.
2016-02-11 23:55:02 +01:00
cketti
1d52a357a6 Make sure DONE continuation is only sent at appropriate times 2016-02-11 21:53:17 +01:00
cketti
690693a21c Synchronize access to listeningThread 2016-02-11 00:00:47 +01:00
cketti
23d4c3fd68 Reorder methods 2016-02-10 23:55:59 +01:00
cketti
51723e46ca Extract methods to make the code a bit more readable 2016-02-10 00:06:47 +01:00
cketti
4a80ab6aa3 Extract Push thread code to named inner class 2016-02-09 22:38:30 +01:00
cketti
6b4da35035 Remove unnecessary variable increment 2016-02-09 22:33:11 +01:00
cketti
5b58aac748 Remove unnecessary local variable 2016-02-09 22:28:21 +01:00
cketti
39c4cf3218 Code style fixes and minor cleanup 2016-02-09 22:25:37 +01:00
cketti
54963b6e1e Extract code to encode/decode folder names to FolderNameCodec 2016-02-09 21:41:55 +01:00
cketti
d1cbac47b1 Remove now unused methods from remote Folder subclasses 2016-02-09 19:03:12 +01:00
cketti
ab1e5ce691 Remove LocalFolder-specific methods from Folder 2016-02-09 18:53:59 +01:00
cketti
61e0df5513 Extract code to parse SEARCH response to SearchResponse 2016-02-09 18:24:56 +01:00
cketti
51ab4d23dc Extract code to parse COPYUID response to CopyUidResponse 2016-02-09 18:21:35 +01:00
cketti
ed7221be03 Extract code to parse SELECT/EXAMINE response to SelectOrExamineResponse 2016-02-09 18:21:07 +01:00
cketti
ef82fe9df1 Extract code to parse PERMANENTFLAGS to PermanentFlagsResponse 2016-02-09 17:37:29 +01:00
cketti
7875b4e99d Tidy up return type of getMessagesFromUids() 2016-02-09 05:01:04 +01:00
cketti
60da56fa7a Inline constant arguments for getMessagesFromUids() 2016-02-09 05:00:07 +01:00
cketti
a4072d30e5 Code style fixes and minor code cleanup 2016-02-09 04:54:05 +01:00
cketti
d9f8d86ff4 Add unit tests for ImapFolder 2016-02-09 03:48:10 +01:00
cketti
877ad2aa72 [WIP] Add unit tests for ImapFolder 2016-02-09 02:08:01 +01:00
cketti
f1bc2b4f21 Reduce visibility of some methods in ImapFolder 2016-02-04 02:11:13 +01:00
cketti
1f766b6919 Avoid unnecessary creation of ImapFolder instances 2016-02-03 22:09:49 +01:00
cketti
d8cd58e42b Move encodeString() from ImapStore to ImapUtility 2016-02-03 21:53:14 +01:00
cketti
e562c4bd5e Move RFC3501_DATE constant to ImapFolder 2016-02-03 21:51:42 +01:00
cketti
2f9a427b22 Code style fixes 2016-02-03 21:33:50 +01:00
cketti
ad1e2caa9c Extract code to encode/decode ImapStore URIs 2016-02-03 20:54:51 +01:00
cketti
06ee1ff1b9 Move url encoding/decoding functionality from Store to UrlEncodingHelper 2016-02-03 20:37:29 +01:00
cketti
d9797d02bf Also use special LIST path in ImapResponseParser for LSUB response 2016-02-03 20:16:43 +01:00
cketti
d0f4ab84fc Extract LIST response parsing to ListResponse 2016-02-03 20:08:43 +01:00
cketti
13663dbc1d Remove support for Gmail-specific XLIST command
Nowadays Google implements RFC 6154 and XLIST was deprecated in 2013.
2016-02-03 19:52:57 +01:00
cketti
2d887b31ac Add unit tests for ImapStore 2016-02-02 19:02:31 +01:00
cketti
7f3fc84c11 Extract helper method to ImapResponseHelper 2016-02-02 19:02:31 +01:00
cketti
bbf6a07e94 Extract ImapStoreSettings from ImapStore 2016-02-02 19:02:31 +01:00
cketti
0c31ed9119 Get rid of ImapFolderPusher caching mechanism
start() will never reuse ImapFolderPusher instances because stop() is called
unconditionally, and that will clear the "cache".
2016-02-02 19:02:31 +01:00
cketti
5cd64dc241 Code style fixes in ImapPusher 2016-02-02 19:02:30 +01:00
cketti
ee25de07db Add unit tests for ImapPusher 2016-02-02 19:02:30 +01:00
cketti
7b5e5bc223 Refactor ImapPushState
The old code supported a more complex input argument format. But as far as I
can tell this "feature" was  never used.
2016-02-02 19:02:30 +01:00
cketti
619ab8629d Add unit tests for ImapPushState 2016-02-02 19:02:30 +01:00