Dr. Stephen Henson
4bf7b29169
Check public key is not NULL.
...
CVE-2015-0288
PR#3708
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 28a00bcd8e
)
2015-03-02 15:26:52 +00:00
Dr. Stephen Henson
42ad0100f1
Fix format script.
...
The format script didn't correctly recognise some ASN.1 macros and
didn't reformat some files as a result. Fix script and reformat
affected files.
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 437b14b533
)
2015-03-02 13:43:40 +00:00
Matt Caswell
dac693c957
Fix a failure to NULL a pointer freed on error.
...
Inspired by BoringSSL commit 517073cd4b by Eric Roman <eroman@chromium.org>
CVE-2015-0209
Reviewed-by: Emilia Käsper <emilia@openssl.org>
2015-02-25 20:38:25 +00:00
Dr. Stephen Henson
6e161ee39e
Document -no_explicit
...
Reviewed-by: Rich Salz <rsalz@openssl.org>
(cherry picked from commit 384dee5124
)
2015-02-24 15:29:07 +00:00
Andy Polyakov
0e5e7af955
Bring objects.pl output even closer to new format.
...
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 849037169d
)
2015-02-09 16:04:58 +01:00
Andy Polyakov
2487d77104
Harmonize objects.pl output with new format.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 7ce3862319
)
2015-02-09 10:01:54 +01:00
Matt Caswell
e5d2a44fb7
Fix error handling in ssltest
...
Reviewed-by: Richard Levitte <levitte@openssl.org>
(cherry picked from commit ae632974f9
)
2015-02-06 10:12:43 +00:00
Rich Salz
189de54506
Fixed bad formatting in crypto/des/spr.h
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit 7e35f06ea9
)
2015-02-05 09:46:06 -05:00
Dr. Stephen Henson
beac071b13
Make objxref.pl output in correct format
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 6922ddee1b
)
2015-02-04 13:36:00 +00:00
Dr. Stephen Henson
99ff40515d
Check PKCS#8 pkey field is valid before cleansing.
...
PR:3683
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 52e028b9de
)
2015-02-03 14:02:34 +00:00
Matt Caswell
192e148154
Fix for reformat problems with e_padlock.c
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit d3b7cac41b
)
2015-01-22 14:15:45 +00:00
Matt Caswell
1804f78298
Fix formatting error in pem.h
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
Conflicts:
crypto/pem/pem.h
2015-01-22 14:15:45 +00:00
Matt Caswell
3d7a9aca8c
Re-align some comments after running the reformat script.
...
This should be a one off operation (subsequent invokation of the
script should not move them)
This commit is for the 1.0.0 changes
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:46:52 +00:00
Matt Caswell
4bc9913844
Rerun util/openssl-format-source -v -c .
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:46:26 +00:00
Matt Caswell
a8b966f48f
Run util/openssl-format-source -v -c .
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:46:18 +00:00
Matt Caswell
e3db68b766
Yet more changes to comments
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:46:13 +00:00
Matt Caswell
c583d40678
More tweaks for comments due indent issues
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:46:08 +00:00
Matt Caswell
31082f2127
Fix modes.h so that indent doesn't complain
...
Conflicts:
crypto/modes/modes.h
Conflicts:
crypto/modes/modes.h
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:46:01 +00:00
Matt Caswell
2c783509f4
Backport hw_ibmca.c from master due to failed merge
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:56 +00:00
Matt Caswell
6bd72a273e
Tweaks for comments due to indent's inability to handle them
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:51 +00:00
Matt Caswell
5011589a0b
Move more comments that confuse indent
...
Conflicts:
crypto/dsa/dsa.h
demos/engines/ibmca/hw_ibmca.c
ssl/ssl_locl.h
Conflicts:
crypto/bn/rsaz_exp.c
crypto/evp/e_aes_cbc_hmac_sha1.c
crypto/evp/e_aes_cbc_hmac_sha256.c
ssl/ssl_locl.h
Conflicts:
crypto/ec/ec2_oct.c
crypto/ec/ecp_nistp256.c
crypto/ec/ecp_nistp521.c
crypto/ec/ecp_nistputil.c
crypto/ec/ecp_oct.c
crypto/modes/gcm128.c
ssl/ssl_locl.h
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:45 +00:00
Dr. Stephen Henson
7b0ec6a4af
Delete trailing whitespace from output.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:40 +00:00
Dr. Stephen Henson
e5ebff7b6a
Add -d debug option to save preprocessed files.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:35 +00:00
Dr. Stephen Henson
9c392088de
Test option -nc
...
Add option -nc which sets COMMENTS=true but disables all indent comment
reformatting options.
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:30 +00:00
Matt Caswell
a75d7245e5
Add ecp_nistz256.c to list of files skipped by openssl-format-source
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:25 +00:00
Matt Caswell
b10a8451e3
Manually reformat aes_x86core.c and add it to the list of files skipped by
...
openssl-format-source
Conflicts:
crypto/aes/aes_x86core.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:19 +00:00
Andy Polyakov
679fee0e18
crypto/ofb128.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:15 +00:00
Andy Polyakov
74c1dc909d
modes/ctr128.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:10 +00:00
Andy Polyakov
638f75b686
modes/cfb128.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:05 +00:00
Matt Caswell
510edea8db
Fix indent comment corruption issue
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:45:01 +00:00
Matt Caswell
3bc28b8022
Amend openssl-format-source so that it give more repeatable output
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:55 +00:00
Andy Polyakov
2d8e9d0c55
bn/bn_const.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:48 +00:00
Andy Polyakov
15a9c36755
bn/asm/x86_64-gcc.cL make it indent-friendly.
...
Conflicts:
crypto/bn/asm/x86_64-gcc.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:42 +00:00
Andy Polyakov
a988c1edfc
bn/bn_asm.c: make it indent-friendly.
...
Conflicts:
crypto/bn/bn_asm.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:35 +00:00
Andy Polyakov
23a79aac28
bn/bn_exp.c: make it indent-friendly.
...
Conflicts:
crypto/bn/bn_exp.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:29 +00:00
Matt Caswell
d8305efeb4
Manually reformat aes_core.c
...
Add aes_core.c to the list of files not processed by openssl-format-source
Conflicts:
crypto/aes/aes_core.c
Conflicts:
crypto/aes/aes_core.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:22 +00:00
Matt Caswell
7566807cfc
Add obj_dat.h to the list of files that will not be processed by
...
openssl-format-source
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:16 +00:00
Matt Caswell
3ad5ae5d44
Fix strange formatting by indent
...
Conflicts:
crypto/hmac/hmac.h
Conflicts:
crypto/evp/e_aes_cbc_hmac_sha256.c
Conflicts:
crypto/ec/ecp_nistp224.c
crypto/ec/ecp_nistp256.c
crypto/ec/ecp_nistp521.c
crypto/ec/ectest.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:08 +00:00
Matt Caswell
e16db4b3d7
indent has problems with comments that are on the right hand side of a line.
...
Sometimes it fails to format them very well, and sometimes it corrupts them!
This commit moves some particularly problematic ones.
Conflicts:
crypto/bn/bn.h
crypto/ec/ec_lcl.h
crypto/rsa/rsa.h
demos/engines/ibmca/hw_ibmca.c
ssl/ssl.h
ssl/ssl3.h
Conflicts:
crypto/ec/ec_lcl.h
ssl/tls1.h
Conflicts:
crypto/ec/ecp_nistp224.c
crypto/evp/evp.h
ssl/d1_both.c
ssl/ssl.h
ssl/ssl_lib.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:44:02 +00:00
Andy Polyakov
134d38bcde
modes/cts128.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:57 +00:00
Andy Polyakov
74d3242514
crypto/mem_dbg.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:52 +00:00
Matt Caswell
6020ffc766
More indent fixes for STACK_OF
...
Conflicts:
ssl/s3_lib.c
Conflicts:
apps/cms.c
crypto/x509/x509_lu.c
crypto/x509/x509_vfy.h
ssl/s3_lib.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:43 +00:00
Matt Caswell
7cba857c9a
Fix indent issue with functions using STACK_OF
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:37 +00:00
Matt Caswell
08220fec49
Fix indent issue with engine.h
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:32 +00:00
Matt Caswell
bfe4de7257
Fix logic to check for indent.pro
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:26 +00:00
Andy Polyakov
7a9f1f174c
crypto/cryptlib.c: make it indent-friendly.
...
Conflicts:
crypto/cryptlib.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:21 +00:00
Andy Polyakov
033a5fcfe8
bn/bntest.c: make it indent-friendly.
...
Conflicts:
crypto/bn/bntest.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:16 +00:00
Andy Polyakov
4f6930f5d3
bn/bn_recp.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:10 +00:00
Andy Polyakov
bc18f2f140
engines/e_ubsec.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:43:05 +00:00
Andy Polyakov
1a9c746696
apps/speed.c: make it indent-friendly.
...
Conflicts:
apps/speed.c
Conflicts:
apps/speed.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:42:56 +00:00