Commit graph

7494 commits

Author SHA1 Message Date
Philip Whitehouse
ae15e0c618 Test and re-order identity priority 2018-01-11 00:33:11 +00:00
Vincent Breitmoser
e4467ef959
Merge pull request #3064 from k9mail/remove_attachment_permission
Remove custom attachment permission
2018-01-10 00:32:21 +01:00
Vincent Breitmoser
d65ccb0077
Merge pull request #3063 from k9mail/forward_as_attachment
Forward message as attachment
2018-01-10 00:32:05 +01:00
cketti
08f79b13b7 Remove unnecessary IOException from methods signatures 2018-01-09 22:09:06 +01:00
Vincent Breitmoser
20d96ae7f4
Simplify crypto info in message view (#3067)
* Simplify crypto info in message view

* incorporate feedback

* Use lowercase end-to-end

* Use signer/sender as button label, get rid of e2e string repetition
2018-01-09 19:25:42 +01:00
cketti
61a47f9650 Remove custom attachment permission 2018-01-08 17:06:17 +01:00
cketti
af4fa4330a Mark forwarded messages as attachment 2018-01-08 16:41:31 +01:00
cketti
6b28c5b41b Don't allow user to supply content of type message/*
Instead we rewrite the MIME type to application/octet-stream. This is
so we don't create broken messages in case the user-supplied content is
not a valid message.
In the future we could add some validation code and allow the user to
attach well-formed messages using the proper MIME type.
2018-01-08 16:41:31 +01:00
cketti
1da373ad06 Load message for "forward as attachment" in background 2018-01-08 16:41:31 +01:00
Thomas E. Horner
4f4e1386cb Forward as Attachment 2018-01-08 16:41:31 +01:00
Philip
d0c8cc3b57 Don't load recipients with no email (fixes #2973) (#2985)
Don't load recipients with no email
2018-01-08 16:25:46 +01:00
Vincent Breitmoser
111f7fc194
Merge pull request #3059 from k9mail/clean_up_sync_code
"Simplify" sync code
2018-01-08 16:22:16 +01:00
cketti
6cecf17645 Remove IMAP-specific code from legacy sync code 2018-01-07 00:45:20 +01:00
cketti
5f44e21aa1 Remove code not relevant for IMAP from ImapSync 2018-01-07 00:45:20 +01:00
cketti
80bee9725f
Merge pull request #2996 from k9mail/message_sync_refactor
Split synchronization code #2
2018-01-06 22:29:01 +01:00
cketti
c4c266c5ee
Merge pull request #3051 from philipwhiuk/testIframeUpdateJsoup
Html Sanitization: Update JSoup, test iframe removal & allow center
2018-01-06 22:25:31 +01:00
Philip Whitehouse
40081b435c Allow center tag and test whitelisting of formatting tags 2018-01-06 15:13:04 +00:00
cketti
9e181e3180
Merge pull request #3050 from k9mail/GH-2999_fix_quiet_time
Fix quiet time
2018-01-06 09:00:45 +01:00
Philip Whitehouse
339b1ed825 Update JSoup to improve unknown tag handling and test iframe removal 2018-01-06 00:40:02 +00:00
cketti
bb14309dd0 Refactor QuietTimeChecker 2018-01-05 20:34:16 +01:00
cketti
e9d90b1e75 Use Calendar.HOUR_OF_DAY instead of Calendar.HOUR in QuietTimeChecker
Fixes #2999
2018-01-05 20:34:16 +01:00
cketti
8fd6a4c83a Add tests for QuietTimeChecker 2018-01-05 20:34:16 +01:00
cketti
0e6108a89f Extract 'quiet time' check to separate class 2018-01-05 19:52:56 +01:00
cketti
023caaa75b Merge branch 'GH-2983_whitelist_font_tag_attributes'
Add attributes for 'font' tag to the whitelist

Fixes #2983
2018-01-04 05:13:28 +01:00
cketti
9b8617d33f Add attributes for 'font' tag to the whitelist 2018-01-04 05:07:41 +01:00
cketti
118b465406
Merge pull request #3037 from k9mail/GH-3006_whitelist_table_background_attribute
Add 'background' attribute for 'table' tag to the whitelist
2018-01-04 05:03:34 +01:00
cketti
13c24c26f4 Add 'background' attribute for 'table' tag to the whitelist 2018-01-04 04:50:23 +01:00
cketti
75fba6898f
Merge pull request #3036 from k9mail/GH-3034_improve_html_sanitation
Fix HTML sanitation
2018-01-04 04:43:47 +01:00
cketti
f69ac0662a Add more table elements attributes to whitelist 2018-01-04 03:39:29 +01:00
cketti
5a4a9042f1 Fix HeadCleaner to not skip everything after a disallowed tag 2018-01-04 03:35:43 +01:00
cketti
f5c9ae4018
Merge pull request #3035 from philipwhiuk/fixPluralDownloadingMessage
Add count to string for replacement

Fixes #3032
2018-01-04 02:26:47 +01:00
Philip Whitehouse
8014943e7d Fix #3032 - add count to string for replacement 2018-01-04 00:41:10 +00:00
cketti
f1deeb76d7
Merge pull request #3021 from MJ10/master
Fix: import/export maintains account order
2018-01-02 15:29:15 +01:00
Moksh Jain
6cb1a60804 Fix: import/export maintains account order 2018-01-01 22:26:32 +05:30
cketti
a549e27875
Merge pull request #2909 from jyn514/deprecation
Removed deprecated members, classes, and APIs
2017-12-30 04:35:38 +01:00
Joshua Nelson
7591319e7e Removed deprecated members
Removed MessageList.EXTRA_SEARCH_OLD (and its reference in a search)
2017-12-30 04:17:35 +01:00
cketti
0cf4b8aaa5
Merge pull request #2910 from jyn514/unused-vars
Removed unused variables
2017-12-30 03:30:14 +01:00
cketti
d50319053a
Merge pull request #2986 from philipwhiuk/testBodyStructure
Add test for IMAP FETCH BODYSTRUCTURE
2017-12-29 06:01:37 +01:00
cketti
47adee116c
Merge pull request #2991 from k9mail/update_translations
Update translations
2017-12-27 21:00:23 +01:00
cketti
2d106e2b1a Add Albanian translation 2017-12-27 17:07:33 +01:00
cketti
285da9122a Update translations 2017-12-27 14:54:31 +01:00
Joshua Nelson
a2ad2dd10b Removed unthrown exceptions from method signatures (#2913)
For OAuth2TokenProvider.getToken(), changed exception thrown to
match method signature (AssertionError -> AuthenticationFailedException)
2017-12-27 12:28:27 +00:00
Philip Whitehouse
fae5017832 Add test for IMAP FETCH BODYSTRUCTURE 2017-12-24 18:52:37 +00:00
cketti
a47ab9d7fe Copy relevant tests from MessagingControllerTest to ImapSyncTest 2017-12-22 07:16:54 +01:00
cketti
87eb9398ae Copy message sync code to ImapMessageStore/ImapSync
This will allow us to modify the sync implementation for IMAP without
having to worry about supporting the other protocols with the same code.
2017-12-22 06:59:01 +01:00
cketti
fc5af3ad9d
Merge pull request #2953 from SreyasRangaraju/master
Add unit tests for AccountCreator and Utility
2017-12-22 03:37:22 +01:00
cketti
012c4ee566 Fix code style issues 2017-12-22 03:29:10 +01:00
cketti
6bb42191ac
Merge pull request #2978 from k9mail/GH-2931_do_not_crash_when_closing_ImapConnection_twice
Do nothing in ImapConnection.close() if connection is not open
2017-12-21 04:38:39 +01:00
cketti
c2eb00b4f6 Do nothing in ImapConnection.close() if connection is not open
Under certain circumstances ImapFolderPusher can call
ImapConnection.close() twice. When using compression this will
lead to a NullPointerException inside ZOutputStream.close(). We're
ignoring all exceptions when closing a connection. So this shouldn't be
a problem. But (early versions of?) Android 8.1 shipped with a bug in
ART that shuts down the VM when a NullPointerException is triggered from
AOT/JIT(?) compiled code that uses a certain optimization. And we're
unlucky enough to trigger this bug.
Not closing the streams more than once should work around this bug.

See issue #2931
2017-12-20 07:07:35 +01:00
cketti
a95e897803
Merge pull request #2967 from lazycodeninja/master
Don't crash when replacing content URIs

Fixes #1988
2017-12-17 01:44:14 +01:00