Commit graph

7444 commits

Author SHA1 Message Date
cketti
c2eb00b4f6 Do nothing in ImapConnection.close() if connection is not open
Under certain circumstances ImapFolderPusher can call
ImapConnection.close() twice. When using compression this will
lead to a NullPointerException inside ZOutputStream.close(). We're
ignoring all exceptions when closing a connection. So this shouldn't be
a problem. But (early versions of?) Android 8.1 shipped with a bug in
ART that shuts down the VM when a NullPointerException is triggered from
AOT/JIT(?) compiled code that uses a certain optimization. And we're
unlucky enough to trigger this bug.
Not closing the streams more than once should work around this bug.

See issue #2931
2017-12-20 07:07:35 +01:00
cketti
a95e897803
Merge pull request #2967 from lazycodeninja/master
Don't crash when replacing content URIs

Fixes #1988
2017-12-17 01:44:14 +01:00
cketti
59ed36c4a9 Convert MigrationTo51Test to Kotlin 2017-12-16 22:39:17 +01:00
cketti
02b6fdfda3 Use simple string replacement instead of replacement via regexp 2017-12-16 20:55:14 +01:00
Philip Whitehouse
d64af371ad Test Migration51 including special characters in Content-IDs 2017-12-10 22:49:24 +00:00
Jason Khallouf
79975cacd0 Issue #1988, escape special chars in Migration51 content ID replacement
Without this fix, content IDs containing '$' would cause the replaceAll() to interpret the string as a capture group backreference and throw an ArrayIndexOutOfBoundsException, which would cause the migration to fail and all messages in the mailbox to be lost.
2017-12-09 14:45:22 +11:00
cketti
1a12b18f0c
Merge pull request #2951 from philipwhiuk/translateSearchFromSender
Allow translation of 'more from sender' search name
2017-11-27 16:26:53 +01:00
cketti
dd9639c6c1
Merge pull request #2950 from philipwhiuk/translateCryptographyPreference
Use translatable string for Cryptography preference
2017-11-27 16:26:00 +01:00
Philip Whitehouse
b35d9a9222 Allow translation of 'more from sender' search name 2017-11-27 03:44:16 +00:00
Philip Whitehouse
4a48555bb7 Use translatable string for Cryptography preference 2017-11-27 03:30:22 +00:00
cketti
01d93858cb
Merge pull request #2899 from jyn514/account-names
Show the name of each account imported
2017-11-15 17:06:42 +01:00
cketti
c113c23f5e Cleanup 2017-11-15 16:50:33 +01:00
Joshua Nelson
349c2aa9f3
Added localization for importing several accounts
Previous commit had a hardcoded string.
2017-11-14 17:18:15 -05:00
cketti
d6090c626b
Merge pull request #2725 from k9mail/improveDecoderUtil
Handle RFC2047 non-compliant splitting of characters
2017-11-12 18:36:02 +01:00
Harikrishnan Rajan
65be2b0357
Merge pull request #2927 from k9mail/rewrite-expunge
Add support for UID EXPUNGE
2017-11-12 21:56:30 +05:30
Hari
31b7cf8dae Rewrite IMAP expunge 2017-11-11 21:38:08 +05:30
cketti
a8c5327dcf Use ProGuard to strip unused code in release builds (#2753) 2017-11-10 21:54:31 +00:00
cketti
f78ed69a88
Merge pull request #2886 from jyn514/fix-todo
Implemented TODO in CoreService
2017-11-10 18:15:28 +01:00
Joshua Nelson
aa4fb26f8f Address now logs an error if given bad arguments (#2897) 2017-11-10 18:09:25 +01:00
Joshua Nelson
3fdb5f532f Simplified logic (#2911) 2017-11-10 18:05:57 +01:00
Harikrishnan Rajan
231cab3f36
Merge pull request #2924 from k9mail/imap_refactoring_refactored
'Refactor IMAP commands' refactored
2017-11-10 22:31:50 +05:30
cketti
fa9fc2d974 Prepare for next development iteration 2017-11-10 17:53:31 +01:00
cketti
934bbbe882 Version 5.304 2017-11-10 17:34:25 +01:00
cketti
d604250c9d Update changelog for 5.304 2017-11-10 17:33:07 +01:00
cketti
8de2fdcce6
Merge pull request #2926 from k9mail/update_translations
Update translations
2017-11-10 17:28:03 +01:00
cketti
2d51250c71 Update translations 2017-11-10 16:48:53 +01:00
cketti
97b4c06632 Remove FolderSelectedStateCommand 2017-11-09 08:51:56 +01:00
cketti
590b6c6cc0 Combine responses in ImapConnection.executeSelectedStateCommand() 2017-11-09 08:51:56 +01:00
Hari
aa7e00263f IMAP refactoring 2017-11-09 08:51:56 +01:00
cketti
4248e4172a
Merge pull request #2908 from jyn514/casting
Remove unneccessary casting and unboxing
2017-11-07 16:16:42 +01:00
Joshua Nelson
26cd24717e
Made requested changes for merge
Changed for-each loop back to for loop (for efficiency)
2017-11-05 18:31:16 -05:00
cketti
ad5897125a
Merge pull request #2907 from jyn514/imports
Remove unused imports
2017-11-05 15:09:27 +01:00
cketti
cd5c4bf9a6
Merge pull request #2903 from k9mail/decrypted-preamble
Don't ignore preamble and epilogue in decrypted messages
2017-11-05 14:44:38 +01:00
Joshua Nelson
9db6cdc1c2
Remove unneccessary casting and unboxing
Removed casts to (View)
Removed calls to <Integer>.getInt(), <Long>.getLong()
Changed a few for loops to for-each loops
2017-11-03 18:45:47 -04:00
Joshua Nelson
a6388ca84f
Remove unused imports 2017-11-03 18:25:28 -04:00
cketti
bfc2dcba35 Prepare for next development iteration 2017-11-03 05:31:32 +01:00
cketti
ed8dfa67a7 Version 5.303 2017-11-03 05:08:16 +01:00
cketti
aa1d905d51 Update changelog for 5.303 2017-11-03 05:07:37 +01:00
Vincent Breitmoser
d2443276c8 Don't ignore preamble and epilogue in decrypted messages 2017-11-02 23:44:48 +01:00
Joshua Nelson
7aa4333e66 Show the name of each account imported
For each account, show "Imported <old account> as <new account>".

Does not currently support localization.
2017-11-02 17:04:28 -04:00
cketti
f2f7b78275
Merge pull request #2893 from k9mail/GH-2889_add_ins_del_html_tags_to_whitelist
Add <ins> and <del> HTML tags to whitelist
2017-11-02 07:11:04 +01:00
cketti
f366e504c7
Merge pull request #2892 from k9mail/GH-2891_display_inline_text_part_as_attachment
Only hide inline image parts with Content-Id header
2017-11-02 07:09:36 +01:00
cketti
b51d9d09a3 Add <ins> and <del> HTML tags to whitelist 2017-11-01 19:34:55 +01:00
cketti
9df026aa7c Update tests in AttachmentInfoExtractorTest 2017-11-01 18:23:59 +01:00
cketti
0a6ef2b70f
Merge pull request #2885 from jyn514/issue-2846
Prevent crash when parsing invalid base64 email address
2017-11-01 18:00:25 +01:00
cketti
d23ff7f6a1 Only hide inline image parts with Content-Id header
The assumption is those parts are images referenced by the main HTML
part. Even without "attachment box" the user is able to save them using
a long-press in the WebView.
2017-11-01 16:43:47 +01:00
Joshua Nelson
4178306273 Implemented TODO in CoreService
The todo:
    // TODO: remove this. we never set threadPool to null

    The fix:
    Removed most code that would be executed if threadPool were null
    Reordered a little logic to make code easier to read
2017-10-30 15:10:39 -04:00
Joshua Nelson
ddcf1e257e Fixed issue 2846
Skip invalid input; parse strictly otherwise.
See [issue](https://github.com/k9mail/k-9/issues/2846) for details.
2017-10-29 21:11:16 -04:00
cketti
d696723023 Prepare for next development iteration 2017-10-28 02:30:08 +02:00
cketti
4e9b47f4ff Version 5.302 2017-10-28 01:53:45 +02:00