Commit graph

3375 commits

Author SHA1 Message Date
Nico
58f7e06b72
Moving unique abilities to an Enum (#2095)
* Unique abilities moved to enums

* remove diplomatic victory type WIP

* Address review comments. Translations for unique abilities names aren't used anywhere as far as I can tell, but added them to relevant translation files just in case.

Co-authored-by: nmeze <nicolas.mezeret@gmail.com>
2020-03-07 22:22:20 +02:00
Yair Morgenstern
2bc590d5b5 Fixed number of strategic resources 2020-03-07 22:07:42 +02:00
Federico Luongo
296936ae53
Fix/city buy sell exploits (#2094)
* Fix erroneous removal from queue

* Buy/Sell popups disable respective button and force closure of other popups
2020-03-07 20:04:27 +02:00
Yair Morgenstern
ccc5c5ee84 3.6.6 2020-03-06 16:18:00 +02:00
Yair Morgenstern
54a29e28bc
Translations (#2091)
* 2 new french translations (#2078)

* Update German.properties (#2079)

Refined a few translations I stumbled upon in-game

* Update Japanese.properties (#2082)

* Added german translations (#2084)

Co-authored-by: Fabian Wrobel <fabian.wrobel@freenet,de>

* Updates

Co-authored-by: armandberger <hoel@free.fr>
Co-authored-by: Marmo <5788516+Marmo@users.noreply.github.com>
Co-authored-by: paontv <57051667+paontv@users.noreply.github.com>
Co-authored-by: CarpeLuxNoctem <61473456+CarpeLuxNoctem@users.noreply.github.com>
Co-authored-by: Fabian Wrobel <fabian.wrobel@freenet,de>
2020-03-06 16:14:09 +02:00
GGGuenni
80ca06afbe
ResponsePopup is now working like intended (#2089) 2020-03-06 16:05:42 +02:00
JackRainy
73e8b718ab
Keshiks are ranged units (#2087) 2020-03-06 10:33:08 +02:00
JackRainy
0df1907383
Distinct color for Korea (#2085) 2020-03-06 10:31:48 +02:00
JackRainy
e12f35660f
Revert close buttons + usability improvement (#2088)
* Revert changes to the Close buttons from PR #2069

* Better sensivity of diplomacy buttons
2020-03-06 10:31:23 +02:00
Yair Morgenstern
585ec2b723 Water units can no longer see over hills etc. 2020-03-05 23:37:58 +02:00
Yair Morgenstern
5117a498f9 Resolved #2040 - Moved the turn counter on the top bar to the second level, to even out both levels 2020-03-05 23:29:42 +02:00
Yair Morgenstern
8ab7f7ae50 Adding the unsigned apk (which doesn't seem to work out-of-the-box for most players) was causing confusion and more harm than good 2020-03-05 23:12:54 +02:00
Yair Morgenstern
978f5bda53 Resolved #2074 - Fixed domination victory 2020-03-05 23:01:39 +02:00
Yair Morgenstern
7bd0365a8e
Issue#2019 (#2051)
* Issue#2019
Player should not be able to nuke a civilsation that it has a peace treaty with

* wordlscreen is updated when notification shown (#2019)

* Fixed PR comments #2019

* issue #2019

* Fixed PR comments #2019

* Fixed PR comments #2019

* Fixed PR comments #2019
refactoring

* Fixed PR comments #2019
removed unnecessary line
2020-03-05 22:50:23 +02:00
Yair Morgenstern
82ab66ad05 Ranking by culture is by number of adopted policies 2020-03-05 22:28:51 +02:00
Yair Morgenstern
955dff89b9
fix research agreement button. (#2080) 2020-03-04 20:13:15 +02:00
Yair Morgenstern
97a07d3530 Resolved #2071 - AI will wait 20 turns between proposing research agreements if declined 2020-03-03 23:05:56 +02:00
Yair Morgenstern
2cf5645629 3.6.5 2020-03-03 22:04:38 +02:00
Yair Morgenstern
14853547dc
Translations (#2073)
* Update Italian.properties (#2050)

* Update Polish.properties (#2058)

* Update Russian.properties (#2061)

* Update Czech.properties (#2068)

* Updates

Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Freshy <60152907+GreenFreshy@users.noreply.github.com>
Co-authored-by: IraqLobster34 <56483230+IraqLobster34@users.noreply.github.com>
Co-authored-by: l3sy <61739053+l3sy@users.noreply.github.com>
2020-03-03 22:02:05 +02:00
Yair Morgenstern
86576e25ae Fixed crash when diplomacy values change while ending the turn 2020-03-03 21:45:39 +02:00
Yair Morgenstern
163d4ad347 Ah welp
Good thing the tests caught it =)
2020-03-03 20:34:54 +02:00
Yair Morgenstern
1acf337d55 Resolved #2055 - cities bombard melee units once again
Basically undid the change from #1993 and prettified a bit
@Kentalot
2020-03-03 20:18:38 +02:00
Yair Morgenstern
a493661aad Merge branch 'master' of https://github.com/yairm210/Unciv 2020-03-03 20:09:52 +02:00
Yair Morgenstern
27b9c93d6f Resolved #2035 - Strategic resources are affected by map generation parameters 2020-03-03 20:09:40 +02:00
lishaoxia1985
95354964ba
some UI update. (#2069) 2020-03-03 19:54:20 +02:00
Yair Morgenstern
8a9bbf4154 City state diplomacy screen cleanup 2020-03-03 17:43:07 +02:00
Yair Morgenstern
9721fb66c0 Resolved #2033 - happiness from tiles is always considered correctly in regards to food consumption 2020-03-03 17:25:30 +02:00
Vladimir Tanakov
78dab67257
[2065] Fix issue when unit can sleep while fortification (#2067) 2020-03-03 14:23:01 +02:00
Yair Morgenstern
f7a010f10e 3.6.4-patch1 2020-03-02 22:30:07 +02:00
Yair Morgenstern
14516a3f90 Merge branch 'master' of https://github.com/yairm210/Unciv 2020-03-02 22:18:51 +02:00
lishaoxia1985
fc9de6f7fb
Fix that when great person creates great improvement great person doesn't disappear. (#2062) 2020-03-02 18:12:17 +02:00
wrov
1df0c408aa
Fixed Multiplayer Turn Notifier periodically failing with error notification. (#2054) 2020-03-02 06:44:53 +02:00
Yair Morgenstern
7b5e59292e 3.6.4 2020-03-01 23:46:11 +02:00
Yair Morgenstern
10b95c6c1c
Translations (#2049)
* Holy crswd (#2031)

HAHAA

* Update Japanese.properties (#2034)

* Translation updates

Co-authored-by: IraqLobster34 <56483230+IraqLobster34@users.noreply.github.com>
Co-authored-by: paontv <57051667+paontv@users.noreply.github.com>
2020-03-01 23:30:54 +02:00
JackRainy
eb9d2b1178
Translations update (#2047) 2020-03-01 23:17:24 +02:00
JackRainy
8cae2fb125
Include Nations in the calculation of a translation`s percentage (#2044)
* Include Nations in the calculation of a translation`s percentage

* Refactoring: Parameter renaming

* Check for empty originals
2020-03-01 23:10:43 +02:00
lishaoxia1985
47065e0384
modify Eiffel Tower effect. translation update. (#1955) 2020-03-01 22:25:59 +02:00
JackRainy
24e4d77453
Civilization rankings (Richest, Strongest, Most Fertile, Largest, etc.) (#2036)
* Initial preparations

* Moving to the separate package

* Calculation and visualization

* Translations

* Using a local function instead of additional class

* Using a local function instead of additional class (part 2)

* Rankings French.properties

* Fixup of the leftover

Co-authored-by: RobertGine <61517798+RobertGine@users.noreply.github.com>
2020-02-29 20:48:55 +02:00
Giuseppe D'Addio
b9682b0c80
Update Nations.json (#2028) 2020-02-29 20:11:55 +02:00
JackRainy
241ce8b4f6
Make the test actually works (#2043)
* Make the test actually works

* Fix of Nations_German.json file
2020-02-29 20:10:55 +02:00
JackRainy
9fbd569e1f
Allow to buy buildings from the queue (#2032)
* Allow to buy buildings from the queue

* Minor refactoring
2020-02-29 20:10:24 +02:00
Yair Morgenstern
f081f02006 3.6.3 (+patch1) 2020-02-27 21:57:52 +02:00
Yair Morgenstern
fa61bdfd04
Translations (#2020)
* Update Polish.properties (#1997)

* Update Polish.properties

* Update Polish.properties

This should solve the problem (and correct a small translation error)

* Update Polish.properties

Next corrections, thanks @rprzystasz

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>

* New french translation (#2014)

* Update Italian.properties (#2016)

* Update German.properties (#2017)

* Update German.properties

* Create Nations_German.json

Start new file for nations translation in german

* Update Nations_German.json

* Extensive correction of French translation (#2022)

* Resolved #1986 - research agreement cost consistency

* Tile stats are shown on a row, rather than on a column (#1946)

* Feature/refactor actions (#2008)

* Fixes Issue #1697 by adding information to the special production constructions.

* Get rid of extra $ sign in the SpecialConstruction tooltips

* Major refactor to use Sequences instead of List to try to improve logic whenever getting a list of tiles at a distance.

* Get rid of extraneous parameter

* get rid of extra exception. slight refactor placeUnitNearTile for readability

* Fix bug of doing intersection instead of union

* Add an extra method to get tiles in distance range

* Refactor the UnitActions to use more sequences and also to grab the actions needed by Automation directly.

* Update based on comments

* Redo to be more easily compared

* use elvis operator for assignment

* resolve merge conflicts

* Fix typo

* Fix one more typo

* Get rid of one more search for great person actions

* Get rid of one more search for pillage action

* Try to realign methods names for better diff

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>

* Resolved #2012 - manually place starting locations are no longer visible in-game

* Extensive correction of French translation

Many, many several little corrections to the French translation. A few mistakes marred gameplay a little bit, but most of them were simple grammar mistakes. But the details are always important.

* Modifications to resolve conflict

* Modifications to resolve conflict (bus)

* Modifications to resolve conflict MK3

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
Co-authored-by: Federico Luongo <fluo392@gmail.com>
Co-authored-by: Kentalot <Kentalot@users.noreply.github.com>

* Updates

Co-authored-by: Freshy <60152907+GreenFreshy@users.noreply.github.com>
Co-authored-by: armandberger <hoel@free.fr>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: CarpeLuxNoctem <61473456+CarpeLuxNoctem@users.noreply.github.com>
Co-authored-by: RobertGine <61517798+RobertGine@users.noreply.github.com>
Co-authored-by: Federico Luongo <fluo392@gmail.com>
Co-authored-by: Kentalot <Kentalot@users.noreply.github.com>
2020-02-27 19:57:55 +02:00
GoldenBronze
3598b51cb3
Update Nations.json (#2027) 2020-02-27 19:38:33 +02:00
wrov
9188c7790f
Multiplayer Notification Fix for random Termination (#2024)
* Reworked Notification service to remove Nullpointer crashes due to non-final static variables being null. Instead moved all state to Worker specific architecture. Also switched to Android based localization because core-based one can be unavailable to worker.

* Added missing blanks

* Added more internationalization
Added missing androidX declaration (neccessary for newer Gradle versions)
Updated Gradle for new Android Studio Version

* Optimization

* Removed missing translations error
2020-02-27 19:35:40 +02:00
Yair Morgenstern
3ccd457759 Victory screen shows the viewing player, not the current player, in multiplayer games 2020-02-27 19:30:22 +02:00
JackRainy
f621ed5192
Fix for the wrong placement of purchased and upgraded units (#2006)
* Place the unit at the current position firstly

* More simple solution

* Try to place unit with traceability taken into account

* Return money and notify about the problem

* Popup dialog instead of notification

* Refactoring: Split UI and logic
2020-02-27 09:22:24 +02:00
Yair Morgenstern
85ea92cf72 Resolved #2012 - manually place starting locations are no longer visible in-game 2020-02-26 22:00:25 +02:00
Kentalot
0565405fc0
Feature/refactor actions (#2008)
* Fixes Issue #1697 by adding information to the special production constructions.

* Get rid of extra $ sign in the SpecialConstruction tooltips

* Major refactor to use Sequences instead of List to try to improve logic whenever getting a list of tiles at a distance.

* Get rid of extraneous parameter

* get rid of extra exception. slight refactor placeUnitNearTile for readability

* Fix bug of doing intersection instead of union

* Add an extra method to get tiles in distance range

* Refactor the UnitActions to use more sequences and also to grab the actions needed by Automation directly.

* Update based on comments

* Redo to be more easily compared

* use elvis operator for assignment

* resolve merge conflicts

* Fix typo

* Fix one more typo

* Get rid of one more search for great person actions

* Get rid of one more search for pillage action

* Try to realign methods names for better diff

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
2020-02-26 21:50:36 +02:00
Federico Luongo
c4375ed4e8
Tile stats are shown on a row, rather than on a column (#1946) 2020-02-26 21:48:24 +02:00